Version0022Date20220623224231::changeSchema() - Code Metrics - Inspection of "storing circles' config in memberships" - nextcloud/circles - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( cd91c1...62d6de )

by Maxence

created 2021-06-24 00:07 UTC

Version0022Date20220623224231::changeSchema() F

↳ Parent: Version0022Date20220623224231

Complexity

Conditions	13
Paths	1296

Size

Total Lines

147

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	147
rs	1.96
c	0
b	0
f	0
cc	13
nc	1296
nop	3

How to fix Long Method Complexity

<?php

declare(strict_types=1);


/**
 * Circles - Bring cloud-users closer together.
 *
 * This file is licensed under the Affero General Public License version 3 or
 * later. See the COPYING file.
 *
 * @author Maxence Lange <[email protected]>
 * @copyright 2021
 * @license GNU AGPL version 3 or any later version
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as
 * published by the Free Software Foundation, either version 3 of the
 * License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 */


namespace OCA\Circles\Migration;

use Closure;
use Doctrine\DBAL\Schema\SchemaException;
use OCP\DB\ISchemaWrapper;
use OCP\IDBConnection;
use OCP\Migration\IOutput;
use OCP\Migration\SimpleMigrationStep;


/**
 * Class Version0022Date20220526113601
 *
 * @package OCA\Circles\Migration
 */
class Version0022Date20220623224231 extends SimpleMigrationStep {


	/**
	 * @param IDBConnection $connection
	 */
	public function __construct(IDBConnection $connection) {
	}


	/**
	 * @param IOutput $output
	 * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
	 * @param array $options
	 *
	 * @return null|ISchemaWrapper
	 * @throws SchemaException
	 */
	public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {
		/** @var ISchemaWrapper $schema */
		$schema = $schemaClosure();

		if ($schema->hasTable('circles_event')) {
			$table = $schema->getTable('circles_event');
			if (!$table->hasColumn('updated')) {
				$table->addColumn(
					'updated', 'datetime', [
								 'notnull' => false,
							 ]
				);
			}
		}

		if ($schema->hasTable('circles_member')) {
			$table = $schema->getTable('circles_member');
			if (!$table->hasColumn('invited_by')) {
				$table->addColumn(
					'invited_by', 'string', [
									'notnull' => false,
									'default' => '',
									'length'  => 31,
								]
				);
			}
		}

		if ($schema->hasTable('circles_membership')) {
			$table = $schema->getTable('circles_membership');
			if (!$table->hasColumn('config')) {
				$table->addColumn(
					'config', 'integer', [
								'notnull'  => false,
								'length'   => 11,
								'unsigned' => true
							]
				);
				$table->addIndex(['single_id', 'config']);
			}

		}

		if ($schema->hasTable('circles_circle')) {
			$table = $schema->getTable('circles_circle');
			if (!$table->hasColumn('sanitized_name')) {
				$table->addColumn(
					'sanitized_name', 'string', [
										'notnull' => false,
										'default' => '',
										'length'  => 127
									]
				);

				$table->addIndex(['sanitized_name']);
			}
		}


		if ($schema->hasTable('circles_membership')) {
			$table = $schema->getTable('circles_membership');
			$table->changeColumn(
				'circle_id', [
							   'notnull' => true,
							   'length'  => 31,
						   ]
			);
			$table->changeColumn(
				'single_id', [
							   'notnull' => true,
							   'length'  => 31,
						   ]
			);
			$table->changeColumn(
				'inheritance_first', [
									   'notnull' => true,
									   'length'  => 31,
								   ]
			);
			$table->changeColumn(
				'inheritance_last', [
									  'notnull' => true,
									  'length'  => 31,
								  ]
			);
		}


		if ($schema->hasTable('circles_mount')) {
			$table = $schema->getTable('circles_mount');
			$table->changeColumn(
				'mount_id', [
							  'notnull' => true,
							  'length'  => 31,
						  ]
			);
			$table->changeColumn(
				'circle_id', [
							   'notnull' => true,
							   'length'  => 31,
						   ]
			);
			$table->changeColumn(
				'single_id', [
							   'notnull' => true,
							   'length'  => 31,
						   ]
			);
		}


		if ($schema->hasTable('circles_mountpoint')) {
			$table = $schema->getTable('circles_mountpoint');
			$table->changeColumn(
				'mount_id', [
							  'notnull' => true,
							  'length'  => 31,
						  ]
			);
			$table->changeColumn(
				'single_id', [
							   'notnull' => true,
							   'length'  => 31,
						   ]
			);
		}


		if ($schema->hasTable('circles_share_lock')) {
			$table = $schema->getTable('circles_share_lock');
			$table->changeColumn(
				'item_id', [
							 'notnull' => true,
							 'length'  => 31,
						 ]
			);
			$table->changeColumn(
				'circle_id', [
							   'notnull' => true,
							   'length'  => 31,
						   ]
			);
		}


		return $schema;
	}

}



1			<?php
2
3			declare(strict_types=1);
4
5
6			/**
7			* Circles - Bring cloud-users closer together.
8			*
9			* This file is licensed under the Affero General Public License version 3 or
10			* later. See the COPYING file.
11			*
12			* @author Maxence Lange <[email protected]>
13			* @copyright 2021
14			* @license GNU AGPL version 3 or any later version
15			*
16			* This program is free software: you can redistribute it and/or modify
17			* it under the terms of the GNU Affero General Public License as
18			* published by the Free Software Foundation, either version 3 of the
19			* License, or (at your option) any later version.
20			*
21			* This program is distributed in the hope that it will be useful,
22			* but WITHOUT ANY WARRANTY; without even the implied warranty of
23			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
24			* GNU Affero General Public License for more details.
25			*
26			* You should have received a copy of the GNU Affero General Public License
27			* along with this program. If not, see <http://www.gnu.org/licenses/>.
28			*
29			*/
30
31
32			namespace OCA\Circles\Migration;
33
34			use Closure;
35			use Doctrine\DBAL\Schema\SchemaException;
36			use OCP\DB\ISchemaWrapper;
37			use OCP\IDBConnection;
38			use OCP\Migration\IOutput;
39			use OCP\Migration\SimpleMigrationStep;
40
41
42			/**
43			* Class Version0022Date20220526113601
44			*
45			* @package OCA\Circles\Migration
46			*/
47			class Version0022Date20220623224231 extends SimpleMigrationStep {
48
49
50			/**
51			* @param IDBConnection $connection
52			*/
53			public function __construct(IDBConnection $connection) {
54			}
55
56
57			/**
58			* @param IOutput $output
59			* @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
60			* @param array $options
61			*
62			* @return null\|ISchemaWrapper
63			* @throws SchemaException
64			*/
65			public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {
66			/** @var ISchemaWrapper $schema */
67			$schema = $schemaClosure();
68
69			if ($schema->hasTable('circles_event')) {
70			$table = $schema->getTable('circles_event');
71			if (!$table->hasColumn('updated')) {
72			$table->addColumn(
73			'updated', 'datetime', [
74			'notnull' => false,
75			]
76			);
77			}
78			}
79
80			if ($schema->hasTable('circles_member')) {
81			$table = $schema->getTable('circles_member');
82			if (!$table->hasColumn('invited_by')) {
83			$table->addColumn(
84			'invited_by', 'string', [
85			'notnull' => false,
86			'default' => '',
87			'length' => 31,
88			]
89			);
90			}
91			}
92
93			if ($schema->hasTable('circles_membership')) {
94			$table = $schema->getTable('circles_membership');
95			if (!$table->hasColumn('config')) {
96			$table->addColumn(
97			'config', 'integer', [
98			'notnull' => false,
99			'length' => 11,
100			'unsigned' => true
101			]
102			);
103			$table->addIndex(['single_id', 'config']);
104			}
105
106			}
107
108			if ($schema->hasTable('circles_circle')) {
109			$table = $schema->getTable('circles_circle');
110			if (!$table->hasColumn('sanitized_name')) {
111			$table->addColumn(
112			'sanitized_name', 'string', [
113			'notnull' => false,
114			'default' => '',
115			'length' => 127
116			]
117			);
118
119			$table->addIndex(['sanitized_name']);
120			}
121			}
122
123
124			if ($schema->hasTable('circles_membership')) {
125			$table = $schema->getTable('circles_membership');
126			$table->changeColumn(
127			'circle_id', [
128			'notnull' => true,
129			'length' => 31,
130			]
131			);
132			$table->changeColumn(
133			'single_id', [
134			'notnull' => true,
135			'length' => 31,
136			]
137			);
138			$table->changeColumn(
139			'inheritance_first', [
140			'notnull' => true,
141			'length' => 31,
142			]
143			);
144			$table->changeColumn(
145			'inheritance_last', [
146			'notnull' => true,
147			'length' => 31,
148			]
149			);
150			}
151
152
153			if ($schema->hasTable('circles_mount')) {
154			$table = $schema->getTable('circles_mount');
155			$table->changeColumn(
156			'mount_id', [
157			'notnull' => true,
158			'length' => 31,
159			]
160			);
161			$table->changeColumn(
162			'circle_id', [
163			'notnull' => true,
164			'length' => 31,
165			]
166			);
167			$table->changeColumn(
168			'single_id', [
169			'notnull' => true,
170			'length' => 31,
171			]
172			);
173			}
174
175
176			if ($schema->hasTable('circles_mountpoint')) {
177			$table = $schema->getTable('circles_mountpoint');
178			$table->changeColumn(
179			'mount_id', [
180			'notnull' => true,
181			'length' => 31,
182			]
183			);
184			$table->changeColumn(
185			'single_id', [
186			'notnull' => true,
187			'length' => 31,
188			]
189			);
190			}
191
192
193			if ($schema->hasTable('circles_share_lock')) {
194			$table = $schema->getTable('circles_share_lock');
195			$table->changeColumn(
196			'item_id', [
197			'notnull' => true,
198			'length' => 31,
199			]
200			);
201			$table->changeColumn(
202			'circle_id', [
203			'notnull' => true,
204			'length' => 31,
205			]
206			);
207			}
208
209
210			return $schema;
211			}
212
213			}
214
215

nextcloud / circles

Push — master ( cd91c1...62d6de )

Version0022Date20220623224231::changeSchema() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like