nextcloud / circles

lib/Service/FederatedLinkCreationService.php

Doc Comments +3 added lines, -3 removed lines

@@ -189,8 +189,8 @@ 
 
 
 	/**
-	 * @param $circleUniqueId
-	 * @param $remote
+	 * @param string $circleUniqueId
+	 * @param string $remote
 	 *
 	 * @return FederatedLink
 	 */
@@ -281,7 +281,7 @@ 
 	 *
 	 * Will parse the error reason returned by requestLink() and throw an Exception
 	 *
-	 * @param $reason
+	 * @param string $reason
 	 *
 	 * @throws Exception
 	 * @throws FederatedRemoteDoesNotAllowException

Spacing +3 added lines, -3 removed lines

@@ -164,7 +164,7 @@ 
 	 *
 	 * @throws Exception
 	 */
-	public function requestedLinkFromRemoteCircle(Circle $circle, FederatedLink &$link) {
+	public function requestedLinkFromRemoteCircle(Circle $circle, FederatedLink & $link) {
 
 		try {
 			$this->checkLinkRequestValidity($circle, $link);
@@ -282,7 +282,7 @@ 
 	 * @return boolean
 	 * @throws Exception
 	 */
-	private function forceRequestNewLink(Circle $circle, FederatedLink &$link) {
+	private function forceRequestNewLink(Circle $circle, FederatedLink & $link) {
 		try {
 			$client = $this->clientService->newClient();
 			$args = ['sourceName' => $circle->getName()];
@@ -317,7 +317,7 @@ 
 	 *
 	 * @throws Exception
 	 */
-	private function eventOnRequestLink(Circle $circle, FederatedLink &$link, $status, $reason) {
+	private function eventOnRequestLink(Circle $circle, FederatedLink & $link, $status, $reason) {
 
 		switch ($status) {
 			case FederatedLink::STATUS_LINK_UP:

lib/Service/FederatedLinkService.php

Spacing +5 added lines, -5 removed lines

@@ -217,7 +217,7 @@ 
 	 * @return string
 	 */
 	public function generateLinkRemoteURL($remote) {
-		return $this->configService->generateRemoteHost($remote) . self::REMOTE_URL_LINK;
+		return $this->configService->generateRemoteHost($remote).self::REMOTE_URL_LINK;
 	}
 
 
@@ -322,7 +322,7 @@ 
 	 * @return bool
 	 * @throws Exception
 	 */
-	private function updateLinkRemote(FederatedLink &$link) {
+	private function updateLinkRemote(FederatedLink & $link) {
 
 		try {
 			$client = $this->clientService->newClient();
@@ -378,7 +378,7 @@ 
 	 * @param Circle $circle
 	 * @param FederatedLink $link
 	 */
-	private function checkUpdateLinkFromRemoteLinkRequestSent(Circle $circle, FederatedLink &$link) {
+	private function checkUpdateLinkFromRemoteLinkRequestSent(Circle $circle, FederatedLink & $link) {
 
 		if ($link->getStatus() !== FederatedLink::STATUS_REQUEST_SENT) {
 			return;
@@ -393,7 +393,7 @@ 
 	 * @param Circle $circle
 	 * @param FederatedLink $link
 	 */
-	private function checkUpdateLinkFromRemoteLinkRequested(Circle $circle, FederatedLink &$link) {
+	private function checkUpdateLinkFromRemoteLinkRequested(Circle $circle, FederatedLink & $link) {
 
 		if ($link->getStatus() !== FederatedLink::STATUS_LINK_REQUESTED) {
 			return;
@@ -408,7 +408,7 @@ 
 	 * @param Circle $circle
 	 * @param FederatedLink $link
 	 */
-	private function checkUpdateLinkFromRemoteLinkDown(Circle $circle, FederatedLink &$link) {
+	private function checkUpdateLinkFromRemoteLinkDown(Circle $circle, FederatedLink & $link) {
 
 		if ($link->getStatus() < FederatedLink::STATUS_LINK_DOWN) {
 			return;

lib/Model/FederatedLink.php

Doc Comments +3 added lines

@@ -303,6 +303,9 @@
 	}
 
 
+	/**
+	 * @param integer $status
+	 */
 	public function hasToBeValidStatusUpdate($status) {
 		try {
 			$this->hasToBeValidStatusUpdateWhileLinkDown($status);

lib/Service/MiscService.php

Doc Comments +5 added lines, -2 removed lines

@@ -64,7 +64,7 @@ 
 
 	/**
 	 * @param $arr
-	 * @param $k
+	 * @param string $k
 	 *
 	 * @param string $default
 	 *
@@ -79,6 +79,9 @@ 
 	}
 
 
+	/**
+	 * @param string[] $arr
+	 */
 	public static function mustContains($data, $arr) {
 		if (!is_array($arr)) {
 			$arr = [$arr];
@@ -188,7 +191,7 @@ 
 
 
 	/**
-	 * @param $ident
+	 * @param string $ident
 	 *
 	 * @return mixed|string
 	 */

Spacing +1 added lines, -1 removed lines

@@ -284,7 +284,7 @@
 		ob_start();
 		echo(json_encode($result));
 		$size = ob_get_length();
-		header('Content-Length: ' . $size);
+		header('Content-Length: '.$size);
 		ob_end_flush();
 		flush();
 	}

lib/Controller/TestController.php

Doc Comments +1 added lines, -1 removed lines

@@ -128,7 +128,7 @@
 
 
 	/**
-	 * @return DataResponse
+	 * @return string
 	 */
 	public function testAsyncStatus() {
 		return $this->miscService->success(

Spacing +1 added lines, -1 removed lines

@@ -91,7 +91,7 @@
 	 * @return string
 	 */
 	private function generateTestAsyncURL($remote) {
-		return $this->configService->generateRemoteHost($remote) . Application::TEST_URL_ASYNC;
+		return $this->configService->generateRemoteHost($remote).Application::TEST_URL_ASYNC;
 	}
 
 

lib/Activity/Provider.php

Spacing +9 added lines, -9 removed lines

@@ -123,13 +123,13 @@ 
 	/**
 	 * @param IEvent $event
 	 */
-	private function generateParsedSubject(IEvent &$event) {
+	private function generateParsedSubject(IEvent & $event) {
 		$subject = $event->getRichSubject();
 		$params = $event->getRichSubjectParameters();
 		$ak = array_keys($params);
 		foreach ($ak as $k) {
 			if (is_array($params[$k])) {
-				$subject = str_replace('{' . $k . '}', $params[$k]['parsed'], $subject);
+				$subject = str_replace('{'.$k.'}', $params[$k]['parsed'], $subject);
 			}
 		}
 
@@ -141,7 +141,7 @@ 
 	 * @param IEvent $event
 	 * @param Circle $circle
 	 */
-	private function setIcon(IEvent &$event, Circle $circle) {
+	private function setIcon(IEvent & $event, Circle $circle) {
 		$event->setIcon(
 			CirclesService::getCircleIcon(
 				$circle->getType(),
@@ -159,7 +159,7 @@ 
 	 *
 	 * @throws InvalidArgumentError
 	 */
-	private function parseAsMember(IEvent &$event, Circle $circle, $params) {
+	private function parseAsMember(IEvent & $event, Circle $circle, $params) {
 		if ($event->getType() !== 'circles_as_member') {
 			return;
 		}
@@ -179,7 +179,7 @@ 
 	 *
 	 * @throws Exception
 	 */
-	private function parseAsModerator(IEvent &$event, Circle $circle, $params) {
+	private function parseAsModerator(IEvent & $event, Circle $circle, $params) {
 		if ($event->getType() !== 'circles_as_moderator') {
 			return;
 		}
@@ -199,7 +199,7 @@ 
 	 *
 	 * @throws InvalidArgumentError
 	 */
-	private function parseMemberAsMember(IEvent &$event, Circle $circle, $params) {
+	private function parseMemberAsMember(IEvent & $event, Circle $circle, $params) {
 
 		if (!key_exists('member', $params)) {
 			return;
@@ -221,7 +221,7 @@ 
 	 * @param Circle $circle
 	 * @param array $params
 	 */
-	private function parseGroupAsModerator(IEvent &$event, Circle $circle, $params) {
+	private function parseGroupAsModerator(IEvent & $event, Circle $circle, $params) {
 		if (!key_exists('group', $params)) {
 			return;
 		}
@@ -241,7 +241,7 @@ 
 	 * @param Circle $circle
 	 * @param array $params
 	 */
-	private function parseMemberAsModerator(IEvent &$event, Circle $circle, $params) {
+	private function parseMemberAsModerator(IEvent & $event, Circle $circle, $params) {
 		if (!key_exists('member', $params)) {
 			return;
 		}
@@ -262,7 +262,7 @@ 
 	 * @param Circle $circle
 	 * @param array $params
 	 */
-	private function parseLinkAsModerator(IEvent &$event, Circle $circle, $params) {
+	private function parseLinkAsModerator(IEvent & $event, Circle $circle, $params) {
 
 		if (!key_exists('link', $params)) {
 			return;

lib/Activity/ProviderSubjectGroup.php

Spacing +3 added lines, -3 removed lines

@@ -44,7 +44,7 @@ 
 	 *
 	 * @throws FakeException
 	 */
-	public function parseGroupLink(IEvent &$event, Circle $circle, Member $group) {
+	public function parseGroupLink(IEvent & $event, Circle $circle, Member $group) {
 		if ($event->getSubject() !== 'group_link') {
 			return;
 		}
@@ -65,7 +65,7 @@ 
 	 *
 	 * @throws FakeException
 	 */
-	public function parseGroupUnlink(IEvent &$event, Circle $circle, Member $group) {
+	public function parseGroupUnlink(IEvent & $event, Circle $circle, Member $group) {
 		if ($event->getSubject() !== 'group_unlink') {
 			return;
 		}
@@ -86,7 +86,7 @@ 
 	 *
 	 * @throws FakeException
 	 */
-	public function parseGroupLevel(IEvent &$event, Circle $circle, Member $group) {
+	public function parseGroupLevel(IEvent & $event, Circle $circle, Member $group) {
 		if ($event->getSubject() !== 'group_level') {
 			return;
 		}

lib/Activity/ProviderParser.php

Spacing +9 added lines, -9 removed lines

@@ -73,7 +73,7 @@ 
 	 * @param string $othersEvent
 	 */
 	protected function parseCircleEvent(
-		IEvent &$event, Circle $circle, $remote, $ownEvent, $othersEvent
+		IEvent & $event, Circle $circle, $remote, $ownEvent, $othersEvent
 	) {
 		$data = [
 			'author' => $this->generateViewerParameter($circle),
@@ -101,7 +101,7 @@ 
 	 * @param $othersEvent
 	 */
 	protected function parseMemberEvent(
-		IEvent &$event, Circle $circle, Member $member, $ownEvent, $othersEvent
+		IEvent & $event, Circle $circle, Member $member, $ownEvent, $othersEvent
 	) {
 		$data = [
 			'circle' => $this->generateCircleParameter($circle),
@@ -127,7 +127,7 @@ 
 	 * @param IEvent $event
 	 * @param string $line
 	 */
-	protected function parseLinkEvent(IEvent &$event, Circle $circle, FederatedLink $remote, $line
+	protected function parseLinkEvent(IEvent & $event, Circle $circle, FederatedLink $remote, $line
 	) {
 		$data = [
 			'circle' => $this->generateCircleParameter($circle),
@@ -148,7 +148,7 @@ 
 	 * @param string $othersEvent
 	 */
 	protected function parseCircleMemberEvent(
-		IEvent &$event, Circle $circle, Member $member, $ownEvent, $othersEvent
+		IEvent & $event, Circle $circle, Member $member, $ownEvent, $othersEvent
 	) {
 		$data = [
 			'author'   => $this->generateViewerParameter($circle),
@@ -179,7 +179,7 @@ 
 	 * @param $othersEvent
 	 */
 	protected function parseCircleMemberAdvancedEvent(
-		IEvent &$event, Circle $circle, Member $member, $ownEvent, $targetEvent, $othersEvent
+		IEvent & $event, Circle $circle, Member $member, $ownEvent, $targetEvent, $othersEvent
 	) {
 		$data = [
 			'author' => $this->generateViewerParameter($circle),
@@ -244,9 +244,9 @@ 
 	 */
 	protected function generateExternalMemberParameter(Member $member) {
 		return [
-			'type'   => 'member_' . $member->getType(),
+			'type'   => 'member_'.$member->getType(),
 			'id'     => $member->getUserId(),
-			'name'   => $member->getDisplayName() . ' (' . $member->getTypeString() . ')',
+			'name'   => $member->getDisplayName().' ('.$member->getTypeString().')',
 			'parsed' => $member->getDisplayName()
 		];
 	}
@@ -277,8 +277,8 @@ 
 		return [
 			'type'   => 'circle',
 			'id'     => $link->getUniqueId(),
-			'name'   => $link->getToken() . '@' . $link->getAddress(),
-			'parsed' => $link->getToken() . '@' . $link->getAddress()
+			'name'   => $link->getToken().'@'.$link->getAddress(),
+			'parsed' => $link->getToken().'@'.$link->getAddress()
 		];
 	}
 

lib/Activity/ProviderSubjectCircle.php

Spacing +2 added lines, -2 removed lines

@@ -43,7 +43,7 @@ 
 	 *
 	 * @throws FakeException
 	 */
-	public function parseSubjectCircleCreate(IEvent &$event, Circle $circle) {
+	public function parseSubjectCircleCreate(IEvent & $event, Circle $circle) {
 		if ($event->getSubject() !== 'circle_create') {
 			return;
 		}
@@ -64,7 +64,7 @@ 
 	 *
 	 * @throws FakeException
 	 */
-	public function parseSubjectCircleDelete(IEvent &$event, Circle $circle) {
+	public function parseSubjectCircleDelete(IEvent & $event, Circle $circle) {
 		if ($event->getSubject() !== 'circle_delete') {
 			return;
 		}