Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 36 | class ProviderSubjectMember extends ProviderParser { |
||
| 37 | |||
| 38 | /** |
||
| 39 | * Parse on Subject 'member_join'. |
||
| 40 | * If circle is closed, we say that user accepted his invitation. |
||
| 41 | * |
||
| 42 | * @param IEvent $event |
||
| 43 | * @param Circle $circle |
||
| 44 | * @param Member $member |
||
| 45 | * |
||
| 46 | * @throws FakeException |
||
| 47 | */ |
||
| 48 | public function parseSubjectMemberJoin(IEvent &$event, Circle $circle, Member $member) { |
||
| 61 | |||
| 62 | |||
| 63 | /** |
||
| 64 | * @param IEvent $event |
||
| 65 | * @param Circle $circle |
||
| 66 | * @param Member $member |
||
| 67 | * |
||
| 68 | * @throws FakeException |
||
| 69 | */ |
||
| 70 | private function parseSubjectMemberJoinClosedCircle(IEvent &$event, Circle $circle, Member $member) { |
||
| 83 | |||
| 84 | |||
| 85 | /** |
||
| 86 | * Parse on Subject 'member_add'. |
||
| 87 | * If circle is closed, we say that user's invitation was accepted. |
||
| 88 | * |
||
| 89 | * @param IEvent $event |
||
| 90 | * @param Circle $circle |
||
| 91 | * @param Member $member |
||
| 92 | * |
||
| 93 | * @throws FakeException |
||
| 94 | */ |
||
| 95 | View Code Duplication | public function parseSubjectMemberAdd(IEvent &$event, Circle $circle, Member $member) { |
|
| 111 | |||
| 112 | |||
| 113 | /** |
||
| 114 | * @param IEvent $event |
||
| 115 | * @param Circle $circle |
||
| 116 | * @param Member $member |
||
| 117 | * |
||
| 118 | * @throws FakeException |
||
| 119 | */ |
||
| 120 | View Code Duplication | private function parseSubjectMemberAddNotLocalMember(IEvent &$event, Circle $circle, Member $member |
|
| 134 | |||
| 135 | |||
| 136 | /** |
||
| 137 | * @param IEvent $event |
||
| 138 | * @param Circle $circle |
||
| 139 | * @param Member $member |
||
| 140 | * |
||
| 141 | * @throws FakeException |
||
| 142 | */ |
||
| 143 | private function parseSubjectMemberAddClosedCircle(IEvent &$event, Circle $circle, Member $member) { |
||
| 157 | |||
| 158 | |||
| 159 | /** |
||
| 160 | * Parse on Subject 'member_left'. |
||
| 161 | * If circle is closed and member was not a real member, we send him to |
||
| 162 | * parseSubjectNonMemberLeftClosedCircle(); |
||
| 163 | * |
||
| 164 | * @param IEvent $event |
||
| 165 | * @param Circle $circle |
||
| 166 | * @param Member $member |
||
| 167 | * |
||
| 168 | * @throws FakeException |
||
| 169 | */ |
||
| 170 | public function parseSubjectMemberLeft(IEvent &$event, Circle $circle, Member $member) { |
||
| 185 | |||
| 186 | |||
| 187 | /** |
||
| 188 | * Parse on Subject 'member_left' on a closed circle when user were not yet a member. |
||
| 189 | * If status is Invited we say that member rejected his invitation. |
||
| 190 | * If status is Requested we say he dismissed his request. |
||
| 191 | * |
||
| 192 | * @param IEvent $event |
||
| 193 | * @param Circle $circle |
||
| 194 | * @param Member $member |
||
| 195 | * |
||
| 196 | * @throws FakeException |
||
| 197 | */ |
||
| 198 | private function parseSubjectNonMemberLeftClosedCircle(IEvent &$event, Circle $circle, Member $member |
||
| 221 | |||
| 222 | |||
| 223 | /** |
||
| 224 | * Parse on Subject 'member_remove'. |
||
| 225 | * If circle is closed and member was not a real member, we send him to |
||
| 226 | * parseSubjectNonMemberRemoveClosedCircle(); |
||
| 227 | * |
||
| 228 | * @param IEvent $event |
||
| 229 | * @param Circle $circle |
||
| 230 | * @param Member $member |
||
| 231 | * |
||
| 232 | * @throws FakeException |
||
| 233 | */ |
||
| 234 | View Code Duplication | public function parseSubjectMemberRemove(IEvent &$event, Circle $circle, Member $member) { |
|
| 251 | |||
| 252 | |||
| 253 | /** |
||
| 254 | * @param IEvent $event |
||
| 255 | * @param Circle $circle |
||
| 256 | * @param Member $member |
||
| 257 | * |
||
| 258 | * @throws FakeException |
||
| 259 | */ |
||
| 260 | View Code Duplication | private function parseSubjectMemberRemoveNotLocalMember( |
|
| 275 | |||
| 276 | |||
| 277 | /** |
||
| 278 | * Parse on Subject 'member_remove' on a closed circle when user were not yet a member. |
||
| 279 | * If status is Invited we say that author cancelled his invitation. |
||
| 280 | * If status is Requested we say that his invitation was rejected. |
||
| 281 | * |
||
| 282 | * @param IEvent $event |
||
| 283 | * @param Circle $circle |
||
| 284 | * @param Member $member |
||
| 285 | * |
||
| 286 | * @throws FakeException |
||
| 287 | */ |
||
| 288 | private function parseSubjectMemberRemoveNotYetMember( |
||
| 306 | |||
| 307 | |||
| 308 | View Code Duplication | private function parseSubjectMemberRemoveNotYetMemberRequesting( |
|
| 324 | |||
| 325 | |||
| 326 | /** |
||
| 327 | * @param IEvent $event |
||
| 328 | * @param Circle $circle |
||
| 329 | * @param Member $member |
||
| 330 | * |
||
| 331 | * @throws FakeException |
||
| 332 | */ |
||
| 333 | View Code Duplication | public function parseMemberInvited(IEvent &$event, Circle $circle, Member $member) { |
|
| 347 | |||
| 348 | |||
| 349 | /** |
||
| 350 | * @param IEvent $event |
||
| 351 | * @param Circle $circle |
||
| 352 | * @param Member $member |
||
| 353 | * |
||
| 354 | * @throws FakeException |
||
| 355 | */ |
||
| 356 | View Code Duplication | public function parseMemberLevel(IEvent &$event, Circle $circle, Member $member) { |
|
| 371 | |||
| 372 | |||
| 373 | /** |
||
| 374 | * @param IEvent $event |
||
| 375 | * @param Circle $circle |
||
| 376 | * @param Member $member |
||
| 377 | * |
||
| 378 | * @throws FakeException |
||
| 379 | */ |
||
| 380 | View Code Duplication | public function parseMemberRequestInvitation(IEvent &$event, Circle $circle, Member $member) { |
|
| 393 | |||
| 394 | |||
| 395 | /** |
||
| 396 | * @param IEvent $event |
||
| 397 | * @param Circle $circle |
||
| 398 | * @param Member $member |
||
| 399 | * |
||
| 400 | * @throws FakeException |
||
| 401 | */ |
||
| 402 | View Code Duplication | public function parseMemberOwner(IEvent &$event, Circle $circle, Member $member) { |
|
| 414 | } |
Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line.