nextcloud / circles

lib/Service/SharingFrameService.php

Doc Comments +2 added lines, -2 removed lines

@@ -181,7 +181,7 @@ 
 	 *
 	 * @param SharingFrame $frame
 	 * @param DeprecatedCircle $circle
-	 * @param $broadcast
+	 * @param string|null $broadcast
 	 */
 	private function generateHeaders(SharingFrame $frame, DeprecatedCircle $circle, $broadcast) {
 
@@ -220,7 +220,7 @@ 
 	 * Please use getFrameFromCircle();
 	 *
 	 * @param string $circleUniqueId
-	 * @param $viewerId
+	 * @param string $viewerId
 	 *
 	 * @return SharingFrame[]
 	 * @throws CircleDoesNotExistException

Unused Use Statements -1 removed lines

@@ -38,7 +38,6 @@
 use OCA\Circles\Exceptions\CircleDoesNotExistException;
 use OCA\Circles\Exceptions\ConfigNoCircleAvailableException;
 use OCA\Circles\Exceptions\MemberDoesNotExistException;
-use OCA\Circles\Exceptions\PayloadDeliveryException;
 use OCA\Circles\Exceptions\SharingFrameAlreadyDeliveredException;
 use OCA\Circles\Exceptions\SharingFrameAlreadyExistException;
 use OCA\Circles\Exceptions\SharingFrameDoesNotExistException;

lib/Model/DeprecatedCircle.php

Doc Comments +1 added lines, -1 removed lines

@@ -178,7 +178,7 @@
 
 	/**
 	 * @param array $arr
-	 * @param $key
+	 * @param string $key
 	 * @param int $type
 	 *
 	 * @return null|DeprecatedMember

lib/Model/DeprecatedMember.php

Doc Comments +3 added lines

@@ -41,6 +41,9 @@
 class DeprecatedMember extends BaseMember {
 
 
+	/**
+	 * @param integer $circleType
+	 */
 	public function inviteToCircle($circleType) {
 
 		if ($circleType === 0) {

Unused Use Statements -2 removed lines

@@ -31,9 +31,7 @@
 use OCA\Circles\Exceptions\MemberCantJoinCircleException;
 use OCA\Circles\Exceptions\MemberDoesNotExistException;
 use OCA\Circles\Exceptions\MemberIsBlockedException;
-use OCA\Circles\Exceptions\MemberIsNotAdminException;
 use OCA\Circles\Exceptions\MemberIsNotModeratorException;
-use OCA\Circles\Exceptions\MemberIsNotOwnerException;
 use OCA\Circles\Exceptions\MemberIsOwnerException;
 use OCA\Circles\Exceptions\MemberTypeCantEditLevelException;
 use OCA\Circles\Exceptions\ModeratorIsNotHighEnoughException;

lib/Service/GroupsService.php

Doc Comments +6 added lines, -6 removed lines

@@ -109,7 +109,7 @@ 
 	 * @param string $circleUniqueId
 	 * @param string $groupId
 	 *
-	 * @return array
+	 * @return DeprecatedMember[]
 	 * @throws \Exception
 	 */
 	public function linkGroup($circleUniqueId, $groupId) {
@@ -165,8 +165,8 @@ 
 	/**
 	 * Check if a fresh member can be generated (by linkGroup)
 	 *
-	 * @param $circleId
-	 * @param $groupId
+	 * @param string $circleId
+	 * @param string $groupId
 	 *
 	 * @return null|DeprecatedMember
 	 * @throws MemberAlreadyExistsException
@@ -202,7 +202,7 @@ 
 	 * @param string $groupId
 	 * @param int $level
 	 *
-	 * @return array
+	 * @return DeprecatedMember[]
 	 * @throws \Exception
 	 */
 	public function levelGroup($circleUniqueId, $groupId, $level) {
@@ -243,7 +243,7 @@ 
 	/**
 	 * @param DeprecatedCircle $circle
 	 * @param DeprecatedMember $group
-	 * @param $level
+	 * @param integer $level
 	 *
 	 * @throws \Exception
 	 */
@@ -270,7 +270,7 @@ 
 	 * @param string $circleUniqueId
 	 * @param string $groupId
 	 *
-	 * @return array
+	 * @return DeprecatedMember[]
 	 * @throws \Exception
 	 */
 	public function unlinkGroup($circleUniqueId, $groupId) {

lib/Service/MembersService.php

Doc Comments +7 added lines, -7 removed lines

@@ -349,8 +349,8 @@ 
 	/**
 	 * Verify if a local account is valid.
 	 *
-	 * @param $ident
-	 * @param $type
+	 * @param string $ident
+	 * @param integer $type
 	 *
 	 * @param string $instance
 	 *
@@ -401,8 +401,8 @@ 
 	/**
 	 * Verify if a contact exist in current user address books.
 	 *
-	 * @param $ident
-	 * @param $type
+	 * @param string $ident
+	 * @param integer $type
 	 *
 	 * @throws NoUserException
 	 * @throws EmailAccountInvalidFormatException
@@ -494,8 +494,8 @@ 
 	 * Will return any data of a user related to a circle (as a Member). User can be a 'non-member'
 	 * Viewer needs to be at least Member of the Circle
 	 *
-	 * @param $circleId
-	 * @param $userId
+	 * @param string $circleId
+	 * @param string $userId
 	 * @param $type
 	 * @param bool $forceAll
 	 *
@@ -551,7 +551,7 @@ 
 	 * @param int $level
 	 * @param bool $force
 	 *
-	 * @return array
+	 * @return DeprecatedMember[]
 	 * @throws CircleDoesNotExistException
 	 * @throws CircleTypeNotValidException
 	 * @throws ConfigNoCircleAvailableException

Unused Use Statements -1 removed lines

@@ -27,7 +27,6 @@
 namespace OCA\Circles\Service;
 
 
-use daita\MySmallPhpTools\Exceptions\RequestNetworkException;
 use daita\MySmallPhpTools\Exceptions\RequestResultNotJsonException;
 use daita\MySmallPhpTools\Model\Nextcloud\nc22\NC22Request;
 use daita\MySmallPhpTools\Model\Request;

lib/Model/Federated/FederatedEvent.php

Doc Comments +1 added lines, -1 removed lines

@@ -111,7 +111,7 @@
 	}
 
 	/**
-	 * @param mixed $class
+	 * @param string $class
 	 *
 	 * @return self
 	 */

lib/Db/CoreRequestBuilder.php

Doc Comments +1 added lines, -1 removed lines

@@ -110,7 +110,7 @@
 
 
 	/**
-	 * @param array $ids
+	 * @param string[] $ids
 	 *
 	 * @throws InvalidIdException
 	 */

lib/Api/v1/Circles.php

Unused Use Statements -1 removed lines

@@ -41,7 +41,6 @@
 use OCA\Circles\Service\MembersService;
 use OCA\Circles\Service\SharingFrameService;
 use OCP\AppFramework\QueryException;
-use OCP\Util;
 
 class Circles {
 

lib/Command/CirclesCheck.php

Unused Use Statements -1 removed lines

@@ -46,7 +46,6 @@
 use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Question\ConfirmationQuestion;
-use Symfony\Component\Process\Process;
 
 
 /**