Completed
Pull Request — master (#551)
by Maxence
03:10 queued 01:14
created
lib/Db/CoreRequestBuilder.php 1 patch
Spacing   +43 added lines, -43 removed lines patch added patch discarded remove patch
@@ -170,16 +170,16 @@  discard block
 block discarded – undo
170 170
 		$this->generateMemberSelectAlias($alias, self::PREFIX_MEMBER)
171 171
 			 ->leftJoin(
172 172
 				 $this->getDefaultSelectAlias(), CoreQueryBuilder::TABLE_MEMBER, $alias,
173
-				 $expr->eq($alias . '.circle_id', $this->getDefaultSelectAlias() . '.unique_id')
173
+				 $expr->eq($alias.'.circle_id', $this->getDefaultSelectAlias().'.unique_id')
174 174
 			 );
175 175
 
176 176
 		// TODO: Check in big table if it is better to put condition in andWhere() or in LeftJoin()
177 177
 		$this->andWhere(
178 178
 			$expr->andX(
179
-				$expr->eq($alias . '.user_id', $this->createNamedParameter($member->getUserId())),
180
-				$expr->eq($alias . '.user_type', $this->createNamedParameter($member->getUserType())),
181
-				$expr->eq($alias . '.instance', $this->createNamedParameter($this->getInstance($member))),
182
-				$expr->gte($alias . '.level', $this->createNamedParameter($level))
179
+				$expr->eq($alias.'.user_id', $this->createNamedParameter($member->getUserId())),
180
+				$expr->eq($alias.'.user_type', $this->createNamedParameter($member->getUserType())),
181
+				$expr->eq($alias.'.instance', $this->createNamedParameter($this->getInstance($member))),
182
+				$expr->gte($alias.'.level', $this->createNamedParameter($level))
183 183
 			)
184 184
 		);
185 185
 	}
@@ -200,7 +200,7 @@  discard block
 block discarded – undo
200 200
 			 ->leftJoin(
201 201
 				 $this->getDefaultSelectAlias(), CoreQueryBuilder::TABLE_CIRCLE, $alias,
202 202
 				 $expr->andX(
203
-					 $expr->eq($alias . '.unique_id', $this->getDefaultSelectAlias() . '.circle_id')
203
+					 $expr->eq($alias.'.unique_id', $this->getDefaultSelectAlias().'.circle_id')
204 204
 				 )
205 205
 			 );
206 206
 
@@ -230,8 +230,8 @@  discard block
 block discarded – undo
230 230
 			 ->leftJoin(
231 231
 				 $circleTableAlias, CoreQueryBuilder::TABLE_MEMBER, $alias,
232 232
 				 $expr->andX(
233
-					 $expr->eq($alias . '.circle_id', $circleTableAlias . '.unique_id'),
234
-					 $expr->eq($alias . '.level', $this->createNamedParameter(Member::LEVEL_OWNER))
233
+					 $expr->eq($alias.'.circle_id', $circleTableAlias.'.unique_id'),
234
+					 $expr->eq($alias.'.level', $this->createNamedParameter(Member::LEVEL_OWNER))
235 235
 				 )
236 236
 			 );
237 237
 	}
@@ -264,11 +264,11 @@  discard block
 block discarded – undo
264 264
 			 ->leftJoin(
265 265
 				 $aliasCircle, CoreQueryBuilder::TABLE_MEMBER, $alias,
266 266
 				 $expr->andX(
267
-					 $expr->eq($alias . '.circle_id', $aliasCircle . '.unique_id'),
268
-					 $expr->eq($alias . '.user_id', $this->createNamedParameter($initiator->getUserId())),
269
-					 $expr->eq($alias . '.user_type', $this->createNamedParameter($initiator->getUserType())),
267
+					 $expr->eq($alias.'.circle_id', $aliasCircle.'.unique_id'),
268
+					 $expr->eq($alias.'.user_id', $this->createNamedParameter($initiator->getUserId())),
269
+					 $expr->eq($alias.'.user_type', $this->createNamedParameter($initiator->getUserType())),
270 270
 					 $expr->eq(
271
-						 $alias . '.instance', $this->createNamedParameter($this->getInstance($initiator))
271
+						 $alias.'.instance', $this->createNamedParameter($this->getInstance($initiator))
272 272
 					 )
273 273
 				 )
274 274
 			 );
@@ -294,9 +294,9 @@  discard block
 block discarded – undo
294 294
 		$this->leftJoin(
295 295
 			$this->getDefaultSelectAlias(), CoreQueryBuilder::TABLE_MEMBER, $alias,
296 296
 			$expr->andX(
297
-				$expr->eq($alias . '.circle_id', $aliasCircle . '.unique_id'),
298
-				$expr->eq($alias . '.instance', $this->createNamedParameter($instance)),
299
-				$expr->gte($alias . '.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
297
+				$expr->eq($alias.'.circle_id', $aliasCircle.'.unique_id'),
298
+				$expr->eq($alias.'.instance', $this->createNamedParameter($instance)),
299
+				$expr->gte($alias.'.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
300 300
 			)
301 301
 		);
302 302
 	}
@@ -321,17 +321,17 @@  discard block
 block discarded – undo
321 321
 		$this->leftJoin(
322 322
 			$this->getDefaultSelectAlias(), CoreQueryBuilder::TABLE_MEMBER, $alias,
323 323
 			$expr->andX(
324
-				$expr->eq($alias . '.single_id', $aliasCircle . '.unique_id'),
325
-				$expr->emptyString($alias . '.instance'),
326
-				$expr->gte($alias . '.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
324
+				$expr->eq($alias.'.single_id', $aliasCircle.'.unique_id'),
325
+				$expr->emptyString($alias.'.instance'),
326
+				$expr->gte($alias.'.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
327 327
 			)
328 328
 		);
329 329
 		$this->leftJoin(
330 330
 			$this->getDefaultSelectAlias(), CoreQueryBuilder::TABLE_MEMBER, $aliasRemoteOwner,
331 331
 			$expr->andX(
332
-				$expr->eq($alias . '.circle_id', $aliasRemoteOwner . '.circle_id'),
333
-				$expr->eq($aliasRemoteOwner . '.instance', $this->createNamedParameter($instance)),
334
-				$expr->eq($aliasRemoteOwner . '.level', $this->createNamedParameter(Member::LEVEL_OWNER))
332
+				$expr->eq($alias.'.circle_id', $aliasRemoteOwner.'.circle_id'),
333
+				$expr->eq($aliasRemoteOwner.'.instance', $this->createNamedParameter($instance)),
334
+				$expr->eq($aliasRemoteOwner.'.level', $this->createNamedParameter(Member::LEVEL_OWNER))
335 335
 			)
336 336
 		);
337 337
 	}
@@ -351,7 +351,7 @@  discard block
 block discarded – undo
351 351
 		$expr = $this->expr();
352 352
 		$this->leftJoin(
353 353
 			$this->getDefaultSelectAlias(), CoreQueryBuilder::TABLE_REMOTE, $alias,
354
-			$expr->eq($alias . '.instance', $this->createNamedParameter($instance))
354
+			$expr->eq($alias.'.instance', $this->createNamedParameter($instance))
355 355
 		);
356 356
 	}
357 357
 
@@ -375,16 +375,16 @@  discard block
 block discarded – undo
375 375
 		// - 4 (Visible to everyone)
376 376
 		$orX = $expr->orX();
377 377
 		$orX->add(
378
-			$expr->andX($expr->gte($alias . '.level', $this->createNamedParameter(Member::LEVEL_MEMBER)))
378
+			$expr->andX($expr->gte($alias.'.level', $this->createNamedParameter(Member::LEVEL_MEMBER)))
379 379
 		);
380 380
 		$orX->add(
381 381
 			$expr->andX(
382
-				$expr->bitwiseAnd($aliasCircle . '.config', Circle::CFG_PERSONAL),
383
-				$expr->eq($alias . '.level', $this->createNamedParameter(Member::LEVEL_OWNER))
382
+				$expr->bitwiseAnd($aliasCircle.'.config', Circle::CFG_PERSONAL),
383
+				$expr->eq($alias.'.level', $this->createNamedParameter(Member::LEVEL_OWNER))
384 384
 			)
385 385
 		);
386 386
 		if (!$mustBeMember) {
387
-			$orX->add($expr->bitwiseAnd($aliasCircle . '.config', Circle::CFG_VISIBLE));
387
+			$orX->add($expr->bitwiseAnd($aliasCircle.'.config', Circle::CFG_VISIBLE));
388 388
 		}
389 389
 		$this->andWhere($orX);
390 390
 
@@ -420,10 +420,10 @@  discard block
 block discarded – undo
420 420
 		$expr = $this->expr();
421 421
 
422 422
 		$orHidden = $expr->orX();
423
-		$orHidden->add($expr->bitwiseAnd($alias . '.config', Circle::CFG_SINGLE));
424
-		$orHidden->add($expr->bitwiseAnd($alias . '.config', Circle::CFG_HIDDEN));
425
-		$orHidden->add($expr->bitwiseAnd($alias . '.config', Circle::CFG_BACKEND));
426
-		$this->andWhere($this->createFunction('NOT') . $orHidden);
423
+		$orHidden->add($expr->bitwiseAnd($alias.'.config', Circle::CFG_SINGLE));
424
+		$orHidden->add($expr->bitwiseAnd($alias.'.config', Circle::CFG_HIDDEN));
425
+		$orHidden->add($expr->bitwiseAnd($alias.'.config', Circle::CFG_BACKEND));
426
+		$this->andWhere($this->createFunction('NOT').$orHidden);
427 427
 	}
428 428
 
429 429
 
@@ -456,16 +456,16 @@  discard block
 block discarded – undo
456 456
 
457 457
 		$orX = $expr->orX();
458 458
 		$orX->add(
459
-			$expr->eq($alias . '.type', $this->createNamedParameter(RemoteInstance::TYPE_GLOBAL_SCALE))
459
+			$expr->eq($alias.'.type', $this->createNamedParameter(RemoteInstance::TYPE_GLOBAL_SCALE))
460 460
 		);
461 461
 
462 462
 		$orExtOrPassive = $expr->orX();
463 463
 		$orExtOrPassive->add(
464
-			$expr->eq($alias . '.type', $this->createNamedParameter(RemoteInstance::TYPE_EXTERNAL))
464
+			$expr->eq($alias.'.type', $this->createNamedParameter(RemoteInstance::TYPE_EXTERNAL))
465 465
 		);
466 466
 		if (!$sensitive) {
467 467
 			$orExtOrPassive->add(
468
-				$expr->eq($alias . '.type', $this->createNamedParameter(RemoteInstance::TYPE_PASSIVE))
468
+				$expr->eq($alias.'.type', $this->createNamedParameter(RemoteInstance::TYPE_PASSIVE))
469 469
 			);
470 470
 		} else {
471 471
 			if ($this->getDefaultSelectAlias() === 'm') {
@@ -475,8 +475,8 @@  discard block
 block discarded – undo
475 475
 
476 476
 
477 477
 		$orInstance = $expr->orX();
478
-		$orInstance->add($expr->isNotNull($aliasMembers . '.instance'));
479
-		$orInstance->add($expr->isNotNull($aliasRemoteOwner . '.instance'));
478
+		$orInstance->add($expr->isNotNull($aliasMembers.'.instance'));
479
+		$orInstance->add($expr->isNotNull($aliasRemoteOwner.'.instance'));
480 480
 
481 481
 		$andExternal = $expr->andX();
482 482
 		$andExternal->add($orExtOrPassive);
@@ -485,13 +485,13 @@  discard block
 block discarded – undo
485 485
 		$orExtOrTrusted = $expr->orX();
486 486
 		$orExtOrTrusted->add($andExternal);
487 487
 		$orExtOrTrusted->add(
488
-			$expr->eq($alias . '.type', $this->createNamedParameter(RemoteInstance::TYPE_TRUSTED))
488
+			$expr->eq($alias.'.type', $this->createNamedParameter(RemoteInstance::TYPE_TRUSTED))
489 489
 		);
490 490
 
491 491
 		$andTrusted = $expr->andX();
492 492
 		$andTrusted->add($orExtOrTrusted);
493
-		$andTrusted->add($expr->bitwiseAnd($aliasCircle . '.config', Circle::CFG_FEDERATED));
494
-		$andTrusted->add($expr->emptyString($aliasOwner . '.instance'));
493
+		$andTrusted->add($expr->bitwiseAnd($aliasCircle.'.config', Circle::CFG_FEDERATED));
494
+		$andTrusted->add($expr->emptyString($aliasOwner.'.instance'));
495 495
 		$orX->add($andTrusted);
496 496
 
497 497
 		$this->andWhere($orX);
@@ -509,21 +509,21 @@  discard block
 block discarded – undo
509 509
 		$expr = $this->expr();
510 510
 		$andPassive = $expr->andX();
511 511
 		$andPassive->add(
512
-			$expr->eq($alias . '.type', $this->createNamedParameter(RemoteInstance::TYPE_PASSIVE))
512
+			$expr->eq($alias.'.type', $this->createNamedParameter(RemoteInstance::TYPE_PASSIVE))
513 513
 		);
514 514
 
515 515
 		$orMemberOrLevel = $expr->orX();
516 516
 		$orMemberOrLevel->add(
517
-			$expr->eq($this->getDefaultSelectAlias() . '.instance', $alias . '.instance')
517
+			$expr->eq($this->getDefaultSelectAlias().'.instance', $alias.'.instance')
518 518
 		);
519 519
 		// TODO: do we need this ? (display members from the local instance)
520 520
 		$orMemberOrLevel->add(
521
-			$expr->emptyString($this->getDefaultSelectAlias() . '.instance')
521
+			$expr->emptyString($this->getDefaultSelectAlias().'.instance')
522 522
 		);
523 523
 
524 524
 		$orMemberOrLevel->add(
525 525
 			$expr->eq(
526
-				$this->getDefaultSelectAlias() . '.level',
526
+				$this->getDefaultSelectAlias().'.level',
527 527
 				$this->createNamedParameter(Member::LEVEL_OWNER)
528 528
 			)
529 529
 		);
@@ -538,7 +538,7 @@  discard block
 block discarded – undo
538 538
 	 * @param int $flag
539 539
 	 */
540 540
 	public function filterConfig(int $flag): void {
541
-		$this->andWhere($this->expr()->bitwiseAnd($this->getDefaultSelectAlias() . '.config', $flag));
541
+		$this->andWhere($this->expr()->bitwiseAnd($this->getDefaultSelectAlias().'.config', $flag));
542 542
 	}
543 543
 
544 544
 
Please login to merge, or discard this patch.