Completed
Pull Request — master (#551)
by Maxence
03:10 queued 01:14
created
lib/Circles/FileSharingBroadcaster.php 1 patch
Doc Comments   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -427,7 +427,7 @@  discard block
 block discarded – undo
427 427
 	 * @param $fileName
428 428
 	 * @param string $link
429 429
 	 * @param string $author
430
-	 * @param $circleName
430
+	 * @param string $circleName
431 431
 	 * @param string $email
432 432
 	 *
433 433
 	 * @throws Exception
@@ -464,7 +464,7 @@  discard block
 block discarded – undo
464 464
 	 * @param string $circleName
465 465
 	 * @param string $email
466 466
 	 *
467
-	 * @param $password
467
+	 * @param string $password
468 468
 	 *
469 469
 	 * @throws NotFoundException
470 470
 	 * @throws Exception
@@ -546,7 +546,7 @@  discard block
 block discarded – undo
546 546
 	 * @param $subject
547 547
 	 * @param $text
548 548
 	 * @param $fileName
549
-	 * @param $link
549
+	 * @param string $link
550 550
 	 * @param string $author
551 551
 	 * @param string $circleName
552 552
 	 *
@@ -714,7 +714,7 @@  discard block
 block discarded – undo
714 714
 
715 715
 
716 716
 	/**
717
-	 * @param $author
717
+	 * @param string $author
718 718
 	 * @param string $circleName
719 719
 	 *
720 720
 	 * @return IEMailTemplate
@@ -757,8 +757,8 @@  discard block
 block discarded – undo
757 757
 
758 758
 	/**
759 759
 	 * @param IEMailTemplate $emailTemplate
760
-	 * @param $author
761
-	 * @param $recipient
760
+	 * @param string $author
761
+	 * @param string $recipient
762 762
 	 *
763 763
 	 * @throws Exception
764 764
 	 */
Please login to merge, or discard this patch.
lib/Service/MiscService.php 1 patch
Doc Comments   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
 
79 79
 	/**
80 80
 	 * @param $arr
81
-	 * @param $k
81
+	 * @param string $k
82 82
 	 *
83 83
 	 * @param string $default
84 84
 	 *
@@ -93,6 +93,9 @@  discard block
 block discarded – undo
93 93
 	}
94 94
 
95 95
 
96
+	/**
97
+	 * @param string[] $arr
98
+	 */
96 99
 	public static function mustContains($data, $arr) {
97 100
 		if (!is_array($arr)) {
98 101
 			$arr = [$arr];
@@ -250,7 +253,7 @@  discard block
 block discarded – undo
250 253
 
251 254
 
252 255
 	/**
253
-	 * @param $ident
256
+	 * @param string $ident
254 257
 	 *
255 258
 	 * @return mixed|string
256 259
 	 * @deprecated
Please login to merge, or discard this patch.
lib/Service/SharingFrameService.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -181,7 +181,7 @@  discard block
 block discarded – undo
181 181
 	 *
182 182
 	 * @param SharingFrame $frame
183 183
 	 * @param DeprecatedCircle $circle
184
-	 * @param $broadcast
184
+	 * @param string|null $broadcast
185 185
 	 */
186 186
 	private function generateHeaders(SharingFrame $frame, DeprecatedCircle $circle, $broadcast) {
187 187
 
@@ -220,7 +220,7 @@  discard block
 block discarded – undo
220 220
 	 * Please use getFrameFromCircle();
221 221
 	 *
222 222
 	 * @param string $circleUniqueId
223
-	 * @param $viewerId
223
+	 * @param string $viewerId
224 224
 	 *
225 225
 	 * @return SharingFrame[]
226 226
 	 * @throws CircleDoesNotExistException
Please login to merge, or discard this patch.
lib/Db/DeprecatedMembersRequest.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -316,7 +316,7 @@  discard block
 block discarded – undo
316 316
 	 * returns the index of a specific UserID in a Members List
317 317
 	 *
318 318
 	 * @param array $members
319
-	 * @param $userId
319
+	 * @param string $userId
320 320
 	 *
321 321
 	 * @return int
322 322
 	 */
@@ -656,6 +656,9 @@  discard block
 block discarded – undo
656 656
 	}
657 657
 
658 658
 
659
+	/**
660
+	 * @param string $groupId
661
+	 */
659 662
 	public function unlinkAllFromGroup($groupId) {
660 663
 		$qb = $this->getMembersDeleteSql();
661 664
 
Please login to merge, or discard this patch.
lib/Model/BaseCircle.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -467,7 +467,7 @@  discard block
 block discarded – undo
467 467
 	}
468 468
 
469 469
 	/**
470
-	 * @return string
470
+	 * @return integer
471 471
 	 */
472 472
 	public function getType() {
473 473
 		return $this->type;
@@ -521,7 +521,7 @@  discard block
 block discarded – undo
521 521
 	}
522 522
 
523 523
 	/**
524
-	 * @return array
524
+	 * @return DeprecatedMember[]
525 525
 	 */
526 526
 	public function getGroups() {
527 527
 		return $this->groups;
@@ -539,7 +539,7 @@  discard block
 block discarded – undo
539 539
 	}
540 540
 
541 541
 	/**
542
-	 * @return array
542
+	 * @return FederatedLink[]
543 543
 	 */
544 544
 	public function getLinks() {
545 545
 		return $this->links;
@@ -575,7 +575,7 @@  discard block
 block discarded – undo
575 575
 //	}
576 576
 
577 577
 	/**
578
-	 * @param integer|string $type
578
+	 * @param string $type
579 579
 	 *
580 580
 	 * @return integer
581 581
 	 */
Please login to merge, or discard this patch.
lib/Model/DeprecatedCircle.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -178,7 +178,7 @@
 block discarded – undo
178 178
 
179 179
 	/**
180 180
 	 * @param array $arr
181
-	 * @param $key
181
+	 * @param string $key
182 182
 	 * @param int $type
183 183
 	 *
184 184
 	 * @return null|DeprecatedMember
Please login to merge, or discard this patch.
lib/Model/DeprecatedMember.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -41,6 +41,9 @@
 block discarded – undo
41 41
 class DeprecatedMember extends BaseMember {
42 42
 
43 43
 
44
+	/**
45
+	 * @param integer $circleType
46
+	 */
44 47
 	public function inviteToCircle($circleType) {
45 48
 
46 49
 		if ($circleType === 0) {
Please login to merge, or discard this patch.
lib/Service/GroupsService.php 1 patch
Doc Comments   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
 	 * @param string $circleUniqueId
110 110
 	 * @param string $groupId
111 111
 	 *
112
-	 * @return array
112
+	 * @return DeprecatedMember[]
113 113
 	 * @throws \Exception
114 114
 	 */
115 115
 	public function linkGroup($circleUniqueId, $groupId) {
@@ -165,8 +165,8 @@  discard block
 block discarded – undo
165 165
 	/**
166 166
 	 * Check if a fresh member can be generated (by linkGroup)
167 167
 	 *
168
-	 * @param $circleId
169
-	 * @param $groupId
168
+	 * @param string $circleId
169
+	 * @param string $groupId
170 170
 	 *
171 171
 	 * @return null|DeprecatedMember
172 172
 	 * @throws MemberAlreadyExistsException
@@ -202,7 +202,7 @@  discard block
 block discarded – undo
202 202
 	 * @param string $groupId
203 203
 	 * @param int $level
204 204
 	 *
205
-	 * @return array
205
+	 * @return DeprecatedMember[]
206 206
 	 * @throws \Exception
207 207
 	 */
208 208
 	public function levelGroup($circleUniqueId, $groupId, $level) {
@@ -243,7 +243,7 @@  discard block
 block discarded – undo
243 243
 	/**
244 244
 	 * @param DeprecatedCircle $circle
245 245
 	 * @param DeprecatedMember $group
246
-	 * @param $level
246
+	 * @param integer $level
247 247
 	 *
248 248
 	 * @throws \Exception
249 249
 	 */
@@ -270,7 +270,7 @@  discard block
 block discarded – undo
270 270
 	 * @param string $circleUniqueId
271 271
 	 * @param string $groupId
272 272
 	 *
273
-	 * @return array
273
+	 * @return DeprecatedMember[]
274 274
 	 * @throws \Exception
275 275
 	 */
276 276
 	public function unlinkGroup($circleUniqueId, $groupId) {
Please login to merge, or discard this patch.
lib/Service/MembersService.php 1 patch
Doc Comments   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -349,8 +349,8 @@  discard block
 block discarded – undo
349 349
 	/**
350 350
 	 * Verify if a local account is valid.
351 351
 	 *
352
-	 * @param $ident
353
-	 * @param $type
352
+	 * @param string $ident
353
+	 * @param integer $type
354 354
 	 *
355 355
 	 * @param string $instance
356 356
 	 *
@@ -401,8 +401,8 @@  discard block
 block discarded – undo
401 401
 	/**
402 402
 	 * Verify if a contact exist in current user address books.
403 403
 	 *
404
-	 * @param $ident
405
-	 * @param $type
404
+	 * @param string $ident
405
+	 * @param integer $type
406 406
 	 *
407 407
 	 * @throws NoUserException
408 408
 	 * @throws EmailAccountInvalidFormatException
@@ -494,8 +494,8 @@  discard block
 block discarded – undo
494 494
 	 * Will return any data of a user related to a circle (as a Member). User can be a 'non-member'
495 495
 	 * Viewer needs to be at least Member of the Circle
496 496
 	 *
497
-	 * @param $circleId
498
-	 * @param $userId
497
+	 * @param string $circleId
498
+	 * @param string $userId
499 499
 	 * @param $type
500 500
 	 * @param bool $forceAll
501 501
 	 *
@@ -551,7 +551,7 @@  discard block
 block discarded – undo
551 551
 	 * @param int $level
552 552
 	 * @param bool $force
553 553
 	 *
554
-	 * @return array
554
+	 * @return DeprecatedMember[]
555 555
 	 * @throws CircleDoesNotExistException
556 556
 	 * @throws CircleTypeNotValidException
557 557
 	 * @throws ConfigNoCircleAvailableException
Please login to merge, or discard this patch.