DavService - Code Metrics - Inspection of "using Circles as backend for Contacts" - nextcloud/circles - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#347)

by Maxence

created 2019-10-23 10:48 UTC

DavService A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	351
Duplicated Lines	7.12 %

Coupling/Cohesion

Components	1
Dependencies	8

Importance

Changes

Metric	Value
wmc	41
lcom	1
cbo	8
dl	25
loc	351
rs	9.1199
c	0
b	0
f	0

17 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	11	11	1
A	onCreateCard()	0	4	1
A	onUpdateCard()	0	4	1
A	onDeleteCard()	0	4	1
A	generateDavCard()	0	12	1
A	updateDavCard()	0	5	1
A	manageContactMembers()	0	15	2
A	manageLocalMembers()	6	19	5
B	manageRemoteMembers()	8	23	6
A	manageMember()	0	22	3
A	isLocalMember()	0	17	5
A	manageCircles()	0	13	1
A	manageNewCircles()	0	25	5
A	manageDeprecatedCircles()	0	2	1
A	assignCirclesToCard()	0	10	3
A	getCirclesFromBook()	0	3	1
A	uuid()	0	17	3

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like DavService often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use DavService, and based on these observations, apply Extract Interface, too.

<?php


/**
 * Circles - Bring cloud-users closer together.
 *
 * This file is licensed under the Affero General Public License version 3 or
 * later. See the COPYING file.
 *
 * @author Maxence Lange <[email protected]>
 * @copyright 2017
 * @license GNU AGPL version 3 or any later version
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as
 * published by the Free Software Foundation, either version 3 of the
 * License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 */


namespace OCA\Circles\Service;


use OCA\Circles\Db\CirclesRequest;
use OCA\Circles\Db\MembersRequest;
use OCA\Circles\Exceptions\CircleAlreadyExistsException;
use OCA\Circles\Exceptions\CircleDoesNotExistException;
use OCA\Circles\Exceptions\MemberAlreadyExistsException;
use OCA\Circles\Exceptions\MemberDoesNotExistException;
use OCA\Circles\Exceptions\NotLocalMemberException;
use OCA\Circles\Model\Circle;
use OCA\Circles\Model\DavCard;
use OCA\Circles\Model\Member;
use OCP\IUserManager;
use Symfony\Component\EventDispatcher\GenericEvent;


/**
 * Class DavService
 *
 * @package OCA\Circles\Service
 */
class DavService {


	/** @var string */
	private $userId;

	/** @var IUserManager */
	private $userManager;

	/** @var CirclesRequest */
	private $circlesRequest;

	/** @var MembersRequest */
	private $membersRequest;

	/** @var ConfigService */
	private $configService;

	/** @var MiscService */
	private $miscService;


	/**
	 * TimezoneService constructor.
	 *
	 * @param string $userId
	 * @param IUserManager $userManager
	 * @param CirclesRequest $circlesRequest
	 * @param MembersRequest $membersRequest
	 * @param ConfigService $configService
	 * @param MiscService $miscService
	 */
	public function __construct(

		$userId, IUserManager $userManager, CirclesRequest $circlesRequest, MembersRequest $membersRequest,
		ConfigService $configService, MiscService $miscService
	) {
		$this->userId = $userId;
		$this->userManager = $userManager;
		$this->circlesRequest = $circlesRequest;
		$this->membersRequest = $membersRequest;
		$this->configService = $configService;
		$this->miscService = $miscService;
	}


	/**
	 * @param GenericEvent $event
	 */
	public function onCreateCard(GenericEvent $event) {
		$davCard = $this->generateDavCard($event);
		$this->updateDavCard($davCard);
	}


	/**
	 * @param GenericEvent $event
	 */
	public function onUpdateCard(GenericEvent $event) {
		$davCard = $this->generateDavCard($event);
		$this->updateDavCard($davCard);
	}


	/**
	 * @param GenericEvent $event
	 */
	public function onDeleteCard(GenericEvent $event) {
		$addressBookId = $event->getArgument('addressBookId');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
		$cardUri = $event->getArgument('cardUri');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
	}


	/**
	 * @param GenericEvent $event
	 *
	 * @return DavCard
	 */
	private function generateDavCard(GenericEvent $event): DavCard {
		$addressBookId = $event->getArgument('addressBookId');
		$cardUri = $event->getArgument('cardUri');
		$cardData = $event->getArgument('cardData');

		$davCard = new DavCard();
		$davCard->importFromDav($cardData);
		$davCard->setAddressBookId($addressBookId);
		$davCard->setCardUri($cardUri);

		return $davCard;
	}


	/**
	 * @param DavCard $davCard
	 */
	private function updateDavCard(DavCard $davCard) {
		$this->miscService->log('Updating Card: ' . json_encode($davCard));
		$this->manageCircles($davCard);
		$this->manageContactMembers($davCard);
	}


	/**
	 * @param DavCard $davCard
	 *
	 * @return Member[]
	 */
	private function manageContactMembers(DavCard $davCard): array {
		$circles = array_map(
			function(Circle $circle) {
				return $circle->getUniqueId();
			}, $davCard->getCircles()
		);

		try {
			$userId = $this->isLocalMember($davCard);

			return $this->manageLocalMembers($circles, $davCard, $userId);
		} catch (NotLocalMemberException $e) {
			return $this->manageRemoteMembers($circles, $davCard);
		}
	}


	/**
	 * @param array $circles
	 * @param DavCard $davCard
	 * @param string $userId
	 *
	 * @return Member[]
	 */
	private function manageLocalMembers(array $circles, DavCard $davCard, string $userId): array {
		// remove all remote members
		$this->membersRequest->removeContactMembers($davCard->getContactId(), Member::TYPE_CONTACT);
		// remove local members with different userid and deprecated circles
		foreach ($this->membersRequest->getLocalContactMembers($davCard->getContactId()) as $member) {

			if ($member->getUserId() !== $userId || !in_array($member->getCircleId(), $circles)
			) {
				$this->membersRequest->removeMember($member);
			}
		}

		// generate members
		$members = [];
		foreach ($davCard->getCircles() as $circle) {
			$members[] = $this->manageMember($davCard->getContactId(), $circle, $userId, Member::TYPE_USER);
		}

		return $members;
	}


	/**
	 * @param array $circles
	 * @param DavCard $davCard
	 *
	 * @return Member[]
	 */
	private function manageRemoteMembers(array $circles, DavCard $davCard): array {
		// remove all local members
		$this->membersRequest->removeContactMembers($davCard->getContactId(), Member::TYPE_USER);
		// remove deprecated mail address & deprecated circles
		foreach ($this->membersRequest->getMembersByContactId($davCard->getContactId()) as $member) {


			if (!in_array($member->getUserId(), $davCard->getEmails())
				|| !in_array($member->getCircleId(), $circles)
			) {
				$this->membersRequest->removeMember($member);
			}
		}

		$members = [];
		foreach ($davCard->getEmails() as $email) {
			foreach ($davCard->getCircles() as $circle) {
				$members[] =
					$this->manageMember($davCard->getContactId(), $circle, $email, Member::TYPE_CONTACT);
			}
		}

		return $members;
	}


	/**
	 * @param string $contactId
	 * @param Circle $circle
	 * @param string $userId
	 * @param int $type
	 *
	 * @return Member
	 */
	private function manageMember(string $contactId, Circle $circle, string $userId, int $type) {
		try {
			$member = $this->membersRequest->getContactMember(
				$circle->getUniqueId(), $contactId, $userId, $type
			);
		} catch (MemberDoesNotExistException $e) {
			$member = new Member();
			$member->setLevel(Member::LEVEL_MEMBER);
			$member->setStatus(Member::STATUS_MEMBER);
			$member->setContactId($contactId);
			$member->setType($type);
			$member->setCircleId($circle->getUniqueId());
			$member->setUserId($userId);

			try {
				$this->membersRequest->createMember($member);
			} catch (MemberAlreadyExistsException $e) {

			}
		}

		return $member;
	}


	/**
	 * @param DavCard $davCard
	 *
	 * @return string
	 * @throws NotLocalMemberException
	 */
	private function isLocalMember(DavCard $davCard): string {
		foreach ($davCard->getEmails() as $email) {
			if (strpos($email, '@') === false) {
				continue;
			}

			list ($username, $domain) = explode('@', $email);
			if (in_array($domain, $this->configService->getAvailableHosts())) {
				$user = $this->userManager->get($username);
				if ($user !== null) {
					return $user->getUID();
				}
			}
		}

		throw new NotLocalMemberException();
	}


	/**
	 * @param DavCard $davCard
	 */
	private function manageCircles(DavCard $davCard) {
		$fromCard = $davCard->getGroups();
		$current = array_map(
			function(Circle $circle) {
				return $circle->getContactGroupName();
			}, $this->getCirclesFromBook($davCard->getAddressBookId())
		);

		$this->manageNewCircles($davCard->getAddressBookId(), $fromCard, $current);
		$this->manageDeprecatedCircles($fromCard, $current);
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}

		$this->assignCirclesToCard($davCard);
	}


	/**
	 * @param int $bookId
	 * @param array $fromCard
	 * @param array $current
	 */
	private function manageNewCircles(int $bookId, array $fromCard, array $current) {
		foreach ($fromCard as $group) {
			if (in_array($group, $current)) {
				continue;
			}
			
			$circle = new Circle(Circle::CIRCLES_PUBLIC, $group . ' - ' . $this->uuid(5));

			$circle->setContactAddressBook($bookId);
			$circle->setContactGroupName($group);

			try {
				$this->circlesRequest->createCircle($circle, $this->userId);
				$member = new Member($this->userId, Member::TYPE_USER, $circle->getUniqueId());
				$member->setLevel(Member::LEVEL_OWNER);
				$member->setStatus(Member::STATUS_MEMBER);

				try {
					$this->membersRequest->createMember($member);
				} catch (MemberAlreadyExistsException $e) {

				}
			} catch (CircleAlreadyExistsException $e) {

			}

		}
	}


	/**
	 * // TODO: Get all group from an addressbook
	 * // TODO: remove deprecated circles
	 *
	 * @param array $fromCard
	 * @param array $current
	 */
	private function manageDeprecatedCircles(array $fromCard, array $current) {

	}


	/**
	 * @param DavCard $davCard
	 */
	private function assignCirclesToCard(DavCard $davCard) {
		foreach ($davCard->getGroups() as $group) {
			try {
				$davCard->addCircle(
					$this->circlesRequest->getFromContactGroup($davCard->getAddressBookId(), $group)
				);
			} catch (CircleDoesNotExistException $e) {

			}
		}
	}


	/**
	 * @param int $addressBookId
	 *
	 * @return Circle[]
	 */
	private function getCirclesFromBook(int $addressBookId): array {
		return $this->circlesRequest->getFromBook($addressBookId);
	}


	/**
	 * @param int $length
	 *
	 * @return string
	 * @deprecated
	 */
	protected function uuid(int $length = 0): string {
		$uuid = sprintf(
			'%04x%04x-%04x-%04x-%04x-%04x%04x%04x', mt_rand(0, 0xffff), mt_rand(0, 0xffff),
			mt_rand(0, 0xffff), mt_rand(0, 0xfff) | 0x4000, mt_rand(0, 0x3fff) | 0x8000,
			mt_rand(0, 0xffff), mt_rand(0, 0xffff), mt_rand(0, 0xffff)
		);

		if ($length > 0) {
			if ($length <= 16) {
				$uuid = str_replace('-', '', $uuid);
			}

			$uuid = substr($uuid, 0, $length);
		}

		return $uuid;
	}


}




1		<?php
2
3
4		/**
5		* Circles - Bring cloud-users closer together.
6		*
7		* This file is licensed under the Affero General Public License version 3 or
8		* later. See the COPYING file.
9		*
10		* @author Maxence Lange <[email protected]>
11		* @copyright 2017
12		* @license GNU AGPL version 3 or any later version
13		*
14		* This program is free software: you can redistribute it and/or modify
15		* it under the terms of the GNU Affero General Public License as
16		* published by the Free Software Foundation, either version 3 of the
17		* License, or (at your option) any later version.
18		*
19		* This program is distributed in the hope that it will be useful,
20		* but WITHOUT ANY WARRANTY; without even the implied warranty of
21		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
22		* GNU Affero General Public License for more details.
23		*
24		* You should have received a copy of the GNU Affero General Public License
25		* along with this program. If not, see <http://www.gnu.org/licenses/>.
26		*
27		*/
28
29
30		namespace OCA\Circles\Service;
31
32
33		use OCA\Circles\Db\CirclesRequest;
34		use OCA\Circles\Db\MembersRequest;
35		use OCA\Circles\Exceptions\CircleAlreadyExistsException;
36		use OCA\Circles\Exceptions\CircleDoesNotExistException;
37		use OCA\Circles\Exceptions\MemberAlreadyExistsException;
38		use OCA\Circles\Exceptions\MemberDoesNotExistException;
39		use OCA\Circles\Exceptions\NotLocalMemberException;
40		use OCA\Circles\Model\Circle;
41		use OCA\Circles\Model\DavCard;
42		use OCA\Circles\Model\Member;
43		use OCP\IUserManager;
44		use Symfony\Component\EventDispatcher\GenericEvent;
45
46
47		/**
48		* Class DavService
49		*
50		* @package OCA\Circles\Service
51		*/
52		class DavService {
53
54
55		/** @var string */
56		private $userId;
57
58		/** @var IUserManager */
59		private $userManager;
60
61		/** @var CirclesRequest */
62		private $circlesRequest;
63
64		/** @var MembersRequest */
65		private $membersRequest;
66
67		/** @var ConfigService */
68		private $configService;
69
70		/** @var MiscService */
71		private $miscService;
72
73
74		/**
75		* TimezoneService constructor.
76		*
77		* @param string $userId
78		* @param IUserManager $userManager
79		* @param CirclesRequest $circlesRequest
80		* @param MembersRequest $membersRequest
81		* @param ConfigService $configService
82		* @param MiscService $miscService
83		*/
84	View Code Duplication	public function __construct(
		0 ignored issues – show Duplication introduced 2019-10-23 10:50 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
85		$userId, IUserManager $userManager, CirclesRequest $circlesRequest, MembersRequest $membersRequest,
86		ConfigService $configService, MiscService $miscService
87		) {
88		$this->userId = $userId;
89		$this->userManager = $userManager;
90		$this->circlesRequest = $circlesRequest;
91		$this->membersRequest = $membersRequest;
92		$this->configService = $configService;
93		$this->miscService = $miscService;
94		}
95
96
97		/**
98		* @param GenericEvent $event
99		*/
100		public function onCreateCard(GenericEvent $event) {
101		$davCard = $this->generateDavCard($event);
102		$this->updateDavCard($davCard);
103		}
104
105
106		/**
107		* @param GenericEvent $event
108		*/
109		public function onUpdateCard(GenericEvent $event) {
110		$davCard = $this->generateDavCard($event);
111		$this->updateDavCard($davCard);
112		}
113
114
115		/**
116		* @param GenericEvent $event
117		*/
118		public function onDeleteCard(GenericEvent $event) {
119		$addressBookId = $event->getArgument('addressBookId');
		0 ignored issues – show Unused Code introduced 2019-10-23 10:50 UTC by Report Bug Copy Issue Report `$addressBookId` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
120		$cardUri = $event->getArgument('cardUri');
		0 ignored issues – show Unused Code introduced 2019-10-23 10:50 UTC by Report Bug Copy Issue Report `$cardUri` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
121		}
122
123
124		/**
125		* @param GenericEvent $event
126		*
127		* @return DavCard
128		*/
129		private function generateDavCard(GenericEvent $event): DavCard {
130		$addressBookId = $event->getArgument('addressBookId');
131		$cardUri = $event->getArgument('cardUri');
132		$cardData = $event->getArgument('cardData');
133
134		$davCard = new DavCard();
135		$davCard->importFromDav($cardData);
136		$davCard->setAddressBookId($addressBookId);
137		$davCard->setCardUri($cardUri);
138
139		return $davCard;
140		}
141
142
143		/**
144		* @param DavCard $davCard
145		*/
146		private function updateDavCard(DavCard $davCard) {
147		$this->miscService->log('Updating Card: ' . json_encode($davCard));
148		$this->manageCircles($davCard);
149		$this->manageContactMembers($davCard);
150		}
151
152
153		/**
154		* @param DavCard $davCard
155		*
156		* @return Member[]
157		*/
158		private function manageContactMembers(DavCard $davCard): array {
159		$circles = array_map(
160		function(Circle $circle) {
161		return $circle->getUniqueId();
162		}, $davCard->getCircles()
163		);
164
165		try {
166		$userId = $this->isLocalMember($davCard);
167
168		return $this->manageLocalMembers($circles, $davCard, $userId);
169		} catch (NotLocalMemberException $e) {
170		return $this->manageRemoteMembers($circles, $davCard);
171		}
172		}
173
174
175		/**
176		* @param array $circles
177		* @param DavCard $davCard
178		* @param string $userId
179		*
180		* @return Member[]
181		*/
182		private function manageLocalMembers(array $circles, DavCard $davCard, string $userId): array {
183		// remove all remote members
184		$this->membersRequest->removeContactMembers($davCard->getContactId(), Member::TYPE_CONTACT);
185		// remove local members with different userid and deprecated circles
186	View Code Duplication	foreach ($this->membersRequest->getLocalContactMembers($davCard->getContactId()) as $member) {
		0 ignored issues – show Duplication introduced 2019-10-23 10:50 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
187		if ($member->getUserId() !== $userId \|\| !in_array($member->getCircleId(), $circles)
188		) {
189		$this->membersRequest->removeMember($member);
190		}
191		}
192
193		// generate members
194		$members = [];
195		foreach ($davCard->getCircles() as $circle) {
196		$members[] = $this->manageMember($davCard->getContactId(), $circle, $userId, Member::TYPE_USER);
197		}
198
199		return $members;
200		}
201
202
203		/**
204		* @param array $circles
205		* @param DavCard $davCard
206		*
207		* @return Member[]
208		*/
209		private function manageRemoteMembers(array $circles, DavCard $davCard): array {
210		// remove all local members
211		$this->membersRequest->removeContactMembers($davCard->getContactId(), Member::TYPE_USER);
212		// remove deprecated mail address & deprecated circles
213	View Code Duplication	foreach ($this->membersRequest->getMembersByContactId($davCard->getContactId()) as $member) {
		0 ignored issues – show Duplication introduced 2019-10-23 10:50 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
214
215		if (!in_array($member->getUserId(), $davCard->getEmails())
216		\|\| !in_array($member->getCircleId(), $circles)
217		) {
218		$this->membersRequest->removeMember($member);
219		}
220		}
221
222		$members = [];
223		foreach ($davCard->getEmails() as $email) {
224		foreach ($davCard->getCircles() as $circle) {
225		$members[] =
226		$this->manageMember($davCard->getContactId(), $circle, $email, Member::TYPE_CONTACT);
227		}
228		}
229
230		return $members;
231		}
232
233
234		/**
235		* @param string $contactId
236		* @param Circle $circle
237		* @param string $userId
238		* @param int $type
239		*
240		* @return Member
241		*/
242		private function manageMember(string $contactId, Circle $circle, string $userId, int $type) {
243		try {
244		$member = $this->membersRequest->getContactMember(
245		$circle->getUniqueId(), $contactId, $userId, $type
246		);
247		} catch (MemberDoesNotExistException $e) {
248		$member = new Member();
249		$member->setLevel(Member::LEVEL_MEMBER);
250		$member->setStatus(Member::STATUS_MEMBER);
251		$member->setContactId($contactId);
252		$member->setType($type);
253		$member->setCircleId($circle->getUniqueId());
254		$member->setUserId($userId);
255
256		try {
257		$this->membersRequest->createMember($member);
258		} catch (MemberAlreadyExistsException $e) {
		0 ignored issues – show Coding Style Comprehensibility introduced 2019-10-23 10:50 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
259		}
260		}
261
262		return $member;
263		}
264
265
266		/**
267		* @param DavCard $davCard
268		*
269		* @return string
270		* @throws NotLocalMemberException
271		*/
272		private function isLocalMember(DavCard $davCard): string {
273		foreach ($davCard->getEmails() as $email) {
274		if (strpos($email, '@') === false) {
275		continue;
276		}
277
278		list ($username, $domain) = explode('@', $email);
279		if (in_array($domain, $this->configService->getAvailableHosts())) {
280		$user = $this->userManager->get($username);
281		if ($user !== null) {
282		return $user->getUID();
283		}
284		}
285		}
286
287		throw new NotLocalMemberException();
288		}
289
290
291		/**
292		* @param DavCard $davCard
293		*/
294		private function manageCircles(DavCard $davCard) {
295		$fromCard = $davCard->getGroups();
296		$current = array_map(
297		function(Circle $circle) {
298		return $circle->getContactGroupName();
299		}, $this->getCirclesFromBook($davCard->getAddressBookId())
300		);
301
302		$this->manageNewCircles($davCard->getAddressBookId(), $fromCard, $current);
303		$this->manageDeprecatedCircles($fromCard, $current);
		0 ignored issues – show Unused Code introduced 2019-10-23 10:50 UTC by Report Bug Copy Issue Report The call to the method `OCA\Circles\Service\DavS...nageDeprecatedCircles()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
304
305		$this->assignCirclesToCard($davCard);
306		}
307
308
309		/**
310		* @param int $bookId
311		* @param array $fromCard
312		* @param array $current
313		*/
314		private function manageNewCircles(int $bookId, array $fromCard, array $current) {
315		foreach ($fromCard as $group) {
316		if (in_array($group, $current)) {
317		continue;
318		}
319
320		$circle = new Circle(Circle::CIRCLES_PUBLIC, $group . ' - ' . $this->uuid(5));
		0 ignored issues – show Deprecated Code introduced 2019-10-23 10:50 UTC by Report Bug Copy Issue Report The method `OCA\Circles\Service\DavService::uuid()` has been deprecated. This method has been deprecated. Loading history...
321		$circle->setContactAddressBook($bookId);
322		$circle->setContactGroupName($group);
323
324		try {
325		$this->circlesRequest->createCircle($circle, $this->userId);
326		$member = new Member($this->userId, Member::TYPE_USER, $circle->getUniqueId());
327		$member->setLevel(Member::LEVEL_OWNER);
328		$member->setStatus(Member::STATUS_MEMBER);
329
330		try {
331		$this->membersRequest->createMember($member);
332		} catch (MemberAlreadyExistsException $e) {
		0 ignored issues – show Coding Style Comprehensibility introduced 2019-10-23 10:50 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
333		}
334		} catch (CircleAlreadyExistsException $e) {
		0 ignored issues – show Coding Style Comprehensibility introduced 2019-10-23 10:50 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
335		}
336
337		}
338		}
339
340
341		/**
342		* // TODO: Get all group from an addressbook
343		* // TODO: remove deprecated circles
344		*
345		* @param array $fromCard
346		* @param array $current
347		*/
348		private function manageDeprecatedCircles(array $fromCard, array $current) {
		0 ignored issues – show Unused Code introduced 2019-10-23 10:50 UTC by Report Bug Copy Issue Report The parameter `$fromCard` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2019-10-23 10:50 UTC by Report Bug Copy Issue Report The parameter `$current` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
349		}
350
351
352		/**
353		* @param DavCard $davCard
354		*/
355		private function assignCirclesToCard(DavCard $davCard) {
356		foreach ($davCard->getGroups() as $group) {
357		try {
358		$davCard->addCircle(
359		$this->circlesRequest->getFromContactGroup($davCard->getAddressBookId(), $group)
360		);
361		} catch (CircleDoesNotExistException $e) {
		0 ignored issues – show Coding Style Comprehensibility introduced 2019-10-23 10:50 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
362		}
363		}
364		}
365
366
367		/**
368		* @param int $addressBookId
369		*
370		* @return Circle[]
371		*/
372		private function getCirclesFromBook(int $addressBookId): array {
373		return $this->circlesRequest->getFromBook($addressBookId);
374		}
375
376
377		/**
378		* @param int $length
379		*
380		* @return string
381		* @deprecated
382		*/
383		protected function uuid(int $length = 0): string {
384		$uuid = sprintf(
385		'%04x%04x-%04x-%04x-%04x-%04x%04x%04x', mt_rand(0, 0xffff), mt_rand(0, 0xffff),
386		mt_rand(0, 0xffff), mt_rand(0, 0xfff) \| 0x4000, mt_rand(0, 0x3fff) \| 0x8000,
387		mt_rand(0, 0xffff), mt_rand(0, 0xffff), mt_rand(0, 0xffff)
388		);
389
390		if ($length > 0) {
391		if ($length <= 16) {
392		$uuid = str_replace('-', '', $uuid);
393		}
394
395		$uuid = substr($uuid, 0, $length);
396		}
397
398		return $uuid;
399		}
400
401
402		}
403
404
405

nextcloud / circles