Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 40 | class CircleProviderRequestBuilder { |
||
| 41 | |||
| 42 | |||
| 43 | /** @var IDBConnection */ |
||
| 44 | protected $dbConnection; |
||
| 45 | |||
| 46 | |||
| 47 | /** |
||
| 48 | * returns the SQL request to get a specific share from the fileId and circleId |
||
| 49 | * |
||
| 50 | * @param int $fileId |
||
| 51 | * @param int $circleId |
||
| 52 | * |
||
| 53 | * @return IQueryBuilder |
||
| 54 | */ |
||
| 55 | protected function findShareParentSql($fileId, $circleId) { |
||
| 64 | |||
| 65 | |||
| 66 | /** |
||
| 67 | * Limit the request to a Circle. |
||
| 68 | * |
||
| 69 | * @param IQueryBuilder $qb |
||
| 70 | * @param int $circleId |
||
| 71 | */ |
||
| 72 | protected function limitToCircle(IQueryBuilder &$qb, $circleId) { |
||
| 78 | |||
| 79 | |||
| 80 | /** |
||
| 81 | * Limit the request to the Share by its Id. |
||
| 82 | * |
||
| 83 | * @param IQueryBuilder $qb |
||
| 84 | * @param $shareId |
||
| 85 | */ |
||
| 86 | protected function limitToShare(IQueryBuilder &$qb, $shareId) { |
||
| 92 | |||
| 93 | |||
| 94 | /** |
||
| 95 | * Limit the request to the top share (no children) |
||
| 96 | * |
||
| 97 | * @param IQueryBuilder $qb |
||
| 98 | */ |
||
| 99 | protected function limitToShareParent(IQueryBuilder &$qb) { |
||
| 104 | |||
| 105 | |||
| 106 | /** |
||
| 107 | * limit the request to the children of a share |
||
| 108 | * |
||
| 109 | * @param IQueryBuilder $qb |
||
| 110 | * @param $userId |
||
| 111 | * @param int $parentId |
||
| 112 | */ |
||
| 113 | protected function limitToShareChildren(IQueryBuilder &$qb, $userId, $parentId = -1) { |
||
| 123 | |||
| 124 | |||
| 125 | /** |
||
| 126 | * limit the request to the share itself AND its children. |
||
| 127 | * perfect if you want to delete everything related to a share |
||
| 128 | * |
||
| 129 | * @param IQueryBuilder $qb |
||
| 130 | * @param $circleId |
||
| 131 | */ |
||
| 132 | protected function limitToShareAndChildren(IQueryBuilder &$qb, $circleId) { |
||
| 144 | |||
| 145 | |||
| 146 | /** |
||
| 147 | * limit the request to a fileId. |
||
| 148 | * |
||
| 149 | * @param IQueryBuilder $qb |
||
| 150 | * @param $files |
||
| 151 | * |
||
| 152 | * @internal param $fileId |
||
| 153 | */ |
||
| 154 | protected function limitToFiles(IQueryBuilder &$qb, $files) { |
||
| 169 | |||
| 170 | |||
| 171 | /** |
||
| 172 | * @param IQueryBuilder $qb |
||
| 173 | * @param int $limit |
||
| 174 | * @param int $offset |
||
| 175 | */ |
||
| 176 | protected function limitToPage(IQueryBuilder &$qb, $limit = -1, $offset = 0) { |
||
| 183 | |||
| 184 | |||
| 185 | /** |
||
| 186 | * limit the request to a userId |
||
| 187 | * |
||
| 188 | * @param IQueryBuilder $qb |
||
| 189 | * @param string $userId |
||
| 190 | * @param bool $reShares |
||
| 191 | */ |
||
| 192 | protected function limitToShareOwner(IQueryBuilder &$qb, $userId, $reShares = false) { |
||
| 208 | |||
| 209 | |||
| 210 | /** |
||
| 211 | * link circle field |
||
| 212 | * |
||
| 213 | * @deprecated |
||
| 214 | * |
||
| 215 | * @param IQueryBuilder $qb |
||
| 216 | * @param int $shareId |
||
| 217 | */ |
||
| 218 | protected function linkCircleField(IQueryBuilder &$qb, $shareId = -1) { |
||
| 242 | |||
| 243 | |||
| 244 | /** |
||
| 245 | * @param IQueryBuilder $qb |
||
| 246 | */ |
||
| 247 | protected function linkToCircleOwner(IQueryBuilder &$qb) { |
||
| 261 | |||
| 262 | |||
| 263 | /** |
||
| 264 | * Link to member (userId) of circle |
||
| 265 | * |
||
| 266 | * @param IQueryBuilder $qb |
||
| 267 | * @param string $userId |
||
| 268 | * @param bool $groupMemberAllowed |
||
| 269 | */ |
||
| 270 | protected function linkToMember(IQueryBuilder &$qb, $userId, $groupMemberAllowed) { |
||
| 271 | $expr = $qb->expr(); |
||
| 272 | |||
| 273 | $qb->from(CoreRequestBuilder::TABLE_MEMBERS, 'm'); |
||
| 274 | |||
| 275 | |||
| 276 | $orX = $expr->orX(); |
||
| 277 | $orX->add($this->exprLinkToMemberAsCircleMember($qb, $userId)); |
||
| 278 | if ($groupMemberAllowed === true) { |
||
| 279 | $orX->add($this->exprLinkToMemberAsGroupMember($qb, $userId)); |
||
| 280 | } |
||
| 281 | |||
| 282 | $qb->andWhere($orX); |
||
| 283 | |||
| 284 | } |
||
| 285 | |||
| 286 | |||
| 287 | /** |
||
| 288 | * generate CompositeExpression to link to a Member as a Real Circle Member |
||
| 289 | * |
||
| 290 | * @param IQueryBuilder $qb |
||
| 291 | * @param string $userId |
||
| 292 | * |
||
| 293 | * @return \OCP\DB\QueryBuilder\ICompositeExpression |
||
| 294 | */ |
||
| 295 | private function exprLinkToMemberAsCircleMember(IQueryBuilder &$qb, $userId) { |
||
| 313 | |||
| 314 | |||
| 315 | /** |
||
| 316 | * generate CompositeExpression to link to a Member as a Group Member (core NC) |
||
| 317 | * |
||
| 318 | * @param IQueryBuilder $qb |
||
| 319 | * @param string $userId |
||
| 320 | * |
||
| 321 | * @return \OCP\DB\QueryBuilder\ICompositeExpression |
||
| 322 | */ |
||
| 323 | private function exprLinkToMemberAsGroupMember(IQueryBuilder &$qb, $userId) { |
||
| 345 | |||
| 346 | |||
| 347 | /** |
||
| 348 | * left join to get more data about the initiator of the share |
||
| 349 | * |
||
| 350 | * @param IQueryBuilder $qb |
||
| 351 | */ |
||
| 352 | protected function leftJoinShareInitiator(IQueryBuilder &$qb) { |
||
| 380 | |||
| 381 | |||
| 382 | /** |
||
| 383 | * Link to all members of circle |
||
| 384 | * |
||
| 385 | * @param IQueryBuilder $qb |
||
| 386 | */ |
||
| 387 | protected function joinCircleMembers(IQueryBuilder &$qb) { |
||
| 393 | |||
| 394 | |||
| 395 | /** |
||
| 396 | * Link to storage/filecache |
||
| 397 | * |
||
| 398 | * @param IQueryBuilder $qb |
||
| 399 | * @param string $userId |
||
| 400 | */ |
||
| 401 | protected function linkToFileCache(IQueryBuilder &$qb, $userId) { |
||
| 419 | |||
| 420 | |||
| 421 | /** |
||
| 422 | * add share to the database and return the ID |
||
| 423 | * |
||
| 424 | * @param IShare $share |
||
| 425 | * |
||
| 426 | * @return IQueryBuilder |
||
| 427 | */ |
||
| 428 | protected function getBaseInsertSql($share) { |
||
| 445 | |||
| 446 | |||
| 447 | /** |
||
| 448 | * generate and return a base sql request. |
||
| 449 | * |
||
| 450 | * @param int $shareId |
||
| 451 | * |
||
| 452 | * @return IQueryBuilder |
||
| 453 | */ |
||
| 454 | protected function getBaseSelectSql($shareId = -1) { |
||
| 473 | |||
| 474 | |||
| 475 | /** |
||
| 476 | * Generate and return a base sql request |
||
| 477 | * This one should be used to retrieve a complete list of users (ie. access list). |
||
| 478 | * |
||
| 479 | * @return IQueryBuilder |
||
| 480 | */ |
||
| 481 | protected function getAccessListBaseSelectSql() { |
||
| 493 | |||
| 494 | |||
| 495 | protected function getCompleteSelectSql() { |
||
| 517 | |||
| 518 | |||
| 519 | /** |
||
| 520 | * @param IQueryBuilder $qb |
||
| 521 | */ |
||
| 522 | private function joinShare(IQueryBuilder &$qb) { |
||
| 535 | |||
| 536 | |||
| 537 | /** |
||
| 538 | * generate and return a base sql request. |
||
| 539 | * |
||
| 540 | * @return \OCP\DB\QueryBuilder\IQueryBuilder |
||
| 541 | */ |
||
| 542 | View Code Duplication | protected function getBaseDeleteSql() { |
|
| 551 | |||
| 552 | |||
| 553 | /** |
||
| 554 | * generate and return a base sql request. |
||
| 555 | * |
||
| 556 | * @return \OCP\DB\QueryBuilder\IQueryBuilder |
||
| 557 | */ |
||
| 558 | View Code Duplication | protected function getBaseUpdateSql() { |
|
| 567 | } |
||
| 568 |
This method has been deprecated.