Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 45 | class FederatedService { |
||
| 46 | |||
| 47 | |||
| 48 | const STATUS_ERROR = 0; |
||
| 49 | const STATUS_LINK_DOWN = 1; |
||
| 50 | const STATUS_REQUEST_DECLINED = 3; |
||
| 51 | const STATUS_REQUEST_SENT = 6; |
||
| 52 | const STATUS_LINK_UP = 9; |
||
| 53 | |||
| 54 | |||
| 55 | /** @var string */ |
||
| 56 | private $userId; |
||
| 57 | |||
| 58 | /** @var IL10N */ |
||
| 59 | private $l10n; |
||
| 60 | |||
| 61 | /** @var ConfigService */ |
||
| 62 | private $configService; |
||
| 63 | |||
| 64 | /** @var CirclesService */ |
||
| 65 | private $circlesService; |
||
| 66 | |||
| 67 | /** @var CirclesMapper */ |
||
| 68 | private $dbCircles; |
||
| 69 | |||
| 70 | /** @var MembersMapper */ |
||
| 71 | private $dbMembers; |
||
| 72 | |||
| 73 | /** @var ClientService */ |
||
| 74 | private $clientService; |
||
| 75 | |||
| 76 | /** @var MiscService */ |
||
| 77 | private $miscService; |
||
| 78 | |||
| 79 | |||
| 80 | /** |
||
| 81 | * CirclesService constructor. |
||
| 82 | * |
||
| 83 | * @param $userId |
||
| 84 | * @param IL10N $l10n |
||
| 85 | * @param ConfigService $configService |
||
| 86 | * @param DatabaseService $databaseService |
||
| 87 | * @param CirclesService $circlesService |
||
| 88 | * @param ClientService $clientService |
||
| 89 | * @param MiscService $miscService |
||
| 90 | */ |
||
| 91 | View Code Duplication | public function __construct( |
|
| 110 | |||
| 111 | |||
| 112 | /** |
||
| 113 | * link to a circle. |
||
| 114 | * |
||
| 115 | * @param int $circleId |
||
| 116 | * @param string $link |
||
| 117 | * |
||
| 118 | * @return bool |
||
|
|
|||
| 119 | * @throws Exception |
||
| 120 | * @throws FederatedCircleLinkFormatException |
||
| 121 | * @throws CircleTypeNotValid |
||
| 122 | * @throws MemberIsNotAdminException |
||
| 123 | */ |
||
| 124 | public function linkCircle($circleId, $link) { |
||
| 151 | |||
| 152 | /** |
||
| 153 | * @param string $remote |
||
| 154 | * |
||
| 155 | * @return string |
||
| 156 | */ |
||
| 157 | private function generateLinkRemoteURL($remote) { |
||
| 164 | |||
| 165 | |||
| 166 | /** |
||
| 167 | * @param Circle $circle |
||
| 168 | * @param $remoteAddress |
||
| 169 | * @param $remoteCircle |
||
| 170 | * |
||
| 171 | * @return integer |
||
| 172 | * @throws Exception |
||
| 173 | */ |
||
| 174 | private function requestLinkWithCircle(Circle $circle, $remoteAddress, $remoteCircle) { |
||
| 205 | |||
| 206 | |||
| 207 | private function requestLinkStatus($result) { |
||
| 229 | |||
| 230 | |||
| 231 | /** |
||
| 232 | * @param Circle $circle |
||
| 233 | * @param $source |
||
| 234 | * @param FederatedLink $link |
||
| 235 | * |
||
| 236 | * @return bool |
||
| 237 | */ |
||
| 238 | public function initiateLink(Circle $circle, FederatedLink &$link) { |
||
| 249 | |||
| 250 | } |
This check compares the return type specified in the
@returnannotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch.