Completed
Pull Request — master (#2254)
by Konstantin
31s
created
lib/Model/Circle.php 1 patch
Spacing   +35 added lines, -35 removed lines patch added patch discarded remove patch
@@ -71,27 +71,27 @@  discard block
 block discarded – undo
71 71
 	public const FLAGS_LONG = 2;
72 72
 
73 73
 	// specific value
74
-	public const CFG_CIRCLE = 0;        // only for code readability. Circle is locked by default.
75
-	public const CFG_SINGLE = 1;        // Circle with only one single member.
76
-	public const CFG_PERSONAL = 2;      // Personal circle, only the owner can see it.
74
+	public const CFG_CIRCLE = 0; // only for code readability. Circle is locked by default.
75
+	public const CFG_SINGLE = 1; // Circle with only one single member.
76
+	public const CFG_PERSONAL = 2; // Personal circle, only the owner can see it.
77 77
 
78 78
 	// bitwise
79
-	public const CFG_SYSTEM = 4;            // System Circle (not managed by the official front-end). Meaning some config are limited
80
-	public const CFG_VISIBLE = 8;           // Visible to everyone, if not visible, people have to know its name to be able to find it
81
-	public const CFG_OPEN = 16;             // Circle is open, people can join
82
-	public const CFG_INVITE = 32;           // Adding a member generate an invitation that needs to be accepted
83
-	public const CFG_REQUEST = 64;          // Request to join Circles needs to be confirmed by a moderator
84
-	public const CFG_FRIEND = 128;          // Members of the circle can invite their friends
85
-	public const CFG_PROTECTED = 256;       // Password protected to join/request
86
-	public const CFG_NO_OWNER = 512;        // no owner, only members
87
-	public const CFG_HIDDEN = 1024;         // hidden from listing, but available as a share entity
88
-	public const CFG_BACKEND = 2048;            // Fully hidden, only backend Circles
89
-	public const CFG_LOCAL = 4096;              // Local even on GlobalScale
90
-	public const CFG_ROOT = 8192;               // Circle cannot be inside another Circle
91
-	public const CFG_CIRCLE_INVITE = 16384;     // Circle must confirm when invited in another circle
92
-	public const CFG_FEDERATED = 32768;         // Federated
93
-	public const CFG_MOUNTPOINT = 65536;        // Generate a Files folder for this Circle
94
-	public const CFG_APP = 131072;          // Some features are not available to the OCS API (ie. destroying Circle)
79
+	public const CFG_SYSTEM = 4; // System Circle (not managed by the official front-end). Meaning some config are limited
80
+	public const CFG_VISIBLE = 8; // Visible to everyone, if not visible, people have to know its name to be able to find it
81
+	public const CFG_OPEN = 16; // Circle is open, people can join
82
+	public const CFG_INVITE = 32; // Adding a member generate an invitation that needs to be accepted
83
+	public const CFG_REQUEST = 64; // Request to join Circles needs to be confirmed by a moderator
84
+	public const CFG_FRIEND = 128; // Members of the circle can invite their friends
85
+	public const CFG_PROTECTED = 256; // Password protected to join/request
86
+	public const CFG_NO_OWNER = 512; // no owner, only members
87
+	public const CFG_HIDDEN = 1024; // hidden from listing, but available as a share entity
88
+	public const CFG_BACKEND = 2048; // Fully hidden, only backend Circles
89
+	public const CFG_LOCAL = 4096; // Local even on GlobalScale
90
+	public const CFG_ROOT = 8192; // Circle cannot be inside another Circle
91
+	public const CFG_CIRCLE_INVITE = 16384; // Circle must confirm when invited in another circle
92
+	public const CFG_FEDERATED = 32768; // Federated
93
+	public const CFG_MOUNTPOINT = 65536; // Generate a Files folder for this Circle
94
+	public const CFG_APP = 131072; // Some features are not available to the OCS API (ie. destroying Circle)
95 95
 	public static $DEF_CFG_MAX = 262143;
96 96
 
97 97
 
@@ -463,7 +463,7 @@  discard block
 block discarded – undo
463 463
 	 */
464 464
 	public function addInheritedMembers(array $members): self {
465 465
 		$knownIds = array_map(
466
-			function (Member $member): string {
466
+			function(Member $member): string {
467 467
 				return $member->getId();
468 468
 			}, $this->inheritedMembers
469 469
 		);
@@ -879,7 +879,7 @@  discard block
 block discarded – undo
879 879
 				$initiatorHelper->mustBeAdmin();
880 880
 				$arr['settings'] = $this->getSettings();
881 881
 				$arr['invitationCode'] = $this->getCircleInvitation()?->getInvitationCode();
882
-			} catch (MemberHelperException|MemberLevelException $e) {
882
+			} catch (MemberHelperException | MemberLevelException $e) {
883 883
 			}
884 884
 		}
885 885
 
@@ -895,23 +895,23 @@  discard block
 block discarded – undo
895 895
 	 * @throws CircleNotFoundException
896 896
 	 */
897 897
 	public function importFromDatabase(array $data, string $prefix = ''): IQueryRow {
898
-		if ($this->get($prefix . 'unique_id', $data) === '') {
898
+		if ($this->get($prefix.'unique_id', $data) === '') {
899 899
 			throw new CircleNotFoundException();
900 900
 		}
901 901
 
902
-		$this->setSingleId($this->get($prefix . 'unique_id', $data))
903
-			->setName($this->get($prefix . 'name', $data))
904
-			->setDisplayName($this->get($prefix . 'display_name', $data))
905
-			->setSanitizedName($this->get($prefix . 'sanitized_name', $data))
906
-			->setConfig($this->getInt($prefix . 'config', $data))
907
-			->setSource($this->getInt($prefix . 'source', $data))
908
-			->setInstance($this->get($prefix . 'instance', $data))
909
-			->setSettings($this->getArray($prefix . 'settings', $data))
910
-			->setContactAddressBook($this->getInt($prefix . 'contact_addressbook', $data))
911
-			->setContactGroupName($this->get($prefix . 'contact_groupname', $data))
912
-			->setDescription($this->get($prefix . 'description', $data));
913
-
914
-		$creation = $this->get($prefix . 'creation', $data);
902
+		$this->setSingleId($this->get($prefix.'unique_id', $data))
903
+			->setName($this->get($prefix.'name', $data))
904
+			->setDisplayName($this->get($prefix.'display_name', $data))
905
+			->setSanitizedName($this->get($prefix.'sanitized_name', $data))
906
+			->setConfig($this->getInt($prefix.'config', $data))
907
+			->setSource($this->getInt($prefix.'source', $data))
908
+			->setInstance($this->get($prefix.'instance', $data))
909
+			->setSettings($this->getArray($prefix.'settings', $data))
910
+			->setContactAddressBook($this->getInt($prefix.'contact_addressbook', $data))
911
+			->setContactGroupName($this->get($prefix.'contact_groupname', $data))
912
+			->setDescription($this->get($prefix.'description', $data));
913
+
914
+		$creation = $this->get($prefix.'creation', $data);
915 915
 		$dateTime = DateTime::createFromFormat('Y-m-d H:i:s', $creation);
916 916
 		$timestamp = $dateTime ? $dateTime->getTimestamp() : (int)strtotime($creation);
917 917
 		$this->setCreation($timestamp);
Please login to merge, or discard this patch.
lib/Db/CircleRequest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -165,8 +165,8 @@  discard block
 block discarded – undo
165 165
 		$qb->filterCircles(CoreQueryBuilder::CIRCLE, $probe);
166 166
 		if (!is_null($initiator)) {
167 167
 			$qb->limitToInitiator(CoreQueryBuilder::CIRCLE, $initiator);
168
-			$qb->orderBy($qb->generateAlias(CoreQueryBuilder::CIRCLE, CoreQueryBuilder::INITIATOR) . '.level', 'desc');
169
-			$qb->addOrderBy(CoreQueryBuilder::CIRCLE . '.display_name', 'asc');
168
+			$qb->orderBy($qb->generateAlias(CoreQueryBuilder::CIRCLE, CoreQueryBuilder::INITIATOR).'.level', 'desc');
169
+			$qb->addOrderBy(CoreQueryBuilder::CIRCLE.'.display_name', 'asc');
170 170
 			$qb->leftJoinCircleInvitation(CoreQueryBuilder::CIRCLE);
171 171
 		}
172 172
 		if ($probe->hasFilterMember()) {
@@ -259,7 +259,7 @@  discard block
 block discarded – undo
259 259
 		$qb->completeProbeWithInitiator(CoreQueryBuilder::CIRCLE, 'single_id', $aliasMembership);
260 260
 		$qb->andWhere(
261 261
 			$limit,
262
-			$qb->expr()->in(CoreQueryBuilder::CIRCLE . '.unique_id', $qb->createNamedParameter($ids, IQueryBuilder::PARAM_STR_ARRAY))
262
+			$qb->expr()->in(CoreQueryBuilder::CIRCLE.'.unique_id', $qb->createNamedParameter($ids, IQueryBuilder::PARAM_STR_ARRAY))
263 263
 		);
264 264
 		$qb->resetSqlPath();
265 265
 
Please login to merge, or discard this patch.
lib/Model/CircleInvitation.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -174,15 +174,15 @@
 block discarded – undo
174 174
 	 * @throws CircleNotFoundException
175 175
 	 */
176 176
 	public function importFromDatabase(array $data, string $prefix = ''): IQueryRow {
177
-		if (!$this->get($prefix . 'circle_id', $data)) {
177
+		if (!$this->get($prefix.'circle_id', $data)) {
178 178
 			throw new CircleInvitationNotFoundException();
179 179
 		}
180 180
 
181
-		$this->setCircleId($this->get($prefix . 'circle_id', $data))
182
-			->setInvitationCode($this->get($prefix . 'invitation_code', $data))
183
-			->setCreatedBy($this->get($prefix . 'created_by', $data));
181
+		$this->setCircleId($this->get($prefix.'circle_id', $data))
182
+			->setInvitationCode($this->get($prefix.'invitation_code', $data))
183
+			->setCreatedBy($this->get($prefix.'created_by', $data));
184 184
 
185
-		$created = $this->get($prefix . 'created', $data);
185
+		$created = $this->get($prefix.'created', $data);
186 186
 		$dateTime = \DateTime::createFromFormat('Y-m-d H:i:s', $created);
187 187
 		$timestamp = $dateTime ? $dateTime->getTimestamp() : (int)strtotime($created);
188 188
 		$this->setCreated($timestamp);
Please login to merge, or discard this patch.
lib/Db/CoreQueryBuilder.php 1 patch
Spacing   +86 added lines, -86 removed lines patch added patch discarded remove patch
@@ -378,8 +378,8 @@  discard block
 block discarded – undo
378 378
 			$andX = [];
379 379
 			foreach (explode(' ', $circle->getDisplayName()) as $word) {
380 380
 				$andX[] = $expr->iLike(
381
-					$this->getDefaultSelectAlias() . '.' . 'display_name',
382
-					$this->createNamedParameter('%' . $word . '%')
381
+					$this->getDefaultSelectAlias().'.'.'display_name',
382
+					$this->createNamedParameter('%'.$word.'%')
383 383
 				);
384 384
 			}
385 385
 		}
@@ -408,7 +408,7 @@  discard block
 block discarded – undo
408 408
 			$this->generateRemoteInstanceSelectAlias($aliasRemoteInstance)
409 409
 				->leftJoin(
410 410
 					$alias, CoreRequestBuilder::TABLE_REMOTE, $aliasRemoteInstance,
411
-					$expr->eq($alias . '.instance', $aliasRemoteInstance . '.instance')
411
+					$expr->eq($alias.'.instance', $aliasRemoteInstance.'.instance')
412 412
 				);
413 413
 		} catch (RequestBuilderException $e) {
414 414
 		}
@@ -460,7 +460,7 @@  discard block
 block discarded – undo
460 460
 		$expr = $this->expr();
461 461
 		$this->leftJoin(
462 462
 			$this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_REMOTE, $aliasRemote,
463
-			$expr->eq($aliasRemote . '.instance', $this->createNamedParameter($remoteInstance->getInstance()))
463
+			$expr->eq($aliasRemote.'.instance', $this->createNamedParameter($remoteInstance->getInstance()))
464 464
 		);
465 465
 	}
466 466
 
@@ -488,12 +488,12 @@  discard block
 block discarded – undo
488 488
 		$this->leftJoin(
489 489
 			$this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_MEMBER, $aliasRemoteMember,
490 490
 			$expr->andX(
491
-				$expr->eq($aliasRemoteMember . '.circle_id', $aliasCircle . '.unique_id'),
491
+				$expr->eq($aliasRemoteMember.'.circle_id', $aliasCircle.'.unique_id'),
492 492
 				$expr->eq(
493
-					$aliasRemoteMember . '.instance',
493
+					$aliasRemoteMember.'.instance',
494 494
 					$this->createNamedParameter($remoteInstance->getInstance())
495 495
 				),
496
-				$expr->gte($aliasRemoteMember . '.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
496
+				$expr->gte($aliasRemoteMember.'.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
497 497
 			)
498 498
 		);
499 499
 	}
@@ -525,21 +525,21 @@  discard block
 block discarded – undo
525 525
 		$this->leftJoin(
526 526
 			$this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_MEMBER, $aliasRemoteCircle,
527 527
 			$expr->andX(
528
-				$expr->eq($aliasRemoteCircle . '.single_id', $aliasCircle . '.unique_id'),
529
-				$expr->emptyString($aliasRemoteCircle . '.instance'),
530
-				$expr->gte($aliasRemoteCircle . '.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
528
+				$expr->eq($aliasRemoteCircle.'.single_id', $aliasCircle.'.unique_id'),
529
+				$expr->emptyString($aliasRemoteCircle.'.instance'),
530
+				$expr->gte($aliasRemoteCircle.'.level', $this->createNamedParameter(Member::LEVEL_MEMBER))
531 531
 			)
532 532
 		);
533 533
 		$this->leftJoin(
534 534
 			$this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_MEMBER, $aliasRemoteCircleOwner,
535 535
 			$expr->andX(
536
-				$expr->eq($aliasRemoteCircle . '.circle_id', $aliasRemoteCircleOwner . '.circle_id'),
536
+				$expr->eq($aliasRemoteCircle.'.circle_id', $aliasRemoteCircleOwner.'.circle_id'),
537 537
 				$expr->eq(
538
-					$aliasRemoteCircleOwner . '.instance',
538
+					$aliasRemoteCircleOwner.'.instance',
539 539
 					$this->createNamedParameter($remoteInstance->getInstance())
540 540
 				),
541 541
 				$expr->eq(
542
-					$aliasRemoteCircleOwner . '.level', $this->createNamedParameter(Member::LEVEL_OWNER)
542
+					$aliasRemoteCircleOwner.'.level', $this->createNamedParameter(Member::LEVEL_OWNER)
543 543
 				)
544 544
 			)
545 545
 		);
@@ -570,11 +570,11 @@  discard block
 block discarded – undo
570 570
 		$aliasRemoteCircleOwner = $this->generateAlias($aliasRemoteCircle, self::OWNER);
571 571
 
572 572
 		$expr = $this->expr();
573
-		$orX = [$expr->eq($aliasRemote . '.type', $this->createNamedParameter(RemoteInstance::TYPE_GLOBALSCALE))];
573
+		$orX = [$expr->eq($aliasRemote.'.type', $this->createNamedParameter(RemoteInstance::TYPE_GLOBALSCALE))];
574 574
 
575
-		$orExtOrPassive = [$expr->eq($aliasRemote . '.type', $this->createNamedParameter(RemoteInstance::TYPE_EXTERNAL))];
575
+		$orExtOrPassive = [$expr->eq($aliasRemote.'.type', $this->createNamedParameter(RemoteInstance::TYPE_EXTERNAL))];
576 576
 		if (!$sensitive) {
577
-			$orExtOrPassive[] = $expr->eq($aliasRemote . '.type', $this->createNamedParameter(RemoteInstance::TYPE_PASSIVE));
577
+			$orExtOrPassive[] = $expr->eq($aliasRemote.'.type', $this->createNamedParameter(RemoteInstance::TYPE_PASSIVE));
578 578
 		} else {
579 579
 			if ($this->getDefaultSelectAlias() === CoreQueryBuilder::MEMBER) {
580 580
 				$orExtOrPassive[] = $this->limitRemoteVisibility_Sensitive_Members($aliasRemote);
@@ -582,8 +582,8 @@  discard block
 block discarded – undo
582 582
 		}
583 583
 
584 584
 		$orInstance = $expr->orX(
585
-			$expr->isNotNull($aliasRemoteMember . '.instance'),
586
-			$expr->isNotNull($aliasRemoteCircleOwner . '.instance'),
585
+			$expr->isNotNull($aliasRemoteMember.'.instance'),
586
+			$expr->isNotNull($aliasRemoteCircleOwner.'.instance'),
587 587
 		);
588 588
 
589 589
 		$andExternal = $expr->andX(
@@ -593,13 +593,13 @@  discard block
 block discarded – undo
593 593
 
594 594
 		$orExtOrTrusted = $expr->orX(
595 595
 			$andExternal,
596
-			$expr->eq($aliasRemote . '.type', $this->createNamedParameter(RemoteInstance::TYPE_TRUSTED)),
596
+			$expr->eq($aliasRemote.'.type', $this->createNamedParameter(RemoteInstance::TYPE_TRUSTED)),
597 597
 		);
598 598
 
599 599
 		$orX[] = $expr->andX(
600 600
 			$orExtOrTrusted,
601 601
 			$this->exprLimitBitwise('config', Circle::CFG_FEDERATED, $aliasCircle),
602
-			$expr->emptyString($aliasOwner . '.instance'),
602
+			$expr->emptyString($aliasOwner.'.instance'),
603 603
 		);
604 604
 
605 605
 		$this->andWhere($expr->orX(...$orX));
@@ -626,7 +626,7 @@  discard block
 block discarded – undo
626 626
 		}
627 627
 		$this->innerJoin(
628 628
 			$this->getDefaultSelectAlias(), CoreRequestBuilder::TABLE_MEMBER, $aliasMember,
629
-			$expr->eq($aliasMember . '.circle_id', $alias . '.unique_id')
629
+			$expr->eq($aliasMember.'.circle_id', $alias.'.unique_id')
630 630
 		);
631 631
 
632 632
 		$this->filterDirectMembership($aliasMember, $member);
@@ -651,12 +651,12 @@  discard block
 block discarded – undo
651 651
 			$aliasCircle,
652 652
 			'circles_membership',
653 653
 			$aliasMembership,
654
-			$this->expr()->eq($aliasCircle . '.unique_id', $aliasMembership . '.circle_id')
654
+			$this->expr()->eq($aliasCircle.'.unique_id', $aliasMembership.'.circle_id')
655 655
 		);
656 656
 
657 657
 		$this->andWhere(
658 658
 			$this->expr()->eq(
659
-				$aliasMembership . '.single_id',
659
+				$aliasMembership.'.single_id',
660 660
 				$this->createNamedParameter($federatedUser->getSingleId())
661 661
 			)
662 662
 		);
@@ -676,22 +676,22 @@  discard block
 block discarded – undo
676 676
 		$andX = [];
677 677
 
678 678
 		if ($member->getUserId() !== '') {
679
-			$andX[] = $expr->eq($aliasMember . '.user_id', $this->createNamedParameter($member->getUserId()));
679
+			$andX[] = $expr->eq($aliasMember.'.user_id', $this->createNamedParameter($member->getUserId()));
680 680
 		}
681 681
 
682 682
 		if ($member->getSingleId() !== '') {
683
-			$andX[] = $expr->eq($aliasMember . '.single_id', $this->createNamedParameter($member->getSingleId()));
683
+			$andX[] = $expr->eq($aliasMember.'.single_id', $this->createNamedParameter($member->getSingleId()));
684 684
 		}
685 685
 
686 686
 		if ($member->getUserType() > 0) {
687
-			$andX[] = $expr->eq($aliasMember . '.user_type', $this->createNamedParameter($member->getUserType()));
687
+			$andX[] = $expr->eq($aliasMember.'.user_type', $this->createNamedParameter($member->getUserType()));
688 688
 		}
689 689
 
690 690
 		$this->limitToInstance($this->getInstance($member));
691 691
 
692 692
 		if ($member->getLevel() > 0) {
693 693
 			$andX[] = $expr->gte(
694
-				$aliasMember . '.level',
694
+				$aliasMember.'.level',
695 695
 				$this->createNamedParameter($member->getLevel(), IQueryBuilder::PARAM_INT)
696 696
 			);
697 697
 		}
@@ -731,7 +731,7 @@  discard block
 block discarded – undo
731 731
 			$helperAlias,
732 732
 			CoreRequestBuilder::TABLE_CIRCLE,
733 733
 			$aliasCircle,
734
-			$expr->eq($aliasCircle . '.unique_id', $helperAlias . '.' . $field)
734
+			$expr->eq($aliasCircle.'.unique_id', $helperAlias.'.'.$field)
735 735
 		);
736 736
 
737 737
 		if (!is_null($initiator)) {
@@ -762,7 +762,7 @@  discard block
 block discarded – undo
762 762
 		$this->generateCircleSelectAlias($aliasInvitedBy)
763 763
 			->leftJoin(
764 764
 				$aliasMember, CoreRequestBuilder::TABLE_CIRCLE, $aliasInvitedBy,
765
-				$expr->eq($aliasMember . '.invited_by', $aliasInvitedBy . '.unique_id')
765
+				$expr->eq($aliasMember.'.invited_by', $aliasInvitedBy.'.unique_id')
766 766
 			);
767 767
 
768 768
 		$this->leftJoinOwner($aliasInvitedBy);
@@ -793,7 +793,7 @@  discard block
 block discarded – undo
793 793
 		$this->generateCircleSelectAlias($aliasBasedOn)
794 794
 			->leftJoin(
795 795
 				$aliasMember, CoreRequestBuilder::TABLE_CIRCLE, $aliasBasedOn,
796
-				$expr->eq($aliasBasedOn . '.unique_id', $aliasMember . '.single_id')
796
+				$expr->eq($aliasBasedOn.'.unique_id', $aliasMember.'.single_id')
797 797
 			);
798 798
 
799 799
 		if (!is_null($initiator)) {
@@ -826,9 +826,9 @@  discard block
 block discarded – undo
826 826
 			->leftJoin(
827 827
 				$alias, CoreRequestBuilder::TABLE_MEMBER, $aliasMember,
828 828
 				$expr->andX(
829
-					$expr->eq($aliasMember . '.circle_id', $alias . '.' . $field),
829
+					$expr->eq($aliasMember.'.circle_id', $alias.'.'.$field),
830 830
 					$expr->eq(
831
-						$aliasMember . '.level',
831
+						$aliasMember.'.level',
832 832
 						$this->createNamedParameter(Member::LEVEL_OWNER, self::PARAM_INT)
833 833
 					)
834 834
 				)
@@ -858,7 +858,7 @@  discard block
 block discarded – undo
858 858
 		$this->generateCircleInvitationSelectAlias($aliasInvitation)
859 859
 			->leftJoin(
860 860
 				$alias, CoreRequestBuilder::TABLE_INVITATIONS, $aliasInvitation,
861
-				$expr->eq($aliasInvitation . '.circle_id', $alias . '.' . $field),
861
+				$expr->eq($aliasInvitation.'.circle_id', $alias.'.'.$field),
862 862
 			);
863 863
 	}
864 864
 
@@ -884,7 +884,7 @@  discard block
 block discarded – undo
884 884
 
885 885
 		$expr = $this->expr();
886 886
 
887
-		$on = $expr->andX($expr->eq($aliasMembership . '.circle_id', $alias . '.' . $field));
887
+		$on = $expr->andX($expr->eq($aliasMembership.'.circle_id', $alias.'.'.$field));
888 888
 
889 889
 		// limit on membership level if requested
890 890
 		$minLevel = $probe?->getMinimumLevel() ?? 0;
@@ -925,8 +925,8 @@  discard block
 block discarded – undo
925 925
 			->leftJoin(
926 926
 				$alias, CoreRequestBuilder::TABLE_MEMBER, $aliasMember,
927 927
 				$expr->andX(
928
-					$expr->eq($aliasMember . '.circle_id', $alias . '.' . $fieldCircleId),
929
-					$expr->eq($aliasMember . '.single_id', $alias . '.' . $fieldSingleId),
928
+					$expr->eq($aliasMember.'.circle_id', $alias.'.'.$fieldCircleId),
929
+					$expr->eq($aliasMember.'.single_id', $alias.'.'.$fieldSingleId),
930 930
 					$this->exprGt('level', Member::LEVEL_MEMBER, true, $aliasMember)
931 931
 				)
932 932
 			);
@@ -958,7 +958,7 @@  discard block
 block discarded – undo
958 958
 
959 959
 		$this->leftJoin(
960 960
 			$alias, CoreRequestBuilder::TABLE_MEMBERSHIP, $aliasMembership,
961
-			$expr->eq($aliasMembership . '.circle_id', $alias . '.' . $field)
961
+			$expr->eq($aliasMembership.'.circle_id', $alias.'.'.$field)
962 962
 		);
963 963
 
964 964
 		//		if (!$this->getBool('getData', $options, false)) {
@@ -972,8 +972,8 @@  discard block
 block discarded – undo
972 972
 			->leftJoin(
973 973
 				$alias, CoreRequestBuilder::TABLE_MEMBER, $aliasInheritedBy,
974 974
 				$expr->andX(
975
-					$expr->eq($aliasMembership . '.inheritance_last', $aliasInheritedBy . '.circle_id'),
976
-					$expr->eq($aliasMembership . '.single_id', $aliasInheritedBy . '.single_id')
975
+					$expr->eq($aliasMembership.'.inheritance_last', $aliasInheritedBy.'.circle_id'),
976
+					$expr->eq($aliasMembership.'.single_id', $aliasInheritedBy.'.single_id')
977 977
 				)
978 978
 			);
979 979
 
@@ -990,12 +990,12 @@  discard block
 block discarded – undo
990 990
 		$aliasUpstreamMembership = $this->generateAlias($alias, self::UPSTREAM_MEMBERSHIPS, $options);
991 991
 		$this->leftJoin(
992 992
 			$alias, CoreRequestBuilder::TABLE_MEMBERSHIP, $aliasUpstreamMembership,
993
-			$expr->eq($aliasUpstreamMembership . '.single_id', $this->createNamedParameter($singleId))
993
+			$expr->eq($aliasUpstreamMembership.'.single_id', $this->createNamedParameter($singleId))
994 994
 		);
995 995
 
996 996
 		$orX = $expr->orX(
997
-			$expr->eq($aliasUpstreamMembership . '.circle_id', $alias . '.' . $field),
998
-			$expr->eq($alias . '.' . $field, $this->createNamedParameter($singleId))
997
+			$expr->eq($aliasUpstreamMembership.'.circle_id', $alias.'.'.$field),
998
+			$expr->eq($alias.'.'.$field, $this->createNamedParameter($singleId))
999 999
 		);
1000 1000
 
1001 1001
 		$this->andWhere($orX);
@@ -1016,11 +1016,11 @@  discard block
 block discarded – undo
1016 1016
 
1017 1017
 		$expr = $this->expr();
1018 1018
 		$aliasMembership = $this->generateAlias($alias, self::MEMBERSHIPS);
1019
-		$this->andWhere($expr->eq($aliasMembership . '.circle_id', $this->createNamedParameter($singleId)));
1019
+		$this->andWhere($expr->eq($aliasMembership.'.circle_id', $this->createNamedParameter($singleId)));
1020 1020
 		if ($level > 1) {
1021 1021
 			$this->andWhere(
1022 1022
 				$expr->gte(
1023
-					$aliasMembership . '.level',
1023
+					$aliasMembership.'.level',
1024 1024
 					$this->createNamedParameter($level, IQueryBuilder::PARAM_INT)
1025 1025
 				)
1026 1026
 			);
@@ -1048,8 +1048,8 @@  discard block
 block discarded – undo
1048 1048
 		$this->leftJoin(
1049 1049
 			$alias, CoreRequestBuilder::TABLE_MEMBERSHIP, $aliasMembership,
1050 1050
 			$expr->andX(
1051
-				$expr->eq($aliasMembership . '.inheritance_last', $alias . '.' . $field),
1052
-				$expr->eq($aliasMembership . '.single_id', $alias . '.single_id')
1051
+				$expr->eq($aliasMembership.'.inheritance_last', $alias.'.'.$field),
1052
+				$expr->eq($aliasMembership.'.single_id', $alias.'.single_id')
1053 1053
 			)
1054 1054
 		);
1055 1055
 
@@ -1062,8 +1062,8 @@  discard block
 block discarded – undo
1062 1062
 			->leftJoin(
1063 1063
 				$aliasMembership, CoreRequestBuilder::TABLE_MEMBER, $aliasInheritanceFrom,
1064 1064
 				$expr->andX(
1065
-					$expr->eq($aliasMembership . '.circle_id', $aliasInheritanceFrom . '.circle_id'),
1066
-					$expr->eq($aliasMembership . '.inheritance_first', $aliasInheritanceFrom . '.single_id')
1065
+					$expr->eq($aliasMembership.'.circle_id', $aliasInheritanceFrom.'.circle_id'),
1066
+					$expr->eq($aliasMembership.'.inheritance_first', $aliasInheritanceFrom.'.single_id')
1067 1067
 				)
1068 1068
 			);
1069 1069
 	}
@@ -1103,7 +1103,7 @@  discard block
 block discarded – undo
1103 1103
 
1104 1104
 		$this->leftJoin(
1105 1105
 			$alias, CoreRequestBuilder::TABLE_TOKEN, $aliasShareToken,
1106
-			$expr->eq($aliasShareToken . '.share_id', $alias . '.' . $field)
1106
+			$expr->eq($aliasShareToken.'.share_id', $alias.'.'.$field)
1107 1107
 		);
1108 1108
 	}
1109 1109
 
@@ -1150,14 +1150,14 @@  discard block
 block discarded – undo
1150 1150
 		try {
1151 1151
 			$aliasConfig = $this->generateAlias($alias, self::CONFIG, $options);
1152 1152
 			$this->selectAlias(
1153
-				$aliasConfig . '.config',
1154
-				(($alias !== $this->getDefaultSelectAlias()) ? $alias . '_' : '') . 'circle_config'
1153
+				$aliasConfig.'.config',
1154
+				(($alias !== $this->getDefaultSelectAlias()) ? $alias.'_' : '').'circle_config'
1155 1155
 			);
1156 1156
 			$this->leftJoin(
1157 1157
 				$alias,
1158 1158
 				CoreRequestBuilder::TABLE_CIRCLE,
1159 1159
 				$aliasConfig,
1160
-				$expr->eq($alias . '.circle_id', $aliasConfig . '.unique_id')
1160
+				$expr->eq($alias.'.circle_id', $aliasConfig.'.unique_id')
1161 1161
 			);
1162 1162
 		} catch (RequestBuilderException $e) {
1163 1163
 		}
@@ -1195,7 +1195,7 @@  discard block
 block discarded – undo
1195 1195
 			$aliasMembership,
1196 1196
 			$expr->andX(
1197 1197
 				$this->exprLimit('single_id', $initiator->getSingleId(), $aliasMembership),
1198
-				$expr->eq($aliasMembership . '.circle_id', $helperAlias . '.' . $field)
1198
+				$expr->eq($aliasMembership.'.circle_id', $helperAlias.'.'.$field)
1199 1199
 			)
1200 1200
 		);
1201 1201
 
@@ -1213,10 +1213,10 @@  discard block
 block discarded – undo
1213 1213
 		try {
1214 1214
 			$aliasMembershipCircle = $this->generateAlias($aliasMembership, self::CONFIG, $options);
1215 1215
 			$orXMembershipCircle = $expr->orX(...array_map(
1216
-				function (string $alias) use ($aliasMembershipCircle) {
1216
+				function(string $alias) use ($aliasMembershipCircle) {
1217 1217
 					return $this->expr()->eq(
1218
-						$alias . '.circle_id',
1219
-						$aliasMembershipCircle . '.unique_id'
1218
+						$alias.'.circle_id',
1219
+						$aliasMembershipCircle.'.unique_id'
1220 1220
 					);
1221 1221
 				},
1222 1222
 				$listMembershipCircleAlias
@@ -1247,7 +1247,7 @@  discard block
 block discarded – undo
1247 1247
 						$aliasDirectInitiator,
1248 1248
 						$expr->andX(
1249 1249
 							$this->exprLimit('single_id', $initiator->getSingleId(), $aliasDirectInitiator),
1250
-							$expr->eq($aliasDirectInitiator . '.circle_id', $helperAlias . '.' . $field)
1250
+							$expr->eq($aliasDirectInitiator.'.circle_id', $helperAlias.'.'.$field)
1251 1251
 						)
1252 1252
 					);
1253 1253
 			} catch (RequestBuilderException $e) {
@@ -1261,8 +1261,8 @@  discard block
 block discarded – undo
1261 1261
 			$this->leftJoin(
1262 1262
 				$aliasMembership, CoreRequestBuilder::TABLE_MEMBER, $aliasInitiator,
1263 1263
 				$expr->andX(
1264
-					$expr->eq($aliasMembership . '.inheritance_first', $aliasInitiator . '.single_id'),
1265
-					$expr->eq($aliasMembership . '.circle_id', $aliasInitiator . '.circle_id')
1264
+					$expr->eq($aliasMembership.'.inheritance_first', $aliasInitiator.'.single_id'),
1265
+					$expr->eq($aliasMembership.'.circle_id', $aliasInitiator.'.circle_id')
1266 1266
 				)
1267 1267
 			);
1268 1268
 
@@ -1270,8 +1270,8 @@  discard block
 block discarded – undo
1270 1270
 			$this->leftJoin(
1271 1271
 				$aliasInitiator, CoreRequestBuilder::TABLE_MEMBER, $aliasInheritedBy,
1272 1272
 				$expr->andX(
1273
-					$expr->eq($aliasMembership . '.single_id', $aliasInheritedBy . '.single_id'),
1274
-					$expr->eq($aliasMembership . '.inheritance_last', $aliasInheritedBy . '.circle_id')
1273
+					$expr->eq($aliasMembership.'.single_id', $aliasInheritedBy.'.single_id'),
1274
+					$expr->eq($aliasMembership.'.inheritance_last', $aliasInheritedBy.'.circle_id')
1275 1275
 				)
1276 1276
 			);
1277 1277
 
@@ -1316,8 +1316,8 @@  discard block
 block discarded – undo
1316 1316
 			->leftJoin(
1317 1317
 				$alias, CoreRequestBuilder::TABLE_MEMBER, $aliasInitiator,
1318 1318
 				$expr->andX(
1319
-					$expr->eq($aliasInitiator . '.circle_id', $alias . '.unique_id'),
1320
-					$expr->eq($aliasInitiator . '.' . $field, $helperAlias . '.inheritance_first'),
1319
+					$expr->eq($aliasInitiator.'.circle_id', $alias.'.unique_id'),
1320
+					$expr->eq($aliasInitiator.'.'.$field, $helperAlias.'.inheritance_first'),
1321 1321
 				)
1322 1322
 			);
1323 1323
 		//
@@ -1353,15 +1353,15 @@  discard block
 block discarded – undo
1353 1353
 		if (!$this->getBool('filterPersonalCircles', $options, false)) {
1354 1354
 			$orX[] = $expr->andX(
1355 1355
 				$this->exprLimitBitwise('config', Circle::CFG_PERSONAL, $aliasMembershipCircle),
1356
-				$expr->eq($aliasMembership . '.level', $this->createNamedParameter(Member::LEVEL_OWNER))
1356
+				$expr->eq($aliasMembership.'.level', $this->createNamedParameter(Member::LEVEL_OWNER))
1357 1357
 			);
1358 1358
 		}
1359 1359
 
1360 1360
 		$minimumLevel = $this->getInt('minimumLevel', $options);
1361 1361
 		$orXLevelCheck = $expr->orX(...array_map(
1362
-			function (string $alias) use ($minimumLevel) {
1362
+			function(string $alias) use ($minimumLevel) {
1363 1363
 				return $this->expr()->gte(
1364
-					$alias . '.level',
1364
+					$alias.'.level',
1365 1365
 					$this->createNamedParameter($minimumLevel, self::PARAM_INT)
1366 1366
 				);
1367 1367
 			},
@@ -1441,13 +1441,13 @@  discard block
 block discarded – undo
1441 1441
 	private function limitRemoteVisibility_Sensitive_Members(string $alias): ICompositeExpression {
1442 1442
 		$expr = $this->expr();
1443 1443
 		return $expr->andX(
1444
-			$expr->eq($alias . '.type', $this->createNamedParameter(RemoteInstance::TYPE_PASSIVE)),
1444
+			$expr->eq($alias.'.type', $this->createNamedParameter(RemoteInstance::TYPE_PASSIVE)),
1445 1445
 			$expr->orX(
1446
-				$expr->eq($this->getDefaultSelectAlias() . '.instance', $alias . '.instance'),
1446
+				$expr->eq($this->getDefaultSelectAlias().'.instance', $alias.'.instance'),
1447 1447
 				// TODO: do we need this ? (display members from the local instance)
1448
-				$expr->emptyString($this->getDefaultSelectAlias() . '.instance'),
1448
+				$expr->emptyString($this->getDefaultSelectAlias().'.instance'),
1449 1449
 				$expr->eq(
1450
-					$this->getDefaultSelectAlias() . '.level',
1450
+					$this->getDefaultSelectAlias().'.level',
1451 1451
 					$this->createNamedParameter(Member::LEVEL_OWNER)
1452 1452
 				),
1453 1453
 			),
@@ -1482,11 +1482,11 @@  discard block
 block discarded – undo
1482 1482
 			)
1483 1483
 			->leftJoin(
1484 1484
 				$aliasShare, CoreRequestBuilder::TABLE_FILE_CACHE, $aliasFileCache,
1485
-				$expr->eq($aliasShare . '.file_source', $aliasFileCache . '.fileid')
1485
+				$expr->eq($aliasShare.'.file_source', $aliasFileCache.'.fileid')
1486 1486
 			)
1487 1487
 			->leftJoin(
1488 1488
 				$aliasFileCache, CoreRequestBuilder::TABLE_STORAGES, $aliasStorages,
1489
-				$expr->eq($aliasFileCache . '.storage', $aliasStorages . '.numeric_id')
1489
+				$expr->eq($aliasFileCache.'.storage', $aliasStorages.'.numeric_id')
1490 1490
 			);
1491 1491
 	}
1492 1492
 
@@ -1508,8 +1508,8 @@  discard block
 block discarded – undo
1508 1508
 		$this->leftJoin(
1509 1509
 			$aliasShareMemberships, CoreRequestBuilder::TABLE_SHARE, $aliasShareChild,
1510 1510
 			$expr->andX(
1511
-				$expr->eq($aliasShareChild . '.parent', $aliasShare . '.id'),
1512
-				$expr->eq($aliasShareChild . '.share_with', $aliasShareMemberships . '.single_id')
1511
+				$expr->eq($aliasShareChild.'.parent', $aliasShare.'.id'),
1512
+				$expr->eq($aliasShareChild.'.share_with', $aliasShareMemberships.'.single_id')
1513 1513
 			)
1514 1514
 		);
1515 1515
 
@@ -1567,7 +1567,7 @@  discard block
 block discarded – undo
1567 1567
 
1568 1568
 		$expr = $this->expr();
1569 1569
 		$this->andWhere(
1570
-			$expr->eq($aliasInvitation . '.invitation_code', $this->createNamedParameter($invitationCode))
1570
+			$expr->eq($aliasInvitation.'.invitation_code', $this->createNamedParameter($invitationCode))
1571 1571
 		);
1572 1572
 	}
1573 1573
 
@@ -1588,13 +1588,13 @@  discard block
 block discarded – undo
1588 1588
 		$this->leftJoin(
1589 1589
 			$aliasMountMemberships, CoreRequestBuilder::TABLE_MOUNTPOINT, $aliasMountpoint,
1590 1590
 			$expr->andX(
1591
-				$expr->eq($aliasMountpoint . '.mount_id', $aliasMount . '.mount_id'),
1592
-				$expr->eq($aliasMountpoint . '.single_id', $this->createNamedParameter($federatedUser->getSingleId()))
1591
+				$expr->eq($aliasMountpoint.'.mount_id', $aliasMount.'.mount_id'),
1592
+				$expr->eq($aliasMountpoint.'.single_id', $this->createNamedParameter($federatedUser->getSingleId()))
1593 1593
 			)
1594 1594
 		);
1595 1595
 
1596
-		$this->selectAlias($aliasMountpoint . '.mountpoint', $aliasMountpoint . '_mountpoint');
1597
-		$this->selectAlias($aliasMountpoint . '.mountpoint_hash', $aliasMountpoint . '_mountpoint_hash');
1596
+		$this->selectAlias($aliasMountpoint.'.mountpoint', $aliasMountpoint.'_mountpoint');
1597
+		$this->selectAlias($aliasMountpoint.'.mountpoint_hash', $aliasMountpoint.'_mountpoint_hash');
1598 1598
 	}
1599 1599
 
1600 1600
 
@@ -1719,10 +1719,10 @@  discard block
 block discarded – undo
1719 1719
 	 */
1720 1720
 	public function generateAlias(string $base, string $extension, ?array &$options = []): string {
1721 1721
 		$search = str_replace('_', '.', $base);
1722
-		$path = $search . '.' . $extension;
1722
+		$path = $search.'.'.$extension;
1723 1723
 		if (!$this->validKey($path, $this->getSqlPath())
1724 1724
 			&& !in_array($extension, $this->getArray($search, $this->getSqlPath()))) {
1725
-			throw new RequestBuilderException($extension . ' not found in ' . $search);
1725
+			throw new RequestBuilderException($extension.' not found in '.$search);
1726 1726
 		}
1727 1727
 
1728 1728
 		if (!is_array($options)) {
@@ -1731,15 +1731,15 @@  discard block
 block discarded – undo
1731 1731
 
1732 1732
 		$optionPath = '';
1733 1733
 		foreach (explode('.', $path) as $p) {
1734
-			$optionPath = trim($optionPath . '.' . $p, '.');
1734
+			$optionPath = trim($optionPath.'.'.$p, '.');
1735 1735
 			$options = array_merge(
1736 1736
 				$options,
1737
-				$this->getArray($optionPath . '.' . self::OPTIONS, $this->getSqlPath()),
1738
-				$this->getArray($optionPath . '.' . self::OPTIONS, $this->options)
1737
+				$this->getArray($optionPath.'.'.self::OPTIONS, $this->getSqlPath()),
1738
+				$this->getArray($optionPath.'.'.self::OPTIONS, $this->options)
1739 1739
 			);
1740 1740
 		}
1741 1741
 
1742
-		return $base . '_' . $extension;
1742
+		return $base.'_'.$extension;
1743 1743
 	}
1744 1744
 
1745 1745
 
@@ -1759,7 +1759,7 @@  discard block
 block discarded – undo
1759 1759
 			} else {
1760 1760
 				$k = $arr;
1761 1761
 			}
1762
-			$path[$k] = $prefix . '_' . $k . '_';
1762
+			$path[$k] = $prefix.'_'.$k.'_';
1763 1763
 		}
1764 1764
 
1765 1765
 		return $path;
Please login to merge, or discard this patch.