Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 39 | class CirclesMapper extends Mapper { |
||
| 40 | |||
| 41 | const TABLENAME = 'circles_circles'; |
||
| 42 | |||
| 43 | private $miscService; |
||
| 44 | |||
| 45 | public function __construct(IDBConnection $db, $miscService) { |
||
| 50 | |||
| 51 | |||
| 52 | /** |
||
| 53 | * Returns all circle from a user point-of-view |
||
| 54 | * |
||
| 55 | * @param $userId |
||
| 56 | * @param $type |
||
| 57 | * @param string $name |
||
| 58 | * @param int $level |
||
| 59 | * @param int $circleId |
||
| 60 | * |
||
| 61 | * @return Circle[] |
||
| 62 | * @throws ConfigNoCircleAvailable |
||
| 63 | */ |
||
| 64 | public function findCirclesByUser($userId, $type, $name = '', $level = 0, $circleId = -1) { |
||
| 83 | |||
| 84 | |||
| 85 | /** |
||
| 86 | * Returns SQL for findCirclesByUser |
||
| 87 | * |
||
| 88 | * @param $userId |
||
| 89 | * @param $type |
||
| 90 | * @param $name |
||
| 91 | * @param $level |
||
| 92 | * @param $circleId |
||
| 93 | * |
||
| 94 | * @return IQueryBuilder |
||
| 95 | * @throws ConfigNoCircleAvailable |
||
| 96 | */ |
||
| 97 | private function findCirclesByUserSql($userId, $type, $name, $level, $circleId) { |
||
| 130 | |||
| 131 | |||
| 132 | private function buildWithOrXTypes(&$qb, $userId, $type, $name, $circleId) { |
||
| 148 | |||
| 149 | |||
| 150 | /** |
||
| 151 | * fill with sql conditions for each type of circles. |
||
| 152 | * |
||
| 153 | * @param $qb |
||
| 154 | * @param $userId |
||
| 155 | * @param $type |
||
| 156 | * @param $name |
||
| 157 | * @param $circleId |
||
| 158 | * |
||
| 159 | * @return array |
||
| 160 | */ |
||
| 161 | private function fillOrXTypes(&$qb, $userId, $type, $name, $circleId) { |
||
| 173 | |||
| 174 | /** |
||
| 175 | * @param IQueryBuilder $qb |
||
| 176 | * @param string $field |
||
| 177 | * @param int $circleId |
||
| 178 | */ |
||
| 179 | private function buildWithCircleId(IQueryBuilder & $qb, string $field, int $circleId) { |
||
| 187 | |||
| 188 | |||
| 189 | /** |
||
| 190 | * @param IQueryBuilder $qb |
||
| 191 | * @param string $field |
||
| 192 | * @param int $level |
||
| 193 | */ |
||
| 194 | private function buildWithMemberLevel(IQueryBuilder & $qb, string $field, int $level) { |
||
| 202 | |||
| 203 | |||
| 204 | /** |
||
| 205 | * @param IQueryBuilder $qb |
||
| 206 | * @param int $type |
||
| 207 | * @param int|string $userId |
||
| 208 | * |
||
| 209 | * @return \OCP\DB\QueryBuilder\ICompositeExpression |
||
| 210 | */ |
||
| 211 | private function generateTypeEntryForCirclePersonal(IQueryBuilder $qb, int $type, string $userId |
||
| 228 | |||
| 229 | /** |
||
| 230 | * @param IQueryBuilder $qb |
||
| 231 | * @param int $type |
||
| 232 | * @param int $circleId |
||
| 233 | * @param string $name |
||
| 234 | * |
||
| 235 | * @return string |
||
| 236 | */ |
||
| 237 | private function generateTypeEntryForCircleHidden( |
||
| 259 | |||
| 260 | |||
| 261 | /** |
||
| 262 | * @param IQueryBuilder $qb |
||
| 263 | * @param int $type |
||
| 264 | * |
||
| 265 | * @return string |
||
| 266 | */ |
||
| 267 | View Code Duplication | private function generateTypeEntryForCirclePrivate(IQueryBuilder $qb, int $type) { |
|
| 278 | |||
| 279 | |||
| 280 | /** |
||
| 281 | * @param IQueryBuilder $qb |
||
| 282 | * @param int $type |
||
| 283 | * |
||
| 284 | * @return string |
||
| 285 | */ |
||
| 286 | View Code Duplication | private function generateTypeEntryForCirclePublic(IQueryBuilder $qb, int $type) { |
|
| 297 | |||
| 298 | /** |
||
| 299 | * Returns details about a circle. |
||
| 300 | * |
||
| 301 | * @param string $userId |
||
| 302 | * @param int $circleId |
||
| 303 | * |
||
| 304 | * @return Circle |
||
| 305 | * @throws CircleDoesNotExistException |
||
| 306 | * @throws ConfigNoCircleAvailable |
||
| 307 | */ |
||
| 308 | public function getDetailsFromCircle($circleId, $userId) { |
||
| 324 | |||
| 325 | |||
| 326 | /** |
||
| 327 | * @param Circle $circle |
||
| 328 | * @param Member $owner |
||
| 329 | * |
||
| 330 | * @return bool |
||
| 331 | * @throws CircleAlreadyExistsException |
||
| 332 | */ |
||
| 333 | public function create(Circle & $circle, Member & $owner) { |
||
| 354 | |||
| 355 | |||
| 356 | /** |
||
| 357 | * remove a circle |
||
| 358 | * |
||
| 359 | * @param Circle $circle |
||
| 360 | */ |
||
| 361 | View Code Duplication | public function destroy(Circle $circle) { |
|
| 373 | |||
| 374 | |||
| 375 | /** |
||
| 376 | * returns if the circle is already in database |
||
| 377 | * |
||
| 378 | * @param Circle $circle |
||
| 379 | * @param Member $owner |
||
| 380 | * |
||
| 381 | * @return bool |
||
| 382 | */ |
||
| 383 | public function isCircleUnique(Circle $circle, Member $owner) { |
||
| 401 | |||
| 402 | |||
| 403 | /** |
||
| 404 | * Return SQL for isCircleUnique(); |
||
| 405 | * |
||
| 406 | * @return IQueryBuilder |
||
| 407 | */ |
||
| 408 | private function isCircleUniqueSql() { |
||
| 423 | |||
| 424 | |||
| 425 | /** |
||
| 426 | * return if the personal circle is unique |
||
| 427 | * |
||
| 428 | * @param Circle $circle |
||
| 429 | * @param Member $owner |
||
| 430 | * |
||
| 431 | * @return bool |
||
| 432 | */ |
||
| 433 | private function isPersonalCircleUnique(Circle $circle, Member $owner) { |
||
| 448 | } |
||
| 449 | |||
| 450 |