Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 31 | class FederatedLink implements \JsonSerializable { |
||
| 32 | |||
| 33 | |||
| 34 | const STATUS_ERROR = -1; |
||
| 35 | const STATUS_LINK_REMOVE = 0; |
||
| 36 | const STATUS_LINK_DOWN = 1; |
||
| 37 | const STATUS_LINK_SETUP = 2; |
||
| 38 | const STATUS_REQUEST_DECLINED = 4; |
||
| 39 | const STATUS_REQUEST_SENT = 5; |
||
| 40 | const STATUS_LINK_REQUESTED = 6; |
||
| 41 | const STATUS_LINK_UP = 9; |
||
| 42 | |||
| 43 | /** @var int */ |
||
| 44 | private $id; |
||
| 45 | |||
| 46 | /** @var string */ |
||
| 47 | private $token; |
||
| 48 | |||
| 49 | /** @var string */ |
||
| 50 | private $address; |
||
| 51 | |||
| 52 | /** @var string */ |
||
| 53 | private $localAddress; |
||
| 54 | |||
| 55 | /** @var int */ |
||
| 56 | private $status; |
||
| 57 | |||
| 58 | /** @var int */ |
||
| 59 | private $creation; |
||
| 60 | |||
| 61 | /** @var int */ |
||
| 62 | private $circleId; |
||
| 63 | |||
| 64 | /** @var string */ |
||
| 65 | private $uniqueId = ''; |
||
| 66 | |||
| 67 | /** @var string */ |
||
| 68 | private $remoteCircleName; |
||
| 69 | |||
| 70 | /** @var string */ |
||
| 71 | private $localCircleName; |
||
| 72 | |||
| 73 | |||
| 74 | public function __construct() { |
||
| 76 | |||
| 77 | |||
| 78 | /** |
||
| 79 | * @param int $id |
||
| 80 | * |
||
| 81 | * @return FederatedLink |
||
| 82 | */ |
||
| 83 | public function setId($id) { |
||
| 88 | |||
| 89 | /** |
||
| 90 | * @return int |
||
| 91 | */ |
||
| 92 | public function getId() { |
||
| 95 | |||
| 96 | |||
| 97 | /** |
||
| 98 | * @param $token |
||
| 99 | * |
||
| 100 | * @return $this |
||
| 101 | */ |
||
| 102 | public function setToken($token) { |
||
| 107 | |||
| 108 | /** |
||
| 109 | * @return string |
||
| 110 | */ |
||
| 111 | public function getToken() { |
||
| 114 | |||
| 115 | |||
| 116 | public function shortenToken() { |
||
| 119 | |||
| 120 | |||
| 121 | public function shortenUniqueId() { |
||
| 124 | |||
| 125 | |||
| 126 | /** |
||
| 127 | * @return string |
||
| 128 | */ |
||
| 129 | public function generateToken() { |
||
| 135 | |||
| 136 | |||
| 137 | /** |
||
| 138 | * @param string $address |
||
| 139 | * |
||
| 140 | * @return FederatedLink |
||
| 141 | */ |
||
| 142 | public function setAddress($address) { |
||
| 147 | |||
| 148 | /** |
||
| 149 | * @return string |
||
| 150 | */ |
||
| 151 | public function getAddress() { |
||
| 154 | |||
| 155 | |||
| 156 | /** |
||
| 157 | * @param string $address |
||
| 158 | * |
||
| 159 | * @return FederatedLink |
||
| 160 | */ |
||
| 161 | public function setLocalAddress($address) { |
||
| 166 | |||
| 167 | /** |
||
| 168 | * @return string |
||
| 169 | */ |
||
| 170 | public function getLocalAddress() { |
||
| 173 | |||
| 174 | |||
| 175 | /** |
||
| 176 | * @param int $circleId |
||
| 177 | * |
||
| 178 | * @return FederatedLink |
||
| 179 | */ |
||
| 180 | public function setCircleId($circleId) { |
||
| 185 | |||
| 186 | /** |
||
| 187 | * @return int |
||
| 188 | */ |
||
| 189 | public function getCircleId() { |
||
| 192 | |||
| 193 | |||
| 194 | /** |
||
| 195 | * @param string $uniqueId |
||
| 196 | * |
||
| 197 | * @return FederatedLink |
||
| 198 | */ |
||
| 199 | public function setUniqueId($uniqueId) { |
||
| 204 | |||
| 205 | /** |
||
| 206 | * @return string |
||
| 207 | */ |
||
| 208 | public function getUniqueId() { |
||
| 211 | |||
| 212 | |||
| 213 | /** |
||
| 214 | * @param string $circleName |
||
| 215 | * |
||
| 216 | * @return FederatedLink |
||
| 217 | */ |
||
| 218 | public function setRemoteCircleName($circleName) { |
||
| 223 | |||
| 224 | /** |
||
| 225 | * @return string |
||
| 226 | */ |
||
| 227 | public function getRemoteCircleName() { |
||
| 230 | |||
| 231 | |||
| 232 | /** |
||
| 233 | * @param string $circleName |
||
| 234 | * |
||
| 235 | * @return FederatedLink |
||
| 236 | */ |
||
| 237 | public function setCircleName($circleName) { |
||
| 242 | |||
| 243 | /** |
||
| 244 | * @return string |
||
| 245 | */ |
||
| 246 | public function getCircleName() { |
||
| 249 | |||
| 250 | |||
| 251 | /** |
||
| 252 | * @param int $status |
||
| 253 | * |
||
| 254 | * @return FederatedLink |
||
| 255 | */ |
||
| 256 | public function setStatus($status) { |
||
| 261 | |||
| 262 | /** |
||
| 263 | * @return int |
||
| 264 | */ |
||
| 265 | public function getStatus() { |
||
| 268 | |||
| 269 | |||
| 270 | /** |
||
| 271 | * @param int $creation |
||
| 272 | * |
||
| 273 | * @return FederatedLink |
||
| 274 | */ |
||
| 275 | public function setCreation($creation) { |
||
| 284 | |||
| 285 | /** |
||
| 286 | * @return int |
||
| 287 | */ |
||
| 288 | public function getCreation() { |
||
| 291 | |||
| 292 | |||
| 293 | public function hasToBeValidStatusUpdate($status) { |
||
| 317 | |||
| 318 | // |
||
| 319 | // public function isValid() { |
||
| 320 | // |
||
| 321 | // if ($this->getStatus() === FederatedLink::STATUS_REQUEST_SENT |
||
| 322 | // || $this->getStatus() === FederatedLink::STATUS_LINK_UP |
||
| 323 | // ) { |
||
| 324 | // return true; |
||
| 325 | // } |
||
| 326 | // |
||
| 327 | // return false; |
||
| 328 | // } |
||
| 329 | |||
| 330 | public function jsonSerialize() { |
||
| 340 | |||
| 341 | } |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.