SyncService - Code Metrics - Inspection of "+invitedBy" - nextcloud/circles - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#609)

by Maxence

created 2021-06-02 18:09 UTC

SyncService A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	369
Duplicated Lines	9.76 %

Coupling/Cohesion

Components	2
Dependencies	12

Importance

Changes

Metric	Value
wmc	25
lcom	2
cbo	12
dl	36
loc	369
rs	10
c	0
b	0
f	0

18 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	21	21	1
A	migration()	0	11	2
A	migrationTo22()	0	3	1
A	syncAll()	0	8	1
A	syncOcc()	0	3	1
A	syncNextcloudUsers()	0	8	3
A	syncNextcloudUser()	0	3	1
A	syncNextcloudGroups()	0	8	3
A	syncNextcloudGroup()	0	17	2
A	userDeleted()	8	8	1
A	groupDeleted()	0	25	2
A	generateGroupMember()	0	12	1
A	groupMemberAdded()	0	13	1
A	groupMemberRemoved()	7	7	1
A	syncContacts()	0	2	1
A	syncGlobalScale()	0	2	1
A	syncRemote()	0	2	1
A	syncRemoteCircle()	0	2	1

How to fix Duplicated Code

<?php

declare(strict_types=1);


/**
 * Circles - Bring cloud-users closer together.
 *
 * This file is licensed under the Affero General Public License version 3 or
 * later. See the COPYING file.
 *
 * @author Maxence Lange <[email protected]>
 * @copyright 2021
 * @license GNU AGPL version 3 or any later version
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as
 * published by the Free Software Foundation, either version 3 of the
 * License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 */


namespace OCA\Circles\Service;


use daita\MySmallPhpTools\Traits\TStringTools;
use Exception;
use OCA\Circles\AppInfo\Application;
use OCA\Circles\Db\CircleRequest;
use OCA\Circles\Db\MemberRequest;
use OCA\Circles\Exceptions\CircleNotFoundException;
use OCA\Circles\Exceptions\FederatedEventException;
use OCA\Circles\Exceptions\FederatedItemException;
use OCA\Circles\Exceptions\FederatedUserException;
use OCA\Circles\Exceptions\FederatedUserNotFoundException;
use OCA\Circles\Exceptions\GroupNotFoundException;
use OCA\Circles\Exceptions\InitiatorNotConfirmedException;
use OCA\Circles\Exceptions\InvalidIdException;
use OCA\Circles\Exceptions\MigrationTo22Exception;
use OCA\Circles\Exceptions\OwnerNotFoundException;
use OCA\Circles\Exceptions\RemoteInstanceException;
use OCA\Circles\Exceptions\RemoteNotFoundException;
use OCA\Circles\Exceptions\RemoteResourceNotFoundException;
use OCA\Circles\Exceptions\RequestBuilderException;
use OCA\Circles\Exceptions\SingleCircleNotFoundException;
use OCA\Circles\Exceptions\UnknownRemoteException;
use OCA\Circles\FederatedItems\SingleMemberAdd;
use OCA\Circles\Model\Circle;
use OCA\Circles\Model\Federated\FederatedEvent;
use OCA\Circles\Model\FederatedUser;
use OCA\Circles\Model\ManagedModel;
use OCA\Circles\Model\Member;
use OCP\IGroupManager;
use OCP\IUserManager;


/**
 * Class SyncService
 *
 * @package OCA\Circles\Service
 */
class SyncService {


	use TStringTools;


	/** @var IUserManager */
	private $userManager;

	/** @var IGroupManager */
	private $groupManager;

	/** @var CircleRequest */
	private $circleRequest;

	/** @var MemberRequest */
	private $memberRequest;

	/** @var FederatedUserService */
	private $federatedUserService;

	/** @var federatedEventService */
	private $federatedEventService;

	/** @var MemberService */
	private $memberService;

	/** @var MembershipService */
	private $membershipService;

	/** @var ConfigService */
	private $configService;


	/**
	 * SyncService constructor.
	 *
	 * @param IUserManager $userManager
	 * @param IGroupManager $groupManager
	 * @param CircleRequest $circleRequest
	 * @param MemberRequest $memberRequest
	 * @param FederatedUserService $federatedUserService
	 * @param federatedEventService $federatedEventService
	 * @param MemberService $memberService
	 * @param MembershipService $membershipService
	 * @param ConfigService $configService
	 */
	public function __construct(

		IUserManager $userManager,
		IGroupManager $groupManager,
		CircleRequest $circleRequest,
		MemberRequest $memberRequest,
		FederatedUserService $federatedUserService,
		federatedEventService $federatedEventService,
		MemberService $memberService,
		MembershipService $membershipService,
		ConfigService $configService
	) {
		$this->userManager = $userManager;
		$this->groupManager = $groupManager;
		$this->circleRequest = $circleRequest;
		$this->memberRequest = $memberRequest;
		$this->federatedUserService = $federatedUserService;
		$this->federatedEventService = $federatedEventService;
		$this->memberService = $memberService;
		$this->membershipService = $membershipService;
		$this->configService = $configService;
	}


	/**
	 * @return bool
	 * @throws MigrationTo22Exception
	 */
	public function migration(): bool {
		if ($this->configService->getAppValueBool(ConfigService::MIGRATION_22)) {
			return false;
		}

		$this->migrationTo22();
		$this->configService->setAppValue(ConfigService::MIGRATION_22, '1');

		return true;

	}

	/**
	 * @return void
	 * @throws MigrationTo22Exception
	 */
	private function migrationTo22(): void {
		throw new MigrationTo22Exception('migration failed');
	}


	/**
	 * @return void
	 */
	public function syncAll(): void {
		$this->syncOcc();
		$this->syncNextcloudUsers();
		$this->syncGlobalScale();
		$this->syncRemote();
		$this->syncNextcloudGroups();
		$this->syncContacts();
	}


	/**
	 * @throws FederatedUserException
	 * @throws InvalidIdException
	 * @throws RequestBuilderException
	 * @throws SingleCircleNotFoundException
	 */
	public function syncOcc(): void {
		$this->federatedUserService->getAppInitiator('occ', Member::APP_OCC);
	}


	/**
	 * @return void
	 */
	public function syncNextcloudUsers(): void {
		foreach ($this->userManager->search('') as $user) {
			try {
				$this->syncNextcloudUser($user->getUID());
			} catch (Exception $e) {

			}
		}
	}

	/**
	 * @param string $userId
	 *
	 * @return FederatedUser
	 * @throws FederatedUserException
	 * @throws FederatedUserNotFoundException
	 * @throws InvalidIdException
	 * @throws SingleCircleNotFoundException
	 * @throws RequestBuilderException
	 */
	public function syncNextcloudUser(string $userId): FederatedUser {
		return $this->federatedUserService->getLocalFederatedUser($userId);
	}


	/**
	 * @return void
	 */
	public function syncNextcloudGroups(): void {
		foreach ($this->groupManager->search('') as $group) {
			try {
				$this->syncNextcloudGroup($group->getGID());
			} catch (Exception $e) {

			}
		}
	}

	/**
	 * @param string $groupId
	 *
	 * @return Circle
	 * @throws FederatedUserException
	 * @throws FederatedUserNotFoundException
	 * @throws GroupNotFoundException
	 * @throws InvalidIdException
	 * @throws SingleCircleNotFoundException
	 * @throws FederatedEventException
	 * @throws FederatedItemException
	 * @throws InitiatorNotConfirmedException
	 * @throws OwnerNotFoundException
	 * @throws RemoteInstanceException
	 * @throws RemoteNotFoundException
	 * @throws RemoteResourceNotFoundException
	 * @throws UnknownRemoteException
	 * @throws RequestBuilderException
	 */
	public function syncNextcloudGroup(string $groupId): Circle {
		$circle = $this->federatedUserService->getGroupCircle($groupId);
		$group = $this->groupManager->get($groupId);
		foreach ($group->getUsers() as $user) {
			$member = $this->generateGroupMember($circle, $user->getUID());
			$event = new FederatedEvent(SingleMemberAdd::class);
			$event->setCircle($circle);
			$event->setMember($member);
			$this->federatedEventService->newEvent($event);

//			$this->memberRequest->insertOrUpdate($member);
		}

//		$this->membershipService->onUpdate($circle->getSingleId());

		return $circle;
	}


	/**
	 * @param string $userId
	 *
	 * @throws FederatedUserException
	 * @throws FederatedUserNotFoundException
	 * @throws InvalidIdException
	 * @throws RequestBuilderException
	 * @throws SingleCircleNotFoundException
	 */
	public function userDeleted(string $userId): void {

		$federatedUser = $this->federatedUserService->getLocalFederatedUser($userId);

		// TODO: check existing circle generated by user !
		$this->circleRequest->delete($federatedUser->getBasedOn());
		$this->memberRequest->deleteAllFromCircle($federatedUser->getBasedOn());
		$this->membershipService->onUpdate($federatedUser->getSingleId());
	}


	/**
	 * @param string $groupId
	 *
	 * @throws FederatedUserException
	 * @throws InvalidIdException
	 * @throws RequestBuilderException
	 * @throws SingleCircleNotFoundException
	 */
	public function groupDeleted(string $groupId): void {
		$circle = new Circle();
		$circle->setName('group:' . $groupId)
			   ->setConfig(Circle::CFG_SYSTEM | Circle::CFG_NO_OWNER | Circle::CFG_HIDDEN)
			   ->setSource(Member::TYPE_GROUP);

		$owner = $this->federatedUserService->getAppInitiator(Application::APP_ID, Member::APP_CIRCLES);

		$member = new Member();
		$member->importFromIFederatedUser($owner);
		$member->setLevel(Member::LEVEL_OWNER)
			   ->setStatus(Member::STATUS_MEMBER);
		$circle->setOwner($member);

		try {
			$circle = $this->circleRequest->searchCircle($circle);
		} catch (CircleNotFoundException $e) {
			return;
		}

		$this->circleRequest->delete($circle);
		$this->memberRequest->deleteAllFromCircle($circle);

		$this->membershipService->onUpdate($circle->getSingleId());
	}


	/**
	 * @param Circle $circle
	 * @param string $userId
	 *
	 * @return Member
	 * @throws FederatedUserException
	 * @throws FederatedUserNotFoundException
	 * @throws InvalidIdException
	 * @throws RequestBuilderException
	 * @throws SingleCircleNotFoundException
	 */
	private function generateGroupMember(Circle $circle, string $userId): Member {
		$federatedUser = $this->federatedUserService->getLocalFederatedUser($userId);

		$member = new Member();
		$member->importFromIFederatedUser($federatedUser);
		$member->setId($this->uuid(ManagedModel::ID_LENGTH));
		$member->setCircleId($circle->getSingleId());
		$member->setLevel(Member::LEVEL_MEMBER);
		$member->setStatus(Member::STATUS_MEMBER);

		return $member;
	}


	/**
	 * @param string $groupId
	 * @param string $userId
	 *
	 * @return Member
	 * @throws FederatedEventException
	 * @throws FederatedItemException
	 * @throws FederatedUserException
	 * @throws FederatedUserNotFoundException
	 * @throws GroupNotFoundException
	 * @throws InitiatorNotConfirmedException
	 * @throws InvalidIdException
	 * @throws OwnerNotFoundException
	 * @throws RemoteInstanceException
	 * @throws RemoteNotFoundException
	 * @throws RemoteResourceNotFoundException
	 * @throws RequestBuilderException
	 * @throws SingleCircleNotFoundException
	 * @throws UnknownRemoteException
	 */
	public function groupMemberAdded(string $groupId, string $userId): void {
		$circle = $this->federatedUserService->getGroupCircle($groupId);
		$member = $this->generateGroupMember($circle, $userId);

		$event = new FederatedEvent(SingleMemberAdd::class);
		$event->setCircle($circle);
		$event->setMember($member);
		$this->federatedEventService->newEvent($event);

//		$this->memberRequest->insertOrUpdate($member);

//		$this->membershipService->onUpdate($member->getSingleId());
	}


	/**
	 * @param string $groupId
	 * @param string $userId
	 *
	 * @throws FederatedEventException
	 * @throws FederatedItemException
	 * @throws FederatedUserException
	 * @throws FederatedUserNotFoundException
	 * @throws GroupNotFoundException
	 * @throws InitiatorNotConfirmedException
	 * @throws InvalidIdException
	 * @throws OwnerNotFoundException
	 * @throws RemoteInstanceException
	 * @throws RemoteNotFoundException
	 * @throws RemoteResourceNotFoundException
	 * @throws RequestBuilderException
	 * @throws SingleCircleNotFoundException
	 * @throws UnknownRemoteException
	 */
	public function groupMemberRemoved(string $groupId, string $userId): void {

		$circle = $this->federatedUserService->getGroupCircle($groupId);
		$federatedUser = $this->federatedUserService->getLocalFederatedUser($userId);

		$this->memberRequest->deleteFederatedUserFromCircle($federatedUser, $circle);
		$this->membershipService->onUpdate($federatedUser->getSingleId());
	}


	/**
	 * @return void
	 */
	public function syncContacts(): void {
	}


	/**
	 * @return void
	 */
	public function syncGlobalScale(): void {
	}


	/**
	 * @return void
	 */
	public function syncRemote(): void {
	}


	/**
	 * @param string $circleId
	 *
	 * @return void
	 */
	public function syncRemoteCircle(string $circleId): void {

	}


}



1		<?php
2
3		declare(strict_types=1);
4
5
6		/**
7		* Circles - Bring cloud-users closer together.
8		*
9		* This file is licensed under the Affero General Public License version 3 or
10		* later. See the COPYING file.
11		*
12		* @author Maxence Lange <[email protected]>
13		* @copyright 2021
14		* @license GNU AGPL version 3 or any later version
15		*
16		* This program is free software: you can redistribute it and/or modify
17		* it under the terms of the GNU Affero General Public License as
18		* published by the Free Software Foundation, either version 3 of the
19		* License, or (at your option) any later version.
20		*
21		* This program is distributed in the hope that it will be useful,
22		* but WITHOUT ANY WARRANTY; without even the implied warranty of
23		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
24		* GNU Affero General Public License for more details.
25		*
26		* You should have received a copy of the GNU Affero General Public License
27		* along with this program. If not, see <http://www.gnu.org/licenses/>.
28		*
29		*/
30
31
32		namespace OCA\Circles\Service;
33
34
35		use daita\MySmallPhpTools\Traits\TStringTools;
36		use Exception;
37		use OCA\Circles\AppInfo\Application;
38		use OCA\Circles\Db\CircleRequest;
39		use OCA\Circles\Db\MemberRequest;
40		use OCA\Circles\Exceptions\CircleNotFoundException;
41		use OCA\Circles\Exceptions\FederatedEventException;
42		use OCA\Circles\Exceptions\FederatedItemException;
43		use OCA\Circles\Exceptions\FederatedUserException;
44		use OCA\Circles\Exceptions\FederatedUserNotFoundException;
45		use OCA\Circles\Exceptions\GroupNotFoundException;
46		use OCA\Circles\Exceptions\InitiatorNotConfirmedException;
47		use OCA\Circles\Exceptions\InvalidIdException;
48		use OCA\Circles\Exceptions\MigrationTo22Exception;
49		use OCA\Circles\Exceptions\OwnerNotFoundException;
50		use OCA\Circles\Exceptions\RemoteInstanceException;
51		use OCA\Circles\Exceptions\RemoteNotFoundException;
52		use OCA\Circles\Exceptions\RemoteResourceNotFoundException;
53		use OCA\Circles\Exceptions\RequestBuilderException;
54		use OCA\Circles\Exceptions\SingleCircleNotFoundException;
55		use OCA\Circles\Exceptions\UnknownRemoteException;
56		use OCA\Circles\FederatedItems\SingleMemberAdd;
57		use OCA\Circles\Model\Circle;
58		use OCA\Circles\Model\Federated\FederatedEvent;
59		use OCA\Circles\Model\FederatedUser;
60		use OCA\Circles\Model\ManagedModel;
61		use OCA\Circles\Model\Member;
62		use OCP\IGroupManager;
63		use OCP\IUserManager;
64
65
66		/**
67		* Class SyncService
68		*
69		* @package OCA\Circles\Service
70		*/
71		class SyncService {
72
73
74		use TStringTools;
75
76
77		/** @var IUserManager */
78		private $userManager;
79
80		/** @var IGroupManager */
81		private $groupManager;
82
83		/** @var CircleRequest */
84		private $circleRequest;
85
86		/** @var MemberRequest */
87		private $memberRequest;
88
89		/** @var FederatedUserService */
90		private $federatedUserService;
91
92		/** @var federatedEventService */
93		private $federatedEventService;
94
95		/** @var MemberService */
96		private $memberService;
97
98		/** @var MembershipService */
99		private $membershipService;
100
101		/** @var ConfigService */
102		private $configService;
103
104
105		/**
106		* SyncService constructor.
107		*
108		* @param IUserManager $userManager
109		* @param IGroupManager $groupManager
110		* @param CircleRequest $circleRequest
111		* @param MemberRequest $memberRequest
112		* @param FederatedUserService $federatedUserService
113		* @param federatedEventService $federatedEventService
114		* @param MemberService $memberService
115		* @param MembershipService $membershipService
116		* @param ConfigService $configService
117		*/
118	View Code Duplication	public function __construct(
		0 ignored issues – show Duplication introduced 2021-05-03 12:38 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
119		IUserManager $userManager,
120		IGroupManager $groupManager,
121		CircleRequest $circleRequest,
122		MemberRequest $memberRequest,
123		FederatedUserService $federatedUserService,
124		federatedEventService $federatedEventService,
125		MemberService $memberService,
126		MembershipService $membershipService,
127		ConfigService $configService
128		) {
129		$this->userManager = $userManager;
130		$this->groupManager = $groupManager;
131		$this->circleRequest = $circleRequest;
132		$this->memberRequest = $memberRequest;
133		$this->federatedUserService = $federatedUserService;
134		$this->federatedEventService = $federatedEventService;
135		$this->memberService = $memberService;
136		$this->membershipService = $membershipService;
137		$this->configService = $configService;
138		}
139
140
141		/**
142		* @return bool
143		* @throws MigrationTo22Exception
144		*/
145		public function migration(): bool {
146		if ($this->configService->getAppValueBool(ConfigService::MIGRATION_22)) {
147		return false;
148		}
149
150		$this->migrationTo22();
151		$this->configService->setAppValue(ConfigService::MIGRATION_22, '1');
152
153		return true;
154
155		}
156
157		/**
158		* @return void
159		* @throws MigrationTo22Exception
160		*/
161		private function migrationTo22(): void {
162		throw new MigrationTo22Exception('migration failed');
163		}
164
165
166		/**
167		* @return void
168		*/
169		public function syncAll(): void {
170		$this->syncOcc();
171		$this->syncNextcloudUsers();
172		$this->syncGlobalScale();
173		$this->syncRemote();
174		$this->syncNextcloudGroups();
175		$this->syncContacts();
176		}
177
178
179		/**
180		* @throws FederatedUserException
181		* @throws InvalidIdException
182		* @throws RequestBuilderException
183		* @throws SingleCircleNotFoundException
184		*/
185		public function syncOcc(): void {
186		$this->federatedUserService->getAppInitiator('occ', Member::APP_OCC);
187		}
188
189
190		/**
191		* @return void
192		*/
193		public function syncNextcloudUsers(): void {
194		foreach ($this->userManager->search('') as $user) {
195		try {
196		$this->syncNextcloudUser($user->getUID());
197		} catch (Exception $e) {
		0 ignored issues – show Coding Style Comprehensibility introduced 2021-05-03 12:38 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
198		}
199		}
200		}
201
202		/**
203		* @param string $userId
204		*
205		* @return FederatedUser
206		* @throws FederatedUserException
207		* @throws FederatedUserNotFoundException
208		* @throws InvalidIdException
209		* @throws SingleCircleNotFoundException
210		* @throws RequestBuilderException
211		*/
212		public function syncNextcloudUser(string $userId): FederatedUser {
213		return $this->federatedUserService->getLocalFederatedUser($userId);
214		}
215
216
217		/**
218		* @return void
219		*/
220		public function syncNextcloudGroups(): void {
221		foreach ($this->groupManager->search('') as $group) {
222		try {
223		$this->syncNextcloudGroup($group->getGID());
224		} catch (Exception $e) {
		0 ignored issues – show Coding Style Comprehensibility introduced 2021-05-03 12:38 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
225		}
226		}
227		}
228
229		/**
230		* @param string $groupId
231		*
232		* @return Circle
233		* @throws FederatedUserException
234		* @throws FederatedUserNotFoundException
235		* @throws GroupNotFoundException
236		* @throws InvalidIdException
237		* @throws SingleCircleNotFoundException
238		* @throws FederatedEventException
239		* @throws FederatedItemException
240		* @throws InitiatorNotConfirmedException
241		* @throws OwnerNotFoundException
242		* @throws RemoteInstanceException
243		* @throws RemoteNotFoundException
244		* @throws RemoteResourceNotFoundException
245		* @throws UnknownRemoteException
246		* @throws RequestBuilderException
247		*/
248		public function syncNextcloudGroup(string $groupId): Circle {
249		$circle = $this->federatedUserService->getGroupCircle($groupId);
250		$group = $this->groupManager->get($groupId);
251		foreach ($group->getUsers() as $user) {
252		$member = $this->generateGroupMember($circle, $user->getUID());
253		$event = new FederatedEvent(SingleMemberAdd::class);
254		$event->setCircle($circle);
255		$event->setMember($member);
256		$this->federatedEventService->newEvent($event);
257
258		// $this->memberRequest->insertOrUpdate($member);
259		}
260
261		// $this->membershipService->onUpdate($circle->getSingleId());
262
263		return $circle;
264		}
265
266
267		/**
268		* @param string $userId
269		*
270		* @throws FederatedUserException
271		* @throws FederatedUserNotFoundException
272		* @throws InvalidIdException
273		* @throws RequestBuilderException
274		* @throws SingleCircleNotFoundException
275		*/
276	View Code Duplication	public function userDeleted(string $userId): void {
		0 ignored issues – show Duplication introduced 2021-05-23 17:16 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
277		$federatedUser = $this->federatedUserService->getLocalFederatedUser($userId);
278
279		// TODO: check existing circle generated by user !
280		$this->circleRequest->delete($federatedUser->getBasedOn());
281		$this->memberRequest->deleteAllFromCircle($federatedUser->getBasedOn());
282		$this->membershipService->onUpdate($federatedUser->getSingleId());
283		}
284
285
286		/**
287		* @param string $groupId
288		*
289		* @throws FederatedUserException
290		* @throws InvalidIdException
291		* @throws RequestBuilderException
292		* @throws SingleCircleNotFoundException
293		*/
294		public function groupDeleted(string $groupId): void {
295		$circle = new Circle();
296		$circle->setName('group:' . $groupId)
297		->setConfig(Circle::CFG_SYSTEM \| Circle::CFG_NO_OWNER \| Circle::CFG_HIDDEN)
298		->setSource(Member::TYPE_GROUP);
299
300		$owner = $this->federatedUserService->getAppInitiator(Application::APP_ID, Member::APP_CIRCLES);
301
302		$member = new Member();
303		$member->importFromIFederatedUser($owner);
304		$member->setLevel(Member::LEVEL_OWNER)
305		->setStatus(Member::STATUS_MEMBER);
306		$circle->setOwner($member);
307
308		try {
309		$circle = $this->circleRequest->searchCircle($circle);
310		} catch (CircleNotFoundException $e) {
311		return;
312		}
313
314		$this->circleRequest->delete($circle);
315		$this->memberRequest->deleteAllFromCircle($circle);
316
317		$this->membershipService->onUpdate($circle->getSingleId());
318		}
319
320
321		/**
322		* @param Circle $circle
323		* @param string $userId
324		*
325		* @return Member
326		* @throws FederatedUserException
327		* @throws FederatedUserNotFoundException
328		* @throws InvalidIdException
329		* @throws RequestBuilderException
330		* @throws SingleCircleNotFoundException
331		*/
332		private function generateGroupMember(Circle $circle, string $userId): Member {
333		$federatedUser = $this->federatedUserService->getLocalFederatedUser($userId);
334
335		$member = new Member();
336		$member->importFromIFederatedUser($federatedUser);
337		$member->setId($this->uuid(ManagedModel::ID_LENGTH));
338		$member->setCircleId($circle->getSingleId());
339		$member->setLevel(Member::LEVEL_MEMBER);
340		$member->setStatus(Member::STATUS_MEMBER);
341
342		return $member;
343		}
344
345
346		/**
347		* @param string $groupId
348		* @param string $userId
349		*
350		* @return Member
351		* @throws FederatedEventException
352		* @throws FederatedItemException
353		* @throws FederatedUserException
354		* @throws FederatedUserNotFoundException
355		* @throws GroupNotFoundException
356		* @throws InitiatorNotConfirmedException
357		* @throws InvalidIdException
358		* @throws OwnerNotFoundException
359		* @throws RemoteInstanceException
360		* @throws RemoteNotFoundException
361		* @throws RemoteResourceNotFoundException
362		* @throws RequestBuilderException
363		* @throws SingleCircleNotFoundException
364		* @throws UnknownRemoteException
365		*/
366		public function groupMemberAdded(string $groupId, string $userId): void {
367		$circle = $this->federatedUserService->getGroupCircle($groupId);
368		$member = $this->generateGroupMember($circle, $userId);
369
370		$event = new FederatedEvent(SingleMemberAdd::class);
371		$event->setCircle($circle);
372		$event->setMember($member);
373		$this->federatedEventService->newEvent($event);
374
375		// $this->memberRequest->insertOrUpdate($member);
376
377		// $this->membershipService->onUpdate($member->getSingleId());
378		}
379
380
381		/**
382		* @param string $groupId
383		* @param string $userId
384		*
385		* @throws FederatedEventException
386		* @throws FederatedItemException
387		* @throws FederatedUserException
388		* @throws FederatedUserNotFoundException
389		* @throws GroupNotFoundException
390		* @throws InitiatorNotConfirmedException
391		* @throws InvalidIdException
392		* @throws OwnerNotFoundException
393		* @throws RemoteInstanceException
394		* @throws RemoteNotFoundException
395		* @throws RemoteResourceNotFoundException
396		* @throws RequestBuilderException
397		* @throws SingleCircleNotFoundException
398		* @throws UnknownRemoteException
399		*/
400	View Code Duplication	public function groupMemberRemoved(string $groupId, string $userId): void {
		0 ignored issues – show Duplication introduced 2021-05-23 17:16 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
401		$circle = $this->federatedUserService->getGroupCircle($groupId);
402		$federatedUser = $this->federatedUserService->getLocalFederatedUser($userId);
403
404		$this->memberRequest->deleteFederatedUserFromCircle($federatedUser, $circle);
405		$this->membershipService->onUpdate($federatedUser->getSingleId());
406		}
407
408
409		/**
410		* @return void
411		*/
412		public function syncContacts(): void {
413		}
414
415
416		/**
417		* @return void
418		*/
419		public function syncGlobalScale(): void {
420		}
421
422
423		/**
424		* @return void
425		*/
426		public function syncRemote(): void {
427		}
428
429
430		/**
431		* @param string $circleId
432		*
433		* @return void
434		*/
435		public function syncRemoteCircle(string $circleId): void {
		0 ignored issues – show Unused Code introduced 2021-05-03 12:38 UTC by Report Bug Copy Issue Report The parameter `$circleId` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
436		}
437
438
439		}
440
441

nextcloud / circles

Pull Request — master (#609)

SyncService A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

18 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like