Completed
Pull Request — master (#577)
by Julius
01:50
created
lib/Search/LocalUsers.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -83,7 +83,7 @@
 block discarded – undo
83 83
 
84 84
 
85 85
 	/**
86
-	 * @param $search
86
+	 * @param string $search
87 87
 	 *
88 88
 	 * @return array
89 89
 	 */
Please login to merge, or discard this patch.
lib/Db/CircleProviderRequestBuilder.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -114,7 +114,7 @@
 block discarded – undo
114 114
 	 * limit the request to the children of a share
115 115
 	 *
116 116
 	 * @param IQueryBuilder $qb
117
-	 * @param $userId
117
+	 * @param string $userId
118 118
 	 * @param int $parentId
119 119
 	 */
120 120
 	protected function limitToShareChildren(IQueryBuilder $qb, $userId, $parentId = -1) {
Please login to merge, or discard this patch.
lib/Db/MembersRequest.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -316,7 +316,7 @@  discard block
 block discarded – undo
316 316
 	 * returns the index of a specific UserID in a Members List
317 317
 	 *
318 318
 	 * @param array $members
319
-	 * @param $userId
319
+	 * @param string $userId
320 320
 	 *
321 321
 	 * @return int
322 322
 	 */
@@ -656,6 +656,9 @@  discard block
 block discarded – undo
656 656
 	}
657 657
 
658 658
 
659
+	/**
660
+	 * @param string $groupId
661
+	 */
659 662
 	public function unlinkAllFromGroup($groupId) {
660 663
 		$qb = $this->getMembersDeleteSql();
661 664
 
Please login to merge, or discard this patch.
lib/Service/ConfigService.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -467,7 +467,7 @@
 block discarded – undo
467 467
 	/**
468 468
 	 * @param string $type
469 469
 	 *
470
-	 * @return array|bool|mixed
470
+	 * @return string
471 471
 	 * @throws GSStatusException
472 472
 	 */
473 473
 	public function getGSStatus(string $type = '') {
Please login to merge, or discard this patch.
lib/Service/FederatedLinkCreationService.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -249,8 +249,8 @@  discard block
 block discarded – undo
249 249
 
250 250
 
251 251
 	/**
252
-	 * @param $circleUniqueId
253
-	 * @param $remote
252
+	 * @param string $circleUniqueId
253
+	 * @param string $remote
254 254
 	 *
255 255
 	 * @return FederatedLink
256 256
 	 * @throws Exception
@@ -342,7 +342,7 @@  discard block
 block discarded – undo
342 342
 	 *
343 343
 	 * Will parse the error reason returned by requestLink() and throw an Exception
344 344
 	 *
345
-	 * @param $reason
345
+	 * @param string $reason
346 346
 	 *
347 347
 	 * @throws Exception
348 348
 	 * @throws FederatedRemoteDoesNotAllowException
Please login to merge, or discard this patch.
lib/Service/SharingFrameService.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
175 175
 	 *
176 176
 	 * @param SharingFrame $frame
177 177
 	 * @param Circle $circle
178
-	 * @param $broadcast
178
+	 * @param string|null $broadcast
179 179
 	 */
180 180
 	private function generateHeaders(SharingFrame $frame, Circle $circle, $broadcast) {
181 181
 
@@ -214,7 +214,7 @@  discard block
 block discarded – undo
214 214
 	 * Please use getFrameFromCircle();
215 215
 	 *
216 216
 	 * @param string $circleUniqueId
217
-	 * @param $viewerId
217
+	 * @param string $viewerId
218 218
 	 *
219 219
 	 * @return SharingFrame[]
220 220
 	 * @throws CircleDoesNotExistException
Please login to merge, or discard this patch.
lib/Service/MembersService.php 1 patch
Doc Comments   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -331,8 +331,8 @@  discard block
 block discarded – undo
331 331
 	/**
332 332
 	 * Verify if a local account is valid.
333 333
 	 *
334
-	 * @param $ident
335
-	 * @param $type
334
+	 * @param string $ident
335
+	 * @param integer $type
336 336
 	 *
337 337
 	 * @param string $instance
338 338
 	 *
@@ -383,8 +383,8 @@  discard block
 block discarded – undo
383 383
 	/**
384 384
 	 * Verify if a contact exist in current user address books.
385 385
 	 *
386
-	 * @param $ident
387
-	 * @param $type
386
+	 * @param string $ident
387
+	 * @param integer $type
388 388
 	 *
389 389
 	 * @throws NoUserException
390 390
 	 * @throws EmailAccountInvalidFormatException
@@ -476,8 +476,8 @@  discard block
 block discarded – undo
476 476
 	 * Will return any data of a user related to a circle (as a Member). User can be a 'non-member'
477 477
 	 * Viewer needs to be at least Member of the Circle
478 478
 	 *
479
-	 * @param $circleId
480
-	 * @param $userId
479
+	 * @param string $circleId
480
+	 * @param string $userId
481 481
 	 * @param $type
482 482
 	 * @param bool $forceAll
483 483
 	 *
@@ -533,7 +533,7 @@  discard block
 block discarded – undo
533 533
 	 * @param int $level
534 534
 	 * @param bool $force
535 535
 	 *
536
-	 * @return array
536
+	 * @return Member[]
537 537
 	 * @throws CircleDoesNotExistException
538 538
 	 * @throws CircleTypeNotValidException
539 539
 	 * @throws ConfigNoCircleAvailableException
Please login to merge, or discard this patch.
lib/Circles/FileSharingBroadcaster.php 1 patch
Doc Comments   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -427,7 +427,7 @@  discard block
 block discarded – undo
427 427
 	 * @param $fileName
428 428
 	 * @param string $link
429 429
 	 * @param string $author
430
-	 * @param $circleName
430
+	 * @param string $circleName
431 431
 	 * @param string $email
432 432
 	 *
433 433
 	 * @throws Exception
@@ -464,7 +464,7 @@  discard block
 block discarded – undo
464 464
 	 * @param string $circleName
465 465
 	 * @param string $email
466 466
 	 *
467
-	 * @param $password
467
+	 * @param string $password
468 468
 	 *
469 469
 	 * @throws NotFoundException
470 470
 	 * @throws Exception
@@ -546,7 +546,7 @@  discard block
 block discarded – undo
546 546
 	 * @param $subject
547 547
 	 * @param $text
548 548
 	 * @param $fileName
549
-	 * @param $link
549
+	 * @param string $link
550 550
 	 * @param string $author
551 551
 	 * @param string $circleName
552 552
 	 *
@@ -714,7 +714,7 @@  discard block
 block discarded – undo
714 714
 
715 715
 
716 716
 	/**
717
-	 * @param $author
717
+	 * @param string $author
718 718
 	 * @param string $circleName
719 719
 	 *
720 720
 	 * @return IEMailTemplate
@@ -757,8 +757,8 @@  discard block
 block discarded – undo
757 757
 
758 758
 	/**
759 759
 	 * @param IEMailTemplate $emailTemplate
760
-	 * @param $author
761
-	 * @param $recipient
760
+	 * @param string $author
761
+	 * @param string $recipient
762 762
 	 *
763 763
 	 * @throws Exception
764 764
 	 */
Please login to merge, or discard this patch.
lib/Service/MiscService.php 1 patch
Doc Comments   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
 
79 79
 	/**
80 80
 	 * @param $arr
81
-	 * @param $k
81
+	 * @param string $k
82 82
 	 *
83 83
 	 * @param string $default
84 84
 	 *
@@ -93,6 +93,9 @@  discard block
 block discarded – undo
93 93
 	}
94 94
 
95 95
 
96
+	/**
97
+	 * @param string[] $arr
98
+	 */
96 99
 	public static function mustContains($data, $arr) {
97 100
 		if (!is_array($arr)) {
98 101
 			$arr = [$arr];
@@ -250,7 +253,7 @@  discard block
 block discarded – undo
250 253
 
251 254
 
252 255
 	/**
253
-	 * @param $ident
256
+	 * @param string $ident
254 257
 	 *
255 258
 	 * @return mixed|string
256 259
 	 * @deprecated
Please login to merge, or discard this patch.