Completed
Push — master ( 98fb41...18d3f8 )
by Maxence
02:48 queued 10s
created
lib/Service/CircleService.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -489,7 +489,7 @@  discard block
 block discarded – undo
489 489
 
490 490
 		$i = 1;
491 491
 		while (true) {
492
-			$testDisplayName = $baseDisplayName . (($i > 1) ? ' (' . $i . ')' : '');
492
+			$testDisplayName = $baseDisplayName.(($i > 1) ? ' ('.$i.')' : '');
493 493
 			$test = new Circle();
494 494
 			$test->setDisplayName($testDisplayName);
495 495
 
@@ -522,7 +522,7 @@  discard block
 block discarded – undo
522 522
 
523 523
 		$i = 1;
524 524
 		while (true) {
525
-			$testSanitizedName = $baseSanitizedName . (($i > 1) ? '-' . $i : '');
525
+			$testSanitizedName = $baseSanitizedName.(($i > 1) ? '-'.$i : '');
526 526
 
527 527
 			$test = new Circle();
528 528
 			$test->setSanitizedName($testSanitizedName);
Please login to merge, or discard this patch.
lib/Listeners/Examples/AddingExampleCircleMember.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -96,13 +96,13 @@  discard block
 block discarded – undo
96 96
 			$circle = $event->getCircle();
97 97
 			$eventType = ($event->getType() === CircleGenericEvent::INVITED) ? 'invited' : 'joined';
98 98
 
99
-			$info = 'A new member have been added (' . $eventType . ') to a Circle. ';
99
+			$info = 'A new member have been added ('.$eventType.') to a Circle. ';
100 100
 
101
-			$info .= 'userId: ' . $member->getUserId() . '; userType: ' . Member::$TYPE[$member->getUserType(
101
+			$info .= 'userId: '.$member->getUserId().'; userType: '.Member::$TYPE[$member->getUserType(
102 102
 				)]
103
-					 . '; singleId: ' . $member->getSingleId() . '; memberId: ' . $member->getId()
104
-					 . '; isLocal: ' . json_encode($member->isLocal()) . '; level: '
105
-					 . Member::$DEF_LEVEL[$member->getLevel()] . '; ';
103
+					 . '; singleId: '.$member->getSingleId().'; memberId: '.$member->getId()
104
+					 . '; isLocal: '.json_encode($member->isLocal()).'; level: '
105
+					 . Member::$DEF_LEVEL[$member->getLevel()].'; ';
106 106
 
107 107
 			$memberships = array_map(
108 108
 				function(Membership $membership) {
@@ -111,22 +111,22 @@  discard block
 block discarded – undo
111 111
 			);
112 112
 
113 113
 			$listMemberships = (count($memberships) > 0) ? implode(', ', $memberships) : 'none';
114
-			$info .= 'circleName: ' . $circle->getDisplayName() . '; circleId: ' . $circle->getSingleId()
115
-					 . '; Circle memberships: ' . $listMemberships . '.';
114
+			$info .= 'circleName: '.$circle->getDisplayName().'; circleId: '.$circle->getSingleId()
115
+					 . '; Circle memberships: '.$listMemberships.'.';
116 116
 
117 117
 			if ($member->getUserType() === Member::TYPE_CIRCLE) {
118 118
 				$basedOn = $member->getBasedOn();
119 119
 				$members = array_map(
120 120
 					function(Member $member) {
121
-						return $member->getUserId() . ' (' . Member::$TYPE[$member->getUserType()] . ')';
121
+						return $member->getUserId().' ('.Member::$TYPE[$member->getUserType()].')';
122 122
 					}, $basedOn->getInheritedMembers()
123 123
 				);
124 124
 
125
-				$info .= ' Member is a Circle (singleId: ' . $basedOn->getSingleId()
126
-						 . ') that contains those inherited members: ' . implode(', ', $members);
125
+				$info .= ' Member is a Circle (singleId: '.$basedOn->getSingleId()
126
+						 . ') that contains those inherited members: '.implode(', ', $members);
127 127
 			}
128 128
 
129
-			$this->log(3, $prefix . $info);
129
+			$this->log(3, $prefix.$info);
130 130
 		}
131 131
 	}
132 132
 
Please login to merge, or discard this patch.
lib/Service/MaintenanceService.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -169,7 +169,7 @@
 block discarded – undo
169 169
 	 */
170 170
 	private function output(string $message): void {
171 171
 		if (!is_null($this->output)) {
172
-			$this->output->writeln('- ' . $message);
172
+			$this->output->writeln('- '.$message);
173 173
 		}
174 174
 	}
175 175
 
Please login to merge, or discard this patch.
lib/Model/FederatedUser.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -400,15 +400,15 @@
 block discarded – undo
400 400
 	 * @throws FederatedUserNotFoundException
401 401
 	 */
402 402
 	public function importFromDatabase(array $data, string $prefix = ''): INC22QueryRow {
403
-		if ($this->get($prefix . 'single_id', $data) === '') {
403
+		if ($this->get($prefix.'single_id', $data) === '') {
404 404
 			throw new FederatedUserNotFoundException();
405 405
 		}
406 406
 
407
-		$this->setSingleId($this->get($prefix . 'single_id', $data));
408
-		$this->setUserId($this->get($prefix . 'user_id', $data));
409
-		$this->setUserType($this->getInt($prefix . 'user_type', $data));
410
-		$this->setDisplayName($this->get($prefix . 'cached_name', $data));
411
-		$this->setInstance($this->get($prefix . 'instance', $data));
407
+		$this->setSingleId($this->get($prefix.'single_id', $data));
408
+		$this->setUserId($this->get($prefix.'user_id', $data));
409
+		$this->setUserType($this->getInt($prefix.'user_type', $data));
410
+		$this->setDisplayName($this->get($prefix.'cached_name', $data));
411
+		$this->setInstance($this->get($prefix.'instance', $data));
412 412
 
413 413
 		$this->getManager()->manageImportFromDatabase($this, $data, $prefix);
414 414
 
Please login to merge, or discard this patch.
lib/Model/Federated/RemoteInstance.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -50,11 +50,11 @@  discard block
 block discarded – undo
50 50
 
51 51
 	use TArrayTools;
52 52
 
53
-	const TYPE_UNKNOWN = 'Unknown';    // not trusted
54
-	const TYPE_PASSIVE = 'Passive';    // Minimum information about Federated Circles are broadcasted if a member belongs to the circle.
55
-	const TYPE_EXTERNAL = 'External';  // info about Federated Circles and their members are broadcasted  if a member belongs to the circle.
56
-	const TYPE_TRUSTED = 'Trusted';    // everything about Federated Circles are broadcasted.
57
-	const TYPE_GLOBALSCALE = 'GlobalScale';  // every Circle is broadcasted,
53
+	const TYPE_UNKNOWN = 'Unknown'; // not trusted
54
+	const TYPE_PASSIVE = 'Passive'; // Minimum information about Federated Circles are broadcasted if a member belongs to the circle.
55
+	const TYPE_EXTERNAL = 'External'; // info about Federated Circles and their members are broadcasted  if a member belongs to the circle.
56
+	const TYPE_TRUSTED = 'Trusted'; // everything about Federated Circles are broadcasted.
57
+	const TYPE_GLOBALSCALE = 'GlobalScale'; // every Circle is broadcasted,
58 58
 
59 59
 	public static $LIST_TYPE = [
60 60
 		self::TYPE_UNKNOWN,
@@ -477,7 +477,7 @@  discard block
 block discarded – undo
477 477
 		];
478 478
 
479 479
 		if ($this->getAuthSigned() !== '') {
480
-			$data['auth-signed'] = $this->getAlgorithm() . ':' . $this->getAuthSigned();
480
+			$data['auth-signed'] = $this->getAlgorithm().':'.$this->getAuthSigned();
481 481
 		}
482 482
 
483 483
 		if (!empty($this->getAliases())) {
@@ -496,17 +496,17 @@  discard block
 block discarded – undo
496 496
 	 * @throws RemoteNotFoundException
497 497
 	 */
498 498
 	public function importFromDatabase(array $data, string $prefix = ''): INC22QueryRow {
499
-		if ($this->getInt($prefix . 'id', $data) === 0) {
499
+		if ($this->getInt($prefix.'id', $data) === 0) {
500 500
 			throw new RemoteNotFoundException();
501 501
 		}
502 502
 
503
-		$this->setDbId($this->getInt($prefix . 'id', $data));
504
-		$this->import($this->getArray($prefix . 'item', $data));
505
-		$this->setOrigData($this->getArray($prefix . 'item', $data));
506
-		$this->setType($this->get($prefix . 'type', $data));
507
-		$this->setInterface($this->getInt($prefix . 'interface', $data));
508
-		$this->setInstance($this->get($prefix . 'instance', $data));
509
-		$this->setId($this->get($prefix . 'href', $data));
503
+		$this->setDbId($this->getInt($prefix.'id', $data));
504
+		$this->import($this->getArray($prefix.'item', $data));
505
+		$this->setOrigData($this->getArray($prefix.'item', $data));
506
+		$this->setType($this->get($prefix.'type', $data));
507
+		$this->setInterface($this->getInt($prefix.'interface', $data));
508
+		$this->setInstance($this->get($prefix.'instance', $data));
509
+		$this->setId($this->get($prefix.'href', $data));
510 510
 
511 511
 		return $this;
512 512
 	}
Please login to merge, or discard this patch.
lib/Service/FederatedUserService.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -394,7 +394,7 @@  discard block
 block discarded – undo
394 394
 		if ($check) {
395 395
 			$user = $this->userManager->get($userId);
396 396
 			if ($user === null) {
397
-				throw new FederatedUserNotFoundException('user ' . $userId . ' not found');
397
+				throw new FederatedUserNotFoundException('user '.$userId.' not found');
398 398
 			}
399 399
 			$userId = $user->getUID();
400 400
 			$displayName = $user->getDisplayName();
@@ -852,7 +852,7 @@  discard block
 block discarded – undo
852 852
 			$prefix = ($federatedUser->getUserType() === Member::TYPE_APP) ? 'app'
853 853
 				: Member::$TYPE[$federatedUser->getUserType()];
854 854
 
855
-			$circle->setName($prefix . ':' . $federatedUser->getUserId() . ':' . $id)
855
+			$circle->setName($prefix.':'.$federatedUser->getUserId().':'.$id)
856 856
 				   ->setDisplayName($federatedUser->getDisplayName())
857 857
 				   ->setSingleId($id)
858 858
 				   ->setSource($source);
@@ -976,7 +976,7 @@  discard block
 block discarded – undo
976 976
 		$owner = $this->getCurrentApp();
977 977
 
978 978
 		$circle = new Circle();
979
-		$circle->setName('group:' . $groupId)
979
+		$circle->setName('group:'.$groupId)
980 980
 			   ->setConfig(Circle::CFG_SYSTEM | Circle::CFG_NO_OWNER | Circle::CFG_HIDDEN)
981 981
 			   ->setSingleId($this->token(ManagedModel::ID_LENGTH))
982 982
 			   ->setSource(Member::TYPE_GROUP);
Please login to merge, or discard this patch.
lib/FederatedItems/SingleMemberAdd.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -336,11 +336,11 @@  discard block
 block discarded – undo
336 336
 	protected function generateMember(FederatedEvent $event, Circle $circle, Member $member): Member {
337 337
 		try {
338 338
 			if ($member->getSingleId() !== '') {
339
-				$userId = $member->getSingleId() . '@' . $member->getInstance();
339
+				$userId = $member->getSingleId().'@'.$member->getInstance();
340 340
 				$federatedUser = $this->federatedUserService->getFederatedUser($userId, Member::TYPE_SINGLE);
341 341
 
342 342
 			} else {
343
-				$userId = $member->getUserId() . '@' . $member->getInstance();
343
+				$userId = $member->getUserId().'@'.$member->getInstance();
344 344
 				$federatedUser = $this->federatedUserService->getFederatedUser(
345 345
 					$userId,
346 346
 					$member->getUserType()
@@ -642,7 +642,7 @@  discard block
 block discarded – undo
642 642
 			$this->sendMailExistingShares($template, $author, $recipient);
643 643
 			$this->sendPasswordExistingShares($author, $recipient, $password);
644 644
 		} catch (Exception $e) {
645
-			$this->miscService->log('Failed to send mail about existing share ' . $e->getMessage());
645
+			$this->miscService->log('Failed to send mail about existing share '.$e->getMessage());
646 646
 		}
647 647
 	}
648 648
 
@@ -794,7 +794,7 @@  discard block
 block discarded – undo
794 794
 		$authorName = ($authorUser instanceof IUser) ? $authorUser->getDisplayName() : $author;
795 795
 		$authorEmail = ($authorUser instanceof IUser) ? $authorUser->getEMailAddress() : null;
796 796
 
797
-		$this->miscService->log("Sending password mail about existing files to '" . $email . "'", 0);
797
+		$this->miscService->log("Sending password mail about existing files to '".$email."'", 0);
798 798
 
799 799
 		$plainBodyPart = $this->l10n->t(
800 800
 			"%1\$s shared multiple files with you.\nYou should have already received a separate email with a link to access them.\n",
@@ -836,7 +836,7 @@  discard block
 block discarded – undo
836 836
 		$message->setFrom([\OCP\Util::getDefaultEmailAddress($instanceName) => $senderName]);
837 837
 		if ($authorEmail !== null) {
838 838
 			$message->setReplyTo([$authorEmail => $authorName]);
839
-			$emailTemplate->addFooter($instanceName . ' - ' . $this->defaults->getSlogan());
839
+			$emailTemplate->addFooter($instanceName.' - '.$this->defaults->getSlogan());
840 840
 		} else {
841 841
 			$emailTemplate->addFooter();
842 842
 		}
Please login to merge, or discard this patch.
lib/Command/CirclesMaintenance.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
 				'<error>WARNING! You are about to delete all data related to the Circles App!</error>'
109 109
 			);
110 110
 			$question = new ConfirmationQuestion(
111
-				'<comment>Do you really want to ' . $action . ' Circles ?</comment> (y/N) ', false, '/^(y|Y)/i'
111
+				'<comment>Do you really want to '.$action.' Circles ?</comment> (y/N) ', false, '/^(y|Y)/i'
112 112
 			);
113 113
 
114 114
 			$helper = $this->getHelper('question');
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
 
124 124
 
125 125
 			$question = new Question(
126
-				'<comment>Please confirm this destructive operation by typing \'' . $action
126
+				'<comment>Please confirm this destructive operation by typing \''.$action
127 127
 				. '\'</comment>: ', ''
128 128
 			);
129 129
 
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
140 140
 				$this->coreQueryBuilder->uninstall();
141 141
 			}
142 142
 
143
-			$output->writeln('<info>' . $action . ' done</info>');
143
+			$output->writeln('<info>'.$action.' done</info>');
144 144
 
145 145
 			return 0;
146 146
 		}
Please login to merge, or discard this patch.