RemoteRequest - Code Metrics - Inspection of "Merge remote-tracking branch 'origin/master'" - nextcloud/circles - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 98fb41...18d3f8 )

by Maxence

created 2021-06-13 12:54 UTC

RemoteRequest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	246
Duplicated Lines	14.63 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

Metric	Value
wmc	16
lcom	1
cbo	4
dl	36
loc	246
rs	10
c	0
b	0
f	0

14 Methods

Rating	Name	Duplication	Size	Complexity
A	update()	0	12	1
A	save()	0	12	1
A	updateItem()	9	9	1
A	updateInstance()	9	9	1
A	updateType()	9	9	1
A	updateHref()	9	9	1
A	getAllInstances()	0	5	1
A	getKnownInstances()	0	6	1
A	getOutgoingRecipient()	0	37	3
A	getFromInstance()	0	6	1
A	getFromHref()	0	6	1
A	getFromType()	0	6	1
A	searchDuplicate()	0	10	1
A	deleteById()	0	5	1

How to fix Duplicated Code

<?php

declare(strict_types=1);


/**
 * Circles - Bring cloud-users closer together.
 *
 * This file is licensed under the Affero General Public License version 3 or
 * later. See the COPYING file.
 *
 * @author Maxence Lange <[email protected]>
 * @copyright 2021
 * @license GNU AGPL version 3 or any later version
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as
 * published by the Free Software Foundation, either version 3 of the
 * License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 */


namespace OCA\Circles\Db;


use OCA\Circles\Exceptions\RemoteNotFoundException;
use OCA\Circles\Exceptions\RemoteUidException;
use OCA\Circles\Exceptions\RequestBuilderException;
use OCA\Circles\Model\Circle;
use OCA\Circles\Model\Federated\RemoteInstance;
use OCA\Circles\Model\Member;
use OCP\DB\QueryBuilder\IQueryBuilder;


/**
 * Class RemoteRequest
 *
 * @package OCA\Circles\Db
 */
class RemoteRequest extends RemoteRequestBuilder {


	/**
	 * @param RemoteInstance $remote
	 *
	 * @throws RemoteUidException
	 */
	public function save(RemoteInstance $remote): void {
		$remote->mustBeIdentityAuthed();
		$qb = $this->getRemoteInsertSql();
		$qb->setValue('uid', $qb->createNamedParameter($remote->getUid(true)))
		   ->setValue('instance', $qb->createNamedParameter($remote->getInstance()))
		   ->setValue('href', $qb->createNamedParameter($remote->getId()))
		   ->setValue('type', $qb->createNamedParameter($remote->getType()))
		   ->setValue('interface', $qb->createNamedParameter($remote->getInterface()))
		   ->setValue('item', $qb->createNamedParameter(json_encode($remote->getOrigData())));

		$qb->execute();
	}


	/**
	 * @param RemoteInstance $remote
	 *
	 * @throws RemoteUidException
	 */
	public function update(RemoteInstance $remote) {
		$remote->mustBeIdentityAuthed();
		$qb = $this->getRemoteUpdateSql();
		$qb->set('uid', $qb->createNamedParameter($remote->getUid(true)))
		   ->set('href', $qb->createNamedParameter($remote->getId()))
		   ->set('type', $qb->createNamedParameter($remote->getType()))
		   ->set('item', $qb->createNamedParameter(json_encode($remote->getOrigData())));

		$qb->limitToInstance($remote->getInstance());

		$qb->execute();
	}


	/**
	 * @param RemoteInstance $remote
	 *
	 * @throws RemoteUidException
	 */
	public function updateItem(RemoteInstance $remote) {

		$remote->mustBeIdentityAuthed();
		$qb = $this->getRemoteUpdateSql();
		$qb->set('item', $qb->createNamedParameter(json_encode($remote->getOrigData())));

		$qb->limitToDBField('uid', $remote->getUid(true), false);


		$qb->execute();
	}


	/**
	 * @param RemoteInstance $remote
	 *
	 * @throws RemoteUidException
	 */
	public function updateInstance(RemoteInstance $remote) {

		$remote->mustBeIdentityAuthed();
		$qb = $this->getRemoteUpdateSql();
		$qb->set('instance', $qb->createNamedParameter($remote->getInstance()));

		$qb->limitToDBField('uid', $remote->getUid(true), false);


		$qb->execute();
	}


	/**
	 * @param RemoteInstance $remote
	 *
	 * @throws RemoteUidException
	 */
	public function updateType(RemoteInstance $remote) {

		$remote->mustBeIdentityAuthed();
		$qb = $this->getRemoteUpdateSql();
		$qb->set('type', $qb->createNamedParameter($remote->getType()));

		$qb->limitToDBField('uid', $remote->getUid(true), false);


		$qb->execute();
	}


	/**
	 * @param RemoteInstance $remote
	 *
	 * @throws RemoteUidException
	 */
	public function updateHref(RemoteInstance $remote) {

		$remote->mustBeIdentityAuthed();
		$qb = $this->getRemoteUpdateSql();
		$qb->set('href', $qb->createNamedParameter($remote->getId()));

		$qb->limitToDBField('uid', $remote->getUid(true), false);


		$qb->execute();
	}


	/**
	 * @return RemoteInstance[]
	 */
	public function getAllInstances(): array {
		$qb = $this->getRemoteSelectSql();

		return $this->getItemsFromRequest($qb);
	}

	/**
	 * @return RemoteInstance[]
	 */
	public function getKnownInstances(): array {
		$qb = $this->getRemoteSelectSql();
		$qb->filterDBField('type', RemoteInstance::TYPE_UNKNOWN, false);


		return $this->getItemsFromRequest($qb);
	}


	/**
	 * - returns:
	 * - all GLOBAL_SCALE
	 * - TRUSTED if Circle is Federated
	 * - EXTERNAL if Circle is Federated and a contains a member from instance
	 *
	 * @param Circle $circle
	 * @param bool $broadcastAsFederated
	 *
	 * @return RemoteInstance[]
	 * @throws RequestBuilderException
	 */
	public function getOutgoingRecipient(Circle $circle, bool $broadcastAsFederated = false): array {
		$qb = $this->getRemoteSelectSql();
		$expr = $qb->expr();
		$orX = $expr->orX();

		$orX->add($qb->exprLimitToDBField('type', RemoteInstance::TYPE_GLOBALSCALE, true, false));


		if ($circle->isConfig(Circle::CFG_FEDERATED) || $broadcastAsFederated) {

			// get all TRUSTED
			$orX->add($qb->exprLimitToDBField('type', RemoteInstance::TYPE_TRUSTED, true, false));


			// get EXTERNAL with Members
			$aliasMember = $qb->generateAlias(CoreQueryBuilder::REMOTE, CoreQueryBuilder::MEMBER);
			$qb->leftJoin(
				CoreQueryBuilder::REMOTE, self::TABLE_MEMBER, $aliasMember,
				$expr->andX(
					$expr->eq($aliasMember . '.circle_id', $qb->createNamedParameter($circle->getSingleId())),
					$expr->eq($aliasMember . '.instance', CoreQueryBuilder::REMOTE . '.instance'),
					$expr->gte(
						$aliasMember . '.level',
						$qb->createNamedParameter(Member::LEVEL_MEMBER, IQueryBuilder::PARAM_INT)
					)
				)
			);

			$external = $expr->andX();
			$external->add($qb->exprLimitToDBField('type', RemoteInstance::TYPE_EXTERNAL, true, false));

			$external->add($expr->isNotNull($aliasMember . '.instance'));
			$orX->add($external);
		}

		$qb->andWhere($orX)
		   ->generateGroupBy(self::$tables[self::TABLE_REMOTE], CoreQueryBuilder::REMOTE);


		return $this->getItemsFromRequest($qb);
	}


	/**
	 * @param string $host
	 *
	 * @return RemoteInstance
	 * @throws RemoteNotFoundException
	 */
	public function getFromInstance(string $host): RemoteInstance {
		$qb = $this->getRemoteSelectSql();
		$qb->limitToInstance($host);

		return $this->getItemFromRequest($qb);
	}


	/**
	 * @param string $href
	 *
	 * @return RemoteInstance
	 * @throws RemoteNotFoundException
	 */
	public function getFromHref(string $href): RemoteInstance {
		$qb = $this->getRemoteSelectSql();
		$qb->limitToDBField('href', $href, false);


		return $this->getItemFromRequest($qb);
	}


	/**
	 * @param string $status
	 *
	 * @return RemoteInstance[]
	 */
	public function getFromType(string $status): array {
		$qb = $this->getRemoteSelectSql();
		$qb->limitToTypeString($status);

		return $this->getItemsFromRequest($qb);
	}


	/**
	 * @param RemoteInstance $remoteInstance
	 *
	 * @return RemoteInstance
	 * @throws RemoteNotFoundException
	 */
	public function searchDuplicate(RemoteInstance $remoteInstance) {
		$qb = $this->getRemoteSelectSql();
		$orX = $qb->expr()->orX();
		$orX->add($qb->exprLimitToDBField('href', $remoteInstance->getId(), true, false));

		$orX->add($qb->exprLimitToDBField('uid', $remoteInstance->getUid(true), true));

		$orX->add($qb->exprLimitToDBField('instance', $remoteInstance->getInstance(), true, false));

		$qb->andWhere($orX);

		return $this->getItemFromRequest($qb);
	}


	/**
	 * @param RemoteInstance $remoteInstance
	 */
	public function deleteById(RemoteInstance $remoteInstance) {
		$qb = $this->getRemoteDeleteSql();
		$qb->limitToId($remoteInstance->getDbId());
		$qb->execute();
	}


}



1		<?php
2
3		declare(strict_types=1);
4
5
6		/**
7		* Circles - Bring cloud-users closer together.
8		*
9		* This file is licensed under the Affero General Public License version 3 or
10		* later. See the COPYING file.
11		*
12		* @author Maxence Lange <[email protected]>
13		* @copyright 2021
14		* @license GNU AGPL version 3 or any later version
15		*
16		* This program is free software: you can redistribute it and/or modify
17		* it under the terms of the GNU Affero General Public License as
18		* published by the Free Software Foundation, either version 3 of the
19		* License, or (at your option) any later version.
20		*
21		* This program is distributed in the hope that it will be useful,
22		* but WITHOUT ANY WARRANTY; without even the implied warranty of
23		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
24		* GNU Affero General Public License for more details.
25		*
26		* You should have received a copy of the GNU Affero General Public License
27		* along with this program. If not, see <http://www.gnu.org/licenses/>.
28		*
29		*/
30
31
32		namespace OCA\Circles\Db;
33
34
35		use OCA\Circles\Exceptions\RemoteNotFoundException;
36		use OCA\Circles\Exceptions\RemoteUidException;
37		use OCA\Circles\Exceptions\RequestBuilderException;
38		use OCA\Circles\Model\Circle;
39		use OCA\Circles\Model\Federated\RemoteInstance;
40		use OCA\Circles\Model\Member;
41		use OCP\DB\QueryBuilder\IQueryBuilder;
42
43
44		/**
45		* Class RemoteRequest
46		*
47		* @package OCA\Circles\Db
48		*/
49		class RemoteRequest extends RemoteRequestBuilder {
50
51
52		/**
53		* @param RemoteInstance $remote
54		*
55		* @throws RemoteUidException
56		*/
57		public function save(RemoteInstance $remote): void {
58		$remote->mustBeIdentityAuthed();
59		$qb = $this->getRemoteInsertSql();
60		$qb->setValue('uid', $qb->createNamedParameter($remote->getUid(true)))
61		->setValue('instance', $qb->createNamedParameter($remote->getInstance()))
62		->setValue('href', $qb->createNamedParameter($remote->getId()))
63		->setValue('type', $qb->createNamedParameter($remote->getType()))
64		->setValue('interface', $qb->createNamedParameter($remote->getInterface()))
65		->setValue('item', $qb->createNamedParameter(json_encode($remote->getOrigData())));
66
67		$qb->execute();
68		}
69
70
71		/**
72		* @param RemoteInstance $remote
73		*
74		* @throws RemoteUidException
75		*/
76		public function update(RemoteInstance $remote) {
77		$remote->mustBeIdentityAuthed();
78		$qb = $this->getRemoteUpdateSql();
79		$qb->set('uid', $qb->createNamedParameter($remote->getUid(true)))
80		->set('href', $qb->createNamedParameter($remote->getId()))
81		->set('type', $qb->createNamedParameter($remote->getType()))
82		->set('item', $qb->createNamedParameter(json_encode($remote->getOrigData())));
83
84		$qb->limitToInstance($remote->getInstance());
85
86		$qb->execute();
87		}
88
89
90		/**
91		* @param RemoteInstance $remote
92		*
93		* @throws RemoteUidException
94		*/
95	View Code Duplication	public function updateItem(RemoteInstance $remote) {
		0 ignored issues – show Duplication introduced 2021-01-13 22:58 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
96		$remote->mustBeIdentityAuthed();
97		$qb = $this->getRemoteUpdateSql();
98		$qb->set('item', $qb->createNamedParameter(json_encode($remote->getOrigData())));
99
100		$qb->limitToDBField('uid', $remote->getUid(true), false);
		0 ignored issues – show Deprecated Code introduced 2021-05-24 13:55 UTC by Report Bug Copy Issue Report The method `daita\MySmallPhpTools\Db...ilder::limitToDBField()` has been deprecated with message: - use limit(); This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
101
102		$qb->execute();
103		}
104
105
106		/**
107		* @param RemoteInstance $remote
108		*
109		* @throws RemoteUidException
110		*/
111	View Code Duplication	public function updateInstance(RemoteInstance $remote) {
		0 ignored issues – show Duplication introduced 2021-01-13 22:58 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
112		$remote->mustBeIdentityAuthed();
113		$qb = $this->getRemoteUpdateSql();
114		$qb->set('instance', $qb->createNamedParameter($remote->getInstance()));
115
116		$qb->limitToDBField('uid', $remote->getUid(true), false);
		0 ignored issues – show Deprecated Code introduced 2021-05-24 13:55 UTC by Report Bug Copy Issue Report The method `daita\MySmallPhpTools\Db...ilder::limitToDBField()` has been deprecated with message: - use limit(); This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
117
118		$qb->execute();
119		}
120
121
122		/**
123		* @param RemoteInstance $remote
124		*
125		* @throws RemoteUidException
126		*/
127	View Code Duplication	public function updateType(RemoteInstance $remote) {
		0 ignored issues – show Duplication introduced 2021-01-13 22:58 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
128		$remote->mustBeIdentityAuthed();
129		$qb = $this->getRemoteUpdateSql();
130		$qb->set('type', $qb->createNamedParameter($remote->getType()));
131
132		$qb->limitToDBField('uid', $remote->getUid(true), false);
		0 ignored issues – show Deprecated Code introduced 2021-05-24 13:55 UTC by Report Bug Copy Issue Report The method `daita\MySmallPhpTools\Db...ilder::limitToDBField()` has been deprecated with message: - use limit(); This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
133
134		$qb->execute();
135		}
136
137
138		/**
139		* @param RemoteInstance $remote
140		*
141		* @throws RemoteUidException
142		*/
143	View Code Duplication	public function updateHref(RemoteInstance $remote) {
		0 ignored issues – show Duplication introduced 2021-05-03 12:38 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
144		$remote->mustBeIdentityAuthed();
145		$qb = $this->getRemoteUpdateSql();
146		$qb->set('href', $qb->createNamedParameter($remote->getId()));
147
148		$qb->limitToDBField('uid', $remote->getUid(true), false);
		0 ignored issues – show Deprecated Code introduced 2021-05-24 13:55 UTC by Report Bug Copy Issue Report The method `daita\MySmallPhpTools\Db...ilder::limitToDBField()` has been deprecated with message: - use limit(); This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
149
150		$qb->execute();
151		}
152
153
154		/**
155		* @return RemoteInstance[]
156		*/
157		public function getAllInstances(): array {
158		$qb = $this->getRemoteSelectSql();
159
160		return $this->getItemsFromRequest($qb);
161		}
162
163		/**
164		* @return RemoteInstance[]
165		*/
166		public function getKnownInstances(): array {
167		$qb = $this->getRemoteSelectSql();
168		$qb->filterDBField('type', RemoteInstance::TYPE_UNKNOWN, false);
		0 ignored issues – show Deprecated Code introduced 2021-05-24 13:55 UTC by Report Bug Copy Issue Report The method `daita\MySmallPhpTools\Db...uilder::filterDBField()` has been deprecated with message: - use filter(); This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
169
170		return $this->getItemsFromRequest($qb);
171		}
172
173
174		/**
175		* - returns:
176		* - all GLOBAL_SCALE
177		* - TRUSTED if Circle is Federated
178		* - EXTERNAL if Circle is Federated and a contains a member from instance
179		*
180		* @param Circle $circle
181		* @param bool $broadcastAsFederated
182		*
183		* @return RemoteInstance[]
184		* @throws RequestBuilderException
185		*/
186		public function getOutgoingRecipient(Circle $circle, bool $broadcastAsFederated = false): array {
187		$qb = $this->getRemoteSelectSql();
188		$expr = $qb->expr();
189		$orX = $expr->orX();
190
191		$orX->add($qb->exprLimitToDBField('type', RemoteInstance::TYPE_GLOBALSCALE, true, false));
		0 ignored issues – show Deprecated Code introduced 2021-05-24 13:55 UTC by Report Bug Copy Issue Report The method `daita\MySmallPhpTools\Db...r::exprLimitToDBField()` has been deprecated with message: - use exprLimit() / exprFilter(); This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
192
193		if ($circle->isConfig(Circle::CFG_FEDERATED) \|\| $broadcastAsFederated) {
194
195		// get all TRUSTED
196		$orX->add($qb->exprLimitToDBField('type', RemoteInstance::TYPE_TRUSTED, true, false));
		0 ignored issues – show Deprecated Code introduced 2021-05-24 13:55 UTC by Report Bug Copy Issue Report The method `daita\MySmallPhpTools\Db...r::exprLimitToDBField()` has been deprecated with message: - use exprLimit() / exprFilter(); This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
197
198		// get EXTERNAL with Members
199		$aliasMember = $qb->generateAlias(CoreQueryBuilder::REMOTE, CoreQueryBuilder::MEMBER);
200		$qb->leftJoin(
201		CoreQueryBuilder::REMOTE, self::TABLE_MEMBER, $aliasMember,
202		$expr->andX(
203		$expr->eq($aliasMember . '.circle_id', $qb->createNamedParameter($circle->getSingleId())),
204		$expr->eq($aliasMember . '.instance', CoreQueryBuilder::REMOTE . '.instance'),
205		$expr->gte(
206		$aliasMember . '.level',
207		$qb->createNamedParameter(Member::LEVEL_MEMBER, IQueryBuilder::PARAM_INT)
208		)
209		)
210		);
211
212		$external = $expr->andX();
213		$external->add($qb->exprLimitToDBField('type', RemoteInstance::TYPE_EXTERNAL, true, false));
		0 ignored issues – show Deprecated Code introduced 2021-05-24 13:55 UTC by Report Bug Copy Issue Report The method `daita\MySmallPhpTools\Db...r::exprLimitToDBField()` has been deprecated with message: - use exprLimit() / exprFilter(); This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
214		$external->add($expr->isNotNull($aliasMember . '.instance'));
215		$orX->add($external);
216		}
217
218		$qb->andWhere($orX)
219		->generateGroupBy(self::$tables[self::TABLE_REMOTE], CoreQueryBuilder::REMOTE);
		0 ignored issues – show Bug introduced 2021-05-07 13:39 UTC by Report Bug Copy Issue Report The property `tables` cannot be accessed from this context as it is declared `private` in class `OCA\Circles\Db\CoreRequestBuilder`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history...
220
221		return $this->getItemsFromRequest($qb);
222		}
223
224
225		/**
226		* @param string $host
227		*
228		* @return RemoteInstance
229		* @throws RemoteNotFoundException
230		*/
231		public function getFromInstance(string $host): RemoteInstance {
232		$qb = $this->getRemoteSelectSql();
233		$qb->limitToInstance($host);
234
235		return $this->getItemFromRequest($qb);
236		}
237
238
239		/**
240		* @param string $href
241		*
242		* @return RemoteInstance
243		* @throws RemoteNotFoundException
244		*/
245		public function getFromHref(string $href): RemoteInstance {
246		$qb = $this->getRemoteSelectSql();
247		$qb->limitToDBField('href', $href, false);
		0 ignored issues – show Deprecated Code introduced 2021-06-13 12:57 UTC by Report Bug Copy Issue Report The method `daita\MySmallPhpTools\Db...ilder::limitToDBField()` has been deprecated with message: - use limit(); This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
248
249		return $this->getItemFromRequest($qb);
250		}
251
252
253		/**
254		* @param string $status
255		*
256		* @return RemoteInstance[]
257		*/
258		public function getFromType(string $status): array {
259		$qb = $this->getRemoteSelectSql();
260		$qb->limitToTypeString($status);
261
262		return $this->getItemsFromRequest($qb);
263		}
264
265
266		/**
267		* @param RemoteInstance $remoteInstance
268		*
269		* @return RemoteInstance
270		* @throws RemoteNotFoundException
271		*/
272		public function searchDuplicate(RemoteInstance $remoteInstance) {
273		$qb = $this->getRemoteSelectSql();
274		$orX = $qb->expr()->orX();
275		$orX->add($qb->exprLimitToDBField('href', $remoteInstance->getId(), true, false));
		0 ignored issues – show Deprecated Code introduced 2021-05-24 13:55 UTC by Report Bug Copy Issue Report The method `daita\MySmallPhpTools\Db...r::exprLimitToDBField()` has been deprecated with message: - use exprLimit() / exprFilter(); This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
276		$orX->add($qb->exprLimitToDBField('uid', $remoteInstance->getUid(true), true));
		0 ignored issues – show Deprecated Code introduced 2021-05-24 13:55 UTC by Report Bug Copy Issue Report The method `daita\MySmallPhpTools\Db...r::exprLimitToDBField()` has been deprecated with message: - use exprLimit() / exprFilter(); This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
277		$orX->add($qb->exprLimitToDBField('instance', $remoteInstance->getInstance(), true, false));
		0 ignored issues – show Deprecated Code introduced 2021-05-24 13:55 UTC by Report Bug Copy Issue Report The method `daita\MySmallPhpTools\Db...r::exprLimitToDBField()` has been deprecated with message: - use exprLimit() / exprFilter(); This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
278		$qb->andWhere($orX);
279
280		return $this->getItemFromRequest($qb);
281		}
282
283
284		/**
285		* @param RemoteInstance $remoteInstance
286		*/
287		public function deleteById(RemoteInstance $remoteInstance) {
288		$qb = $this->getRemoteDeleteSql();
289		$qb->limitToId($remoteInstance->getDbId());
290		$qb->execute();
291		}
292
293
294		}
295
296

nextcloud / circles

Push — master ( 98fb41...18d3f8 )

RemoteRequest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

14 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like