Complex classes like Circle often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Circle, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
75 | class Circle extends ManagedModel implements IMemberships, IDeserializable, INC22QueryRow, JsonSerializable { |
||
76 | |||
77 | |||
78 | use TArrayTools; |
||
79 | use TNC22Deserialize; |
||
80 | |||
81 | |||
82 | const FLAGS_SHORT = 1; |
||
83 | const FLAGS_LONG = 2; |
||
84 | |||
85 | |||
86 | // specific value |
||
87 | const CFG_CIRCLE = 0; // only for code readability. Circle is locked by default. |
||
88 | const CFG_SINGLE = 1; // Circle with only one single member. |
||
89 | const CFG_PERSONAL = 2; // Personal circle, only the owner can see it. |
||
90 | |||
91 | // bitwise |
||
92 | const CFG_SYSTEM = 4; // System Circle (not managed by the official front-end). Meaning some config are limited |
||
93 | const CFG_VISIBLE = 8; // Visible to everyone, if not visible, people have to know its name to be able to find it |
||
94 | const CFG_OPEN = 16; // Circle is open, people can join |
||
95 | const CFG_INVITE = 32; // Adding a member generate an invitation that needs to be accepted |
||
96 | const CFG_REQUEST = 64; // Request to join Circles needs to be confirmed by a moderator |
||
97 | const CFG_FRIEND = 128; // Members of the circle can invite their friends |
||
98 | const CFG_PROTECTED = 256; // Password protected to join/request |
||
99 | const CFG_NO_OWNER = 512; // no owner, only members |
||
100 | const CFG_HIDDEN = 1024; // hidden from listing, but available as a share entity |
||
101 | const CFG_BACKEND = 2048; // Fully hidden, only backend Circles |
||
102 | const CFG_LOCAL = 4096; // Local even on GlobalScale |
||
103 | const CFG_ROOT = 8192; // Circle cannot be inside another Circle |
||
104 | const CFG_CIRCLE_INVITE = 16384; // Circle must confirm when invited in another circle |
||
105 | const CFG_FEDERATED = 32768; // Federated |
||
106 | const CFG_MOUNTPOINT = 65536; // Generate a Files folder for this Circle |
||
107 | |||
108 | public static $DEF_CFG_MAX = 131071; |
||
109 | |||
110 | |||
111 | /** |
||
112 | * Note: When editing those values, update lib/Application/Capabilities.php |
||
113 | * |
||
114 | * @see Capabilities::getCapabilitiesCircleConstants() |
||
115 | * @var array |
||
116 | */ |
||
117 | public static $DEF_CFG = [ |
||
118 | 1 => 'S|Single', |
||
119 | 2 => 'P|Personal', |
||
120 | 4 => 'Y|System', |
||
121 | 8 => 'V|Visible', |
||
122 | 16 => 'O|Open', |
||
123 | 32 => 'I|Invite', |
||
124 | 64 => 'JR|Join Request', |
||
125 | 128 => 'F|Friends', |
||
126 | 256 => 'PP|Password Protected', |
||
127 | 512 => 'NO|No Owner', |
||
128 | 1024 => 'H|Hidden', |
||
129 | 2048 => 'T|Backend', |
||
130 | 4096 => 'L|Local', |
||
131 | 8192 => 'T|Root', |
||
132 | 16384 => 'CI|Circle Invite', |
||
133 | 32768 => 'F|Federated', |
||
134 | 65536 => 'M|Nountpoint' |
||
135 | ]; |
||
136 | |||
137 | |||
138 | /** |
||
139 | * Note: When editing those values, update lib/Application/Capabilities.php |
||
140 | * |
||
141 | * @see Capabilities::getCapabilitiesCircleConstants() |
||
142 | * @var array |
||
143 | */ |
||
144 | public static $DEF_SOURCE = [ |
||
145 | 1 => 'Nextcloud User', |
||
146 | 2 => 'Nextcloud Group', |
||
147 | 4 => 'Mail Address', |
||
148 | 8 => 'Contact', |
||
149 | 16 => 'Circle', |
||
150 | 10001 => 'Circles App' |
||
151 | ]; |
||
152 | |||
153 | |||
154 | public static $DEF_CFG_CORE_FILTER = [ |
||
155 | 1, |
||
156 | 2, |
||
157 | 4 |
||
158 | ]; |
||
159 | |||
160 | public static $DEF_CFG_SYSTEM_FILTER = [ |
||
161 | 512, |
||
162 | 1024, |
||
163 | 2048 |
||
164 | ]; |
||
165 | |||
166 | |||
167 | /** @var string */ |
||
168 | private $singleId = ''; |
||
169 | |||
170 | /** @var int */ |
||
171 | private $config = 0; |
||
172 | |||
173 | /** @var string */ |
||
174 | private $name = ''; |
||
175 | |||
176 | /** @var string */ |
||
177 | private $displayName = ''; |
||
178 | |||
179 | /** @var int */ |
||
180 | private $source = 0; |
||
181 | |||
182 | /** @var Member */ |
||
183 | private $owner; |
||
184 | |||
185 | /** @var Member */ |
||
186 | private $initiator; |
||
187 | |||
188 | /** @var array */ |
||
189 | private $settings = []; |
||
190 | |||
191 | /** @var string */ |
||
192 | private $description = ''; |
||
193 | |||
194 | /** @var int */ |
||
195 | private $contactAddressBook = 0; |
||
196 | |||
197 | /** @var string */ |
||
198 | private $contactGroupName = ''; |
||
199 | |||
200 | /** @var string */ |
||
201 | private $instance = ''; |
||
202 | |||
203 | // /** @var bool */ |
||
204 | // private $hidden = false; |
||
205 | |||
206 | /** @var int */ |
||
207 | private $creation = 0; |
||
208 | |||
209 | |||
210 | /** @var Member[] */ |
||
211 | private $members = null; |
||
212 | |||
213 | /** @var Member[] */ |
||
214 | private $inheritedMembers = null; |
||
215 | |||
216 | /** @var bool */ |
||
217 | private $detailedInheritedMember = false; |
||
218 | |||
219 | /** @var Membership[] */ |
||
220 | private $memberships = null; |
||
221 | |||
222 | |||
223 | /** |
||
224 | * Circle constructor. |
||
225 | */ |
||
226 | public function __construct() { |
||
228 | |||
229 | /** |
||
230 | * @param string $singleId |
||
231 | * |
||
232 | * @return self |
||
233 | */ |
||
234 | public function setSingleId(string $singleId): self { |
||
239 | |||
240 | /** |
||
241 | * @return string |
||
242 | */ |
||
243 | public function getSingleId(): string { |
||
246 | |||
247 | |||
248 | /** |
||
249 | * @param int $config |
||
250 | * |
||
251 | * @return self |
||
252 | */ |
||
253 | public function setConfig(int $config): self { |
||
258 | |||
259 | /** |
||
260 | * @return int |
||
261 | */ |
||
262 | public function getConfig(): int { |
||
265 | |||
266 | /** |
||
267 | * @param int $flag |
||
268 | * @param int $test |
||
269 | * |
||
270 | * @return bool |
||
271 | */ |
||
272 | public function isConfig(int $flag, int $test = 0): bool { |
||
279 | |||
280 | /** |
||
281 | * @param int $flag |
||
282 | */ |
||
283 | public function addConfig(int $flag): void { |
||
288 | |||
289 | /** |
||
290 | * @param int $flag |
||
291 | */ |
||
292 | public function remConfig(int $flag): void { |
||
297 | |||
298 | |||
299 | /** |
||
300 | * @param string $name |
||
301 | * |
||
302 | * @return self |
||
303 | */ |
||
304 | public function setName(string $name): self { |
||
312 | |||
313 | /** |
||
314 | * @return string |
||
315 | */ |
||
316 | public function getName(): string { |
||
319 | |||
320 | |||
321 | /** |
||
322 | * @param string $displayName |
||
323 | * |
||
324 | * @return self |
||
325 | */ |
||
326 | public function setDisplayName(string $displayName): self { |
||
333 | |||
334 | /** |
||
335 | * @return string |
||
336 | */ |
||
337 | public function getDisplayName(): string { |
||
340 | |||
341 | |||
342 | /** |
||
343 | * @param int $source |
||
344 | * |
||
345 | * @return Circle |
||
346 | */ |
||
347 | public function setSource(int $source): self { |
||
352 | |||
353 | /** |
||
354 | * @return int |
||
355 | */ |
||
356 | public function getSource(): int { |
||
359 | |||
360 | |||
361 | /** |
||
362 | * @param ?Member $owner |
||
|
|||
363 | * |
||
364 | * @return self |
||
365 | */ |
||
366 | public function setOwner(?Member $owner): self { |
||
371 | |||
372 | /** |
||
373 | * @return Member |
||
374 | */ |
||
375 | public function getOwner(): Member { |
||
378 | |||
379 | /** |
||
380 | * @return bool |
||
381 | */ |
||
382 | public function hasOwner(): bool { |
||
385 | |||
386 | |||
387 | /** |
||
388 | * @return bool |
||
389 | */ |
||
390 | public function hasMembers(): bool { |
||
393 | |||
394 | /** |
||
395 | * @param array $members |
||
396 | * |
||
397 | * @return self |
||
398 | */ |
||
399 | public function setMembers(array $members): IMemberships { |
||
404 | |||
405 | /** |
||
406 | * @return array |
||
407 | */ |
||
408 | public function getMembers(): array { |
||
415 | |||
416 | |||
417 | /** |
||
418 | * @param array $members |
||
419 | * @param bool $detailed |
||
420 | * |
||
421 | * @return self |
||
422 | */ |
||
423 | public function setInheritedMembers(array $members, bool $detailed): IMemberships { |
||
429 | |||
430 | /** |
||
431 | * @param bool $detailed |
||
432 | * |
||
433 | * @return array |
||
434 | */ |
||
435 | public function getInheritedMembers(bool $detailed = false): array { |
||
443 | |||
444 | |||
445 | /** |
||
446 | * @return bool |
||
447 | */ |
||
448 | public function hasMemberships(): bool { |
||
451 | |||
452 | /** |
||
453 | * @param array $memberships |
||
454 | * |
||
455 | * @return self |
||
456 | */ |
||
457 | public function setMemberships(array $memberships): IMemberships { |
||
462 | |||
463 | /** |
||
464 | * @return Membership[] |
||
465 | */ |
||
466 | public function getMemberships(): array { |
||
473 | |||
474 | |||
475 | /** |
||
476 | * @param Member|null $initiator |
||
477 | * |
||
478 | * @return Circle |
||
479 | */ |
||
480 | public function setInitiator(?Member $initiator): self { |
||
485 | |||
486 | /** |
||
487 | * @return Member |
||
488 | */ |
||
489 | public function getInitiator(): Member { |
||
492 | |||
493 | /** |
||
494 | * @return bool |
||
495 | */ |
||
496 | public function hasInitiator(): bool { |
||
499 | |||
500 | /** |
||
501 | * @param string $instance |
||
502 | * |
||
503 | * @return Circle |
||
504 | */ |
||
505 | public function setInstance(string $instance): self { |
||
512 | |||
513 | /** |
||
514 | * @return string |
||
515 | * @throws OwnerNotFoundException |
||
516 | */ |
||
517 | public function getInstance(): string { |
||
524 | |||
525 | |||
526 | /** |
||
527 | * @param array $settings |
||
528 | * |
||
529 | * @return self |
||
530 | */ |
||
531 | public function setSettings(array $settings): self { |
||
536 | |||
537 | /** |
||
538 | * @return array |
||
539 | */ |
||
540 | public function getSettings(): array { |
||
543 | |||
544 | |||
545 | /** |
||
546 | * @param string $description |
||
547 | * |
||
548 | * @return self |
||
549 | */ |
||
550 | public function setDescription(string $description): self { |
||
555 | |||
556 | /** |
||
557 | * @return string |
||
558 | */ |
||
559 | public function getDescription(): string { |
||
562 | |||
563 | |||
564 | /** |
||
565 | * @return string |
||
566 | */ |
||
567 | public function getUrl(): string { |
||
568 | return $this->getManager()->generateLinkToCircle($this->getSingleId()); |
||
569 | } |
||
570 | |||
571 | |||
572 | /** |
||
573 | * @param int $contactAddressBook |
||
574 | * |
||
575 | * @return self |
||
576 | */ |
||
577 | public function setContactAddressBook(int $contactAddressBook): self { |
||
582 | |||
583 | /** |
||
584 | * @return int |
||
585 | */ |
||
586 | public function getContactAddressBook(): int { |
||
589 | |||
590 | |||
591 | /** |
||
592 | * @param string $contactGroupName |
||
593 | * |
||
594 | * @return self |
||
595 | */ |
||
596 | public function setContactGroupName(string $contactGroupName): self { |
||
601 | |||
602 | /** |
||
603 | * @return string |
||
604 | */ |
||
605 | public function getContactGroupName(): string { |
||
608 | |||
609 | |||
610 | /** |
||
611 | * @param int $creation |
||
612 | * |
||
613 | * @return self |
||
614 | */ |
||
615 | public function setCreation(int $creation): self { |
||
620 | |||
621 | /** |
||
622 | * @return int |
||
623 | */ |
||
624 | public function getCreation(): int { |
||
627 | |||
628 | |||
629 | /** |
||
630 | * @param array $data |
||
631 | * |
||
632 | * @return $this |
||
633 | * @throws InvalidItemException |
||
634 | */ |
||
635 | public function import(array $data): IDeserializable { |
||
667 | |||
668 | |||
669 | /** |
||
670 | * @return array |
||
671 | */ |
||
672 | public function jsonSerialize(): array { |
||
704 | |||
705 | |||
706 | /** |
||
707 | * @param array $data |
||
708 | * @param string $prefix |
||
709 | * |
||
710 | * @return INC22QueryRow |
||
711 | * @throws CircleNotFoundException |
||
712 | */ |
||
713 | public function importFromDatabase(array $data, string $prefix = ''): INC22QueryRow { |
||
736 | |||
737 | |||
738 | /** |
||
739 | * @param Circle $circle |
||
740 | * |
||
741 | * @return bool |
||
742 | * @throws OwnerNotFoundException |
||
743 | */ |
||
744 | public function compareWith(Circle $circle): bool { |
||
765 | |||
766 | |||
767 | /** |
||
768 | * @param Circle $circle |
||
769 | * @param int $display |
||
770 | * |
||
771 | * @return array |
||
772 | */ |
||
773 | public static function getCircleFlags(Circle $circle, int $display = self::FLAGS_LONG): array { |
||
793 | |||
794 | } |
||
795 | |||
796 |
This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types.