nextcloud / circles

lib/Command/MembersList.php

Unused Use Statements -1 removed lines

@@ -32,7 +32,6 @@
 namespace OCA\Circles\Command;
 
 use ArtificialOwl\MySmallPhpTools\Exceptions\InvalidItemException;
-use ArtificialOwl\MySmallPhpTools\Exceptions\ItemNotFoundException;
 use ArtificialOwl\MySmallPhpTools\Exceptions\RequestNetworkException;
 use ArtificialOwl\MySmallPhpTools\Exceptions\SignatoryException;
 use ArtificialOwl\MySmallPhpTools\Exceptions\UnknownTypeException;

Spacing +14 added lines, -15 removed lines

@@ -186,11 +186,11 @@ 
 			$this->federatedUserService->commandLineInitiator($initiator, $initiatorType, $circleId, true);
 			$circle = $this->circleService->getCircle($circleId);
 
-			$output->writeln('<info>Name</info>: ' . $circle->getName());
+			$output->writeln('<info>Name</info>: '.$circle->getName());
 			$owner = $circle->getOwner();
-			$output->writeln('<info>Owner</info>: ' . $owner->getUserId() . '@' . $owner->getInstance());
+			$output->writeln('<info>Owner</info>: '.$owner->getUserId().'@'.$owner->getInstance());
 			$type = implode(", ", Circle::getCircleFlags($circle, Circle::FLAGS_LONG));
-			$output->writeln('<info>Config</info>: ' . $type);
+			$output->writeln('<info>Config</info>: '.$type);
 			$output->writeln(' ');
 
 			$tree = new NC22TreeNode(null, new SimpleDataStore(['circle' => $circle]));
@@ -255,8 +255,7 @@ 
 						$member, $this->input->getOption('display-name')
 					),
 					$this->configService->displayInstance($member->getInstance()),
-					($level > 0) ? Member::$DEF_LEVEL[$level] :
-						'(' . strtolower($member->getStatus()) . ')',
+					($level > 0) ? Member::$DEF_LEVEL[$level] : '('.strtolower($member->getStatus()).')',
 					($member->hasInvitedBy()) ? $this->configService->displayFederatedUser(
 						$member->getInvitedBy(), $this->input->getOption('display-name')
 					) : 'Unknown'
@@ -418,19 +417,19 @@ 
 				$member = $data->gObj('member', Member::class);
 
 				if ($lineNumber === 1) {
-					$line .= '<info>' . $member->getSingleId() . '</info>';
+					$line .= '<info>'.$member->getSingleId().'</info>';
 					if (!$this->configService->isLocalInstance($member->getInstance())) {
-						$line .= '@' . $member->getInstance();
+						$line .= '@'.$member->getInstance();
 					}
-					$line .= ' (' . Member::$DEF_LEVEL[$member->getLevel()] . ')';
+					$line .= ' ('.Member::$DEF_LEVEL[$member->getLevel()].')';
 
-					$line .= ' <info>MemberId</info>: ' . $member->getId();
-					$line .= ' <info>Name</info>: ' . $this->configService->displayFederatedUser(
+					$line .= ' <info>MemberId</info>: '.$member->getId();
+					$line .= ' <info>Name</info>: '.$this->configService->displayFederatedUser(
 							$member,
 							$this->input->getOption('display-name')
 						);
 					$source = ($member->hasBasedOn()) ? $member->getBasedOn()->getSource() : '';
-					$line .= ' <info>Source</info>: ' . Circle::$DEF_SOURCE[$source];
+					$line .= ' <info>Source</info>: '.Circle::$DEF_SOURCE[$source];
 				}
 
 				if ($lineNumber === 2) {
@@ -442,16 +441,16 @@ 
 						return $line;
 					}
 					$owner = $circle->getOwner();
-					$line .= '<info>Owner</info>: ' . $owner->getUserId() . '@' . $owner->getInstance();
+					$line .= '<info>Owner</info>: '.$owner->getUserId().'@'.$owner->getInstance();
 					$type = implode(", ", Circle::getCircleFlags($circle, Circle::FLAGS_LONG));
-					$line .= ($type === '') ? '' : ' <info>Config</info>: ' . $type;
+					$line .= ($type === '') ? '' : ' <info>Config</info>: '.$type;
 				}
 
 			} else {
 				if ($lineNumber === 1 && !is_null($circle)) {
-					$line .= '<info>' . $circle->getSingleId() . '</info>';
+					$line .= '<info>'.$circle->getSingleId().'</info>';
 					if (!$this->configService->isLocalInstance($circle->getInstance())) {
-						$line .= '@' . $circle->getInstance();
+						$line .= '@'.$circle->getInstance();
 					}
 				}
 			}

lib/Handlers/WebfingerHandler.php

Unused Use Statements -2 removed lines

@@ -33,11 +33,9 @@
 
 
 use ArtificialOwl\MySmallPhpTools\Exceptions\SignatoryException;
-use ArtificialOwl\MySmallPhpTools\Exceptions\SignatureException;
 use ArtificialOwl\MySmallPhpTools\Traits\TArrayTools;
 use OC\URLGenerator;
 use OCA\Circles\AppInfo\Application;
-use OCA\Circles\Exceptions\UnknownInterfaceException;
 use OCA\Circles\Service\ConfigService;
 use OCA\Circles\Service\InterfaceService;
 use OCA\Circles\Service\RemoteStreamService;

lib/Model/Federated/EventWrapper.php

Unused Use Statements -1 removed lines

@@ -37,7 +37,6 @@
 use ArtificialOwl\MySmallPhpTools\Model\SimpleDataStore;
 use ArtificialOwl\MySmallPhpTools\Traits\TArrayTools;
 use JsonSerializable;
-use OCA\Circles\Exceptions\UnknownInterfaceException;
 
 
 /**

lib/Service/ConfigService.php

Spacing +6 added lines, -6 removed lines

@@ -186,7 +186,7 @@ 
 			return $value;
 		}
 
-		if (($value = $this->config->getSystemValue(Application::APP_ID . '.' . $key, '')) !== '') {
+		if (($value = $this->config->getSystemValue(Application::APP_ID.'.'.$key, '')) !== '') {
 			return $value;
 		}
 
@@ -440,7 +440,7 @@ 
 		}
 
 		if (array_key_exists('port', $loopback)) {
-			$loopbackCloudId = $loopback['host'] . ':' . $loopback['port'];
+			$loopbackCloudId = $loopback['host'].':'.$loopback['port'];
 		} else {
 			$loopbackCloudId = $loopback['host'];
 		}
@@ -469,12 +469,12 @@ 
 			$scheme = $this->getAppValue(self::LOOPBACK_CLOUD_SCHEME);
 		}
 
-		$base = $scheme . '://' . $instance;
+		$base = $scheme.'://'.$instance;
 		if ($route === '') {
 			return $base;
 		}
 
-		return $base . $this->urlGenerator->linkToRoute($route, $args);
+		return $base.$this->urlGenerator->linkToRoute($route, $args);
 	}
 
 
@@ -574,7 +574,7 @@ 
 	public function displayFederatedUser(IFederatedUser $federatedUser, bool $displayName = false): string {
 		$name = ($displayName) ? $federatedUser->getDisplayName() : $federatedUser->getUserId();
 
-		return $name . $this->displayInstance($federatedUser->getInstance(), true);
+		return $name.$this->displayInstance($federatedUser->getInstance(), true);
 	}
 
 	/**
@@ -588,7 +588,7 @@ 
 			return '';
 		}
 
-		return (($showAt) ? '@' : '') . $instance;
+		return (($showAt) ? '@' : '').$instance;
 	}
 
 

lib/Command/CirclesList.php

Spacing +1 added lines, -1 removed lines

@@ -224,7 +224,7 @@
 					Circle::$DEF_SOURCE[$circle->getSource()],
 					$displayName ? $owner->getDisplayName() : $owner->getUserId(),
 					$this->configService->displayInstance($owner->getInstance()),
-					$circle->getPopulation() . '/' . $this->getInt('members_limit', $circle->getSettings(), -1),
+					$circle->getPopulation().'/'.$this->getInt('members_limit', $circle->getSettings(), -1),
 					substr(str_replace("\n", ' ', $circle->getDescription()), 0, 30)
 				]
 			);

lib/Command/CirclesMaintenance.php

Spacing +3 added lines, -3 removed lines

@@ -115,7 +115,7 @@ 
 				'<error>WARNING! You are about to delete all data related to the Circles App!</error>'
 			);
 			$question = new ConfirmationQuestion(
-				'<comment>Do you really want to ' . $action . ' Circles ?</comment> (y/N) ', false,
+				'<comment>Do you really want to '.$action.' Circles ?</comment> (y/N) ', false,
 				'/^(y|Y)/i'
 			);
 
@@ -131,7 +131,7 @@ 
 
 
 			$question = new Question(
-				'<comment>Please confirm this destructive operation by typing \'' . $action
+				'<comment>Please confirm this destructive operation by typing \''.$action
 				. '\'</comment>: ', ''
 			);
 
@@ -148,7 +148,7 @@ 
 				$this->coreQueryBuilder->uninstall();
 			}
 
-			$output->writeln('<info>' . $action . ' done</info>');
+			$output->writeln('<info>'.$action.' done</info>');
 
 			return 0;
 		}

lib/Service/SyncService.php

Spacing +3 added lines, -3 removed lines

@@ -250,7 +250,7 @@ 
 	 * @throws SingleCircleNotFoundException
 	 */
 	public function syncNextcloudUser(string $userId): FederatedUser {
-		$this->outputService->output('Syncing Nextcloud User \'' . $userId . '\'', true);
+		$this->outputService->output('Syncing Nextcloud User \''.$userId.'\'', true);
 
 		return $this->federatedUserService->getLocalFederatedUser($userId);
 	}
@@ -294,7 +294,7 @@ 
 	 * @throws RequestBuilderException
 	 */
 	public function syncNextcloudGroup(string $groupId): Circle {
-		$this->outputService->output('Syncing Nextcloud Group \'' . $groupId . '\'', true);
+		$this->outputService->output('Syncing Nextcloud Group \''.$groupId.'\'', true);
 
 		$circle = $this->federatedUserService->getGroupCircle($groupId);
 		$group = $this->groupManager->get($groupId);
@@ -363,7 +363,7 @@ 
 	 */
 	public function groupDeleted(string $groupId): void {
 		$circle = new Circle();
-		$circle->setName('group:' . $groupId)
+		$circle->setName('group:'.$groupId)
 			   ->setConfig(Circle::CFG_SYSTEM | Circle::CFG_NO_OWNER | Circle::CFG_HIDDEN)
 			   ->setSource(Member::TYPE_GROUP);
 

lib/Service/OutputService.php

Spacing +3 added lines, -3 removed lines

@@ -82,14 +82,14 @@
 	 */
 	public function output(string $message, bool $advance = false): void {
 		if (!is_null($this->occOutput)) {
-			$this->occOutput->writeln((($advance) ? '+' : '-') . ' ' . $message);
+			$this->occOutput->writeln((($advance) ? '+' : '-').' '.$message);
 		}
 
 		if (!is_null($this->migrationOutput)) {
 			if ($advance) {
-				$this->migrationOutput->advance(1, '(Circles) ' . $message);
+				$this->migrationOutput->advance(1, '(Circles) '.$message);
 			} else {
-				$this->migrationOutput->info('(Circles) ' . $message);
+				$this->migrationOutput->info('(Circles) '.$message);
 			}
 		}
 	}

lib/Service/MigrationService.php

Spacing +3 added lines, -3 removed lines

@@ -231,7 +231,7 @@ 
 				try {
 					$data = new SimpleDataStore($row);
 					$this->outputService->output(
-						'Migrating Circle \'' . $data->g('name') . '\'',
+						'Migrating Circle \''.$data->g('name').'\'',
 						true
 					);
 
@@ -336,7 +336,7 @@ 
 				try {
 					$data = new SimpleDataStore($row);
 					$this->outputService->output(
-						'Migrating Member \'' . $data->g('user_id') . '\'',
+						'Migrating Member \''.$data->g('user_id').'\'',
 						true
 					);
 
@@ -453,7 +453,7 @@ 
 			$addressBook =
 				$this->contactService->getAddressBoxById($cm, $this->get('addressbook-key', $entry));
 
-			$member->setUserId($userId . '/' . $addressBook->getUri() . '/' . $contactId);
+			$member->setUserId($userId.'/'.$addressBook->getUri().'/'.$contactId);
 		}
 	}