Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like DavService often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use DavService, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 57 | class DavService { |
||
| 58 | |||
| 59 | |||
| 60 | /** @var string */ |
||
| 61 | private $userId; |
||
| 62 | |||
| 63 | /** @var IUserManager */ |
||
| 64 | private $userManager; |
||
| 65 | |||
| 66 | /** @var CardDavBackend */ |
||
| 67 | private $cardDavBackend; |
||
| 68 | |||
| 69 | /** @var ICloudIdManager */ |
||
| 70 | private $cloudManager; |
||
| 71 | |||
| 72 | /** @var FileSharingBroadcaster */ |
||
| 73 | private $fileSharingBroadcaster; |
||
| 74 | |||
| 75 | /** @var CirclesRequest */ |
||
| 76 | private $circlesRequest; |
||
| 77 | |||
| 78 | /** @var MembersRequest */ |
||
| 79 | private $membersRequest; |
||
| 80 | |||
| 81 | /** @var ConfigService */ |
||
| 82 | private $configService; |
||
| 83 | |||
| 84 | /** @var MiscService */ |
||
| 85 | private $miscService; |
||
| 86 | |||
| 87 | |||
| 88 | /** @var array */ |
||
| 89 | private $migratedBooks = []; |
||
| 90 | |||
| 91 | |||
| 92 | /** |
||
| 93 | * TimezoneService constructor. |
||
| 94 | * |
||
| 95 | * @param string $userId |
||
| 96 | * @param IUserManager $userManager |
||
| 97 | * @param CardDavBackend $cardDavBackend |
||
| 98 | * @param ICloudIdManager $cloudManager |
||
| 99 | * @param CirclesRequest $circlesRequest |
||
| 100 | * @param FileSharingBroadcaster $fileSharingBroadcaster |
||
| 101 | * @param MembersRequest $membersRequest |
||
| 102 | * @param ConfigService $configService |
||
| 103 | * @param MiscService $miscService |
||
| 104 | */ |
||
| 105 | View Code Duplication | public function __construct( |
|
| 120 | |||
| 121 | |||
| 122 | /** |
||
| 123 | * @param ManagerEvent $event |
||
| 124 | */ |
||
| 125 | public function onAppEnabled(ManagerEvent $event) { |
||
| 135 | |||
| 136 | |||
| 137 | /** |
||
| 138 | * @param GenericEvent $event |
||
| 139 | */ |
||
| 140 | public function onCreateCard(GenericEvent $event) { |
||
| 144 | |||
| 145 | |||
| 146 | /** |
||
| 147 | * @param GenericEvent $event |
||
| 148 | */ |
||
| 149 | public function onUpdateCard(GenericEvent $event) { |
||
| 153 | |||
| 154 | |||
| 155 | /** |
||
| 156 | * @param GenericEvent $event |
||
| 157 | */ |
||
| 158 | public function onDeleteCard(GenericEvent $event) { |
||
| 164 | |||
| 165 | |||
| 166 | /** |
||
| 167 | * @param GenericEvent $event |
||
| 168 | * @param bool $tiny |
||
| 169 | * |
||
| 170 | * @return DavCard |
||
| 171 | */ |
||
| 172 | private function generateDavCard(GenericEvent $event, bool $tiny = false): DavCard { |
||
| 190 | |||
| 191 | |||
| 192 | /** |
||
| 193 | * @param int $bookId |
||
| 194 | * @param array $card |
||
| 195 | * |
||
| 196 | * @return DavCard |
||
| 197 | */ |
||
| 198 | private function generateDavCardFromCard(int $bookId, array $card): DavCard { |
||
| 208 | |||
| 209 | |||
| 210 | /** |
||
| 211 | * @param DavCard $davCard |
||
| 212 | * |
||
| 213 | */ |
||
| 214 | private function manageDavCard(DavCard $davCard) { |
||
| 219 | |||
| 220 | |||
| 221 | /** |
||
| 222 | * @param DavCard $davCard |
||
| 223 | */ |
||
| 224 | private function manageContact(DavCard $davCard) { |
||
| 241 | |||
| 242 | |||
| 243 | /** |
||
| 244 | * @param DavCard $davCard |
||
| 245 | */ |
||
| 246 | private function manageDeprecatedMembers(DavCard $davCard) { |
||
| 261 | |||
| 262 | |||
| 263 | /** |
||
| 264 | * @param DavCard $davCard |
||
| 265 | */ |
||
| 266 | private function manageLocalContact(DavCard $davCard) { |
||
| 271 | |||
| 272 | |||
| 273 | /** |
||
| 274 | * @param DavCard $davCard |
||
| 275 | */ |
||
| 276 | private function manageRemoteContact(DavCard $davCard) { |
||
| 281 | |||
| 282 | |||
| 283 | /** |
||
| 284 | * @param Circle $circle |
||
| 285 | * @param DavCard $davCard |
||
| 286 | * @param int $type |
||
| 287 | */ |
||
| 288 | private function manageMember(Circle $circle, DavCard $davCard, int $type) { |
||
| 289 | try { |
||
| 290 | $member = |
||
| 291 | $this->membersRequest->getContactMember($circle->getUniqueId(), $davCard->getUniqueId()); |
||
| 292 | |||
| 293 | if ($member->getType() !== $type) { |
||
| 294 | $this->membersRequest->removeMember($member); |
||
| 295 | throw new MemberDoesNotExistException(); |
||
| 296 | } |
||
| 297 | } catch (MemberDoesNotExistException $e) { |
||
| 298 | $member = new Member(); |
||
| 299 | $member->setLevel(Member::LEVEL_MEMBER); |
||
| 300 | $member->setStatus(Member::STATUS_MEMBER); |
||
| 301 | $member->setContactId($davCard->getUniqueId()); |
||
| 302 | $member->setType($type); |
||
| 303 | $member->setCircleId($circle->getUniqueId()); |
||
| 304 | $member->setUserId($davCard->getUserId()); |
||
| 305 | |||
| 306 | try { |
||
| 307 | $this->membersRequest->createMember($member); |
||
| 308 | |||
| 309 | // if ($type === Member::TYPE_CONTACT) { |
||
| 310 | // $this->fileSharingBroadcaster->sendMailAboutExistingShares($circle, $member); |
||
| 311 | // } |
||
| 312 | } catch (MemberAlreadyExistsException $e) { |
||
| 313 | $this->membersRequest->checkMember($member, false); |
||
| 314 | } |
||
| 315 | } |
||
| 316 | } |
||
| 317 | |||
| 318 | |||
| 319 | /** |
||
| 320 | * @param DavCard $davCard |
||
| 321 | * |
||
| 322 | * @return int |
||
| 323 | */ |
||
| 324 | private function getMemberType(DavCard $davCard): int { |
||
| 325 | foreach ($davCard->getEmails() as $email) { |
||
| 326 | try { |
||
| 327 | $davCard->setUserId($this->isLocalMember($email)); |
||
| 328 | |||
| 329 | return DavCard::TYPE_LOCAL; |
||
| 330 | } catch (NotLocalMemberException $e) { |
||
| 331 | } |
||
| 332 | } |
||
| 333 | |||
| 334 | $davCard->setUserId($davCard->getOwner() . ':' . $davCard->getContactId()); |
||
| 335 | |||
| 336 | return DavCard::TYPE_CONTACT; |
||
| 337 | } |
||
| 338 | |||
| 339 | |||
| 340 | /** |
||
| 341 | * @param string $email |
||
| 342 | * |
||
| 343 | * @return string |
||
| 344 | * @throws NotLocalMemberException |
||
| 345 | */ |
||
| 346 | private function isLocalMember(string $email): string { |
||
| 347 | if (strpos($email, '@') === false) { |
||
| 348 | throw new NotLocalMemberException(); |
||
| 349 | } |
||
| 350 | |||
| 351 | list ($username, $domain) = explode('@', $email); |
||
| 352 | if (in_array($domain, $this->configService->getAvailableHosts())) { |
||
| 353 | $user = $this->userManager->get($username); |
||
| 354 | if ($user !== null) { |
||
| 355 | return $user->getUID(); |
||
| 356 | } |
||
| 357 | } |
||
| 358 | |||
| 359 | throw new NotLocalMemberException(); |
||
| 360 | } |
||
| 361 | |||
| 362 | |||
| 363 | /** |
||
| 364 | * @param DavCard $davCard |
||
| 365 | */ |
||
| 366 | private function manageCircles(DavCard $davCard) { |
||
| 367 | $fromCard = $davCard->getGroups(); |
||
| 368 | $current = array_map( |
||
| 369 | function(Circle $circle) { |
||
| 370 | return $circle->getContactGroupName(); |
||
| 371 | }, $this->getCirclesFromBook($davCard->getAddressBookId()) |
||
| 372 | ); |
||
| 373 | |||
| 374 | $this->manageNewCircles($davCard, $fromCard, $current); |
||
| 375 | $this->manageDeprecatedCircles($davCard->getAddressBookId()); |
||
| 376 | |||
| 377 | $this->assignCirclesToCard($davCard); |
||
| 378 | } |
||
| 379 | |||
| 380 | |||
| 381 | /** |
||
| 382 | * @param DavCard $davCard |
||
| 383 | * @param array $fromCard |
||
| 384 | * @param array $current |
||
| 385 | */ |
||
| 386 | private function manageNewCircles(DavCard $davCard, array $fromCard, array $current) { |
||
| 387 | foreach ($fromCard as $group) { |
||
| 388 | if (in_array($group, $current)) { |
||
| 389 | continue; |
||
| 390 | } |
||
| 391 | |||
| 392 | $circle = new Circle(Circle::CIRCLES_PUBLIC, $group . ' - ' . $this->uuid(5)); |
||
| 393 | $circle->setContactAddressBook($davCard->getAddressBookId()); |
||
| 394 | $circle->setContactGroupName($group); |
||
| 395 | |||
| 396 | try { |
||
| 397 | $this->circlesRequest->createCircle($circle, $davCard->getOwner()); |
||
| 398 | $member = new Member($davCard->getOwner(), Member::TYPE_USER, $circle->getUniqueId()); |
||
| 399 | $member->setLevel(Member::LEVEL_OWNER); |
||
| 400 | $member->setStatus(Member::STATUS_MEMBER); |
||
| 401 | |||
| 402 | try { |
||
| 403 | $this->membersRequest->createMember($member); |
||
| 404 | } catch (MemberAlreadyExistsException $e) { |
||
| 405 | } |
||
| 406 | } catch (CircleAlreadyExistsException $e) { |
||
| 407 | } |
||
| 408 | |||
| 409 | } |
||
| 410 | } |
||
| 411 | |||
| 412 | |||
| 413 | /** |
||
| 414 | * @param DavCard $davCard |
||
| 415 | */ |
||
| 416 | private function assignCirclesToCard(DavCard $davCard) { |
||
| 417 | foreach ($davCard->getGroups() as $group) { |
||
| 418 | try { |
||
| 419 | $davCard->addCircle( |
||
| 420 | $this->circlesRequest->getFromContactGroup($davCard->getAddressBookId(), $group) |
||
| 421 | ); |
||
| 422 | } catch (CircleDoesNotExistException $e) { |
||
| 423 | } |
||
| 424 | } |
||
| 425 | } |
||
| 426 | |||
| 427 | |||
| 428 | /** |
||
| 429 | * @param int $addressBookId |
||
| 430 | * |
||
| 431 | * @return Circle[] |
||
| 432 | */ |
||
| 433 | private function getCirclesFromBook(int $addressBookId): array { |
||
| 434 | return $this->circlesRequest->getFromBook($addressBookId); |
||
| 435 | } |
||
| 436 | |||
| 437 | |||
| 438 | /** |
||
| 439 | * @param int $length |
||
| 440 | * |
||
| 441 | * @return string |
||
| 442 | * @deprecated |
||
| 443 | */ |
||
| 444 | protected function uuid(int $length = 0): string { |
||
| 445 | $uuid = sprintf( |
||
| 446 | '%04x%04x-%04x-%04x-%04x-%04x%04x%04x', mt_rand(0, 0xffff), mt_rand(0, 0xffff), |
||
| 447 | mt_rand(0, 0xffff), mt_rand(0, 0xfff) | 0x4000, mt_rand(0, 0x3fff) | 0x8000, |
||
| 448 | mt_rand(0, 0xffff), mt_rand(0, 0xffff), mt_rand(0, 0xffff) |
||
| 449 | ); |
||
| 450 | |||
| 451 | if ($length > 0) { |
||
| 452 | if ($length <= 16) { |
||
| 453 | $uuid = str_replace('-', '', $uuid); |
||
| 454 | } |
||
| 455 | |||
| 456 | $uuid = substr($uuid, 0, $length); |
||
| 457 | } |
||
| 458 | |||
| 459 | return $uuid; |
||
| 460 | } |
||
| 461 | |||
| 462 | |||
| 463 | /** |
||
| 464 | * @param int $bookId |
||
| 465 | * |
||
| 466 | * @return string |
||
| 467 | */ |
||
| 468 | private function getOwnerFromAddressBook(int $bookId): string { |
||
| 469 | $data = $this->cardDavBackend->getAddressBookById($bookId); |
||
| 470 | |||
| 471 | // let's assume the format is principals/users/OWNER |
||
| 472 | $owner = substr($data['principaluri'], 17); |
||
| 473 | |||
| 474 | return $owner; |
||
| 475 | } |
||
| 476 | |||
| 477 | |||
| 478 | /** |
||
| 479 | * |
||
| 480 | * @throws Exception |
||
| 481 | */ |
||
| 482 | public function migration() { |
||
| 483 | if ($this->configService->getAppValue(ConfigService::CIRCLES_CONTACT_BACKEND) !== '1') { |
||
| 484 | throw new Exception('Circles needs to be set as Contacts App Backend first'); |
||
| 485 | } |
||
| 486 | |||
| 487 | $this->manageDeprecatedContacts(); |
||
| 488 | $this->manageDeprecatedCircles(); |
||
| 489 | $users = $this->userManager->search(''); |
||
| 490 | foreach ($users as $user) { |
||
| 491 | $books = $this->cardDavBackend->getAddressBooksForUser('principals/users/' . $user->getUID()); |
||
| 492 | foreach ($books as $book) { |
||
| 493 | $this->migrateBook($book['id']); |
||
| 494 | } |
||
| 495 | } |
||
| 496 | } |
||
| 497 | |||
| 498 | |||
| 499 | /** |
||
| 500 | */ |
||
| 501 | private function manageDeprecatedContacts() { |
||
| 512 | |||
| 513 | |||
| 514 | /** |
||
| 515 | * @param int $bookId |
||
| 516 | */ |
||
| 517 | private function manageDeprecatedCircles(int $bookId = 0) { |
||
| 546 | |||
| 547 | |||
| 548 | /** |
||
| 549 | * @param int $bookId |
||
| 550 | * |
||
| 551 | * @return Circle[] |
||
| 552 | */ |
||
| 553 | private function getExistingCirclesFromBook(int $bookId): array { |
||
| 570 | |||
| 571 | |||
| 572 | /** |
||
| 573 | * @param Member $contact |
||
| 574 | * |
||
| 575 | * @return DavCard |
||
| 576 | * @throws MemberDoesNotExistException |
||
| 577 | */ |
||
| 578 | public function getDavCardFromMember(Member $contact): DavCard { |
||
| 579 | list($bookId, $cardUri) = explode('/', $contact->getContactId(), 2); |
||
| 580 | $cards = $this->cardDavBackend->getCards($bookId); |
||
| 581 | foreach ($cards as $card) { |
||
| 582 | if ($card['uri'] === $cardUri) { |
||
| 583 | return $this->generateDavCardFromCard($bookId, $card); |
||
| 584 | } |
||
| 585 | } |
||
| 586 | |||
| 587 | throw new MemberDoesNotExistException(); |
||
| 588 | } |
||
| 589 | |||
| 590 | |||
| 591 | /** |
||
| 592 | * @param int $bookId |
||
| 593 | */ |
||
| 594 | private function migrateBook(int $bookId) { |
||
| 613 | |||
| 614 | |||
| 615 | } |
||
| 616 | |||
| 617 | |||
| 618 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.