x Sorry, these patches are not available anymore due to data migration. Please run a fresh inspection.
Completed
Pull Request — master (#551)
by Maxence
02:37
created
lib/Model/Helpers/MemberHelper.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
 		try {
105 105
 			$level = Member::parseLevelString($levelString);
106 106
 		} catch (ParseMemberLevelException $e) {
107
-			throw new MemberHelperException('method ' . $levelString . ' not found');
107
+			throw new MemberHelperException('method '.$levelString.' not found');
108 108
 		}
109 109
 
110 110
 		$this->mustHaveLevelEqualOrAbove($level);
@@ -122,11 +122,11 @@  discard block
 block discarded – undo
122 122
 		try {
123 123
 			$level = Member::parseLevelString($levelString);
124 124
 		} catch (ParseMemberLevelException $e) {
125
-			throw new MemberHelperException('method ' . $levelString . ' not found');
125
+			throw new MemberHelperException('method '.$levelString.' not found');
126 126
 		}
127 127
 
128 128
 		if ($this->member->getLevel() >= $level) {
129
-			throw new MemberLevelException('Member cannot be ' . $levelString);
129
+			throw new MemberLevelException('Member cannot be '.$levelString);
130 130
 		}
131 131
 	}
132 132
 
Please login to merge, or discard this patch.
lib/Model/Membership.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -259,17 +259,17 @@
 block discarded – undo
259 259
 	 * @throws MembershipNotFoundException
260 260
 	 */
261 261
 	public function importFromDatabase(array $data, string $prefix = ''): INC22QueryRow {
262
-		if ($this->get($prefix . 'single_id', $data) === '') {
262
+		if ($this->get($prefix.'single_id', $data) === '') {
263 263
 			throw new MembershipNotFoundException();
264 264
 		}
265 265
 
266
-		$this->setSingleId($this->get($prefix . 'single_id', $data));
267
-		$this->setCircleId($this->get($prefix . 'circle_id', $data));
268
-		$this->setLevel($this->getInt($prefix . 'level', $data));
269
-		$this->setInheritanceFirst($this->get($prefix . 'inheritance_first', $data));
270
-		$this->setInheritanceLast($this->get($prefix . 'inheritance_last', $data));
271
-		$this->setInheritancePath($this->getArray($prefix . 'inheritance_path', $data));
272
-		$this->setInheritanceDepth($this->getInt($prefix . 'inheritance_depth', $data));
266
+		$this->setSingleId($this->get($prefix.'single_id', $data));
267
+		$this->setCircleId($this->get($prefix.'circle_id', $data));
268
+		$this->setLevel($this->getInt($prefix.'level', $data));
269
+		$this->setInheritanceFirst($this->get($prefix.'inheritance_first', $data));
270
+		$this->setInheritanceLast($this->get($prefix.'inheritance_last', $data));
271
+		$this->setInheritancePath($this->getArray($prefix.'inheritance_path', $data));
272
+		$this->setInheritanceDepth($this->getInt($prefix.'inheritance_depth', $data));
273 273
 
274 274
 		return $this;
275 275
 	}
Please login to merge, or discard this patch.
lib/ShareByCircleProviderDeprecated.php 2 patches
Indentation   -1 removed lines patch added patch discarded remove patch
@@ -494,7 +494,6 @@
 block discarded – undo
494 494
 
495 495
 	/**
496 496
 	 * Get shares for a given path
497
-
498 497
 	 * @param Node $path
499 498
 	 *
500 499
 	 * @return IShare[]|null
Please login to merge, or discard this patch.
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -331,19 +331,19 @@  discard block
 block discarded – undo
331 331
 	 */
332 332
 	private function createShare($share) {
333 333
 		$this->miscService->log(
334
-			'Creating share (1/4) - type: ' . $share->getShareType() . ' - token: '
335
-			. $share->getToken() . ' - type: ' . $share->getShareType() . ' - with: '
336
-			. $share->getSharedWith() . ' - permissions: ' . $share->getPermissions(), 0
334
+			'Creating share (1/4) - type: '.$share->getShareType().' - token: '
335
+			. $share->getToken().' - type: '.$share->getShareType().' - with: '
336
+			. $share->getSharedWith().' - permissions: '.$share->getPermissions(), 0
337 337
 		);
338 338
 
339 339
 		$qb = $this->getBaseInsertSql($share);
340
-		$this->miscService->log('Share creation (2/4) : ' . json_encode($qb->getSQL()), 0);
340
+		$this->miscService->log('Share creation (2/4) : '.json_encode($qb->getSQL()), 0);
341 341
 
342 342
 		$result = $qb->execute();
343
-		$this->miscService->log('Share creation result (3/4) : ' . json_encode($result), 0);
343
+		$this->miscService->log('Share creation result (3/4) : '.json_encode($result), 0);
344 344
 
345 345
 		$id = $qb->getLastInsertId();
346
-		$this->miscService->log('Share created ID (4/4) : ' . $id, 0);
346
+		$this->miscService->log('Share created ID (4/4) : '.$id, 0);
347 347
 
348 348
 		try {
349 349
 			$share->setId($id);
@@ -590,7 +590,7 @@  discard block
 block discarded – undo
590 590
 		\OC::$server->getLogger()->log(3, 'deprecated>getShareByToken');
591 591
 		$qb = $this->dbConnection->getQueryBuilder();
592 592
 
593
-		$this->miscService->log("Opening share by token '#" . $token . "'", 0);
593
+		$this->miscService->log("Opening share by token '#".$token."'", 0);
594 594
 
595 595
 		$cursor = $qb->select('*')
596 596
 					 ->from('share')
@@ -614,7 +614,7 @@  discard block
 block discarded – undo
614 614
 			try {
615 615
 				$data = $this->getShareByPersonalToken($token);
616 616
 			} catch (Exception $e) {
617
-				$this->miscService->log("Share '#" . $token . "' not found.", 0);
617
+				$this->miscService->log("Share '#".$token."' not found.", 0);
618 618
 				throw new ShareNotFound('Share not found', $this->l10n->t('Could not find share'));
619 619
 			}
620 620
 		}
@@ -623,7 +623,7 @@  discard block
 block discarded – undo
623 623
 			$share = $this->createShareObject($data);
624 624
 		} catch (InvalidShare $e) {
625 625
 			$this->miscService->log(
626
-				"Share Object '#" . $token . "' not created. " . json_encode($data), 0
626
+				"Share Object '#".$token."' not created. ".json_encode($data), 0
627 627
 			);
628 628
 			throw new ShareNotFound('Share not found', $this->l10n->t('Could not find share'));
629 629
 		}
Please login to merge, or discard this patch.
lib/Command/MembersLevel.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -125,7 +125,7 @@
 block discarded – undo
125 125
 		} catch (FederatedItemException $e) {
126 126
 			if ($input->getOption('status-code')) {
127 127
 				throw new FederatedItemException(
128
-					' [' . get_class($e) . ', ' . $e->getStatus() . ']' . "\n" . $e->getMessage()
128
+					' ['.get_class($e).', '.$e->getStatus().']'."\n".$e->getMessage()
129 129
 				);
130 130
 			}
131 131
 
Please login to merge, or discard this patch.
lib/Command/CirclesLeave.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -125,7 +125,7 @@
 block discarded – undo
125 125
 		} catch (FederatedItemException $e) {
126 126
 			if ($input->getOption('status-code')) {
127 127
 				throw new FederatedItemException(
128
-					' [' . get_class($e) . ', ' . $e->getStatus() . ']' . "\n" . $e->getMessage()
128
+					' ['.get_class($e).', '.$e->getStatus().']'."\n".$e->getMessage()
129 129
 				);
130 130
 			}
131 131
 
Please login to merge, or discard this patch.
lib/Command/CirclesDetails.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -125,7 +125,7 @@
 block discarded – undo
125 125
 		} catch (FederatedItemException $e) {
126 126
 			if ($input->getOption('status-code')) {
127 127
 				throw new FederatedItemException(
128
-					' [' . get_class($e) . ', ' . $e->getStatus() . ']' . "\n" . $e->getMessage()
128
+					' ['.get_class($e).', '.$e->getStatus().']'."\n".$e->getMessage()
129 129
 				);
130 130
 			}
131 131
 
Please login to merge, or discard this patch.
lib/Command/CirclesCreate.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -125,7 +125,7 @@
 block discarded – undo
125 125
 		} catch (FederatedItemException $e) {
126 126
 			if ($input->getOption('status-code')) {
127 127
 				throw new FederatedItemException(
128
-					' [' . get_class($e) . ', ' . $e->getStatus() . ']' . "\n" . $e->getMessage()
128
+					' ['.get_class($e).', '.$e->getStatus().']'."\n".$e->getMessage()
129 129
 				);
130 130
 			}
131 131
 
Please login to merge, or discard this patch.
lib/Command/CirclesJoin.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -125,7 +125,7 @@
 block discarded – undo
125 125
 		} catch (FederatedItemException $e) {
126 126
 			if ($input->getOption('status-code')) {
127 127
 				throw new FederatedItemException(
128
-					' [' . get_class($e) . ', ' . $e->getStatus() . ']' . "\n" . $e->getMessage()
128
+					' ['.get_class($e).', '.$e->getStatus().']'."\n".$e->getMessage()
129 129
 				);
130 130
 			}
131 131
 
Please login to merge, or discard this patch.
lib/Command/CirclesEdit.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -125,7 +125,7 @@
 block discarded – undo
125 125
 		} catch (FederatedItemException $e) {
126 126
 			if ($input->getOption('status-code')) {
127 127
 				throw new FederatedItemException(
128
-					' [' . get_class($e) . ', ' . $e->getStatus() . ']' . "\n" . $e->getMessage()
128
+					' ['.get_class($e).', '.$e->getStatus().']'."\n".$e->getMessage()
129 129
 				);
130 130
 			}
131 131
 
Please login to merge, or discard this patch.