nextcloud / circles

lib/Listeners/GroupChanged.php

Spacing +1 added lines, -1 removed lines

@@ -41,7 +41,7 @@
 		$groupId = $event->getGroup()->getGID();
 
 		$circle = new Circle();
-		$circle->setName('group:' . $groupId)
+		$circle->setName('group:'.$groupId)
 			->setConfig(Circle::CFG_SYSTEM | Circle::CFG_NO_OWNER | Circle::CFG_HIDDEN)
 			->setSource(Member::TYPE_GROUP);
 

lib/Tools/Db/ExtendedQueryBuilder.php

Spacing +30 added lines, -30 removed lines

@@ -195,7 +195,7 @@ 
 	 */
 	public function limitToCreation(int $delay = 0): self {
 		$date = new DateTime('now');
-		$date->sub(new DateInterval('PT' . ((string)$delay) . 'M'));
+		$date->sub(new DateInterval('PT'.((string)$delay).'M'));
 
 		$this->limitToDBFieldDateTime('creation', $date, true);
 
@@ -212,7 +212,7 @@ 
 		$expr = $this->expr();
 		$pf = ($this->getType() === DBALQueryBuilder::SELECT) ? $this->getDefaultSelectAlias()
 																. '.' : '';
-		$field = $pf . $field;
+		$field = $pf.$field;
 
 		$orX = [$expr->lte($field, $this->createNamedParameter($date, IQueryBuilder::PARAM_DATE))];
 
@@ -239,8 +239,8 @@ 
 		}
 
 		$expr = $this->expr();
-		$pf = ($this->getType() === DBALQueryBuilder::SELECT) ? $this->getDefaultSelectAlias() . '.' : '';
-		$field = $pf . $field;
+		$pf = ($this->getType() === DBALQueryBuilder::SELECT) ? $this->getDefaultSelectAlias().'.' : '';
+		$field = $pf.$field;
 
 		$this->andWhere($expr->gte($field, $this->createNamedParameter($dTime, IQueryBuilder::PARAM_DATE)));
 	}
@@ -253,8 +253,8 @@ 
 	public function searchInDBField(string $field, string $value): void {
 		$expr = $this->expr();
 
-		$pf = ($this->getType() === DBALQueryBuilder::SELECT) ? $this->getDefaultSelectAlias() . '.' : '';
-		$field = $pf . $field;
+		$pf = ($this->getType() === DBALQueryBuilder::SELECT) ? $this->getDefaultSelectAlias().'.' : '';
+		$field = $pf.$field;
 
 		$this->andWhere($expr->iLike($field, $this->createNamedParameter($value)));
 	}
@@ -377,7 +377,7 @@ 
 	 */
 	public function exprLike(string $field, string $value, string $alias = '', bool $cs = true): string {
 		if ($this->getType() === DBALQueryBuilder::SELECT) {
-			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias) . '.' . $field;
+			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias).'.'.$field;
 		}
 
 		$expr = $this->expr();
@@ -390,7 +390,7 @@ 
 
 	public function exprLimit(string $field, string $value, string $alias = '', bool $cs = true): string {
 		if ($this->getType() === DBALQueryBuilder::SELECT) {
-			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias) . '.' . $field;
+			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias).'.'.$field;
 		}
 
 		$expr = $this->expr();
@@ -408,7 +408,7 @@ 
 
 	public function exprLimitInt(string $field, int $value, string $alias = ''): string {
 		if ($this->getType() === DBALQueryBuilder::SELECT) {
-			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias) . '.' . $field;
+			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias).'.'.$field;
 		}
 
 		$expr = $this->expr();
@@ -426,7 +426,7 @@ 
 	 */
 	public function exprLimitBool(string $field, bool $value, string $alias = ''): string {
 		if ($this->getType() === DBALQueryBuilder::SELECT) {
-			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias) . '.' . $field;
+			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias).'.'.$field;
 		}
 
 		$expr = $this->expr();
@@ -447,7 +447,7 @@ 
 		string $alias = '',
 	): ICompositeExpression {
 		if ($this->getType() === DBALQueryBuilder::SELECT) {
-			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias) . '.' . $field;
+			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias).'.'.$field;
 		}
 
 		$expr = $this->expr();
@@ -472,7 +472,7 @@ 
 		string $alias = '',
 	): ICompositeExpression {
 		if ($this->getType() === DBALQueryBuilder::SELECT) {
-			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias) . '.' . $field;
+			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias).'.'.$field;
 		}
 
 		$expr = $this->expr();
@@ -526,7 +526,7 @@ 
 		int $type = IQueryBuilder::PARAM_STR_ARRAY,
 	): string {
 		if ($this->getType() === DBALQueryBuilder::SELECT) {
-			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias) . '.' . $field;
+			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias).'.'.$field;
 		}
 
 		$expr = $this->expr();
@@ -543,7 +543,7 @@ 
 	 */
 	public function exprLimitBitwise(string $field, int $flag, string $alias = ''): string {
 		if ($this->getType() === DBALQueryBuilder::SELECT) {
-			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias) . '.' . $field;
+			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias).'.'.$field;
 		}
 
 		$expr = $this->expr();
@@ -565,7 +565,7 @@ 
 	 */
 	public function exprLt(string $field, int $value, bool $lte = false, string $alias = ''): string {
 		if ($this->getType() === DBALQueryBuilder::SELECT) {
-			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias) . '.' . $field;
+			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias).'.'.$field;
 		}
 
 		$expr = $this->expr();
@@ -587,7 +587,7 @@ 
 	 */
 	public function exprGt(string $field, int $value, bool $gte = false, string $alias = ''): string {
 		if ($this->getType() === DBALQueryBuilder::SELECT) {
-			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias) . '.' . $field;
+			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias).'.'.$field;
 		}
 
 		$expr = $this->expr();
@@ -696,7 +696,7 @@ 
 	 */
 	public function exprUnlike(string $field, string $value, string $alias = '', bool $cs = true): string {
 		if ($this->getType() === DBALQueryBuilder::SELECT) {
-			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias) . '.' . $field;
+			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias).'.'.$field;
 		}
 
 		$expr = $this->expr();
@@ -720,7 +720,7 @@ 
 	 */
 	public function exprFilter(string $field, string $value, string $alias = '', bool $cs = true): string {
 		if ($this->getType() === DBALQueryBuilder::SELECT) {
-			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias) . '.' . $field;
+			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias).'.'.$field;
 		}
 
 		$expr = $this->expr();
@@ -746,7 +746,7 @@ 
 	 */
 	public function exprFilterInt(string $field, int $value, string $alias = ''): string {
 		if ($this->getType() === DBALQueryBuilder::SELECT) {
-			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias) . '.' . $field;
+			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias).'.'.$field;
 		}
 
 		$expr = $this->expr();
@@ -764,7 +764,7 @@ 
 	 */
 	public function exprFilterBool(string $field, bool $value, string $alias = ''): string {
 		if ($this->getType() === DBALQueryBuilder::SELECT) {
-			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias) . '.' . $field;
+			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias).'.'.$field;
 		}
 
 		$expr = $this->expr();
@@ -785,7 +785,7 @@ 
 		string $alias = '',
 	): ICompositeExpression {
 		if ($this->getType() === DBALQueryBuilder::SELECT) {
-			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias) . '.' . $field;
+			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias).'.'.$field;
 		}
 
 		$expr = $this->expr();
@@ -810,7 +810,7 @@ 
 		string $alias = '',
 	): ICompositeExpression {
 		if ($this->getType() === DBALQueryBuilder::SELECT) {
-			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias) . '.' . $field;
+			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias).'.'.$field;
 		}
 
 		$expr = $this->expr();
@@ -838,7 +838,7 @@ 
 		bool $cs = true,
 	): ICompositeExpression {
 		if ($this->getType() === DBALQueryBuilder::SELECT) {
-			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias) . '.' . $field;
+			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias).'.'.$field;
 		}
 
 		$orX = [];
@@ -863,7 +863,7 @@ 
 	 */
 	public function exprFilterInArray(string $field, array $values, string $alias = ''): string {
 		if ($this->getType() === DBALQueryBuilder::SELECT) {
-			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias) . '.' . $field;
+			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias).'.'.$field;
 		}
 
 		$expr = $this->expr();
@@ -881,7 +881,7 @@ 
 	 */
 	public function exprFilterBitwise(string $field, int $flag, string $alias = ''): string {
 		if ($this->getType() === DBALQueryBuilder::SELECT) {
-			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias) . '.' . $field;
+			$field = (($alias === '') ? $this->getDefaultSelectAlias() : $alias).'.'.$field;
 		}
 
 		$expr = $this->expr();
@@ -1042,12 +1042,12 @@ 
 		string $alias = '',
 	): self {
 		$selectFields = array_map(
-			function (string $item) use ($alias) {
+			function(string $item) use ($alias) {
 				if ($alias === '') {
 					return $item;
 				}
 
-				return $alias . '.' . $item;
+				return $alias.'.'.$item;
 			}, $fields
 		);
 
@@ -1073,13 +1073,13 @@ 
 		string $prefix,
 		array $default = [],
 	): self {
-		$prefix = trim($prefix) . '_';
+		$prefix = trim($prefix).'_';
 		foreach ($default as $k => $v) {
-			$this->addDefaultValue($prefix . $k, (string)$v);
+			$this->addDefaultValue($prefix.$k, (string)$v);
 		}
 
 		foreach ($fields as $field) {
-			$this->selectAlias($alias . '.' . $field, $prefix . $field);
+			$this->selectAlias($alias.'.'.$field, $prefix.$field);
 		}
 
 		return $this;

lib/Service/SyncService.php

Spacing +4 added lines, -4 removed lines

@@ -226,7 +226,7 @@ 
 	 * @throws SingleCircleNotFoundException
 	 */
 	public function syncNextcloudUser(string $userId): FederatedUser {
-		$this->outputService->output('Syncing Nextcloud Account \'' . $userId . '\'', true);
+		$this->outputService->output('Syncing Nextcloud Account \''.$userId.'\'', true);
 
 		return $this->federatedUserService->getLocalFederatedUser($userId, false, true);
 	}
@@ -270,12 +270,12 @@ 
 	 * @throws RequestBuilderException
 	 */
 	public function syncNextcloudGroup(string $groupId): Circle {
-		$this->outputService->output('Syncing Nextcloud Group \'' . $groupId . '\'', true);
+		$this->outputService->output('Syncing Nextcloud Group \''.$groupId.'\'', true);
 
 		$circle = $this->federatedUserService->getGroupCircle($groupId);
 		$this->circleService->updateDisplayName($circle->getSingleId(), $this->groupManager->getDisplayName($groupId));
 
-		$members = array_map(function (Member $member): string {
+		$members = array_map(function(Member $member): string {
 			return $member->getSingleId();
 		}, $this->memberRequest->getMembers($circle->getSingleId()));
 
@@ -353,7 +353,7 @@ 
 	 */
 	public function groupDeleted(string $groupId): void {
 		$circle = new Circle();
-		$circle->setName('group:' . $groupId)
+		$circle->setName('group:'.$groupId)
 			->setConfig(Circle::CFG_SYSTEM | Circle::CFG_NO_OWNER | Circle::CFG_HIDDEN)
 			->setSource(Member::TYPE_GROUP);
 

lib/Command/MigrateCustomGroups.php

Spacing +10 added lines, -10 removed lines

@@ -78,15 +78,15 @@ 
 
 			$name = $rowCG['display_name'];
 			while (strlen($name) < 3) {
-				$name = '_' . $name;
+				$name = '_'.$name;
 			}
 
-			$this->output->writeln('+ New Team <info>' . $name . '</info>, owned by <info>' . $ownerId . '</info>');
+			$this->output->writeln('+ New Team <info>'.$name.'</info>, owned by <info>'.$ownerId.'</info>');
 
 			// based on owner's userid, we create federateduser and a new circle
 			$owner = $this->cachedFed($ownerId);
 			if ($owner === null) {
-				$this->output->writeln('<error>unknown user</error> ' . $ownerId);
+				$this->output->writeln('<error>unknown user</error> '.$ownerId);
 				continue;
 			}
 
@@ -95,7 +95,7 @@ 
 			try {
 				$circle = $this->circlesManager->createCircle($name);
 			} catch (\Exception $e) {
-				$this->output->writeln('<error>' . get_class($e) . ' ' . $e->getMessage() . '</error> with data ' . json_encode($rowCG));
+				$this->output->writeln('<error>'.get_class($e).' '.$e->getMessage().'</error> with data '.json_encode($rowCG));
 				$this->logger->log(2, 'error while creating circle', ['exception' => $e]);
 				$this->circlesManager->stopSession();
 				continue;
@@ -124,17 +124,17 @@ 
 
 					$fedUser = $this->cachedFed($userId);
 					if ($fedUser === null) {
-						$this->output->writeln('<error>unknown user</error> ' . $userId);
+						$this->output->writeln('<error>unknown user</error> '.$userId);
 						continue;
 					}
-					$this->output->writeln(' - new member <info>' . $userId . '</info>');
+					$this->output->writeln(' - new member <info>'.$userId.'</info>');
 
 					$member = $this->circlesManager->addMember($circle->getSingleId(), $fedUser);
 					if ($rowM['role'] === '1') {
 						$this->circlesManager->levelMember($member->getId(), Member::LEVEL_ADMIN);
 					}
 				} catch (\Exception $e) {
-					$this->output->writeln('<error>' . get_class($e) . ' ' . $e->getMessage() . '</error>');
+					$this->output->writeln('<error>'.get_class($e).' '.$e->getMessage().'</error>');
 					$this->logger->log(2, 'error while migrating custom group member', ['exception' => $e]);
 				}
 			}
@@ -170,7 +170,7 @@ 
 			->where($update->expr()->in('id', $update->createNamedParameter($shareIds, IQueryBuilder::PARAM_INT_ARRAY)));
 
 		$count = $update->executeStatement();
-		$this->output->writeln('> ' . ((string)$count) . ' shares updated');
+		$this->output->writeln('> '.((string)$count).' shares updated');
 
 		$this->fixShareChildren($shareIds, $memberIds);
 	}
@@ -186,7 +186,7 @@ 
 			try {
 				$this->fedList[$userId] = $this->circlesManager->getLocalFederatedUser($userId);
 			} catch (\Exception $e) {
-				$this->logger->warning('unknown local user ' . $userId, ['exception' => $e]);
+				$this->logger->warning('unknown local user '.$userId, ['exception' => $e]);
 				$this->fedList[$userId] = null;
 			}
 		}
@@ -220,7 +220,7 @@ 
 			$count += $update->executeStatement();
 		}
 
-		$this->output->writeln('> ' . ((string)$count) . ' children shares updated');
+		$this->output->writeln('> '.((string)$count).' children shares updated');
 	}
 
 

lib/Command/CirclesMaintenance.php

Spacing +6 added lines, -6 removed lines

@@ -91,7 +91,7 @@ 
 				'<error>WARNING! You are about to delete all data related to the Circles App!</error>'
 			);
 			$question = new ConfirmationQuestion(
-				'<comment>Do you really want to ' . $action . ' Circles ?</comment> (y/N) ', false,
+				'<comment>Do you really want to '.$action.' Circles ?</comment> (y/N) ', false,
 				'/^(y|Y)/i'
 			);
 
@@ -107,7 +107,7 @@ 
 			$output->writeln('<error>WARNING! This operation is not reversible.</error>');
 
 			$question = new Question(
-				'<comment>Please confirm this destructive operation by typing \'' . $action
+				'<comment>Please confirm this destructive operation by typing \''.$action
 				. '\'</comment>: ', ''
 			);
 
@@ -125,7 +125,7 @@ 
 				$this->coreRequestBuilder->uninstall();
 			}
 
-			$output->writeln('<info>' . $action . ' done</info>');
+			$output->writeln('<info>'.$action.' done</info>');
 
 			return 0;
 		}
@@ -138,7 +138,7 @@ 
 				$this->maintenanceService->runMaintenance($i, $input->getOption('force-refresh'));
 			} catch (MaintenanceException $e) {
 				$this->logger->warning('issue while performing maintenance', ['level' => $i, ['exception' => $e]]);
-				$output->writeln('- <error>issue while performing maintenance</error> ' . $e->getMessage() . ' (more details in logs)');
+				$output->writeln('- <error>issue while performing maintenance</error> '.$e->getMessage().' (more details in logs)');
 			}
 		}
 
@@ -158,7 +158,7 @@ 
 		$federatedUser = $this->federatedUserService->getLocalFederatedUser($userId);
 		$displayName = $this->maintenanceService->updateDisplayName($federatedUser);
 		if ($displayName !== '') {
-			$output->writeln('Display name of ' . $federatedUser->getSingleId() . ' updated to ' . $displayName);
+			$output->writeln('Display name of '.$federatedUser->getSingleId().' updated to '.$displayName);
 		}
 
 		return 0;
@@ -173,7 +173,7 @@ 
 			try {
 				$this->refreshSingleDisplayName($row['uid'], $output);
 			} catch (Exception $e) {
-				$output->writeln(get_class($e) . ' while trying to update display name of ' . $row['uid']);
+				$output->writeln(get_class($e).' while trying to update display name of '.$row['uid']);
 			}
 		}
 	}

lib/Model/ShareWrapper.php

Spacing +19 added lines, -19 removed lines

@@ -450,7 +450,7 @@ 
 			$l10n = \OCP\Server::get(IFactory::class)->get('circles');
 			$display = $l10n->t('%s (Team owned by %s)', [$display, $circle->getOwner()->getDisplayName()]);
 		} else {
-			$display .= ' (' . Circle::$DEF_SOURCE[$circle->getSource()] . ')';
+			$display .= ' ('.Circle::$DEF_SOURCE[$circle->getSource()].')';
 		}
 
 		$share->setSharedWithDisplayName($display);
@@ -540,22 +540,22 @@ 
 
 	public function importFromDatabase(array $data, string $prefix = ''): IQueryRow {
 		$shareTime = new DateTime();
-		$shareTime->setTimestamp($this->getInt($prefix . 'stime', $data));
-
-		$this->setId($this->get($prefix . 'id', $data))
-			->setShareType($this->getInt($prefix . 'share_type', $data))
-			->setPermissions($this->getInt($prefix . 'permissions', $data))
-			->setItemType($this->get($prefix . 'item_type', $data))
-			->setItemSource($this->getInt($prefix . 'item_source', $data))
-			->setItemTarget($this->get($prefix . 'item_target', $data))
-			->setFileSource($this->getInt($prefix . 'file_source', $data))
-			->setFileTarget($this->get($prefix . 'file_target', $data))
-			->setSharedWith($this->get($prefix . 'share_with', $data))
-			->setSharedBy($this->get($prefix . 'uid_initiator', $data))
-			->setShareOwner($this->get($prefix . 'uid_owner', $data))
-			->setToken($this->get($prefix . 'token', $data))
+		$shareTime->setTimestamp($this->getInt($prefix.'stime', $data));
+
+		$this->setId($this->get($prefix.'id', $data))
+			->setShareType($this->getInt($prefix.'share_type', $data))
+			->setPermissions($this->getInt($prefix.'permissions', $data))
+			->setItemType($this->get($prefix.'item_type', $data))
+			->setItemSource($this->getInt($prefix.'item_source', $data))
+			->setItemTarget($this->get($prefix.'item_target', $data))
+			->setFileSource($this->getInt($prefix.'file_source', $data))
+			->setFileTarget($this->get($prefix.'file_target', $data))
+			->setSharedWith($this->get($prefix.'share_with', $data))
+			->setSharedBy($this->get($prefix.'uid_initiator', $data))
+			->setShareOwner($this->get($prefix.'uid_owner', $data))
+			->setToken($this->get($prefix.'token', $data))
 			->setShareTime($shareTime)
-			->setShareNote($this->get($prefix . 'note', $data));
+			->setShareNote($this->get($prefix.'note', $data));
 
 		$this->importAttributesFromDatabase($this->get('attributes', $data));
 
@@ -565,9 +565,9 @@ 
 		//			$share->setPassword($this->get('password', $data, ''));
 		//		}
 
-		$this->setChildId($this->getInt($prefix . 'child_id', $data))
-			->setChildFileTarget($this->get($prefix . 'child_file_target', $data))
-			->setChildPermissions($this->getInt($prefix . 'child_permissions', $data))
+		$this->setChildId($this->getInt($prefix.'child_id', $data))
+			->setChildFileTarget($this->get($prefix.'child_file_target', $data))
+			->setChildPermissions($this->getInt($prefix.'child_permissions', $data))
 			->setProviderId(ShareByCircleProvider::IDENTIFIER)
 			->setStatus(Ishare::STATUS_ACCEPTED);