Issues (51)

Security Analysis    no request data  

This project does not seem to handle request data directly as such no vulnerable execution paths were found.

  Cross-Site Scripting
Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.
  File Exposure
File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.
  File Manipulation
File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.
  Object Injection
Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.
  Code Injection
Code Injection enables an attacker to execute arbitrary code on the server.
  Response Splitting
Response Splitting can be used to send arbitrary responses.
  File Inclusion
File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.
  Command Injection
Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.
  SQL Injection
SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.
  XPath Injection
XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.
  LDAP Injection
LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.
  Header Injection
  Other Vulnerability
This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.
  Regex Injection
Regex Injection enables an attacker to execute arbitrary code in your PHP process.
  XML Injection
XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.
  Variable Injection
Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.
Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

controller/proxycontroller.php (2 issues)

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

1
<?php
2
/**
3
 * ownCloud - Calendar App
4
 *
5
 * @author Georg Ehrke
6
 * @copyright 2016 Georg Ehrke <[email protected]>
7
 *
8
 * This library is free software; you can redistribute it and/or
9
 * modify it under the terms of the GNU AFFERO GENERAL PUBLIC LICENSE
10
 * License as published by the Free Software Foundation; either
11
 * version 3 of the License, or any later version.
12
 *
13
 * This library is distributed in the hope that it will be useful,
14
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
16
 * GNU AFFERO GENERAL PUBLIC LICENSE for more details.
17
 *
18
 * You should have received a copy of the GNU Affero General Public
19
 * License along with this library.  If not, see <http://www.gnu.org/licenses/>.
20
 *
21
 */
22
namespace OCA\Calendar\Controller;
23
24
use GuzzleHttp\Exception\RequestException;
25
use GuzzleHttp\Exception\ClientException;
26
use GuzzleHttp\Exception\ConnectException;
27
28
use OCP\AppFramework\Http;
29
use OCP\AppFramework\Http\JSONResponse;
30
use OCP\AppFramework\Http\DataDisplayResponse;
31
use OCP\AppFramework\Controller;
32
use OCP\Http\Client\IClientService;
33
use OCP\IConfig;
34
use OCP\IL10N;
35
use OCP\ILogger;
36
use OCP\IRequest;
37
use Sabre\VObject\Reader;
38
39
class ProxyController extends Controller {
40
41
	/**
42
	 * @var IClientService
43
	 */
44
	protected $client;
45
46
	/**
47
	 * @var IL10N
48
	 */
49
	protected $l10n;
50
51
	/**
52
	 * @var ILogger
53
	 */
54
	protected $logger;
55
56
	/**
57
	 * @var IConfig
58
	 */
59
	protected $config;
60
61
	/**
62 10
	 * @param string $appName
63
	 * @param IRequest $request an instance of the request
64
	 * @param IClientService $client
65 10
	 * @param IL10N $l10n
66 10
	 * @param ILogger $logger
67 10
	 * @param IConfig $config
68 10
	 */
69 10
	public function __construct($appName, IRequest $request,
70
								IClientService $client,
71
								IL10N $l10n, ILogger $logger,
72
								IConfig $config) {
73
		parent::__construct($appName, $request);
74
		$this->client = $client;
75
		$this->l10n = $l10n;
76
		$this->logger = $logger;
77 10
		$this->config = $config;
78 10
	}
79
80 10
	/**
81 10
	 * @NoAdminRequired
82 10
	 *
83 10
	 * @param $url
84 10
	 * @return DataDisplayResponse|JSONResponse
85
	 */
86
	public function proxy($url) {
87
		$client = $this->client->newClient();
88 10
		try {
89 10
			$queryUrl = $url;
90
			$allow_redirects = false; // try to handle redirects manually at first
91
			$redirect_count = 0;
92 6
			$max_redirects = 5;
93 6
			$done = false;
94 4
95 4
			$allowLocalAccess = $this->config->getAppValue('dav', 'webcalAllowLocalAccess', 'no');
96 5
			if ($allowLocalAccess !== 'yes') {
97 2
				$host = strtolower(parse_url($url, PHP_URL_HOST));
98
				// remove brackets from IPv6 addresses
99
				if (strpos($host, '[') === 0 && substr($host, -1) === ']') {
100 1
					$host = substr($host, 1, -1);
101
				}
102
103
				// Disallow localhost and local network
104
				if ($host === 'localhost' || substr($host, -6) === '.local' || substr($host, -10) === '.localhost') {
105
					$this->logger->warning("ProxyController: Subscription $url was not refreshed because it violates local access rules");
106 1
107
					$response = new JSONResponse([
108
						'message' => $this->l10n->t('URL violates local access rules'),
109
						'proxy_code' => 403
110 4
					], Http::STATUS_UNPROCESSABLE_ENTITY);
111
112 6
					return $response;
113
				}
114 6
115 3
				// Disallow hostname only
116 3
				if (substr_count($host, '.') === 0) {
117 3
					$this->logger->warning("ProxyController: Subscription $url was not refreshed because it violates local access rules");
118 3
119 3
					$response = new JSONResponse([
120 2
						'message' => $this->l10n->t('URL violates local access rules'),
121
						'proxy_code' => 403
122
					], Http::STATUS_UNPROCESSABLE_ENTITY);
123 2
124
					return $response;
125
				}
126
127
				if ((bool)filter_var($host, FILTER_VALIDATE_IP) && !filter_var($host, FILTER_VALIDATE_IP, FILTER_FLAG_NO_PRIV_RANGE | FILTER_FLAG_NO_RES_RANGE)) {
128
					$this->logger->warning("ProxyController: Subscription $url was not refreshed because it violates local access rules");
129
130
					$response = new JSONResponse([
131
						'message' => $this->l10n->t('URL violates local access rules'),
132
						'proxy_code' => 403
133 2
					], Http::STATUS_UNPROCESSABLE_ENTITY);
134 2
135 2
					return $response;
136
				}
137
			}
138 1
139 1
			// try to find a chain of 301s
140
			do {
141 6
				$clientResponse = $client->get($queryUrl, [
142
					'allow_redirects' => $allow_redirects,
143 4
				]);
144 1
145 1
				$statusCode = $clientResponse->getStatusCode();
146
				if ($statusCode === 301) { // 400+ goes straight to catch
147 1
					$redirect_count++;
148 1
					$queryUrl = $clientResponse->getHeader('Location');
149 1
				} elseif ($statusCode >= 300) {
150 1
					if ($redirect_count > 0) {
151
						// $redirect_count > 0 => There have been 301s before,
152 1
						// break and return Location from last 301
153 1
						break;
154 3
					} else {
155 1
						// this is the very first request
156 1
						// it's being redirected, but the redirection is not
157 1
						// permanently, just let Guzzle take care
158
						$allow_redirects = [
159 1
							'max' => $max_redirects
160 2
						];
161 2
					}
162
				} else {
163 2
					$done = true;
164 1
				}
165
			} while(!$done && $redirect_count <= $max_redirects);
166 1
167
			if ($redirect_count > 0 && $redirect_count <= $max_redirects) {
168
				$response = new JSONResponse([
169 2
					'proxy_code' => -4,
170 2
					'new_url' => $queryUrl,
171
				], Http::STATUS_BAD_REQUEST);
172 2
			} elseif ($done) {
173
				$icsData = $clientResponse->getBody();
174
175 10
				try {
176
					Reader::read($icsData, Reader::OPTION_FORGIVING);
177
				} catch(\Exception $ex) {
178
					$response = new JSONResponse([
179
						'message' => $this->l10n->t('The remote server did not give us access to the calendar (HTTP 404 error)'),
180
						'proxy_code' => 404
181
					], Http::STATUS_UNPROCESSABLE_ENTITY);
182
183
					return $response;
184
				}
185
186
				$response = new DataDisplayResponse($icsData, 200);
187
				$response->setHeaders([
188
					'Content-Type' => 'text/calendar',
189
				]);
190
			} else {
191
				$response = new JSONResponse([
192
					'message' => $this->l10n->t('Too many redirects. Aborting ...'),
193
					'proxy_code' => -3
194
				], Http::STATUS_UNPROCESSABLE_ENTITY);
195
			}
196
		} catch (ClientException $e) {
197
			$error_code = $e->getResponse()->getStatusCode();
198
			$message = $e->getMessage();
199
200
			$this->logger->debug($message);
201
			$response = new JSONResponse([
202
				'message' => $this->l10n->t('The remote server did not give us access to the calendar (HTTP {%s} error)', [
203
					(string) $error_code
204
				]),
205
				'proxy_code' => $error_code
206
			], Http::STATUS_UNPROCESSABLE_ENTITY);
207
		} catch (ConnectException $e) {
0 ignored issues
show
The class GuzzleHttp\Exception\ConnectException does not exist. Did you forget a USE statement, or did you not list all dependencies?

Scrutinizer analyzes your composer.json/composer.lock file if available to determine the classes, and functions that are defined by your dependencies.

It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis.

Loading history...
208
			$this->logger->debug($e->getMessage());
209
			$response = new JSONResponse([
210
				'message' => $this->l10n->t('Error connecting to remote server'),
211
				'proxy_code' => -1
212
			], Http::STATUS_UNPROCESSABLE_ENTITY);
213
		} catch (RequestException $e) {
0 ignored issues
show
The class GuzzleHttp\Exception\RequestException does not exist. Did you forget a USE statement, or did you not list all dependencies?

Scrutinizer analyzes your composer.json/composer.lock file if available to determine the classes, and functions that are defined by your dependencies.

It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis.

Loading history...
214
			$this->logger->debug($e->getMessage());
215
216
			if (substr($url, 0, 8) === 'https://') {
217
				$message = $this->l10n->t('Error requesting resource on remote server. This could possible be related to a certificate mismatch');
218
			} else {
219
				$message = $this->l10n->t('Error requesting resource on remote server');
220
			}
221
222
			$response = new JSONResponse([
223
				'message' => $message,
224
				'proxy_code' => -2,
225
			], Http::STATUS_UNPROCESSABLE_ENTITY);
226
		}
227
228
		return $response;
229
	}
230
}
231