Application::__construct() - Code Metrics - Inspection of "Federated calendar sharing" - nextcloud/calendar - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#878)

by Björn

created 2018-08-01 15:02 UTC

Application::__construct() B

↳ Parent: Application

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	16
Ratio	20.51 %

Importance

Changes

Metric	Value
dl	16
loc	78
rs	8.48
c	0
b	0
f	0
cc	1
nc	1
nop	1

How to fix Long Method

<?php
/**
 * Calendar App
 *
 * @author Georg Ehrke
 * @copyright 2017 Georg Ehrke <[email protected]>
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU AFFERO GENERAL PUBLIC LICENSE
 * License as published by the Free Software Foundation; either
 * version 3 of the License, or any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU AFFERO GENERAL PUBLIC LICENSE for more details.
 *
 * You should have received a copy of the GNU Affero General Public
 * License along with this library.  If not, see <http://www.gnu.org/licenses/>.
 *
 */
namespace OCA\Calendar\AppInfo;

use OCA\Calendar\CloudFederationProviderCalendar;
use OCA\Calendar\Controller;

use OCP\AppFramework\App;
use OCP\AppFramework\IAppContainer;

class Application extends App {

	/**
	 * @param array $params
	 */
	public function __construct($params=[]) {
		parent::__construct('calendar', $params);
		$container = $this->getContainer();

		$container->registerService('ContactController', function(IAppContainer $c) {
			$request = $c->query('Request');
			$contacts = $c->getServer()->getContactsManager();

			return new Controller\ContactController($c->getAppName(), $request, $contacts);
		});

		$container->registerService('EmailController', function(IAppContainer $c) {
			$request = $c->query('Request');
			$userSession = $c->getServer()->getUserSession();
			$config = $c->getServer()->getConfig();
			$mailer = $c->getServer()->getMailer();
			$l10n = $c->getServer()->getL10N($c->query('AppName'));
			$defaults = new \OCP\Defaults();

			return new Controller\EmailController($c->getAppName(), $request, $userSession, $config, $mailer, $l10n, $defaults);
		});

		$container->registerService('FederationController', function(IAppContainer $c) {
			$request = $c->query('Request');
			$server = $c->getServer();

			return new Controller\FederationController(
				$c->getAppName(),
				$request,
				$server->getCloudIdManager(),
				$server->getCloudFederationProviderManager(),
				$server->getCloudFederationFactory(),
				$server->getSecureRandom(),
				$server->getUserSession()
			);
		});


		$container->registerService('ProxyController', function(IAppContainer $c) {

			$request = $c->query('Request');
			$client = $c->getServer()->getHTTPClientService();
			$l10n = $c->getServer()->getL10N($c->query('AppName'));
			$logger = $c->getServer()->getLogger();

			return new Controller\ProxyController($c->getAppName(), $request, $client, $l10n, $logger);
		});

		$container->registerService('SettingsController', function(IAppContainer $c) {
			$request = $c->query('Request');
			$config = $c->getServer()->getConfig();
			$userSession = $c->getServer()->getUserSession();

			return new Controller\SettingsController($c->getAppName(), $request, $userSession, $config);
		});

		$container->registerService('TimezoneController', function(IAppContainer $c) {
			$request = $c->query('Request');

			return new Controller\TimezoneController($c->getAppName(), $request);
		});

		$container->registerService('ViewController', function(IAppContainer $c) {

			$request = $c->query('Request');
			$userSession = $c->getServer()->getUserSession();
			$config = $c->getServer()->getConfig();
			$urlGenerator = $c->getServer()->getURLGenerator();

			return new Controller\ViewController($c->getAppName(), $request, $userSession, $config, $urlGenerator);
		});

		$cloudFederationManager = $container->getServer()->getCloudFederationProviderManager();
		$cloudFederationManager->addCloudFederationProvider('calendar',
			'Federated calendar Sharing',
			function() {
				return new CloudFederationProviderCalendar();
			});

	}

	/**
	 * register navigation entry
	 */
	public function registerNavigation() {
		$appName = $this->getContainer()->getAppName();
		$server = $this->getContainer()->getServer();

		$server->getNavigationManager()->add(function() use ($appName, $server) {
			return [
				'id' => $appName,
				'order' => 5,
				'href' => $server->getURLGenerator()
					->linkToRoute('calendar.view.index'),
				'icon' => $server->getURLGenerator()
					->imagePath($appName, 'calendar.svg'),
				'name' => $server->getL10N($appName)->t('Calendar'),
			];
		});
	}
}


1		<?php
2		/**
3		* Calendar App
4		*
5		* @author Georg Ehrke
6		* @copyright 2017 Georg Ehrke <[email protected]>
7		*
8		* This library is free software; you can redistribute it and/or
9		* modify it under the terms of the GNU AFFERO GENERAL PUBLIC LICENSE
10		* License as published by the Free Software Foundation; either
11		* version 3 of the License, or any later version.
12		*
13		* This library is distributed in the hope that it will be useful,
14		* but WITHOUT ANY WARRANTY; without even the implied warranty of
15		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16		* GNU AFFERO GENERAL PUBLIC LICENSE for more details.
17		*
18		* You should have received a copy of the GNU Affero General Public
19		* License along with this library. If not, see <http://www.gnu.org/licenses/>.
20		*
21		*/
22		namespace OCA\Calendar\AppInfo;
23
24		use OCA\Calendar\CloudFederationProviderCalendar;
25		use OCA\Calendar\Controller;
26
27		use OCP\AppFramework\App;
28		use OCP\AppFramework\IAppContainer;
29
30		class Application extends App {
31
32		/**
33		* @param array $params
34		*/
35		public function __construct($params=[]) {
36		parent::__construct('calendar', $params);
37		$container = $this->getContainer();
38
39		$container->registerService('ContactController', function(IAppContainer $c) {
40		$request = $c->query('Request');
41		$contacts = $c->getServer()->getContactsManager();
42
43		return new Controller\ContactController($c->getAppName(), $request, $contacts);
44		});
45
46		$container->registerService('EmailController', function(IAppContainer $c) {
47		$request = $c->query('Request');
48		$userSession = $c->getServer()->getUserSession();
49		$config = $c->getServer()->getConfig();
50		$mailer = $c->getServer()->getMailer();
51		$l10n = $c->getServer()->getL10N($c->query('AppName'));
52		$defaults = new \OCP\Defaults();
53
54		return new Controller\EmailController($c->getAppName(), $request, $userSession, $config, $mailer, $l10n, $defaults);
55		});
56
57		$container->registerService('FederationController', function(IAppContainer $c) {
58		$request = $c->query('Request');
59		$server = $c->getServer();
60
61		return new Controller\FederationController(
62		$c->getAppName(),
63		$request,
64		$server->getCloudIdManager(),
65		$server->getCloudFederationProviderManager(),
66		$server->getCloudFederationFactory(),
67		$server->getSecureRandom(),
68		$server->getUserSession()
69		);
70		});
71
72
73	View Code Duplication	$container->registerService('ProxyController', function(IAppContainer $c) {
		0 ignored issues – show Duplication introduced 2017-01-20 10:29 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
74		$request = $c->query('Request');
75		$client = $c->getServer()->getHTTPClientService();
76		$l10n = $c->getServer()->getL10N($c->query('AppName'));
77		$logger = $c->getServer()->getLogger();
78
79		return new Controller\ProxyController($c->getAppName(), $request, $client, $l10n, $logger);
80		});
81
82		$container->registerService('SettingsController', function(IAppContainer $c) {
83		$request = $c->query('Request');
84		$config = $c->getServer()->getConfig();
85		$userSession = $c->getServer()->getUserSession();
86
87		return new Controller\SettingsController($c->getAppName(), $request, $userSession, $config);
88		});
89
90		$container->registerService('TimezoneController', function(IAppContainer $c) {
91		$request = $c->query('Request');
92
93		return new Controller\TimezoneController($c->getAppName(), $request);
94		});
95
96	View Code Duplication	$container->registerService('ViewController', function(IAppContainer $c) {
		0 ignored issues – show Duplication introduced 2016-09-17 12:37 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
97		$request = $c->query('Request');
98		$userSession = $c->getServer()->getUserSession();
99		$config = $c->getServer()->getConfig();
100		$urlGenerator = $c->getServer()->getURLGenerator();
101
102		return new Controller\ViewController($c->getAppName(), $request, $userSession, $config, $urlGenerator);
103		});
104
105		$cloudFederationManager = $container->getServer()->getCloudFederationProviderManager();
106		$cloudFederationManager->addCloudFederationProvider('calendar',
107		'Federated calendar Sharing',
108		function() {
109		return new CloudFederationProviderCalendar();
110		});
111
112		}
113
114		/**
115		* register navigation entry
116		*/
117		public function registerNavigation() {
118		$appName = $this->getContainer()->getAppName();
119		$server = $this->getContainer()->getServer();
120
121		$server->getNavigationManager()->add(function() use ($appName, $server) {
122		return [
123		'id' => $appName,
124		'order' => 5,
125		'href' => $server->getURLGenerator()
126		->linkToRoute('calendar.view.index'),
127		'icon' => $server->getURLGenerator()
128		->imagePath($appName, 'calendar.svg'),
129		'name' => $server->getL10N($appName)->t('Calendar'),
130		];
131		});
132		}
133		}
134

nextcloud / calendar

Pull Request — master (#878)

Application::__construct() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like