Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 30 | class Manager { |
||
| 31 | |||
| 32 | /** @var IDBConnection */ |
||
| 33 | private $connection; |
||
| 34 | |||
| 35 | /** @var IGroupManager */ |
||
| 36 | private $groupManager; |
||
| 37 | |||
| 38 | |||
| 39 | /** @var IUserSession */ |
||
| 40 | private $userSession; |
||
| 41 | |||
| 42 | /** |
||
| 43 | * @param IDBConnection $connection |
||
| 44 | * @param IGroupManager $groupManager |
||
| 45 | * @param IUserSession $userSession |
||
| 46 | */ |
||
| 47 | 10 | public function __construct(IDBConnection $connection, IGroupManager $groupManager, IUserSession $userSession) { |
|
| 52 | |||
| 53 | /** |
||
| 54 | * @param string $subject |
||
| 55 | * @param string $message |
||
| 56 | * @param string $user |
||
| 57 | * @param int $time |
||
| 58 | * @param string[] $groups |
||
| 59 | * @return array |
||
| 60 | * @throws \InvalidArgumentException when the subject is empty or invalid |
||
| 61 | */ |
||
| 62 | 6 | public function announce($subject, $message, $user, $time, array $groups) { |
|
| 63 | 6 | $subject = trim($subject); |
|
| 64 | 6 | $message = trim($message); |
|
| 65 | 6 | if (isset($subject[512])) { |
|
| 66 | 1 | throw new \InvalidArgumentException('Invalid subject', 1); |
|
| 67 | } |
||
| 68 | |||
| 69 | 5 | if ($subject === '') { |
|
| 70 | 1 | throw new \InvalidArgumentException('Invalid subject', 2); |
|
| 71 | } |
||
| 72 | |||
| 73 | 4 | $queryBuilder = $this->connection->getQueryBuilder(); |
|
| 74 | 4 | $queryBuilder->insert('announcements') |
|
| 75 | 4 | ->values([ |
|
| 76 | 4 | 'announcement_time' => $queryBuilder->createParameter('time'), |
|
| 77 | 4 | 'announcement_user' => $queryBuilder->createParameter('user'), |
|
| 78 | 4 | 'announcement_subject' => $queryBuilder->createParameter('subject'), |
|
| 79 | 4 | 'announcement_message' => $queryBuilder->createParameter('message'), |
|
| 80 | 4 | ]) |
|
| 81 | 4 | ->setParameter('time', $time) |
|
| 82 | 4 | ->setParameter('user', $user) |
|
| 83 | 4 | ->setParameter('subject', $subject) |
|
| 84 | 4 | ->setParameter('message', $message); |
|
| 85 | 4 | $queryBuilder->execute(); |
|
| 86 | |||
| 87 | 4 | $queryBuilder = $this->connection->getQueryBuilder(); |
|
| 88 | 4 | $query = $queryBuilder->select('*') |
|
| 89 | 4 | ->from('announcements') |
|
| 90 | 4 | ->where($queryBuilder->expr()->eq('announcement_time', $queryBuilder->createParameter('time'))) |
|
| 91 | 4 | ->andWhere($queryBuilder->expr()->eq('announcement_user', $queryBuilder->createParameter('user'))) |
|
| 92 | 4 | ->orderBy('announcement_id', 'DESC') |
|
| 93 | 4 | ->setParameter('time', (int) $time) |
|
| 94 | 4 | ->setParameter('user', $user); |
|
| 95 | 4 | $result = $query->execute(); |
|
| 96 | 4 | $row = $result->fetch(); |
|
| 97 | 4 | $result->closeCursor(); |
|
| 98 | |||
| 99 | 4 | $addedGroups = 0; |
|
| 100 | 4 | foreach ($groups as $group) { |
|
| 101 | 4 | if ($this->groupManager->groupExists($group)) { |
|
| 102 | 3 | $this->addGroupLink((int) $row['announcement_id'], $group); |
|
| 103 | 3 | $addedGroups++; |
|
| 104 | 3 | } |
|
| 105 | 4 | } |
|
| 106 | |||
| 107 | 4 | if ($addedGroups === 0) { |
|
| 108 | 3 | $this->addGroupLink((int) $row['announcement_id'], 'everyone'); |
|
| 109 | 3 | } |
|
| 110 | |||
| 111 | return [ |
||
| 112 | 4 | 'id' => (int) $row['announcement_id'], |
|
| 113 | 4 | 'author' => $row['announcement_user'], |
|
| 114 | 4 | 'time' => (int) $row['announcement_time'], |
|
| 115 | 4 | 'subject' => $this->parseSubject($row['announcement_subject']), |
|
| 116 | 4 | 'message' => $this->parseMessage($row['announcement_message']), |
|
| 117 | 4 | ]; |
|
| 118 | } |
||
| 119 | |||
| 120 | /** |
||
| 121 | * @param int $announcementId |
||
| 122 | * @param string $group |
||
| 123 | */ |
||
| 124 | 4 | protected function addGroupLink($announcementId, $group) { |
|
| 133 | |||
| 134 | /** |
||
| 135 | * @param int $id |
||
| 136 | */ |
||
| 137 | 3 | public function delete($id) { |
|
| 148 | |||
| 149 | /** |
||
| 150 | * @param int $id |
||
| 151 | * @param bool $parseStrings |
||
| 152 | * @param bool $ignorePermissions |
||
| 153 | * @return array |
||
| 154 | * @throws \InvalidArgumentException when the id is invalid |
||
| 155 | */ |
||
| 156 | 3 | public function getAnnouncement($id, $parseStrings = true, $ignorePermissions = false) { |
|
| 157 | 3 | if (!$ignorePermissions) { |
|
| 158 | 3 | $user = $this->userSession->getUser(); |
|
| 159 | 3 | View Code Duplication | if ($user instanceof IUser) { |
| 160 | 1 | $groups = $this->groupManager->getUserGroupIds($user); |
|
| 161 | 1 | $groups[] = 'everyone'; |
|
| 162 | 1 | } else { |
|
| 163 | 2 | $groups = ['everyone']; |
|
| 164 | } |
||
| 165 | |||
| 166 | 3 | if (!in_array('admin', $groups)) { |
|
| 167 | 3 | $query = $this->connection->getQueryBuilder(); |
|
| 168 | 3 | $query->select('*') |
|
| 169 | 3 | ->from('announcements_groups') |
|
| 170 | 3 | ->where($query->expr()->eq('announcement_id', $query->createNamedParameter((int) $id))) |
|
| 171 | 3 | ->andWhere($query->expr()->in('gid', $query->createNamedParameter($groups, IQueryBuilder::PARAM_STR_ARRAY))) |
|
| 172 | 3 | ->setMaxResults(1); |
|
| 173 | 3 | $result = $query->execute(); |
|
| 174 | 3 | $entry = $result->fetch(); |
|
| 175 | 3 | $result->closeCursor(); |
|
| 176 | |||
| 177 | 3 | if (!$entry) { |
|
| 178 | 2 | throw new \InvalidArgumentException('Invalid ID'); |
|
| 179 | } |
||
| 180 | 2 | } |
|
| 181 | 2 | } |
|
| 182 | |||
| 183 | 2 | $queryBuilder = $this->connection->getQueryBuilder(); |
|
| 184 | 2 | $query = $queryBuilder->select('*') |
|
| 185 | 2 | ->from('announcements') |
|
| 186 | 2 | ->where($queryBuilder->expr()->eq('announcement_id', $queryBuilder->createParameter('id'))) |
|
| 187 | 2 | ->setParameter('id', (int) $id); |
|
| 188 | 2 | $result = $query->execute(); |
|
| 189 | 2 | $row = $result->fetch(); |
|
| 190 | 2 | $result->closeCursor(); |
|
| 191 | |||
| 192 | 2 | if ($row === false) { |
|
| 193 | 1 | throw new \InvalidArgumentException('Invalid ID'); |
|
| 194 | } |
||
| 195 | |||
| 196 | return [ |
||
| 197 | 2 | 'id' => (int) $row['announcement_id'], |
|
| 198 | 2 | 'author' => $row['announcement_user'], |
|
| 199 | 2 | 'time' => (int) $row['announcement_time'], |
|
| 200 | 2 | 'subject' => ($parseStrings) ? $this->parseSubject($row['announcement_subject']) : $row['announcement_subject'], |
|
| 201 | 2 | 'message' => ($parseStrings) ? $this->parseMessage($row['announcement_message']) : $row['announcement_message'], |
|
| 202 | 2 | ]; |
|
| 203 | } |
||
| 204 | |||
| 205 | /** |
||
| 206 | * @param int $limit |
||
| 207 | * @param int $offset |
||
| 208 | * @param bool $parseStrings |
||
| 209 | * @return array |
||
| 210 | */ |
||
| 211 | 2 | public function getAnnouncements($limit = 15, $offset = 0, $parseStrings = true) { |
|
| 212 | 2 | $query = $this->connection->getQueryBuilder(); |
|
| 213 | 2 | $query->select('a.*') |
|
| 214 | 2 | ->from('announcements', 'a') |
|
| 215 | 2 | ->orderBy('a.announcement_time', 'DESC') |
|
| 216 | 2 | ->groupBy('a.announcement_id') |
|
| 217 | 2 | ->setMaxResults($limit); |
|
| 218 | |||
| 219 | 2 | $user = $this->userSession->getUser(); |
|
| 220 | 2 | View Code Duplication | if ($user instanceof IUser) { |
| 221 | 1 | $groups = $this->groupManager->getUserGroupIds($user); |
|
| 222 | 1 | $groups[] = 'everyone'; |
|
| 223 | 1 | } else { |
|
| 224 | 1 | $groups = ['everyone']; |
|
| 225 | } |
||
| 226 | |||
| 227 | 2 | if (!in_array('admin', $groups)) { |
|
| 228 | 2 | $query->leftJoin('a', 'announcements_groups', 'ag', $query->expr()->eq( |
|
| 229 | 2 | 'a.announcement_id', 'ag.announcement_id' |
|
| 230 | 2 | )) |
|
| 231 | 2 | ->andWhere($query->expr()->in('ag.gid', $query->createNamedParameter($groups, IQueryBuilder::PARAM_STR_ARRAY))); |
|
| 232 | 2 | } |
|
| 233 | |||
| 234 | 2 | if ($offset > 0) { |
|
| 235 | $query->andWhere($query->expr()->lt('a.announcement_id', $query->createNamedParameter($offset, IQueryBuilder::PARAM_INT))); |
||
| 236 | } |
||
| 237 | |||
| 238 | 2 | $result = $query->execute(); |
|
| 239 | |||
| 240 | |||
| 241 | 2 | $announcements = []; |
|
| 242 | 2 | while ($row = $result->fetch()) { |
|
| 243 | 2 | $announcements[] = [ |
|
| 244 | 2 | 'id' => (int) $row['announcement_id'], |
|
| 245 | 2 | 'author' => $row['announcement_user'], |
|
| 246 | 2 | 'time' => (int) $row['announcement_time'], |
|
| 247 | 2 | 'subject' => ($parseStrings) ? $this->parseSubject($row['announcement_subject']) : $row['announcement_subject'], |
|
| 248 | 2 | 'message' => ($parseStrings) ? $this->parseMessage($row['announcement_message']) : $row['announcement_message'], |
|
| 249 | ]; |
||
| 250 | 2 | } |
|
| 251 | 2 | $result->closeCursor(); |
|
| 252 | |||
| 253 | |||
| 254 | 2 | return $announcements; |
|
| 255 | } |
||
| 256 | |||
| 257 | /** |
||
| 258 | * Return the groups (or string everyone) which have access to the announcement |
||
| 259 | * |
||
| 260 | * @param int $id |
||
| 261 | * @return string[] |
||
| 262 | */ |
||
| 263 | 3 | public function getGroups($id) { |
|
| 278 | |||
| 279 | /** |
||
| 280 | * @param string $message |
||
| 281 | * @return string |
||
| 282 | */ |
||
| 283 | 4 | protected function parseMessage($message) { |
|
| 286 | |||
| 287 | /** |
||
| 288 | * @param string $subject |
||
| 289 | * @return string |
||
| 290 | */ |
||
| 291 | 4 | protected function parseSubject($subject) { |
|
| 294 | } |
||
| 295 |
This error could be the result of:
1. Missing dependencies
PHP Analyzer uses your
composer.jsonfile (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects thecomposer.jsonto be in the root folder of your repository.Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the
requireorrequire-devsection?2. Missing use statement
PHP does not complain about undefined classes in
ìnstanceofchecks. For example, the following PHP code will work perfectly fine:If you have not tested against this specific condition, such errors might go unnoticed.