nextcloud /
announcementcenter
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like Manager often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Manager, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 37 | class Manager { |
||
| 38 | |||
| 39 | /** @var IConfig */ |
||
| 40 | protected $config; |
||
| 41 | |||
| 42 | /** @var IDBConnection */ |
||
| 43 | protected $connection; |
||
| 44 | |||
| 45 | /** @var IGroupManager */ |
||
| 46 | protected $groupManager; |
||
| 47 | |||
| 48 | /** @var INotificationManager */ |
||
| 49 | protected $notificationManager; |
||
| 50 | |||
| 51 | /** @var ICommentsManager */ |
||
| 52 | protected $commentsManager; |
||
| 53 | |||
| 54 | /** @var IJobList */ |
||
| 55 | protected $jobList; |
||
| 56 | |||
| 57 | /** @var IUserSession */ |
||
| 58 | protected $userSession; |
||
| 59 | |||
| 60 | 21 | public function __construct(IConfig $config, |
|
| 75 | |||
| 76 | /** |
||
| 77 | * @param string $subject |
||
| 78 | * @param string $message |
||
| 79 | * @param string $user |
||
| 80 | * @param int $time |
||
| 81 | * @param string[] $groups |
||
| 82 | * @param bool $comments |
||
| 83 | * @return array |
||
| 84 | * @throws \InvalidArgumentException when the subject is empty or invalid |
||
| 85 | */ |
||
| 86 | 7 | public function announce(string $subject, string $message, string $user, int $time, array $groups, bool$comments): array { |
|
| 124 | |||
| 125 | 5 | protected function addGroupLink(int $announcementId, string $group) { |
|
| 134 | |||
| 135 | 5 | public function delete(int $id) { |
|
| 155 | |||
| 156 | /** |
||
| 157 | * @param int $id |
||
| 158 | * @param bool $parseStrings |
||
| 159 | * @param bool $ignorePermissions |
||
| 160 | * @param bool $returnGroups |
||
| 161 | * @return array |
||
| 162 | * @throws \InvalidArgumentException when the id is invalid |
||
| 163 | */ |
||
| 164 | 6 | public function getAnnouncement(int $id, bool $parseStrings = true, bool $ignorePermissions = false, bool $returnGroups = true): array { |
|
| 165 | 6 | if (!$ignorePermissions) { |
|
| 166 | 4 | $user = $this->userSession->getUser(); |
|
| 167 | 4 | View Code Duplication | if ($user instanceof IUser) { |
| 168 | 2 | $userGroups = $this->groupManager->getUserGroupIds($user); |
|
| 169 | 2 | $userGroups[] = 'everyone'; |
|
| 170 | } else { |
||
| 171 | 2 | $userGroups = ['everyone']; |
|
| 172 | } |
||
| 173 | 4 | $isInAdminGroups = array_intersect($this->getAdminGroups(), $userGroups); |
|
| 174 | |||
| 175 | 4 | if (empty($isInAdminGroups)) { |
|
| 176 | 3 | $query = $this->connection->getQueryBuilder(); |
|
| 177 | 3 | $query->select('*') |
|
| 178 | 3 | ->from('announcements_groups') |
|
| 179 | 3 | ->where($query->expr()->eq('announcement_id', $query->createNamedParameter((int) $id))) |
|
| 180 | 3 | ->andWhere($query->expr()->in('gid', $query->createNamedParameter($userGroups, IQueryBuilder::PARAM_STR_ARRAY))) |
|
| 181 | 3 | ->setMaxResults(1); |
|
| 182 | 3 | $result = $query->execute(); |
|
| 183 | 3 | $entry = $result->fetch(); |
|
| 184 | 3 | $result->closeCursor(); |
|
| 185 | |||
| 186 | 3 | if (!$entry) { |
|
| 187 | 3 | throw new \InvalidArgumentException('Invalid ID'); |
|
| 188 | } |
||
| 189 | } |
||
| 190 | } |
||
| 191 | |||
| 192 | 5 | $queryBuilder = $this->connection->getQueryBuilder(); |
|
| 193 | 5 | $query = $queryBuilder->select('*') |
|
| 194 | 5 | ->from('announcements') |
|
| 195 | 5 | ->where($queryBuilder->expr()->eq('announcement_id', $queryBuilder->createParameter('id'))) |
|
| 196 | 5 | ->setParameter('id', (int) $id); |
|
| 197 | 5 | $result = $query->execute(); |
|
| 198 | 5 | $row = $result->fetch(); |
|
| 199 | 5 | $result->closeCursor(); |
|
| 200 | |||
| 201 | 5 | if ($row === false) { |
|
| 202 | 3 | throw new \InvalidArgumentException('Invalid ID'); |
|
| 203 | } |
||
| 204 | |||
| 205 | 5 | $groups = null; |
|
| 206 | 5 | if ($returnGroups && ($ignorePermissions || !empty($isInAdminGroups))) { |
|
| 207 | 5 | $groups = $this->getGroups((int) $id); |
|
| 208 | } |
||
| 209 | |||
| 210 | $announcement = [ |
||
| 211 | 5 | 'id' => (int) $row['announcement_id'], |
|
| 212 | 5 | 'author' => $row['announcement_user'], |
|
| 213 | 5 | 'time' => (int) $row['announcement_time'], |
|
| 214 | 5 | 'subject' => $parseStrings ? $this->parseSubject($row['announcement_subject']) : $row['announcement_subject'], |
|
| 215 | 5 | 'message' => $row['announcement_message'], |
|
| 216 | 5 | 'groups' => $groups, |
|
| 217 | 5 | 'comments' => $row['allow_comments'] ? 0 : false, |
|
| 218 | ]; |
||
| 219 | |||
| 220 | 5 | if ($ignorePermissions || !empty($isInAdminGroups)) { |
|
| 221 | 5 | $announcement['notifications'] = $this->hasNotifications((int) $id); |
|
| 222 | } |
||
| 223 | |||
| 224 | 5 | return $announcement; |
|
| 225 | } |
||
| 226 | |||
| 227 | 3 | public function getAnnouncements(int $limit = 15, int $offset = 0, bool $parseStrings = true): array { |
|
| 228 | 3 | $query = $this->connection->getQueryBuilder(); |
|
| 229 | 3 | $query->select('a.announcement_id') |
|
| 230 | 3 | ->from('announcements', 'a') |
|
| 231 | 3 | ->orderBy('a.announcement_time', 'DESC') |
|
| 232 | 3 | ->groupBy('a.announcement_id') |
|
| 233 | 3 | ->setMaxResults($limit); |
|
| 234 | |||
| 235 | 3 | $user = $this->userSession->getUser(); |
|
| 236 | 3 | View Code Duplication | if ($user instanceof IUser) { |
| 237 | 2 | $userGroups = $this->groupManager->getUserGroupIds($user); |
|
| 238 | 2 | $userGroups[] = 'everyone'; |
|
| 239 | } else { |
||
| 240 | 1 | $userGroups = ['everyone']; |
|
| 241 | } |
||
| 242 | |||
| 243 | 3 | $isInAdminGroups = array_intersect($this->getAdminGroups(), $userGroups); |
|
| 244 | 3 | if (empty($isInAdminGroups)) { |
|
| 245 | 2 | $query->leftJoin('a', 'announcements_groups', 'ag', $query->expr()->eq( |
|
| 246 | 2 | 'a.announcement_id', 'ag.announcement_id' |
|
| 247 | )) |
||
| 248 | 2 | ->andWhere($query->expr()->in('ag.gid', $query->createNamedParameter($userGroups, IQueryBuilder::PARAM_STR_ARRAY))); |
|
| 249 | } |
||
| 250 | |||
| 251 | 3 | if ($offset > 0) { |
|
| 252 | 3 | $query->andWhere($query->expr()->lt('a.announcement_id', $query->createNamedParameter($offset, IQueryBuilder::PARAM_INT))); |
|
| 253 | } |
||
| 254 | |||
| 255 | 3 | $ids = []; |
|
| 256 | 3 | $result = $query->execute(); |
|
| 257 | 3 | while ($row = $result->fetch()) { |
|
| 258 | 3 | $ids[] = (int) $row['announcement_id']; |
|
| 259 | } |
||
| 260 | 3 | $result->closeCursor(); |
|
| 261 | |||
| 262 | 3 | if (empty($ids)) { |
|
| 263 | 3 | return []; |
|
| 264 | } |
||
| 265 | |||
| 266 | 3 | $query = $this->connection->getQueryBuilder(); |
|
| 267 | 3 | $query->select('*') |
|
| 268 | 3 | ->from('announcements') |
|
| 269 | 3 | ->orderBy('announcement_time', 'DESC') |
|
| 270 | 3 | ->where($query->expr()->in('announcement_id', $query->createNamedParameter($ids, IQueryBuilder::PARAM_INT_ARRAY))); |
|
| 271 | 3 | $result = $query->execute(); |
|
| 272 | |||
| 273 | 3 | $announcements = []; |
|
| 274 | 3 | while ($row = $result->fetch()) { |
|
| 275 | 3 | $id = (int) $row['announcement_id']; |
|
| 276 | 3 | $announcements[$id] = [ |
|
| 277 | 3 | 'id' => $id, |
|
| 278 | 3 | 'author' => $row['announcement_user'], |
|
| 279 | 3 | 'time' => (int) $row['announcement_time'], |
|
| 280 | 3 | 'subject' => $parseStrings ? $this->parseSubject($row['announcement_subject']) : $row['announcement_subject'], |
|
| 281 | 3 | 'message' => $row['announcement_message'], |
|
| 282 | 'groups' => null, |
||
| 283 | 3 | 'comments' => $row['allow_comments'] ? $this->getNumberOfComments($id) : false, |
|
| 284 | ]; |
||
| 285 | |||
| 286 | 3 | if (!empty($isInAdminGroups)) { |
|
| 287 | 1 | $announcements[$id]['notifications'] = $this->hasNotifications($id); |
|
| 288 | } |
||
| 289 | } |
||
| 290 | 3 | $result->closeCursor(); |
|
| 291 | |||
| 292 | 3 | if (!empty($isInAdminGroups)) { |
|
| 293 | 1 | $allGroups = $this->getGroups(array_keys($announcements)); |
|
| 294 | 1 | foreach ($allGroups as $id => $groups) { |
|
| 295 | 1 | $announcements[$id]['groups'] = $groups; |
|
| 296 | } |
||
| 297 | } |
||
| 298 | |||
| 299 | 3 | return $announcements; |
|
| 300 | } |
||
| 301 | |||
| 302 | /** |
||
| 303 | * Return the groups (or string everyone) which have access to the announcement(s) |
||
| 304 | * |
||
| 305 | * @param int|int[] $ids |
||
| 306 | * @return string[]|array[] |
||
| 307 | */ |
||
| 308 | 5 | public function getGroups($ids): array { |
|
| 332 | |||
| 333 | public function markNotificationRead(int $id) { |
||
| 344 | |||
| 345 | 2 | protected function getNumberOfComments(int $id): int { |
|
| 348 | |||
| 349 | 5 | protected function hasNotifications(int $id): bool { |
|
| 371 | |||
| 372 | public function removeNotifications(int $id) { |
||
| 403 | |||
| 404 | protected function parseMessage(string $message): string { |
||
| 405 | return str_replace(['<', '>', "\n"], ['<', '>', '<br />'], $message); |
||
| 406 | } |
||
| 407 | |||
| 408 | 5 | protected function parseSubject(string $subject): string { |
|
| 411 | |||
| 412 | /** |
||
| 413 | * Check if the user is in the admin group |
||
| 414 | */ |
||
| 415 | 6 | public function checkIsAdmin(): bool { |
|
| 429 | |||
| 430 | /** |
||
| 431 | * @return string[] |
||
| 432 | */ |
||
| 433 | 9 | protected function getAdminGroups(): array { |
|
| 438 | } |
||
| 439 |
Loading history...
This error could be the result of:
1. Missing dependencies
PHP Analyzer uses your
composer.jsonfile (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects thecomposer.jsonto be in the root folder of your repository.Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the
requireorrequire-devsection?2. Missing use statement
PHP does not complain about undefined classes in
ìnstanceofchecks. For example, the following PHP code will work perfectly fine:If you have not tested against this specific condition, such errors might go unnoticed.