Issues in CurrentUser.php (master) - Issues in master - nextcloud/activity - Measure and Improve Code Quality continuously with Scrutinizer

Issues (159)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

lib/CurrentUser.php (4 issues)

Labels

Severity

Major 4

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * @copyright Copyright (c) 2016 Joas Schilling <[email protected]>
 *
 * @license GNU AGPL version 3 or any later version
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as
 * published by the Free Software Foundation, either version 3 of the
 * License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 */

namespace OCA\Activity;


use OCP\IRequest;
use OCP\IUser;
use OCP\IUserSession;
use OCP\Share;
use OCP\Share\Exceptions\ShareNotFound;
use OCP\Share\IManager;

class CurrentUser {

	/** @var IUserSession */
	protected $userSession;
	/** @var IRequest */
	protected $request;
	/** @var IManager */
	protected $shareManager;

	/** @var string */
	protected $identifier;
	/** @var string|null */
	protected $cloudId;
	/** @var string|false|null */
	protected $sessionUser;

	/**
	 * @param IUserSession $userSession
	 * @param IRequest $request
	 * @param IManager $shareManager
	 */
	public function __construct(IUserSession $userSession, IRequest $request, IManager $shareManager) {
		$this->userSession = $userSession;
		$this->request = $request;
		$this->shareManager = $shareManager;
		$this->cloudId = false;

		$this->sessionUser = false;
	}

	/**
	 * Get an identifier for the user, session or token
	 * @return string
	 */
	public function getUserIdentifier() {
		if ($this->identifier === null) {
			$this->identifier = $this->getUID();

			if ($this->identifier === null) {
				$this->identifier = $this->getCloudIDFromToken();

				if ($this->identifier === null) {
					// Nothing worked, fallback to empty string
					$this->identifier = '';
				}
			}
		}

		return $this->identifier;
	}

	/**
	 * Get the current user from the session
	 * @return string|null
	 */
	public function getUID() {
		if ($this->sessionUser === false) {
			$user = $this->userSession->getUser();
			if ($user instanceof IUser) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
				$this->sessionUser = (string) $user->getUID();
			} else {
				$this->sessionUser = null;
			}
		}

		return $this->sessionUser;
	}

	/**
	 * Get the current user from the session
	 * @return string|null
	 */
	public function getCloudId() {
		if ($this->cloudId === false) {
			$user = $this->userSession->getUser();
			if ($user instanceof IUser) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
				$this->cloudId = (string) $user->getCloudId();
			} else {
				$this->cloudId = $this->getCloudIDFromToken();
			}
		}

		return $this->cloudId;
	}

	/**
	 * Get the cloud ID from the sharing token
	 * @return string|null
	 */
	protected function getCloudIDFromToken() {
		if (!empty($this->request->server['PHP_AUTH_USER'])) {
			$token = $this->request->server['PHP_AUTH_USER'];
			try {
				$share = $this->shareManager->getShareByToken($token);
				if ($share->getShareType() === Share::SHARE_TYPE_REMOTE) {
					return $share->getSharedWith();
				}
			} catch (ShareNotFound $e) {

				// No share, use the fallback
			}
		}

		return null;
	}
}


1		<?php
2		/**
3		* @copyright Copyright (c) 2016 Joas Schilling <[email protected]>
4		*
5		* @license GNU AGPL version 3 or any later version
6		*
7		* This program is free software: you can redistribute it and/or modify
8		* it under the terms of the GNU Affero General Public License as
9		* published by the Free Software Foundation, either version 3 of the
10		* License, or (at your option) any later version.
11		*
12		* This program is distributed in the hope that it will be useful,
13		* but WITHOUT ANY WARRANTY; without even the implied warranty of
14		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15		* GNU Affero General Public License for more details.
16		*
17		* You should have received a copy of the GNU Affero General Public License
18		* along with this program. If not, see <http://www.gnu.org/licenses/>.
19		*
20		*/
21
22		namespace OCA\Activity;
23
24
25		use OCP\IRequest;
26		use OCP\IUser;
27		use OCP\IUserSession;
28		use OCP\Share;
29		use OCP\Share\Exceptions\ShareNotFound;
30		use OCP\Share\IManager;
31
32		class CurrentUser {
33
34		/** @var IUserSession */
35		protected $userSession;
36		/** @var IRequest */
37		protected $request;
38		/** @var IManager */
39		protected $shareManager;
40
41		/** @var string */
42		protected $identifier;
43		/** @var string\|null */
44		protected $cloudId;
45		/** @var string\|false\|null */
46		protected $sessionUser;
47
48		/**
49		* @param IUserSession $userSession
50		* @param IRequest $request
51		* @param IManager $shareManager
52		*/
53	35	public function __construct(IUserSession $userSession, IRequest $request, IManager $shareManager) {
54	35	$this->userSession = $userSession;
55	35	$this->request = $request;
56	35	$this->shareManager = $shareManager;
57	35	$this->cloudId = false;
		0 ignored issues – show Documentation Bug introduced 2017-04-18 09:55 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `false` of type `false` is incompatible with the declared type `string\|null` of property `$cloudId`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
58	35	$this->sessionUser = false;
59	35	}
60
61		/**
62		* Get an identifier for the user, session or token
63		* @return string
64		*/
65	4	public function getUserIdentifier() {
66	4	if ($this->identifier === null) {
67	3	$this->identifier = $this->getUID();
68
69	3	if ($this->identifier === null) {
70	2	$this->identifier = $this->getCloudIDFromToken();
71
72	2	if ($this->identifier === null) {
73		// Nothing worked, fallback to empty string
74	1	$this->identifier = '';
75		}
76		}
77		}
78
79	4	return $this->identifier;
80		}
81
82		/**
83		* Get the current user from the session
84		* @return string\|null
85		*/
86	22	public function getUID() {
87	22	if ($this->sessionUser === false) {
88	22	$user = $this->userSession->getUser();
89	22	if ($user instanceof IUser) {
		0 ignored issues – show Bug introduced 2016-12-12 16:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this The class `OCP\IUser` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
90	2	$this->sessionUser = (string) $user->getUID();
91		} else {
92	20	$this->sessionUser = null;
93		}
94		}
95
96	22	return $this->sessionUser;
97		}
98
99		/**
100		* Get the current user from the session
101		* @return string\|null
102		*/
103		public function getCloudId() {
104		if ($this->cloudId === false) {
105		$user = $this->userSession->getUser();
106		if ($user instanceof IUser) {
		0 ignored issues – show Bug introduced 2017-04-18 09:55 UTC by Report Bug Copy Issue Report Show Similar Issues like this The class `OCP\IUser` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
107		$this->cloudId = (string) $user->getCloudId();
108		} else {
109		$this->cloudId = $this->getCloudIDFromToken();
110		}
111		}
112
113		return $this->cloudId;
114		}
115
116		/**
117		* Get the cloud ID from the sharing token
118		* @return string\|null
119		*/
120	4	protected function getCloudIDFromToken() {
121	4	if (!empty($this->request->server['PHP_AUTH_USER'])) {
122	3	$token = $this->request->server['PHP_AUTH_USER'];
123		try {
124	3	$share = $this->shareManager->getShareByToken($token);
125	2	if ($share->getShareType() === Share::SHARE_TYPE_REMOTE) {
126	2	return $share->getSharedWith();
127		}
128	1	} catch (ShareNotFound $e) {
		0 ignored issues – show Bug introduced 2016-12-12 16:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this The class `OCP\Share\Exceptions\ShareNotFound` does not exist. Did you forget a USE statement, or did you not list all dependencies? Scrutinizer analyzes your `composer.json`/`composer.lock` file if available to determine the classes, and functions that are defined by your dependencies. It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis. Loading history...
129		// No share, use the fallback
130		}
131		}
132
133	3	return null;
134		}
135		}
136

nextcloud / activity

Issues (159)

Security Analysis no request data

lib/CurrentUser.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

Duplication Side-by-Side

Filter issues like