Completed
Push — master ( 37428d...11fdad )
by Morris
71:17 queued 71:12
created

Data   B

Complexity

Total Complexity 44

Size/Duplication

Total Lines 356
Duplicated Lines 0 %

Coupling/Cohesion

Components 1
Dependencies 2

Test Coverage

Coverage 82.07%

Importance

Changes 0
Metric Value
wmc 44
lcom 1
cbo 2
dl 0
loc 356
ccs 151
cts 184
cp 0.8207
rs 8.3396
c 0
b 0
f 0

8 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 0 4 1
B send() 0 44 3
B storeMail() 0 30 3
F get() 0 109 20
B setOffsetFromSince() 0 48 6
A validateFilter() 0 17 4
A expire() 0 8 1
B deleteActivities() 0 16 6

How to fix   Complexity   

Complex Class

Complex classes like Data often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use Data, and based on these observations, apply Extract Interface, too.

1
<?php
2
/**
3
 * @copyright Copyright (c) 2016, ownCloud, Inc.
4
 *
5
 * @author Frank Karlitschek <[email protected]>
6
 * @author Joas Schilling <[email protected]>
7
 * @author Thomas Müller <[email protected]>
8
 *
9
 * @license AGPL-3.0
10
 *
11
 * This code is free software: you can redistribute it and/or modify
12
 * it under the terms of the GNU Affero General Public License, version 3,
13
 * as published by the Free Software Foundation.
14
 *
15
 * This program is distributed in the hope that it will be useful,
16
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
17
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
18
 * GNU Affero General Public License for more details.
19
 *
20
 * You should have received a copy of the GNU Affero General Public License, version 3,
21
 * along with this program.  If not, see <http://www.gnu.org/licenses/>
22
 *
23
 */
24
25
namespace OCA\Activity;
26
27
use OCP\Activity\IEvent;
28
use OCP\Activity\IExtension;
29
use OCP\Activity\IFilter;
30
use OCP\Activity\IManager;
31
use OCP\DB\QueryBuilder\IQueryBuilder;
32
use OCP\IDBConnection;
33
use OCP\IL10N;
34
35
/**
36
 * @brief Class for managing the data in the activities
37
 */
38
class Data {
39
	/** @var IManager */
40
	protected $activityManager;
41
42
	/** @var IDBConnection */
43
	protected $connection;
44
45
	/**
46
	 * @param IManager $activityManager
47
	 * @param IDBConnection $connection
48
	 */
49 40
	public function __construct(IManager $activityManager, IDBConnection $connection) {
50 40
		$this->activityManager = $activityManager;
51 40
		$this->connection = $connection;
52 40
	}
53
54
	/**
55
	 * Send an event into the activity stream
56
	 *
57
	 * @param IEvent $event
58
	 * @return bool
59
	 */
60 5
	public function send(IEvent $event) {
61 5
		if ($event->getAffectedUser() === '' || $event->getAffectedUser() === null) {
62 2
			return false;
63
		}
64
65
		// store in DB
66 3
		$queryBuilder = $this->connection->getQueryBuilder();
67 3
		$queryBuilder->insert('activity')
68 3
			->values([
69 3
				'app' => $queryBuilder->createParameter('app'),
70 3
				'subject' => $queryBuilder->createParameter('subject'),
71 3
				'subjectparams' => $queryBuilder->createParameter('subjectparams'),
72 3
				'message' => $queryBuilder->createParameter('message'),
73 3
				'messageparams' => $queryBuilder->createParameter('messageparams'),
74 3
				'file' => $queryBuilder->createParameter('object_name'),
75 3
				'link' => $queryBuilder->createParameter('link'),
76 3
				'user' => $queryBuilder->createParameter('user'),
77 3
				'affecteduser' => $queryBuilder->createParameter('affecteduser'),
78 3
				'timestamp' => $queryBuilder->createParameter('timestamp'),
79 3
				'priority' => $queryBuilder->createParameter('priority'),
80 3
				'type' => $queryBuilder->createParameter('type'),
81 3
				'object_type' => $queryBuilder->createParameter('object_type'),
82 3
				'object_id' => $queryBuilder->createParameter('object_id'),
83
			])
84 3
			->setParameters([
85 3
				'app' => $event->getApp(),
86 3
				'type' => $event->getType(),
87 3
				'affecteduser' => $event->getAffectedUser(),
88 3
				'user' => $event->getAuthor(),
89 3
				'timestamp' => (int) $event->getTimestamp(),
90 3
				'subject' => $event->getSubject(),
91 3
				'subjectparams' => json_encode($event->getSubjectParameters()),
92 3
				'message' => $event->getMessage(),
93 3
				'messageparams' => json_encode($event->getMessageParameters()),
94 3
				'priority' => IExtension::PRIORITY_MEDIUM,
95 3
				'object_type' => $event->getObjectType(),
96 3
				'object_id' => (int) $event->getObjectId(),
97 3
				'object_name' => $event->getObjectName(),
98 3
				'link' => $event->getLink(),
99
			])
100 3
			->execute();
101
102 3
		return true;
103
	}
104
105
	/**
106
	 * Send an event as email
107
	 *
108
	 * @param IEvent $event
109
	 * @param int    $latestSendTime Activity $timestamp + batch setting of $affectedUser
110
	 * @return bool
111
	 */
112 4
	public function storeMail(IEvent $event, $latestSendTime) {
113 4
		if ($event->getAffectedUser() === '' || $event->getAffectedUser() === null) {
114 2
			return false;
115
		}
116
117
		// store in DB
118 2
		$queryBuilder = $this->connection->getQueryBuilder();
119 2
		$queryBuilder->insert('activity_mq')
120 2
			->values([
121 2
				'amq_appid' => $queryBuilder->createParameter('app'),
122 2
				'amq_subject' => $queryBuilder->createParameter('subject'),
123 2
				'amq_subjectparams' => $queryBuilder->createParameter('subjectparams'),
124 2
				'amq_affecteduser' => $queryBuilder->createParameter('affecteduser'),
125 2
				'amq_timestamp' => $queryBuilder->createParameter('timestamp'),
126 2
				'amq_type' => $queryBuilder->createParameter('type'),
127 2
				'amq_latest_send' => $queryBuilder->createParameter('latest_send'),
128
			])
129 2
			->setParameters([
130 2
				'app' => $event->getApp(),
131 2
				'subject' => $event->getSubject(),
132 2
				'subjectparams' => json_encode($event->getSubjectParameters()),
133 2
				'affecteduser' => $event->getAffectedUser(),
134 2
				'timestamp' => (int) $event->getTimestamp(),
135 2
				'type' => $event->getType(),
136 2
				'latest_send' => $latestSendTime,
137
			])
138 2
			->execute();
139
140 2
		return true;
141
	}
142
143
	/**
144
	 * Read a list of events from the activity stream
145
	 *
146
	 * @param GroupHelper $groupHelper Allows activities to be grouped
147
	 * @param UserSettings $userSettings Gets the settings of the user
148
	 * @param string $user User for whom we display the stream
149
	 *
150
	 * @param int $since The integer ID of the last activity that has been seen.
151
	 * @param int $limit How many activities should be returned
152
	 * @param string $sort Should activities be given ascending or descending
153
	 *
154
	 * @param string $filter Filter the activities
155
	 * @param string $objectType Allows to filter the activities to a given object. May only appear together with $objectId
156
	 * @param int $objectId Allows to filter the activities to a given object. May only appear together with $objectType
157
	 *
158
	 * @return array
159
	 *
160
	 * @throws \OutOfBoundsException if the user (Code: 1) or the since (Code: 2) is invalid
161
	 * @throws \BadMethodCallException if the user has selected to display no types for this filter (Code: 3)
162
	 */
163 5
	public function get(GroupHelper $groupHelper, UserSettings $userSettings, $user, $since, $limit, $sort, $filter, $objectType = '', $objectId = 0) {
164
		// get current user
165 5
		if ($user === '') {
166
			throw new \OutOfBoundsException('Invalid user', 1);
167
		}
168 5
		$groupHelper->setUser($user);
169
170 5
		$activeFilter = null;
171
		try {
172 5
			$activeFilter = $this->activityManager->getFilterById($filter);
173 5
		} catch (\InvalidArgumentException $e) {
174
			// Unknown filter => ignore and show all activities
175
		}
176
177 5
		$enabledNotifications = $userSettings->getNotificationTypes($user, 'stream');
178 5
		if ($activeFilter instanceof IFilter) {
0 ignored issues
show
Bug introduced by
The class OCP\Activity\IFilter does not exist. Did you forget a USE statement, or did you not list all dependencies?

This error could be the result of:

1. Missing dependencies

PHP Analyzer uses your composer.json file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the composer.json to be in the root folder of your repository.

Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the require or require-dev section?

2. Missing use statement

PHP does not complain about undefined classes in ìnstanceof checks. For example, the following PHP code will work perfectly fine:

if ($x instanceof DoesNotExist) {
    // Do something.
}

If you have not tested against this specific condition, such errors might go unnoticed.

Loading history...
179
			$enabledNotifications = $activeFilter->filterTypes($enabledNotifications);
180
		}
181 5
		$enabledNotifications = array_unique($enabledNotifications);
182
183
		// We don't want to display any activities
184 5
		if (empty($enabledNotifications)) {
185
			throw new \BadMethodCallException('No settings enabled', 3);
186
		}
187
188 5
		$query = $this->connection->getQueryBuilder();
189 5
		$query->select('*')
190 5
			->from('activity');
191
192 5
		$query->where($query->expr()->eq('affecteduser', $query->createNamedParameter($user)))
193 5
			->andWhere($query->expr()->in('type', $query->createNamedParameter($enabledNotifications, IQueryBuilder::PARAM_STR_ARRAY)));
194 5
		if ($filter === 'self') {
195
			$query->andWhere($query->expr()->eq('user', $query->createNamedParameter($user)));
196
197 5
		} else if ($filter === 'by') {
198
			$query->andWhere($query->expr()->neq('user', $query->createNamedParameter($user)));
199
200 5
		} else if ($filter === 'all' && !$userSettings->getUserSetting($user, 'setting', 'self')) {
201
			$query->andWhere($query->expr()->orX(
202
				$query->expr()->neq('user', $query->createNamedParameter($user)),
203
				$query->expr()->notIn('type', $query->createNamedParameter([
204
					'file_created',
205
					'file_changed',
206
					'file_deleted',
207
					'file_restored',
208
				], IQueryBuilder::PARAM_STR_ARRAY))
209
			));
210
211 5
		} else if ($filter === 'filter') {
212
			if (!$userSettings->getUserSetting($user, 'setting', 'self')) {
213
				$query->andWhere($query->expr()->orX(
214
					$query->expr()->neq('user', $query->createNamedParameter($user)),
215
					$query->expr()->notIn('type', $query->createNamedParameter([
216
						'file_created',
217
						'file_changed',
218
						'file_deleted',
219
						'file_restored',
220
					], IQueryBuilder::PARAM_STR_ARRAY))
221
				));
222
			}
223
224
			$query->andWhere($query->expr()->eq('object_type', $query->createNamedParameter($objectType)));
225
			$query->andWhere($query->expr()->eq('object_id', $query->createNamedParameter($objectId)));
226
		}
227
228 5
		if ($activeFilter instanceof IFilter) {
0 ignored issues
show
Bug introduced by
The class OCP\Activity\IFilter does not exist. Did you forget a USE statement, or did you not list all dependencies?

This error could be the result of:

1. Missing dependencies

PHP Analyzer uses your composer.json file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the composer.json to be in the root folder of your repository.

Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the require or require-dev section?

2. Missing use statement

PHP does not complain about undefined classes in ìnstanceof checks. For example, the following PHP code will work perfectly fine:

if ($x instanceof DoesNotExist) {
    // Do something.
}

If you have not tested against this specific condition, such errors might go unnoticed.

Loading history...
229
			$apps = $activeFilter->allowedApps();
230
			if (!empty($apps)) {
231
				$query->andWhere($query->expr()->in('app', $query->createNamedParameter($apps, IQueryBuilder::PARAM_STR_ARRAY)));
232
			}
233
		}
234
235
		if (
236 5
			$filter === 'files_favorites' ||
237 5
			(in_array($filter, ['all', 'by', 'self']) && $userSettings->getUserSetting($user, 'stream', 'files_favorites'))
238
		) {
239
			try {
240
				$favoriteFilter = $this->activityManager->getFilterById('files_favorites');
241
				/** @var \OCA\Files\Activity\Filter\Favorites $favoriteFilter */
242
				$favoriteFilter->filterFavorites($query);
243
			} catch (\InvalidArgumentException $e) {
0 ignored issues
show
Coding Style Comprehensibility introduced by
Consider adding a comment why this CATCH block is empty.
Loading history...
244
			}
245
		}
246
247
		/**
248
		 * Order and specify the offset
249
		 */
250 5
		$sqlSort = ($sort === 'asc') ? 'ASC' : 'DESC';
251 5
		$headers = $this->setOffsetFromSince($query, $user, $since, $sqlSort);
252 5
		$query->orderBy('timestamp', $sqlSort)
253 5
			->addOrderBy('activity_id', $sqlSort);
254
255 5
		$query->setMaxResults($limit + 1);
256
257 5
		$result = $query->execute();
258 5
		$hasMore = false;
259 5
		while ($row = $result->fetch()) {
260 4
			if ($limit === 0) {
261 2
				$hasMore = true;
262 2
				break;
263
			}
264 4
			$headers['X-Activity-Last-Given'] = (int) $row['activity_id'];
265 4
			$groupHelper->addActivity($row);
266 4
			$limit--;
267
		}
268 5
		$result->closeCursor();
269
270 5
		return ['data' => $groupHelper->getActivities(), 'has_more' => $hasMore, 'headers' => $headers];
271
	}
272
273
	/**
274
	 * @param IQueryBuilder $query
275
	 * @param string $user
276
	 * @param int $since
277
	 * @param string $sort
278
	 *
279
	 * @return array Headers that should be set on the response
280
	 *
281
	 * @throws \OutOfBoundsException If $since is not owned by $user
282
	 */
283 10
	protected function setOffsetFromSince(IQueryBuilder $query, $user, $since, $sort) {
284 10
		if ($since) {
285 5
			$queryBuilder = $this->connection->getQueryBuilder();
286 5
			$queryBuilder->select(['affecteduser', 'timestamp'])
287 5
				->from('activity')
288 5
				->where($queryBuilder->expr()->eq('activity_id', $queryBuilder->createNamedParameter((int) $since)));
289 5
			$result = $queryBuilder->execute();
290 5
			$activity = $result->fetch();
291 5
			$result->closeCursor();
292
293 5
			if ($activity) {
294 4
				if ($activity['affecteduser'] !== $user) {
295 1
					throw new \OutOfBoundsException('Invalid since', 2);
296
				}
297 3
				$timestamp = (int) $activity['timestamp'];
298
299 3
				if ($sort === 'DESC') {
300 2
					$query->andWhere($query->expr()->lte('timestamp', $query->createNamedParameter($timestamp)));
301 2
					$query->andWhere($query->expr()->lt('activity_id', $query->createNamedParameter($since)));
302
				} else {
303 1
					$query->andWhere($query->expr()->gte('timestamp', $query->createNamedParameter($timestamp)));
304 1
					$query->andWhere($query->expr()->gt('activity_id', $query->createNamedParameter($since)));
305
				}
306 3
				return [];
307
			}
308
		}
309
310
		/**
311
		 * Couldn't find the since, so find the oldest one and set the header
312
		 */
313 6
		$fetchQuery = $this->connection->getQueryBuilder();
314 6
		$fetchQuery->select('activity_id')
315 6
			->from('activity')
316 6
			->where($fetchQuery->expr()->eq('affecteduser', $fetchQuery->createNamedParameter($user)))
317 6
			->orderBy('timestamp', $sort)
318 6
			->setMaxResults(1);
319 6
		$result = $fetchQuery->execute();
320 6
		$activity = $result->fetch();
321 6
		$result->closeCursor();
322
323 6
		if ($activity !== false) {
324
			return [
325 4
				'X-Activity-First-Known' => (int) $activity['activity_id'],
326
			];
327
		}
328
329 2
		return [];
330
	}
331
332
	/**
333
	 * Verify that the filter is valid
334
	 *
335
	 * @param string $filterValue
336
	 * @return string
337
	 */
338
	public function validateFilter($filterValue) {
339
		if (!isset($filterValue)) {
340
			return 'all';
341
		}
342
343
		switch ($filterValue) {
344
			case 'filter':
345
				return $filterValue;
346
			default:
347
				try {
348
					$this->activityManager->getFilterById($filterValue);
349
					return $filterValue;
350
				} catch (\InvalidArgumentException $e) {
351
					return 'all';
352
				}
353
		}
354
	}
355
356
	/**
357
	 * Delete old events
358
	 *
359
	 * @param int $expireDays Minimum 1 day
360
	 */
361 1
	public function expire($expireDays = 365) {
362 1
		$ttl = (60 * 60 * 24 * max(1, $expireDays));
363
364 1
		$timelimit = time() - $ttl;
365 1
		$this->deleteActivities(array(
366 1
			'timestamp' => array($timelimit, '<'),
367
		));
368 1
	}
369
370
	/**
371
	 * Delete activities that match certain conditions
372
	 *
373
	 * @param array $conditions Array with conditions that have to be met
374
	 *                      'field' => 'value'  => `field` = 'value'
375
	 *    'field' => array('value', 'operator') => `field` operator 'value'
376
	 */
377 11
	public function deleteActivities($conditions) {
378 11
		$sqlWhere = '';
379 11
		$sqlParameters = $sqlWhereList = array();
380 11
		foreach ($conditions as $column => $comparison) {
381 11
			$sqlWhereList[] = " `$column` " . ((is_array($comparison) && isset($comparison[1])) ? $comparison[1] : '=') . ' ? ';
382 11
			$sqlParameters[] = (is_array($comparison)) ? $comparison[0] : $comparison;
383
		}
384
385 11
		if (!empty($sqlWhereList)) {
386 11
			$sqlWhere = ' WHERE ' . implode(' AND ', $sqlWhereList);
387
		}
388
389 11
		$query = $this->connection->prepare(
390 11
			'DELETE FROM `*PREFIX*activity`' . $sqlWhere);
391 11
		$query->execute($sqlParameters);
392 11
	}
393
}
394