Conditions | 3 |
Paths | 1 |
Total Lines | 63 |
Code Lines | 49 |
Lines | 0 |
Ratio | 0 % |
Tests | 58 |
CRAP Score | 3 |
Changes | 1 | ||
Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
38 | public function configureChannelOptions(OptionsResolver $resolver, Generator $generator): void { |
||
39 | 1 | $resolver->setRequired(["title", "description", "link", "lastBuildDate", ]); |
|
40 | 1 | $resolver->setAllowedTypes("title", "string"); |
|
41 | 1 | $resolver->setAllowedTypes("description", "string"); |
|
42 | 1 | $resolver->setAllowedTypes("link", "string"); |
|
43 | 1 | $resolver->setAllowedTypes("lastBuildDate", "callable"); |
|
44 | 1 | $resolver->setDefault("lastBuildDate", "time"); |
|
45 | 1 | $resolver->setNormalizer("lastBuildDate", function(Options $options, callable $value) use($generator) { |
|
1 ignored issue
–
show
|
|||
46 | 1 | $value = call_user_func($value); |
|
47 | 1 | if(!is_int($value)) { |
|
48 | 1 | throw new \InvalidArgumentException("Callback for last build date for RSS generator has to return integer."); |
|
49 | } |
||
50 | 1 | $value = date($generator->dateTimeFormat, $value); |
|
51 | 1 | return new GenericElement("lastBuildDate", $value); |
|
52 | 1 | }); |
|
53 | 1 | $resolver->setDefined([ |
|
54 | 1 | "language", "copyright", "managingEditor", "webMaster", "ttl", "pubDate", "rating", "categories", "skipDays", |
|
55 | "skipHours", "image", "cloud", "textInput", |
||
56 | ]); |
||
57 | 1 | $resolver->setAllowedTypes("language", "string"); |
|
58 | 1 | $resolver->setAllowedTypes("copyright", "string"); |
|
59 | 1 | $resolver->setAllowedTypes("managingEditor", "string"); |
|
60 | 1 | $resolver->setAllowedTypes("webMaster", "string"); |
|
61 | 1 | $resolver->setAllowedTypes("ttl", "int"); |
|
62 | 1 | $resolver->setAllowedValues("ttl", function(int $value) { |
|
63 | 1 | return ($value >= 0); |
|
64 | 1 | }); |
|
65 | 1 | $resolver->setAllowedTypes("pubDate", "callable"); |
|
66 | 1 | $resolver->setNormalizer("pubDate", function(Options $options, callable $value) use($generator) { |
|
1 ignored issue
–
show
|
|||
67 | 1 | $value = call_user_func($value); |
|
68 | 1 | if(!is_int($value)) { |
|
69 | 1 | throw new \InvalidArgumentException("Callback for pub date for RSS generator has to return integer."); |
|
70 | } |
||
71 | 1 | $value = date($generator->dateTimeFormat, $value); |
|
72 | 1 | return new GenericElement("pubDate", $value); |
|
73 | 1 | }); |
|
74 | 1 | $resolver->setAllowedTypes("rating", "string"); |
|
75 | 1 | $resolver->setAllowedTypes("categories", Category::class . "[]"); |
|
76 | 1 | $resolver->setNormalizer("categories", function(Options $options, array $value) { |
|
1 ignored issue
–
show
|
|||
77 | 1 | return CategoriesCollection::fromArray($value); |
|
78 | 1 | }); |
|
79 | 1 | $resolver->setAllowedTypes("skipDays", "string[]"); |
|
80 | 1 | $resolver->setAllowedValues("skipDays", function(array $value) { |
|
81 | 1 | $allowedValues = ["Monday", "Tuesday", "Wednesday", "Thursday", "Friday", "Saturday", "Sunday", ]; |
|
82 | 1 | return Arrays::every($value, function(string $value) use($allowedValues) { |
|
83 | 1 | return in_array($value, $allowedValues, true); |
|
84 | 1 | }); |
|
85 | 1 | }); |
|
86 | 1 | $resolver->setNormalizer("skipDays", function(Options $options, array $value) { |
|
1 ignored issue
–
show
|
|||
87 | 1 | return new SkipDaysCollection($value); |
|
88 | 1 | }); |
|
89 | 1 | $resolver->setAllowedTypes("skipHours", "int[]"); |
|
90 | 1 | $resolver->setAllowedValues("skipHours", function(array $value) { |
|
91 | 1 | return Arrays::every($value, function(int $value) { |
|
92 | 1 | return Numbers::isInRange($value, 0, 23); |
|
93 | 1 | }); |
|
94 | 1 | }); |
|
95 | 1 | $resolver->setNormalizer("skipHours", function(Options $options, array $value) { |
|
1 ignored issue
–
show
|
|||
96 | 1 | return new SkipHoursCollection($value); |
|
97 | 1 | }); |
|
98 | 1 | $resolver->setAllowedTypes("image", Image::class); |
|
99 | 1 | $resolver->setAllowedTypes("cloud", Cloud::class); |
|
100 | 1 | $resolver->setAllowedTypes("textInput", TextInput::class); |
|
101 | 1 | } |
|
138 | ?> |