Completed
Pull Request — devel (#1222)
by Aric
02:43
created
community/Nexcessnet/Turpentine/Model/Varnish/Configurator/Abstract.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -173,8 +173,8 @@
 block discarded – undo
173 173
      */
174 174
     protected function _getAdminFrontname() {
175 175
         if (Mage::getStoreConfig('admin/url/use_custom_path')) {
176
-            if(Mage::getStoreConfig('web/url/use_store')) {
177
-                return Mage::getModel('core/store')->load(0)->getCode() . "/" . Mage::getStoreConfig('admin/url/custom_path');
176
+            if (Mage::getStoreConfig('web/url/use_store')) {
177
+                return Mage::getModel('core/store')->load(0)->getCode()."/".Mage::getStoreConfig('admin/url/custom_path');
178 178
             } else {
179 179
                 return Mage::getStoreConfig('admin/url/custom_path');
180 180
             }
Please login to merge, or discard this patch.
Braces   +5 added lines, -10 removed lines patch added patch discarded remove patch
@@ -148,8 +148,7 @@  discard block
 block discarded – undo
148 148
             Mage::getStoreConfig('turpentine_varnish/servers/custom_vcl_template'),
149 149
             array('root_dir' => Mage::getBaseDir())
150 150
         );
151
-        if (is_file($filePath)) { return $filePath; }
152
-        else { return null; }
151
+        if (is_file($filePath)) { return $filePath; } else { return null; }
153 152
     }
154 153
 
155 154
 
@@ -414,8 +413,7 @@  discard block
 block discarded – undo
414 413
      * @return string
415 414
      */
416 415
     protected function _getGenerateSessionStart() {
417
-        if (Mage::getStoreConfig('turpentine_varnish/general/vcl_fix') == 1) { return ''; }
418
-        else { return '/* -- REMOVED'; }
416
+        if (Mage::getStoreConfig('turpentine_varnish/general/vcl_fix') == 1) { return ''; } else { return '/* -- REMOVED'; }
419 417
     }
420 418
 
421 419
     /**
@@ -424,8 +422,7 @@  discard block
 block discarded – undo
424 422
      * @return string
425 423
      */
426 424
     protected function _getGenerateSessionEnd() {
427
-        if (Mage::getStoreConfig('turpentine_varnish/general/vcl_fix') == 1) { return ''; }
428
-        else { return '-- */'; }
425
+        if (Mage::getStoreConfig('turpentine_varnish/general/vcl_fix') == 1) { return ''; } else { return '-- */'; }
429 426
     }
430 427
 
431 428
 
@@ -435,8 +432,7 @@  discard block
 block discarded – undo
435 432
      * @return string
436 433
      */
437 434
     protected function _getGenerateSession() {
438
-        if (Mage::getStoreConfig('turpentine_varnish/general/vcl_fix') == 1) { return 'call generate_session;'; }
439
-        else { return 'return (pipe);'; }
435
+        if (Mage::getStoreConfig('turpentine_varnish/general/vcl_fix') == 1) { return 'call generate_session;'; } else { return 'return (pipe);'; }
440 436
     }
441 437
 
442 438
 
@@ -446,8 +442,7 @@  discard block
 block discarded – undo
446 442
      * @return string
447 443
      */
448 444
     protected function _getGenerateSessionExpires() {
449
-        if (Mage::getStoreConfig('turpentine_varnish/general/vcl_fix') == 1) { return 'call generate_session_expires;'; }
450
-        else { return ''; }
445
+        if (Mage::getStoreConfig('turpentine_varnish/general/vcl_fix') == 1) { return 'call generate_session_expires;'; } else { return ''; }
451 446
     }
452 447
 
453 448
     /**
Please login to merge, or discard this patch.
community/Nexcessnet/Turpentine/Model/Varnish/Configurator/Version4.php 2 patches
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -87,13 +87,13 @@  discard block
 block discarded – undo
87 87
         $backendNodes = Mage::helper('turpentine/data')->cleanExplode(PHP_EOL,
88 88
             Mage::getStoreConfig('turpentine_vcl/backend/backend_nodes'));
89 89
 
90
-        for($i = 0, $iMax = count($backendNodes); $i < $iMax; $i++) {
90
+        for ($i = 0, $iMax = count($backendNodes); $i < $iMax; $i++) {
91 91
             $tpl .= <<<EOS
92 92
     vdir.add_backend(web{$i});
93 93
 EOS;
94 94
         }
95 95
 
96
-        for($i = 0, $iMax = count($adminBackendNodes); $i < $iMax; $i++) {
96
+        for ($i = 0, $iMax = count($adminBackendNodes); $i < $iMax; $i++) {
97 97
             $tpl .= <<<EOS
98 98
     vdir_admin.add_backend(webadmin{$i});
99 99
 EOS;
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
                 Mage::getStoreConfig('turpentine_vcl/backend/backend_nodes'));
126 126
             $probeUrl = Mage::getStoreConfig('turpentine_vcl/backend/backend_probe_url');
127 127
 
128
-            if('admin' == $name) {
128
+            if ('admin' == $name) {
129 129
                 $prefix = 'admin';
130 130
             } else {
131 131
                 $prefix = '';
@@ -138,7 +138,7 @@  discard block
 block discarded – undo
138 138
             $parts = explode(':', $backendNode, 2);
139 139
             $host = (empty($parts[0])) ? '127.0.0.1' : $parts[0];
140 140
             $port = (empty($parts[1])) ? '80' : $parts[1];
141
-            $backends .= $this->_vcl_director_backend($host, $port, $prefix . $number, $probeUrl, $backendOptions);
141
+            $backends .= $this->_vcl_director_backend($host, $port, $prefix.$number, $probeUrl, $backendOptions);
142 142
 
143 143
             $number++;
144 144
         }
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -35,8 +35,7 @@
 block discarded – undo
35 35
         $customTemplate = $this->_getCustomTemplateFilename();
36 36
         if ($customTemplate) { 
37 37
             $tplFile = $customTemplate;
38
-        }
39
-        else { 
38
+        } else { 
40 39
             $tplFile = $this->_getVclTemplateFilename(self::VCL_TEMPLATE_FILE);
41 40
         }
42 41
         $vcl = $this->_formatTemplate(file_get_contents($tplFile),
Please login to merge, or discard this patch.
app/code/community/Nexcessnet/Turpentine/Block/Poll/ActivePoll.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
 	public function setTemplate($template)
25 25
 	{
26 26
 		if ((Mage::getConfig()->getModuleConfig('Mage_Poll')->is('active', 'true')) &&
27
-		(!Mage::getStoreConfig('advanced/modules_disable_output/Mage_Poll')))
27
+		( ! Mage::getStoreConfig('advanced/modules_disable_output/Mage_Poll')))
28 28
 		{
29 29
 			$this->_template = $template;
30 30
 			$this->setPollTemplate('turpentine/ajax.phtml', 'poll');
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -29,8 +29,7 @@
 block discarded – undo
29 29
 			$this->_template = $template;
30 30
 			$this->setPollTemplate('turpentine/ajax.phtml', 'poll');
31 31
 			$this->setPollTemplate('turpentine/ajax.phtml', 'results');
32
-		}
33
-		else
32
+		} else
34 33
 		{
35 34
 			// Mage_Poll is disabled, so do nothing
36 35
 		}
Please login to merge, or discard this patch.
community/Nexcessnet/Turpentine/Model/Varnish/Configurator/Version3.php 1 patch
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -35,8 +35,7 @@
 block discarded – undo
35 35
         $customTemplate = $this->_getCustomTemplateFilename();
36 36
         if ($customTemplate) { 
37 37
             $tplFile = $customTemplate;
38
-        }
39
-        else { 
38
+        } else { 
40 39
             $tplFile = $this->_getVclTemplateFilename(self::VCL_TEMPLATE_FILE);
41 40
         }
42 41
         $vcl = $this->_formatTemplate(file_get_contents($tplFile),
Please login to merge, or discard this patch.