OrderService::instantiateOrderItems() - Code Metrics - newscoop/plugin-NewscoopPaywallBundle - Measure and Improve Code Quality continuously with Scrutinizer

OrderService::instantiateOrderItems() B
last analyzed 2017-11-03 12:01 UTC

↳ Parent: OrderService

Complexity

Conditions	9
Paths	54

Size

Total Lines	56
Code Lines	36

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	9
eloc	36
nc	54
nop	1
dl	0
loc	56
rs	7.1584
c	0
b	0
f	0

How to fix Long Method

<?php

/**
 * @author Rafał Muszyński <[email protected]>
 * @copyright 2015 Sourcefabric z.ú.
 * @license http://www.gnu.org/licenses/gpl-3.0.txt
 */
namespace Newscoop\PaywallBundle\Services;

use Newscoop\PaywallBundle\Currency\Context\CurrencyContextInterface;
use Sylius\Component\Currency\Converter\CurrencyConverterInterface;
use Newscoop\PaywallBundle\Entity\Order;
use Newscoop\PaywallBundle\Entity\OrderInterface;
use Newscoop\PaywallBundle\Entity\Subscription;
use Newscoop\PaywallBundle\Subscription\SubscriptionData;
use Newscoop\PaywallBundle\Discount\DiscountProcessorInterface;
use Newscoop\PaywallBundle\Entity\Duration;
use Newscoop\PaywallBundle\Entity\UserSubscription;

/**
 * Order service.
 */
class OrderService
{
    protected $context;
    protected $converter;
    protected $subscriptionService;
    protected $processor;

    public function __construct(
        CurrencyContextInterface $context,
        CurrencyConverterInterface $converter,
        PaywallService $subscriptionService,
        DiscountProcessorInterface $processor
    ) {
        $this->context = $context;
        $this->converter = $converter;
        $this->subscriptionService = $subscriptionService;
        $this->processor = $processor;
    }

    /**
     * Processes and calculates order items.
     * Calculates prices including all discounts.
     *
     * @param array  $items    array of subscription identifiers and its periods
     * @param string $surrency currency
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return OrderInterface
     */
    public function processAndCalculateOrderItems(array $items = array(), $currency = null)
    {
        if (null !== $currency) {
            $this->context->setCurrency($currency);
        }

        $order = $this->instantiateOrderItems($items);
        foreach ($order->getItems() as $item) {
            $this->processor->process($item);
        }

        $order->calculateTotal();

        return $order;
    }

    /**
     * Processes and calculates order.
     * Calculates prices, including all discounts.
     *
     * @param OrderInterface $order
     *
     * @return OrderInterface
     */
    public function processAndCalculateOrder(OrderInterface $order)
    {
        $order = $this->processor->process($order);
        $order->calculateTotal();

        return $order;
    }

    private function instantiateOrderItems(array $items = array())
    {
        try {
            $order = new Order();
            $order->setCurrency($this->context->getCurrency());
            $order->setUser($this->subscriptionService->getCurrentUser());
            foreach ($items as $subscriptionId => $periodId) {
                if (!$periodId) {
                    continue;
                }

                $orderItem = null;
                $subscription = $this->subscriptionService
                    ->getSubscriptionRepository()
                    ->getReference($subscriptionId);

                $newlySelectedPeriod = $this->subscriptionService->filterRanges($subscription, $periodId);
                if (!$newlySelectedPeriod) {
                    return new Order();
                }

                $item = $this->subscriptionService->getOrderItemBy(
                    $subscription->getId()
                );

                if ($item) {
                    if (!$item->isActive()) {
                        continue;
                    }

                    $currentItemPeriod = $item->getDuration();
                    // e.g month === month
                    if ($currentItemPeriod['attribute'] === $newlySelectedPeriod->getAttribute()) {
                        $orderItem = $this->instantiateOrderItem($subscription, $newlySelectedPeriod);
                        $orderItem->setProlonged(true);
                        $orderItem->setParent($item);
                        $orderItem->setCreatedAt($item->getCreatedAt());
                        $orderItem->setStartsAt($item->getExpireAt());
                    } else {
                        continue;
                    }
                }

                if (!$orderItem) {
                    $orderItem = $this->instantiateOrderItem($subscription, $newlySelectedPeriod);
                }

                $orderItem->setOrder($order);
                $order->addItem($orderItem);
            }

            return $order;
        } catch (\Exception $e) {
            throw $e;
        }
    }

    private function instantiateOrderItem(Subscription $subscription, $period)
    {
        $specification = $subscription->getSpecification()->first();

        $orderItem = $this->subscriptionService->create();
        $subscriptionData = new SubscriptionData(array(
            'userId' => $this->subscriptionService->getCurrentUser(),
            'subscriptionId' => $subscription,
            'publicationId' => $specification->getPublication(),
            'toPay' => $this->converter->convert($subscription->getPrice(), $this->context->getCurrency()),
            'duration' => $this->createPeriodArray($period),
            'discount' => $this->createDiscountArray($period),
            'currency' => $this->context->getCurrency(),
            'type' => 'T',
            'active' => false,
        ), $orderItem);

        return $this->subscriptionService->update($orderItem, $subscriptionData);
    }

    private function createDiscountArray(Duration $period)
    {
        $discount = array();
        if ($period->getDiscount()) {
            $discount['id'] = $period->getDiscount()->getId();
            $discount['value'] = $period->getDiscount()->getValue();
            $discount['type'] = $period->getDiscount()->getType();
        }

        return $discount;
    }

    private function createPeriodArray(Duration $period)
    {
        $periodArray = array(
            'id' => $period->getId(),
            'value' => $period->getValue(),
            'attribute' => $period->getAttribute(),
        );

        return $periodArray;
    }

    /**
     * Activate order item.
     *
     * @param UserSubscription $item
     */
    public function activateItem(UserSubscription $item)
    {
        $this->subscriptionService->activateUserSubscription($item);
    }
}


1			<?php
2
3			/**
4			* @author Rafał Muszyński <[email protected]>
5			* @copyright 2015 Sourcefabric z.ú.
6			* @license http://www.gnu.org/licenses/gpl-3.0.txt
7			*/
8			namespace Newscoop\PaywallBundle\Services;
9
10			use Newscoop\PaywallBundle\Currency\Context\CurrencyContextInterface;
11			use Sylius\Component\Currency\Converter\CurrencyConverterInterface;
12			use Newscoop\PaywallBundle\Entity\Order;
13			use Newscoop\PaywallBundle\Entity\OrderInterface;
14			use Newscoop\PaywallBundle\Entity\Subscription;
15			use Newscoop\PaywallBundle\Subscription\SubscriptionData;
16			use Newscoop\PaywallBundle\Discount\DiscountProcessorInterface;
17			use Newscoop\PaywallBundle\Entity\Duration;
18			use Newscoop\PaywallBundle\Entity\UserSubscription;
19
20			/**
21			* Order service.
22			*/
23			class OrderService
24			{
25			protected $context;
26			protected $converter;
27			protected $subscriptionService;
28			protected $processor;
29
30			public function __construct(
31			CurrencyContextInterface $context,
32			CurrencyConverterInterface $converter,
33			PaywallService $subscriptionService,
34			DiscountProcessorInterface $processor
35			) {
36			$this->context = $context;
37			$this->converter = $converter;
38			$this->subscriptionService = $subscriptionService;
39			$this->processor = $processor;
40			}
41
42			/**
43			* Processes and calculates order items.
44			* Calculates prices including all discounts.
45			*
46			* @param array $items array of subscription identifiers and its periods
47			* @param string $surrency currency
			0 ignored issues – show Bug introduced 2015-11-24 16:25 UTC by Report Bug Copy Issue Report There is no parameter named `$surrency`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
48			*
49			* @return OrderInterface
50			*/
51			public function processAndCalculateOrderItems(array $items = array(), $currency = null)
52			{
53			if (null !== $currency) {
54			$this->context->setCurrency($currency);
55			}
56
57			$order = $this->instantiateOrderItems($items);
58			foreach ($order->getItems() as $item) {
59			$this->processor->process($item);
60			}
61
62			$order->calculateTotal();
63
64			return $order;
65			}
66
67			/**
68			* Processes and calculates order.
69			* Calculates prices, including all discounts.
70			*
71			* @param OrderInterface $order
72			*
73			* @return OrderInterface
74			*/
75			public function processAndCalculateOrder(OrderInterface $order)
76			{
77			$order = $this->processor->process($order);
78			$order->calculateTotal();
79
80			return $order;
81			}
82
83			private function instantiateOrderItems(array $items = array())
84			{
85			try {
86			$order = new Order();
87			$order->setCurrency($this->context->getCurrency());
88			$order->setUser($this->subscriptionService->getCurrentUser());
89			foreach ($items as $subscriptionId => $periodId) {
90			if (!$periodId) {
91			continue;
92			}
93
94			$orderItem = null;
95			$subscription = $this->subscriptionService
96			->getSubscriptionRepository()
97			->getReference($subscriptionId);
98
99			$newlySelectedPeriod = $this->subscriptionService->filterRanges($subscription, $periodId);
100			if (!$newlySelectedPeriod) {
101			return new Order();
102			}
103
104			$item = $this->subscriptionService->getOrderItemBy(
105			$subscription->getId()
106			);
107
108			if ($item) {
109			if (!$item->isActive()) {
110			continue;
111			}
112
113			$currentItemPeriod = $item->getDuration();
114			// e.g month === month
115			if ($currentItemPeriod['attribute'] === $newlySelectedPeriod->getAttribute()) {
116			$orderItem = $this->instantiateOrderItem($subscription, $newlySelectedPeriod);
117			$orderItem->setProlonged(true);
118			$orderItem->setParent($item);
119			$orderItem->setCreatedAt($item->getCreatedAt());
120			$orderItem->setStartsAt($item->getExpireAt());
121			} else {
122			continue;
123			}
124			}
125
126			if (!$orderItem) {
127			$orderItem = $this->instantiateOrderItem($subscription, $newlySelectedPeriod);
128			}
129
130			$orderItem->setOrder($order);
131			$order->addItem($orderItem);
132			}
133
134			return $order;
135			} catch (\Exception $e) {
136			throw $e;
137			}
138			}
139
140			private function instantiateOrderItem(Subscription $subscription, $period)
141			{
142			$specification = $subscription->getSpecification()->first();
			0 ignored issues – show Bug introduced 2015-11-24 16:25 UTC by Report Bug Copy Issue Report The method `first` cannot be called on `$subscription->getSpecification()` (of type `array`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
143			$orderItem = $this->subscriptionService->create();
144			$subscriptionData = new SubscriptionData(array(
145			'userId' => $this->subscriptionService->getCurrentUser(),
146			'subscriptionId' => $subscription,
147			'publicationId' => $specification->getPublication(),
148			'toPay' => $this->converter->convert($subscription->getPrice(), $this->context->getCurrency()),
149			'duration' => $this->createPeriodArray($period),
150			'discount' => $this->createDiscountArray($period),
151			'currency' => $this->context->getCurrency(),
152			'type' => 'T',
153			'active' => false,
154			), $orderItem);
155
156			return $this->subscriptionService->update($orderItem, $subscriptionData);
157			}
158
159			private function createDiscountArray(Duration $period)
160			{
161			$discount = array();
162			if ($period->getDiscount()) {
163			$discount['id'] = $period->getDiscount()->getId();
164			$discount['value'] = $period->getDiscount()->getValue();
165			$discount['type'] = $period->getDiscount()->getType();
166			}
167
168			return $discount;
169			}
170
171			private function createPeriodArray(Duration $period)
172			{
173			$periodArray = array(
174			'id' => $period->getId(),
175			'value' => $period->getValue(),
176			'attribute' => $period->getAttribute(),
177			);
178
179			return $periodArray;
180			}
181
182			/**
183			* Activate order item.
184			*
185			* @param UserSubscription $item
186			*/
187			public function activateItem(UserSubscription $item)
188			{
189			$this->subscriptionService->activateUserSubscription($item);
190			}
191			}
192

newscoop / plugin-NewscoopPaywallBundle

OrderService::instantiateOrderItems() B last analyzed 2017-11-03 12:01 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

OrderService::instantiateOrderItems() B
last analyzed 2017-11-03 12:01 UTC