Newscoop\PaywallBundle\Subscription\SubscriptionData

Complexity

Total Complexity

4

Size/Duplication

Total Lines	122
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	18	4

<?php

/**
 * @author Rafał Muszyński <rafal.muszynski@sourcefabric.org>
 * @copyright 2014 Sourcefabric o.p.s.
 * @license http://www.gnu.org/licenses/gpl-3.0.txt
 */

namespace Newscoop\PaywallBundle\Subscription;

use Newscoop\PaywallBundle\Entity\UserSubscription;

/**
 * Subscription Data holder.
 */
class SubscriptionData
{
    /**
     * Subscription Class.
     *
     * @var Subscription
     */
    public $subscription;

    /**
     * User id.
     *
     * @var int
     */
    public $userId;

    /**
     * Subscription id.
     *
     * @var int
     */
    public $subscriptionId;

    /**
     * Publication Id.
     *
     * @var int
     */
    public $publicationId;

    /**
     * To pay value.
     *
     * @var decimal
     */
    public $toPay;

    /**
     * Subscription start date.
     *
     * @var \DateTime
     */
    public $startDate;

    /**
     * How long subscription should be valid.
     *
     * @var int
     */
    public $days;

    /**
     * Subscription duration.
     *
     * @var array
     */
    public $duration;

    /**
     * Subscription discount.
     *
     * @var array
     */
    public $discount;

    /**
     * How long subscription will be valid.
     *
     * @var int
     */
    public $paidDays;

    /**
     * Currency.
     *
     * @var string
     */
    public $currency;

    /**
     * Subscription status.
     *
     * @var bool
     */
    public $active;

    /**
     * Status to hide it globally.
     *
     * @var bool
     */
    public $is_active;

    public $mainSubscriptionId;

    /**
     * Subscription type.
     * 'T' for Trial subscription, 'P' for paid subscription or 'PN' for paid now subscriptions.
     *
     * @var string
     */
    public $type = 'P';

    public function __construct(array $data, UserSubscription $subscription = null)
    {
        // process data array
        $this->startDate = new \DateTime();
        foreach ($data as $key => $value) {
            if (property_exists($this, $key)) {
                $this->$key = $value;
            }
        }

        if (!$subscription) {
            $this->subscription = new UserSubscription();

It seems like new \Newscoop\PaywallBundle\Entity\UserSubscription() of type object<Newscoop\PaywallBundle\Entity\UserSubscription> is incompatible with the declared type object<Newscoop\PaywallBundle\Subscription\Subscription> of property $subscription.

        } else {
            $this->subscription = $subscription;

It seems like $subscription of type object<Newscoop\PaywallBundle\Entity\UserSubscription> is incompatible with the declared type object<Newscoop\PaywallBundle\Subscription\Subscription> of property $subscription.

        }

        return $this;

Constructors do not have meaningful return values, anything that is returned from here is discarded. Are you sure this is correct?

    }
}