Netzmacht\Workflow\Flow\Condition\Transition\ConditionCollection

Complexity

Total Complexity

8

Size/Duplication

Total Lines	81
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	4	4	1
A	addCondition()	6	6	1
A	removeCondition()	10	10	3
A	getConditions()	4	4	1
A	addConditions()	10	10	2

<?php

/**
 * Workflow library.
 *
 * @package    workflow
 * @author     David Molineus <david.molineus@netzmacht.de>
 * @copyright  2014-2017 netzmacht David Molineus
 * @license    LGPL 3.0 https://github.com/netzmacht/workflow
 * @filesource
 */

declare(strict_types=1);

namespace Netzmacht\Workflow\Flow\Condition\Transition;

use Assert\Assertion;

/**
 * Class ConditionCollection contains child conditions which are called during match.
 *
 * @package Netzmacht\Workflow\Flow\Transition\Condition
 */
abstract class ConditionCollection implements Condition

This class seems to be duplicated in your project.

{
    /**
     * All child conditions of the collection.
     *
     * @var Condition[]
     */
    protected $conditions = array();

    /**
     * ConditionCollection constructor.
     *
     * @param Condition[]|iterable $conditions List of child conditions.
     */
    public function __construct(iterable $conditions = [])
    {
        $this->addConditions($conditions);

It seems like $conditions defined by parameter $conditions on line 38 can also be of type array<integer,object<Netzmacht\Workflow\Flow\Condition\Transition\Condition>>; however, Netzmacht\Workflow\Flow\Condition\Transition\ConditionCollection::addConditions() does only seem to accept object<Netzmacht\Workflow\Flow\Condition\Transition\iterable>, maybe add an additional type check?

    }

    /**
     * Add condition.
     *
     * @param Condition $condition Condition being added.
     *
     * @return $this
     */
    public function addCondition(Condition $condition): self
    {
        $this->conditions[] = $condition;

        return $this;
    }

    /**
     * Remove condition from collection.
     *
     * @param Condition $condition Condition being removed.
     *
     * @return $this
     */
    public function removeCondition(Condition $condition): self
    {
        foreach ($this->conditions as $index => $value) {
            if ($value === $condition) {
                unset($this->conditions[$index]);
            }
        }

        return $this;
    }

    /**
     * Get child conditions.
     *
     * @return Condition[]|iterable
     */
    public function getConditions(): iterable
    {
        return $this->conditions;
    }

    /**
     * Add multiple conditions.
     *
     * @param iterable $conditions Array of conditions being added.
     *
     * @return $this
     *
     * @throws \Assert\InvalidArgumentException If array contains an invalid condition.
     */
    public function addConditions(iterable $conditions): self
    {
        Assertion::allIsInstanceOf($conditions, Condition::class);

        foreach ($conditions as $condition) {
            $this->addCondition($condition);
        }

        return $this;
    }
}