Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
24 | View Code Duplication | abstract class ConditionCollection implements Condition |
|
|
|||
25 | { |
||
26 | /** |
||
27 | * Child conditions of the collection. |
||
28 | * |
||
29 | * @var Condition[]|iterable |
||
30 | */ |
||
31 | protected $conditions = array(); |
||
32 | |||
33 | /** |
||
34 | * Construct. |
||
35 | * |
||
36 | * @param Condition[]|iterable $conditions Conditions. |
||
37 | */ |
||
38 | public function __construct(iterable $conditions = array()) |
||
42 | |||
43 | /** |
||
44 | * Add new child condition. |
||
45 | * |
||
46 | * @param Condition $condition Child condition. |
||
47 | * |
||
48 | * @return $this |
||
49 | */ |
||
50 | public function addCondition(Condition $condition): self |
||
56 | |||
57 | /** |
||
58 | * Add multiple conditions. |
||
59 | * |
||
60 | * @param Condition[]|iterable $conditions Array of conditions. |
||
61 | * |
||
62 | * @return $this |
||
63 | */ |
||
64 | public function addConditions(iterable $conditions): self |
||
74 | |||
75 | /** |
||
76 | * Get all conditions. |
||
77 | * |
||
78 | * @return Condition[]|iterable |
||
79 | */ |
||
80 | public function getConditions(): iterable |
||
84 | |||
85 | /** |
||
86 | * Remove condition from collection. |
||
87 | * |
||
88 | * @param Condition $condition Condition to remove. |
||
89 | * |
||
90 | * @return $this |
||
91 | */ |
||
92 | public function removeCondition(Condition $condition): self |
||
102 | } |
||
103 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.