Filesystem::recursiveRemoveDirectory() - Code Metrics - Inspection of "Merge branch 'release/1.1.11'" - netz98/n98-magerun2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ad0611...abd676 )

by Tom

created 2016-05-18 16:01 UTC

Filesystem::recursiveRemoveDirectory() C

↳ Parent: Filesystem

Complexity

Conditions	10
Paths	20

Size

Total Lines	57
Code Lines	21

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	57
rs	6.7123
c	1
b	0
f	0
cc	10
eloc	21
nc	20
nop	2

How to fix Long Method Complexity

<?php
/*
 * this file is part of magerun
 *
 * @author Tom Klingenberg <https://github.com/ktomk>
 */

namespace N98\Util;

use RuntimeException;

/**
 * Class Filesystem
 *
 * @package N98\Util
 */
class Filesystem
{
    /**
     * @param string $src
     * @param string $dst
     * @param string[]  $blacklist
     *
     * @return void
     */
    public function recursiveCopy($src, $dst, $blacklist = array())
    {
        if (!is_dir($dst)) {
            @mkdir($dst, 0777, true);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
        }

        if (!is_dir($dst)) {
            throw new RuntimeException(sprintf('Destination directory <%s> error', $dst));
        }

        $handle = opendir($src);

        if (!$handle) {
            throw new RuntimeException(sprintf('Source directory <%s> error', $src));
        }

        $skip = array_merge(array(".", ".."), $blacklist);
        $stack = array();

        while (false !== ($file = readdir($handle))) {
            if (in_array($file, $skip)) {
                continue;
            }

            if (is_dir($src . '/' . $file)) {
                $stack[] = $file;
            } else {
                copy($src . '/' . $file, $dst . '/' . $file);
            }
        }
        closedir($handle);

        foreach ($stack as $file) {
            $this->recursiveCopy($src . '/' . $file, $dst . '/' . $file, $blacklist);
        }
    }

    /**
     * @param string $directory
     * @param bool $empty
     *
     * @see http://lixlpixel.org/recursive_function/php/recursive_directory_delete/
     *
     * @return bool
     */
    public function recursiveRemoveDirectory($directory, $empty = false)
    {
        // if the path has a slash at the end we remove it here
        if (substr($directory, -1) === '/') {
            $directory = substr($directory, 0, -1);
        }

        // if the path is not valid or is not a directory ...
        // ... if the path is not readable
        if (!is_dir($directory) || !is_readable($directory)) {
            return false;
        }

        // we open the directory
        $handle = opendir($directory);

        if (!$handle) {
            throw new RuntimeException(sprintf('Directory <%s> error', $directory));
        }

        $skip = array(".", "..");

        // and scan through the items inside
        while (false !== ($file = readdir($handle))) {
            // if the filepointer is not the current directory
            // or the parent directory
            if (in_array($file, $skip)) {
                continue;
            }

            // we build the new path to delete
            $path = $directory . '/' . $file;

            // if the new path is a directory
            // don't recursively delete symlinks - just remove the actual link
            // this is helpful for extensions sym-linked from vendor directory
            // previous behaviour would wipe out the files in the vendor directory
            if (!is_link($path) && is_dir($path)) {
                // we call this function with the new path
                $this->recursiveRemoveDirectory($path);

                // if the new path is a file
            } else {
                // we remove the file
                unlink($path);
            }
        }
        closedir($handle);

        // if the option not empty
        if (!$empty) {
            return rmdir($directory);
        }

        // return success
        return true;
    }

    /**
     * @param int $bytes
     * @param int $decimals
     *
     * @see http://www.php.net/manual/en/function.filesize.php#106569
     *
     * @return string
     */
    public static function humanFileSize($bytes, $decimals = 2)
    {
        $units  = array('B', 'K', 'M', 'G', 'T', 'P', 'E', 'Z', 'Y');
        $factor = floor((strlen($bytes) - 1) / 3);

        return sprintf("%.{$decimals}f%s", $bytes / pow(1024, $factor), $units[$factor]);
    }
}


1			<?php
2			/*
3			* this file is part of magerun
4			*
5			* @author Tom Klingenberg <https://github.com/ktomk>
6			*/
7
8			namespace N98\Util;
9
10			use RuntimeException;
11
12			/**
13			* Class Filesystem
14			*
15			* @package N98\Util
16			*/
17			class Filesystem
18			{
19			/**
20			* @param string $src
21			* @param string $dst
22			* @param string[] $blacklist
23			*
24			* @return void
25			*/
26			public function recursiveCopy($src, $dst, $blacklist = array())
27			{
28			if (!is_dir($dst)) {
29			@mkdir($dst, 0777, true);
			0 ignored issues – show Security Best Practice introduced 2015-11-23 11:00 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
30			}
31
32			if (!is_dir($dst)) {
33			throw new RuntimeException(sprintf('Destination directory <%s> error', $dst));
34			}
35
36			$handle = opendir($src);
37
38			if (!$handle) {
39			throw new RuntimeException(sprintf('Source directory <%s> error', $src));
40			}
41
42			$skip = array_merge(array(".", ".."), $blacklist);
43			$stack = array();
44
45			while (false !== ($file = readdir($handle))) {
46			if (in_array($file, $skip)) {
47			continue;
48			}
49
50			if (is_dir($src . '/' . $file)) {
51			$stack[] = $file;
52			} else {
53			copy($src . '/' . $file, $dst . '/' . $file);
54			}
55			}
56			closedir($handle);
57
58			foreach ($stack as $file) {
59			$this->recursiveCopy($src . '/' . $file, $dst . '/' . $file, $blacklist);
60			}
61			}
62
63			/**
64			* @param string $directory
65			* @param bool $empty
66			*
67			* @see http://lixlpixel.org/recursive_function/php/recursive_directory_delete/
68			*
69			* @return bool
70			*/
71			public function recursiveRemoveDirectory($directory, $empty = false)
72			{
73			// if the path has a slash at the end we remove it here
74			if (substr($directory, -1) === '/') {
75			$directory = substr($directory, 0, -1);
76			}
77
78			// if the path is not valid or is not a directory ...
79			// ... if the path is not readable
80			if (!is_dir($directory) \|\| !is_readable($directory)) {
81			return false;
82			}
83
84			// we open the directory
85			$handle = opendir($directory);
86
87			if (!$handle) {
88			throw new RuntimeException(sprintf('Directory <%s> error', $directory));
89			}
90
91			$skip = array(".", "..");
92
93			// and scan through the items inside
94			while (false !== ($file = readdir($handle))) {
95			// if the filepointer is not the current directory
96			// or the parent directory
97			if (in_array($file, $skip)) {
98			continue;
99			}
100
101			// we build the new path to delete
102			$path = $directory . '/' . $file;
103
104			// if the new path is a directory
105			// don't recursively delete symlinks - just remove the actual link
106			// this is helpful for extensions sym-linked from vendor directory
107			// previous behaviour would wipe out the files in the vendor directory
108			if (!is_link($path) && is_dir($path)) {
109			// we call this function with the new path
110			$this->recursiveRemoveDirectory($path);
111
112			// if the new path is a file
113			} else {
114			// we remove the file
115			unlink($path);
116			}
117			}
118			closedir($handle);
119
120			// if the option not empty
121			if (!$empty) {
122			return rmdir($directory);
123			}
124
125			// return success
126			return true;
127			}
128
129			/**
130			* @param int $bytes
131			* @param int $decimals
132			*
133			* @see http://www.php.net/manual/en/function.filesize.php#106569
134			*
135			* @return string
136			*/
137			public static function humanFileSize($bytes, $decimals = 2)
138			{
139			$units = array('B', 'K', 'M', 'G', 'T', 'P', 'E', 'Z', 'Y');
140			$factor = floor((strlen($bytes) - 1) / 3);
141
142			return sprintf("%.{$decimals}f%s", $bytes / pow(1024, $factor), $units[$factor]);
143			}
144			}
145

netz98 / n98-magerun2

Push — master ( ad0611...abd676 )

Filesystem::recursiveRemoveDirectory() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like