CreateDatabase::execute() - Code Metrics - Inspection of "Merge branch 'release/1.1.11'" - netz98/n98-magerun2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ad0611...abd676 )

by Tom

created 2016-05-18 16:01 UTC

CreateDatabase::execute() D

↳ Parent: CreateDatabase

Complexity

Conditions	13
Paths	136

Size

Total Lines	111
Code Lines	75

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	2	Features	0

Metric	Value
c	2
b	2
f	0
dl	0
loc	111
rs	4.6605
cc	13
eloc	75
nc	136
nop	0

How to fix Long Method Complexity

<?php

namespace N98\Magento\Command\Installer\SubCommand;

use N98\Magento\Command\SubCommand\AbstractSubCommand;
use N98\Util\BinaryString;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;

class CreateDatabase extends AbstractSubCommand
{
    /**
     * @var array
     */
    protected $_argv;

    /**
     * @var \Closure
     */
    protected $notEmptyCallback;

    /**
     * @return void
     */
    public function execute()
    {
        $this->notEmptyCallback = function ($input) {
            if (empty($input)) {
                throw new \InvalidArgumentException('Please enter a value');
            }
            return $input;
        };

        $dbOptions = array('--dbHost', '--dbUser', '--dbPass', '--dbName');
        $dbOptionsFound = 0;
        foreach ($dbOptions as $dbOption) {
            foreach ($this->getCliArguments() as $definedCliOption) {
                if (BinaryString::startsWith($definedCliOption, $dbOption)) {
                    $dbOptionsFound++;
                }
            }
        }

        $hasAllOptions = $dbOptionsFound == 4;

        // if all database options were passed in at cmd line
        if ($hasAllOptions) {
            $this->config->setString('db_host', $this->input->getOption('dbHost'));
            $this->config->setString('db_user', $this->input->getOption('dbUser'));
            $this->config->setString('db_pass', $this->input->getOption('dbPass'));
            $this->config->setString('db_name', $this->input->getOption('dbName'));
            $this->config->setInt('db_port', intval($this->input->getOption('dbPort')));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $db = $this->validateDatabaseSettings($this->input, $this->output);

            if ($db === false) {
                throw new \InvalidArgumentException("Database configuration is invalid", null);
            }
        } else {
            $dialog = $this->getCommand()->getHelperSet()->get('dialog');
            do {

                // Host
                $dbHostDefault = $this->input->getOption('dbHost') ? $this->input->getOption('dbHost') : 'localhost';
                $this->config->setString(
                    'db_host',
                    $dialog->askAndValidate(
                        $this->output,
                        '<question>Please enter the database host</question> <comment>[' .
                        $dbHostDefault . ']</comment>: ',
                        $this->notEmptyCallback,
                        false,
                        $dbHostDefault
                    )
                );

                // Port
                $dbPortDefault = $this->input->getOption('dbPort') ? $this->input->getOption('dbPort') : 3306;
                $this->config->setInt(
                    'db_port',
                    intval($dialog->askAndValidate(
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                        $this->output,
                        '<question>Please enter the database port </question> <comment>[' .
                        $dbPortDefault . ']</comment>: ',
                        $this->notEmptyCallback,
                        false,
                        $dbPortDefault
                    ))
                );

                // User
                $dbUserDefault = $this->input->getOption('dbUser') ? $this->input->getOption('dbUser') : 'root';
                $this->config->setString(
                    'db_user',
                    $dialog->askAndValidate(
                        $this->output,
                        '<question>Please enter the database username</question> <comment>[' .
                        $dbUserDefault . ']</comment>: ',
                        $this->notEmptyCallback,
                        false,
                        $dbUserDefault
                    )
                );

                // Password
                $dbPassDefault = $this->input->getOption('dbPass') ? $this->input->getOption('dbPass') : '';
                $this->config->setString(
                    'db_pass',
                    $dialog->ask(
                        $this->output,
                        '<question>Please enter the database password</question> <comment>[' .
                        $dbPassDefault . ']</comment>: ',
                        $dbPassDefault
                    )
                );

                // DB-Name
                $dbNameDefault = $this->input->getOption('dbName') ? $this->input->getOption('dbName') : 'magento';
                $this->config->setString(
                    'db_name',
                    $dialog->askAndValidate(
                        $this->output,
                        '<question>Please enter the database name</question> <comment>[' .
                        $dbNameDefault . ']</comment>: ',
                        $this->notEmptyCallback,
                        false,
                        $dbNameDefault
                    )
                );

                $db = $this->validateDatabaseSettings($this->input, $this->output);
            } while ($db === false);
        }

        $this->config->setObject('db', $db);
    }

    /**
     * @param InputInterface $input
     * @param OutputInterface $output
     * @return bool|\PDO
     */
    protected function validateDatabaseSettings(InputInterface $input, OutputInterface $output)
    {
        try {
            $dsn = sprintf(
                "mysql:host=%s;port=%s",
                $this->config->getString('db_host'),
                $this->config->getString('db_port')
            );

            $db = new \PDO($dsn, $this->config->getString('db_user'), $this->config->getString('db_pass'));

            $dbName = $this->config->getString('db_name');
            if (!$db->query('USE `' . $dbName . '`')) {
                $db->query("CREATE DATABASE `" . $dbName . "`");
                $output->writeln('<info>Created database ' . $dbName . '</info>');
                $db->query('USE `' . $dbName . '`');

                // Check DB version
                $statement = $db->query('SELECT VERSION()');
                $mysqlVersion = $statement->fetchColumn(0);
                if (version_compare($mysqlVersion, '5.6.0', '<')) {
                    throw new \Exception('MySQL Version must be >= 5.6.0');
                }

                return $db;
            }

            if ($input->getOption('noDownload') && !$input->getOption('forceUseDb')) {
                $output->writeln("<error>Database {$this->config->getString('db_name')} already exists.</error>");

                return false;
            }

            return $db;
        } catch (\Exception $e) {
            $output->writeln('<error>' . $e->getMessage() . '</error>');
        } catch (\PDOException $e) {
            $output->writeln('<error>' . $e->getMessage() . '</error>');
        }

        return false;
    }

    /**
     * @return array
     */
    public function getCliArguments()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if ($this->_argv === null) {
            $this->_argv = $_SERVER['argv'];
        }

        return $this->_argv;
    }
}


1			<?php
2
3			namespace N98\Magento\Command\Installer\SubCommand;
4
5			use N98\Magento\Command\SubCommand\AbstractSubCommand;
6			use N98\Util\BinaryString;
7			use Symfony\Component\Console\Input\InputInterface;
8			use Symfony\Component\Console\Output\OutputInterface;
9
10			class CreateDatabase extends AbstractSubCommand
11			{
12			/**
13			* @var array
14			*/
15			protected $_argv;
16
17			/**
18			* @var \Closure
19			*/
20			protected $notEmptyCallback;
21
22			/**
23			* @return void
24			*/
25			public function execute()
26			{
27			$this->notEmptyCallback = function ($input) {
28			if (empty($input)) {
29			throw new \InvalidArgumentException('Please enter a value');
30			}
31			return $input;
32			};
33
34			$dbOptions = array('--dbHost', '--dbUser', '--dbPass', '--dbName');
35			$dbOptionsFound = 0;
36			foreach ($dbOptions as $dbOption) {
37			foreach ($this->getCliArguments() as $definedCliOption) {
38			if (BinaryString::startsWith($definedCliOption, $dbOption)) {
39			$dbOptionsFound++;
40			}
41			}
42			}
43
44			$hasAllOptions = $dbOptionsFound == 4;
45
46			// if all database options were passed in at cmd line
47			if ($hasAllOptions) {
48			$this->config->setString('db_host', $this->input->getOption('dbHost'));
49			$this->config->setString('db_user', $this->input->getOption('dbUser'));
50			$this->config->setString('db_pass', $this->input->getOption('dbPass'));
51			$this->config->setString('db_name', $this->input->getOption('dbName'));
52			$this->config->setInt('db_port', intval($this->input->getOption('dbPort')));
			0 ignored issues – show Documentation introduced 2015-11-23 11:00 UTC by Report Bug Copy Issue Report `intval($this->input->getOption('dbPort'))` is of type `integer`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
53			$db = $this->validateDatabaseSettings($this->input, $this->output);
54
55			if ($db === false) {
56			throw new \InvalidArgumentException("Database configuration is invalid", null);
57			}
58			} else {
59			$dialog = $this->getCommand()->getHelperSet()->get('dialog');
60			do {
61
62			// Host
63			$dbHostDefault = $this->input->getOption('dbHost') ? $this->input->getOption('dbHost') : 'localhost';
64			$this->config->setString(
65			'db_host',
66			$dialog->askAndValidate(
67			$this->output,
68			'<question>Please enter the database host</question> <comment>[' .
69			$dbHostDefault . ']</comment>: ',
70			$this->notEmptyCallback,
71			false,
72			$dbHostDefault
73			)
74			);
75
76			// Port
77			$dbPortDefault = $this->input->getOption('dbPort') ? $this->input->getOption('dbPort') : 3306;
78			$this->config->setInt(
79			'db_port',
80			intval($dialog->askAndValidate(
			0 ignored issues – show Documentation introduced 2015-11-23 11:00 UTC by Report Bug Copy Issue Report `intval($dialog->askAndVa...false, $dbPortDefault))` is of type `integer`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
81			$this->output,
82			'<question>Please enter the database port </question> <comment>[' .
83			$dbPortDefault . ']</comment>: ',
84			$this->notEmptyCallback,
85			false,
86			$dbPortDefault
87			))
88			);
89
90			// User
91			$dbUserDefault = $this->input->getOption('dbUser') ? $this->input->getOption('dbUser') : 'root';
92			$this->config->setString(
93			'db_user',
94			$dialog->askAndValidate(
95			$this->output,
96			'<question>Please enter the database username</question> <comment>[' .
97			$dbUserDefault . ']</comment>: ',
98			$this->notEmptyCallback,
99			false,
100			$dbUserDefault
101			)
102			);
103
104			// Password
105			$dbPassDefault = $this->input->getOption('dbPass') ? $this->input->getOption('dbPass') : '';
106			$this->config->setString(
107			'db_pass',
108			$dialog->ask(
109			$this->output,
110			'<question>Please enter the database password</question> <comment>[' .
111			$dbPassDefault . ']</comment>: ',
112			$dbPassDefault
113			)
114			);
115
116			// DB-Name
117			$dbNameDefault = $this->input->getOption('dbName') ? $this->input->getOption('dbName') : 'magento';
118			$this->config->setString(
119			'db_name',
120			$dialog->askAndValidate(
121			$this->output,
122			'<question>Please enter the database name</question> <comment>[' .
123			$dbNameDefault . ']</comment>: ',
124			$this->notEmptyCallback,
125			false,
126			$dbNameDefault
127			)
128			);
129
130			$db = $this->validateDatabaseSettings($this->input, $this->output);
131			} while ($db === false);
132			}
133
134			$this->config->setObject('db', $db);
135			}
136
137			/**
138			* @param InputInterface $input
139			* @param OutputInterface $output
140			* @return bool\|\PDO
141			*/
142			protected function validateDatabaseSettings(InputInterface $input, OutputInterface $output)
143			{
144			try {
145			$dsn = sprintf(
146			"mysql:host=%s;port=%s",
147			$this->config->getString('db_host'),
148			$this->config->getString('db_port')
149			);
150
151			$db = new \PDO($dsn, $this->config->getString('db_user'), $this->config->getString('db_pass'));
152
153			$dbName = $this->config->getString('db_name');
154			if (!$db->query('USE `' . $dbName . '`')) {
155			$db->query("CREATE DATABASE `" . $dbName . "`");
156			$output->writeln('<info>Created database ' . $dbName . '</info>');
157			$db->query('USE `' . $dbName . '`');
158
159			// Check DB version
160			$statement = $db->query('SELECT VERSION()');
161			$mysqlVersion = $statement->fetchColumn(0);
162			if (version_compare($mysqlVersion, '5.6.0', '<')) {
163			throw new \Exception('MySQL Version must be >= 5.6.0');
164			}
165
166			return $db;
167			}
168
169			if ($input->getOption('noDownload') && !$input->getOption('forceUseDb')) {
170			$output->writeln("<error>Database {$this->config->getString('db_name')} already exists.</error>");
171
172			return false;
173			}
174
175			return $db;
176			} catch (\Exception $e) {
177			$output->writeln('<error>' . $e->getMessage() . '</error>');
178			} catch (\PDOException $e) {
179			$output->writeln('<error>' . $e->getMessage() . '</error>');
180			}
181
182			return false;
183			}
184
185			/**
186			* @return array
187			*/
188			public function getCliArguments()
			0 ignored issues – show Coding Style introduced 2015-11-23 11:00 UTC by Report Bug Copy Issue Report `getCliArguments` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
189			{
190			if ($this->_argv === null) {
191			$this->_argv = $_SERVER['argv'];
192			}
193
194			return $this->_argv;
195			}
196			}
197

netz98 / n98-magerun2

Push — master ( ad0611...abd676 )

CreateDatabase::execute() D

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like