Completed
Pull Request — develop (#184)
by Tom
04:42
created
src/N98/Magento/Command/Developer/Module/Create/SubCommand/EnableModule.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -9,7 +9,7 @@
 block discarded – undo
9 9
 class InstallSampleData extends AbstractSubCommand
10 10
 {
11 11
     /**
12
-     * @return bool
12
+     * @return false|null
13 13
      */
14 14
     public function execute()
15 15
     {
Please login to merge, or discard this patch.
src/N98/Magento/Command/Installer/SubCommand/CreateDatabase.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@
 block discarded – undo
51 51
      *
52 52
      * @param Bootstrap $bootstrap
53 53
      * @param \Exception $exception
54
-     * @return bool
54
+     * @return boolean|null
55 55
      */
56 56
     public function catchException(Bootstrap $bootstrap, \Exception $exception)
57 57
     {
Please login to merge, or discard this patch.
src/N98/Magento/Command/Installer/SubCommand/PostInstallation.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@
 block discarded – undo
51 51
      *
52 52
      * @param Bootstrap $bootstrap
53 53
      * @param \Exception $exception
54
-     * @return bool
54
+     * @return boolean|null
55 55
      */
56 56
     public function catchException(Bootstrap $bootstrap, \Exception $exception)
57 57
     {
Please login to merge, or discard this patch.
src/N98/Magento/Command/Installer/SubCommand/RemoveEmptyFolders.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@
 block discarded – undo
51 51
      *
52 52
      * @param Bootstrap $bootstrap
53 53
      * @param \Exception $exception
54
-     * @return bool
54
+     * @return boolean|null
55 55
      */
56 56
     public function catchException(Bootstrap $bootstrap, \Exception $exception)
57 57
     {
Please login to merge, or discard this patch.
tests/N98/Magento/Command/Database/DumpCommandTest.php 2 patches
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -2,8 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace N98\Magento\Command\Database\Maintain;
4 4
 
5
-use Symfony\Component\Console\Output\NullOutput;
6
-use Symfony\Component\Console\Tester\ApplicationTester;
7 5
 use Symfony\Component\Console\Tester\CommandTester;
8 6
 use N98\Magento\Command\PHPUnit\TestCase;
9 7
 
Please login to merge, or discard this patch.
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -53,17 +53,17 @@
 block discarded – undo
53 53
             # testAddTimeAutogenerated
54 54
             ['/^.*[0-9]{4}-[0-9]{2}-[0-9]{2}_[0-9]{6}\.sql$/', []],
55 55
             # testAddTimePrefixAutogenerated
56
-            ['/^[0-9]{4}-[0-9]{2}-[0-9]{2}_[0-9]{6}.*\.sql$/', ['--add-time' => 'prefix',]],
56
+            ['/^[0-9]{4}-[0-9]{2}-[0-9]{2}_[0-9]{6}.*\.sql$/', ['--add-time' => 'prefix', ]],
57 57
             # testAddTimeFilenameSpecified
58
-            [ '/^.*[0-9]{4}-[0-9]{2}-[0-9]{2}_[0-9]{6}\.sql.gz$/', ['--compression' => 'gzip',]],
58
+            ['/^.*[0-9]{4}-[0-9]{2}-[0-9]{2}_[0-9]{6}\.sql.gz$/', ['--compression' => 'gzip', ]],
59 59
             # testAddTimeFilenameSpecified
60
-            ['/^foo_[0-9]{4}-[0-9]{2}-[0-9]{2}_[0-9]{6}\.sql$/', ['filename' => 'foo.sql',]],
60
+            ['/^foo_[0-9]{4}-[0-9]{2}-[0-9]{2}_[0-9]{6}\.sql$/', ['filename' => 'foo.sql', ]],
61 61
             # testAddTimePrefixFilenameSpecified
62
-            [ '/^[0-9]{4}-[0-9]{2}-[0-9]{2}_[0-9]{6}_foo\.sql$/', ['filename' => 'foo.sql', '--add-time' => 'prefix',]],
62
+            ['/^[0-9]{4}-[0-9]{2}-[0-9]{2}_[0-9]{6}_foo\.sql$/', ['filename' => 'foo.sql', '--add-time' => 'prefix', ]],
63 63
             # testAddTimeOffFilenameSpecified
64
-            ['/^foo.sql$/', ['filename' => 'foo.sql', '--add-time' => false,]],
64
+            ['/^foo.sql$/', ['filename' => 'foo.sql', '--add-time' => false, ]],
65 65
             # testAddTimeFilenameSpecifiedRelative
66
-            ['/^..\/foo_[0-9]{4}-[0-9]{2}-[0-9]{2}_[0-9]{6}\.sql$/', ['filename' => '../foo.sql',]],
66
+            ['/^..\/foo_[0-9]{4}-[0-9]{2}-[0-9]{2}_[0-9]{6}\.sql$/', ['filename' => '../foo.sql', ]],
67 67
         ];
68 68
     }
69 69
 
Please login to merge, or discard this patch.
Magento/Command/Developer/Module/Create/SubCommand/CreateComposerFile.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@
 block discarded – undo
28 28
             )
29 29
         );
30 30
 
31
-        $this->output->writeln('<info>Created file: <comment>' .  $outFile .'<comment></info>');
31
+        $this->output->writeln('<info>Created file: <comment>' . $outFile . '<comment></info>');
32 32
 
33 33
         return true;
34 34
     }
Please login to merge, or discard this patch.
N98/Magento/Command/Developer/Module/Create/SubCommand/CreateModmanFile.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@
 block discarded – undo
28 28
             )
29 29
         );
30 30
 
31
-        $this->output->writeln('<info>Created file: <comment>' .  $outFile .'<comment></info>');
31
+        $this->output->writeln('<info>Created file: <comment>' . $outFile . '<comment></info>');
32 32
 
33 33
         return true;
34 34
     }
Please login to merge, or discard this patch.
tests/N98/Magento/Command/Cache/DisableCommandTest.php 1 patch
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -1,9 +1,9 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * @todo    writing unit tests for toggling caches is complicated because environments differ
4
- *          touching caches changes state and will result in different test result second time
5
- *          solutions: disabling/enabling, faking&mocking or having one defined test environment
6
- */
3
+     * @todo    writing unit tests for toggling caches is complicated because environments differ
4
+     *          touching caches changes state and will result in different test result second time
5
+     *          solutions: disabling/enabling, faking&mocking or having one defined test environment
6
+     */
7 7
 namespace N98\Magento\Command\Cache;
8 8
 
9 9
 use Symfony\Component\Console\Tester\CommandTester;
Please login to merge, or discard this patch.
src/N98/Magento/Command/GiftCard/CreateCommand.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@
 block discarded – undo
49 49
                 'status'        => 1,
50 50
                 'is_redeemable' => 1,
51 51
                 'website_id'    => $input->getOption('website')
52
-                    ? : $this->getObjectManager()->get('Magento\Store\Model\StoreManager')->getWebsite(true)->getId(),
52
+                    ?: $this->getObjectManager()->get('Magento\Store\Model\StoreManager')->getWebsite(true)->getId(),
53 53
                 'balance'       => $input->getArgument('amount'),
54 54
                 'date_expires'  => $input->getOption('expires')
55 55
             )
Please login to merge, or discard this patch.