DumpCommandTest::testAddTimePrefixFilenameSpecified() - Code Metrics - Inspection of "Develop 1.1.5" - netz98/n98-magerun2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#184)

by Tom

created 2016-04-04 00:30 UTC

nameSpecified() A

↳ Parent: DumpCommandTest::testWithStripOption()

Complexity

Conditions	1
Paths	1

Size

Total Lines	17
Code Lines	11

Duplication

Lines	17
Ratio	100 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	17
loc	17
rs	9.4285
c	1
b	0
f	0
cc	1
eloc	11
nc	1
nop	0

<?php

namespace N98\Magento\Command\Database;

use N98\Magento\Command\PHPUnit\TestCase;
use Symfony\Component\Console\Output\NullOutput;
use Symfony\Component\Console\Tester\ApplicationTester;
use Symfony\Component\Console\Tester\CommandTester;

/**
 * @see \N98\Magento\Command\Database\DumpCommand
 */
class DumpCommandTest extends TestCase
{
    /**
     * @return \Symfony\Component\Console\Command\Command
     */
    protected function getCommand()
    {
        $application = $this->getApplication();
        $application->add(new DumpCommand());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $command = $this->getApplication()->find('db:dump');
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        return $command;
    }

    public function testExecute()
    {
        $command = $this->getCommand();

        $commandTester = new CommandTester($command);
        $commandTester->execute(
            array(
                'command'        => $command->getName(),
                '--add-time'     => true,
                '--only-command' => true,
                '--force'        => true,
                '--compression'  => 'gz'
            )
        );
    
        $this->assertRegExp('/mysqldump/', $commandTester->getDisplay());
        $this->assertRegExp('/\.sql/', $commandTester->getDisplay());
        $this->assertContains(".sql.gz", $commandTester->getDisplay());
    }

    /**
     * @see filenamePatterns
     */
    public function provideFilenamePatternsAndOptions()
    {
        return [
            # testAddTimeAutogenerated
            ['/^.*[0-9]{4}-[0-9]{2}-[0-9]{2}_[0-9]{6}\.sql$/', []],
            # testAddTimePrefixAutogenerated
            ['/^[0-9]{4}-[0-9]{2}-[0-9]{2}_[0-9]{6}.*\.sql$/', ['--add-time' => 'prefix',]],
            # testAddTimeFilenameSpecified
            [ '/^.*[0-9]{4}-[0-9]{2}-[0-9]{2}_[0-9]{6}\.sql.gz$/', ['--compression' => 'gzip',]],
            # testAddTimeFilenameSpecified
            ['/^foo_[0-9]{4}-[0-9]{2}-[0-9]{2}_[0-9]{6}\.sql$/', ['filename' => 'foo.sql',]],
            # testAddTimePrefixFilenameSpecified
            [ '/^[0-9]{4}-[0-9]{2}-[0-9]{2}_[0-9]{6}_foo\.sql$/', ['filename' => 'foo.sql', '--add-time' => 'prefix',]],
            # testAddTimeOffFilenameSpecified
            ['/^foo.sql$/', ['filename' => 'foo.sql', '--add-time' => false,]],
            # testAddTimeFilenameSpecifiedRelative
            ['/^..\/foo_[0-9]{4}-[0-9]{2}-[0-9]{2}_[0-9]{6}\.sql$/', ['filename' => '../foo.sql',]],
        ];
    }

    /**
     * @test
     * @dataProvider provideFilenamePatternsAndOptions
     *
     * @param string $regex
     * @param array $options
     * @return void
     */
    public function filenamePatterns($regex, array $options)
    {
        $command = $this->getCommand();

        $mandatory = array(
            'command' => $command->getName(),
            '--force' => true,
            '--print-only-filename' => true,
            '--dry-run' => null,
        );

        $defaults = array(
            '--add-time' => true,
        );

        $commandTester = new CommandTester($command);
        $commandTester->execute($mandatory + $options + $defaults);
        $this->assertRegExp($regex, $commandTester->getDisplay());
    }

    public function testWithStripOption()
    {
        $command = $this->getCommand();

        $this->getApplication()->initMagento();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        $commandTester = new CommandTester($command);
        $commandTester->execute(
            array(
                'command'        => $command->getName(),
                '--add-time'     => true,
                '--only-command' => true,
                '--force'        => true,
                '--strip'        => '@development not_existing_table_1',
                '--compression'  => 'gzip'
            )
        );

        $dbConfig = $this->getDatabaseConnection()->getConfig();
        $db = $dbConfig['dbname'];

        $this->assertRegExp("/--ignore-table=$db.customer_entity/", $commandTester->getDisplay());
        $this->assertRegExp("/--ignore-table=$db.customer_address_entity/", $commandTester->getDisplay());
        $this->assertRegExp("/--ignore-table=$db.sales_order/", $commandTester->getDisplay());
        $this->assertRegExp("/--ignore-table=$db.sales_order_item/", $commandTester->getDisplay());
        $this->assertRegExp("/--ignore-table=$db.sales_order_item/", $commandTester->getDisplay());
        $this->assertNotContains("not_existing_table_1", $commandTester->getDisplay());
        $this->assertContains(".sql.gz", $commandTester->getDisplay());


        /**
         * Uncompressed
         */
        $commandTester = new CommandTester($command);
        $commandTester->execute(
            array(
                'command'        => $command->getName(),
                '--add-time'     => true,
                '--only-command' => true,
                '--force'        => true,
                '--strip'        => '@development',
            )
        );
        $this->assertNotContains(".sql.gz", $commandTester->getDisplay());

    }
}


1			<?php
2
3			namespace N98\Magento\Command\Database;
4
5			use N98\Magento\Command\PHPUnit\TestCase;
6			use Symfony\Component\Console\Output\NullOutput;
7			use Symfony\Component\Console\Tester\ApplicationTester;
8			use Symfony\Component\Console\Tester\CommandTester;
9
10			/**
11			* @see \N98\Magento\Command\Database\DumpCommand
12			*/
13			class DumpCommandTest extends TestCase
14			{
15			/**
16			* @return \Symfony\Component\Console\Command\Command
17			*/
18			protected function getCommand()
19			{
20			$application = $this->getApplication();
21			$application->add(new DumpCommand());
			0 ignored issues – show Bug introduced 2015-11-23 11:00 UTC by Report Bug Copy Issue Report The method `add` does only exist in `N98\Magento\Application`, but not in `PHPUnit_Framework_MockObject_MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
22			$command = $this->getApplication()->find('db:dump');
			0 ignored issues – show Bug introduced 2015-11-23 11:00 UTC by Report Bug Copy Issue Report The method `find` does only exist in `N98\Magento\Application`, but not in `PHPUnit_Framework_MockObject_MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
23
24			return $command;
25			}
26
27			public function testExecute()
28			{
29			$command = $this->getCommand();
30
31			$commandTester = new CommandTester($command);
32			$commandTester->execute(
33			array(
34			'command' => $command->getName(),
35			'--add-time' => true,
36			'--only-command' => true,
37			'--force' => true,
38			'--compression' => 'gz'
39			)
40			);
41
42			$this->assertRegExp('/mysqldump/', $commandTester->getDisplay());
43			$this->assertRegExp('/\.sql/', $commandTester->getDisplay());
44			$this->assertContains(".sql.gz", $commandTester->getDisplay());
45			}
46
47			/**
48			* @see filenamePatterns
49			*/
50			public function provideFilenamePatternsAndOptions()
51			{
52			return [
53			# testAddTimeAutogenerated
54			['/^.*[0-9]{4}-[0-9]{2}-[0-9]{2}_[0-9]{6}\.sql$/', []],
55			# testAddTimePrefixAutogenerated
56			['/^[0-9]{4}-[0-9]{2}-[0-9]{2}_[0-9]{6}.*\.sql$/', ['--add-time' => 'prefix',]],
57			# testAddTimeFilenameSpecified
58			[ '/^.*[0-9]{4}-[0-9]{2}-[0-9]{2}_[0-9]{6}\.sql.gz$/', ['--compression' => 'gzip',]],
59			# testAddTimeFilenameSpecified
60			['/^foo_[0-9]{4}-[0-9]{2}-[0-9]{2}_[0-9]{6}\.sql$/', ['filename' => 'foo.sql',]],
61			# testAddTimePrefixFilenameSpecified
62			[ '/^[0-9]{4}-[0-9]{2}-[0-9]{2}_[0-9]{6}_foo\.sql$/', ['filename' => 'foo.sql', '--add-time' => 'prefix',]],
63			# testAddTimeOffFilenameSpecified
64			['/^foo.sql$/', ['filename' => 'foo.sql', '--add-time' => false,]],
65			# testAddTimeFilenameSpecifiedRelative
66			['/^..\/foo_[0-9]{4}-[0-9]{2}-[0-9]{2}_[0-9]{6}\.sql$/', ['filename' => '../foo.sql',]],
67			];
68			}
69
70			/**
71			* @test
72			* @dataProvider provideFilenamePatternsAndOptions
73			*
74			* @param string $regex
75			* @param array $options
76			* @return void
77			*/
78			public function filenamePatterns($regex, array $options)
79			{
80			$command = $this->getCommand();
81
82			$mandatory = array(
83			'command' => $command->getName(),
84			'--force' => true,
85			'--print-only-filename' => true,
86			'--dry-run' => null,
87			);
88
89			$defaults = array(
90			'--add-time' => true,
91			);
92
93			$commandTester = new CommandTester($command);
94			$commandTester->execute($mandatory + $options + $defaults);
95			$this->assertRegExp($regex, $commandTester->getDisplay());
96			}
97
98			public function testWithStripOption()
99			{
100			$command = $this->getCommand();
101
102			$this->getApplication()->initMagento();
			0 ignored issues – show Bug introduced 2015-11-23 11:00 UTC by Report Bug Copy Issue Report The method `initMagento` does only exist in `N98\Magento\Application`, but not in `PHPUnit_Framework_MockObject_MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
103
104			$commandTester = new CommandTester($command);
105			$commandTester->execute(
106			array(
107			'command' => $command->getName(),
108			'--add-time' => true,
109			'--only-command' => true,
110			'--force' => true,
111			'--strip' => '@development not_existing_table_1',
112			'--compression' => 'gzip'
113			)
114			);
115
116			$dbConfig = $this->getDatabaseConnection()->getConfig();
117			$db = $dbConfig['dbname'];
118
119			$this->assertRegExp("/--ignore-table=$db.customer_entity/", $commandTester->getDisplay());
120			$this->assertRegExp("/--ignore-table=$db.customer_address_entity/", $commandTester->getDisplay());
121			$this->assertRegExp("/--ignore-table=$db.sales_order/", $commandTester->getDisplay());
122			$this->assertRegExp("/--ignore-table=$db.sales_order_item/", $commandTester->getDisplay());
123			$this->assertRegExp("/--ignore-table=$db.sales_order_item/", $commandTester->getDisplay());
124			$this->assertNotContains("not_existing_table_1", $commandTester->getDisplay());
125			$this->assertContains(".sql.gz", $commandTester->getDisplay());
126
127
128			/**
129			* Uncompressed
130			*/
131			$commandTester = new CommandTester($command);
132			$commandTester->execute(
133			array(
134			'command' => $command->getName(),
135			'--add-time' => true,
136			'--only-command' => true,
137			'--force' => true,
138			'--strip' => '@development',
139			)
140			);
141			$this->assertNotContains(".sql.gz", $commandTester->getDisplay());
142
143			}
144			}
145

netz98 / n98-magerun2

Pull Request — develop (#184)

nameSpecified() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like