DemoNoticeCommandTest::testExecute() - Code Metrics - Inspection of "Port of design:demo-notice command, tasks #69" - netz98/n98-magerun2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 9ef43c...2134af )

by Tom

created 2016-12-20 17:16 UTC

DemoNoticeCommandTest::testExecute() B

↳ Parent: DemoNoticeCommandTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	28
Code Lines	19

Duplication

Lines	28
Ratio	100 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	28
loc	28
rs	8.8571
cc	1
eloc	19
nc	1
nop	0

<?php

namespace N98\Magento\Command\Design;

use N98\Magento\Command\TestCase;
use Symfony\Component\Console\Tester\CommandTester;

class DemoNoticeCommandTest extends TestCase

{
    public function testExecute()
    {
        $application = $this->getApplication();
        $application->add(new DemoNoticeCommand());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $application->setAutoExit(false);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $command = $this->getApplication()->find('design:demo-notice');
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        $commandTester = new CommandTester($command);
        $commandTester->execute(
            array(
                'command'  => $command->getName(),
                '--global' => true,
                '--on'     => true,
            )
        );
        $this->assertRegExp('/Demo Notice enabled/', $commandTester->getDisplay());

        $commandTester = new CommandTester($command);
        $commandTester->execute(
            array(
                'command'  => $command->getName(),
                '--global' => true,
                '--off'    => true,
            )
        );

        $this->assertRegExp('/Demo Notice disabled/', $commandTester->getDisplay());
    }
}


Push — develop ( 9ef43c...2134af )

DemoNoticeCommandTest::testExecute() B

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

1		<?php
2
3		namespace N98\Magento\Command\Design;
4
5		use N98\Magento\Command\TestCase;
6		use Symfony\Component\Console\Tester\CommandTester;
7
8	View Code Duplication	class DemoNoticeCommandTest extends TestCase
		0 ignored issues – show Duplication introduced 2016-12-20 09:07 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
9		{
10		public function testExecute()
11		{
12		$application = $this->getApplication();
13		$application->add(new DemoNoticeCommand());
		0 ignored issues – show Bug introduced 2016-12-20 09:07 UTC by Report Bug Copy Issue Report The method `add` does only exist in `N98\Magento\Application`, but not in `PHPUnit_Framework_MockObject_MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
14		$application->setAutoExit(false);
		0 ignored issues – show Bug introduced 2016-12-20 09:07 UTC by Report Bug Copy Issue Report The method `setAutoExit` does only exist in `N98\Magento\Application`, but not in `PHPUnit_Framework_MockObject_MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
15		$command = $this->getApplication()->find('design:demo-notice');
		0 ignored issues – show Bug introduced 2016-12-20 09:07 UTC by Report Bug Copy Issue Report The method `find` does only exist in `N98\Magento\Application`, but not in `PHPUnit_Framework_MockObject_MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
16
17		$commandTester = new CommandTester($command);
18		$commandTester->execute(
19		array(
20		'command' => $command->getName(),
21		'--global' => true,
22		'--on' => true,
23		)
24		);
25		$this->assertRegExp('/Demo Notice enabled/', $commandTester->getDisplay());
26
27		$commandTester = new CommandTester($command);
28		$commandTester->execute(
29		array(
30		'command' => $command->getName(),
31		'--global' => true,
32		'--off' => true,
33		)
34		);
35
36		$this->assertRegExp('/Demo Notice disabled/', $commandTester->getDisplay());
37		}
38		}
39

netz98 / n98-magerun2

Push — develop ( 9ef43c...2134af )

DemoNoticeCommandTest::testExecute() B

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like