DatabaseHelperTest::getMysqlVariable() - Code Metrics - Inspection of "Merge branch 'release/1.3.3'" - netz98/n98-magerun2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( fb5c6c...3561cd )

by Tom

created 2017-03-03 13:33 UTC

DatabaseHelperTest::getMysqlVariable() B

↳ Parent: DatabaseHelperTest

Complexity

Conditions	3
Paths	9

Size

Total Lines	41
Code Lines	23

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	41
rs	8.8571
cc	3
eloc	23
nc	9
nop	0

<?php

namespace N98\Util\Console\Helper;

use InvalidArgumentException;
use N98\Magento\Command\TestCase;
use RuntimeException;

/**
 * Class DatabaseHelperTest
 *
 * @covers  \N98\Util\Console\Helper\DatabaseHelper
 */
class DatabaseHelperTest extends TestCase
{
    /**
     * @return DatabaseHelper
     */
    protected function getHelper()
    {
        $command = $this->getApplication()->find('db:info');
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $command->getHelperSet()->setCommand($command);

        return $command->getHelper('database');
    }

    /**
     * @test
     */
    public function testHelperInstance()
    {
        $this->assertInstanceOf('\N98\Util\Console\Helper\DatabaseHelper', $this->getHelper());
    }

    /**
     * @test
     */
    public function getConnection()
    {
        $this->assertInstanceOf('\PDO', $this->getHelper()->getConnection());
    }

    /**
     * @test
     */
    public function dsn()
    {
        $this->assertStringStartsWith('mysql:', $this->getHelper()->dsn());
    }

    /**
     * @test
     */
    public function mysqlUserHasPrivilege()
    {
        $this->assertTrue($this->getHelper()->mysqlUserHasPrivilege('SELECT'));
    }

    /**
     * @test
     */
    public function getMysqlVariableValue()
    {
        $helper = $this->getHelper();

        // verify (complex) return value with existing global variable
        $actual = $helper->getMysqlVariableValue('version');

        $this->assertInternalType('array', $actual);
        $this->assertCount(1, $actual);
        $key = '@@version';
        $this->assertArrayHasKey($key, $actual);
        $this->assertInternalType('string', $actual[$key]);

        // quoted
        $actual = $helper->getMysqlVariableValue('`version`');
        $this->assertEquals('@@`version`', key($actual));

        // non-existent global variable
        try {
            $helper->getMysqlVariableValue('nonexistent');
            $this->fail('An expected exception has not been thrown');
        } catch (RuntimeException $e) {
            $this->assertEquals("Failed to query mysql variable 'nonexistent'", $e->getMessage());
        }
    }

    /**
     * @test
     */
    public function getMysqlVariable()
    {
        $helper = $this->getHelper();

        // behaviour with existing global variable
        $actual = $helper->getMysqlVariable('version');
        $this->assertInternalType('string', $actual);

        // behavior with existent session variable (INTEGER)
        $helper->getConnection()->query('SET @existent = 14;');
        $actual = $helper->getMysqlVariable('existent', '@');
        $this->assertSame("14", $actual);

        // behavior with non-existent session variable
        $actual = $helper->getMysqlVariable('nonexistent', '@');
        $this->assertNull($actual);

        // behavior with non-existent global variable
        try {
            $helper->getMysqlVariable('nonexistent');
            $this->fail('An expected Exception has not been thrown');
        } catch (RuntimeException $e) {
            // test against the mysql error message
            $this->assertStringEndsWith(
                "SQLSTATE[HY000]: 1193: Unknown system variable 'nonexistent'",
                $e->getMessage()
            );
        }

        // invalid variable type
        try {
            $helper->getMysqlVariable('nonexistent', '@@@');
            $this->fail('An expected Exception has not been thrown');
        } catch (InvalidArgumentException $e) {
            // test against the mysql error message
            $this->assertEquals(
                'Invalid mysql variable type "@@@", must be "@@" (system) or "@" (session)',
                $e->getMessage()
            );
        }
    }

    /**
     * @test
     */
    public function getTables()
    {
        $helper = $this->getHelper();

        $tables = $helper->getTables();
        $this->assertInternalType('array', $tables);
        $this->assertContains('admin_user', $tables);
    }

    /**
     * @test
     */
    public function resolveTables()
    {
        $tables = $this->getHelper()->resolveTables(array('catalog\_*'));
        $this->assertContains('catalog_product_entity', $tables);
        $this->assertNotContains('catalogrule', $tables);

        $definitions = array(
            'catalog_glob' => array('tables' => array('catalog\_*')),
            'directory'    => array('tables' => array('directory_country directory_country_format')),
        );

        $tables = $this->getHelper()->resolveTables(
            array('@catalog_glob', '@directory'),
            $definitions
        );
        $this->assertContains('catalog_product_entity', $tables);
        $this->assertContains('directory_country', $tables);
        $this->assertNotContains('catalogrule', $tables);
    }
}


1			<?php
2
3			namespace N98\Util\Console\Helper;
4
5			use InvalidArgumentException;
6			use N98\Magento\Command\TestCase;
7			use RuntimeException;
8
9			/**
10			* Class DatabaseHelperTest
11			*
12			* @covers \N98\Util\Console\Helper\DatabaseHelper
13			*/
14			class DatabaseHelperTest extends TestCase
15			{
16			/**
17			* @return DatabaseHelper
18			*/
19			protected function getHelper()
20			{
21			$command = $this->getApplication()->find('db:info');
			0 ignored issues – show Bug introduced 2015-11-23 11:00 UTC by Report Bug Copy Issue Report The method `find` does only exist in `N98\Magento\Application`, but not in `PHPUnit_Framework_MockObject_MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
22			$command->getHelperSet()->setCommand($command);
23
24			return $command->getHelper('database');
25			}
26
27			/**
28			* @test
29			*/
30			public function testHelperInstance()
31			{
32			$this->assertInstanceOf('\N98\Util\Console\Helper\DatabaseHelper', $this->getHelper());
33			}
34
35			/**
36			* @test
37			*/
38			public function getConnection()
39			{
40			$this->assertInstanceOf('\PDO', $this->getHelper()->getConnection());
41			}
42
43			/**
44			* @test
45			*/
46			public function dsn()
47			{
48			$this->assertStringStartsWith('mysql:', $this->getHelper()->dsn());
49			}
50
51			/**
52			* @test
53			*/
54			public function mysqlUserHasPrivilege()
55			{
56			$this->assertTrue($this->getHelper()->mysqlUserHasPrivilege('SELECT'));
57			}
58
59			/**
60			* @test
61			*/
62			public function getMysqlVariableValue()
63			{
64			$helper = $this->getHelper();
65
66			// verify (complex) return value with existing global variable
67			$actual = $helper->getMysqlVariableValue('version');
68
69			$this->assertInternalType('array', $actual);
70			$this->assertCount(1, $actual);
71			$key = '@@version';
72			$this->assertArrayHasKey($key, $actual);
73			$this->assertInternalType('string', $actual[$key]);
74
75			// quoted
76			$actual = $helper->getMysqlVariableValue('`version`');
77			$this->assertEquals('@@`version`', key($actual));
78
79			// non-existent global variable
80			try {
81			$helper->getMysqlVariableValue('nonexistent');
82			$this->fail('An expected exception has not been thrown');
83			} catch (RuntimeException $e) {
84			$this->assertEquals("Failed to query mysql variable 'nonexistent'", $e->getMessage());
85			}
86			}
87
88			/**
89			* @test
90			*/
91			public function getMysqlVariable()
92			{
93			$helper = $this->getHelper();
94
95			// behaviour with existing global variable
96			$actual = $helper->getMysqlVariable('version');
97			$this->assertInternalType('string', $actual);
98
99			// behavior with existent session variable (INTEGER)
100			$helper->getConnection()->query('SET @existent = 14;');
101			$actual = $helper->getMysqlVariable('existent', '@');
102			$this->assertSame("14", $actual);
103
104			// behavior with non-existent session variable
105			$actual = $helper->getMysqlVariable('nonexistent', '@');
106			$this->assertNull($actual);
107
108			// behavior with non-existent global variable
109			try {
110			$helper->getMysqlVariable('nonexistent');
111			$this->fail('An expected Exception has not been thrown');
112			} catch (RuntimeException $e) {
113			// test against the mysql error message
114			$this->assertStringEndsWith(
115			"SQLSTATE[HY000]: 1193: Unknown system variable 'nonexistent'",
116			$e->getMessage()
117			);
118			}
119
120			// invalid variable type
121			try {
122			$helper->getMysqlVariable('nonexistent', '@@@');
123			$this->fail('An expected Exception has not been thrown');
124			} catch (InvalidArgumentException $e) {
125			// test against the mysql error message
126			$this->assertEquals(
127			'Invalid mysql variable type "@@@", must be "@@" (system) or "@" (session)',
128			$e->getMessage()
129			);
130			}
131			}
132
133			/**
134			* @test
135			*/
136			public function getTables()
137			{
138			$helper = $this->getHelper();
139
140			$tables = $helper->getTables();
141			$this->assertInternalType('array', $tables);
142			$this->assertContains('admin_user', $tables);
143			}
144
145			/**
146			* @test
147			*/
148			public function resolveTables()
149			{
150			$tables = $this->getHelper()->resolveTables(array('catalog\_*'));
151			$this->assertContains('catalog_product_entity', $tables);
152			$this->assertNotContains('catalogrule', $tables);
153
154			$definitions = array(
155			'catalog_glob' => array('tables' => array('catalog\_*')),
156			'directory' => array('tables' => array('directory_country directory_country_format')),
157			);
158
159			$tables = $this->getHelper()->resolveTables(
160			array('@catalog_glob', '@directory'),
161			$definitions
162			);
163			$this->assertContains('catalog_product_entity', $tables);
164			$this->assertContains('directory_country', $tables);
165			$this->assertNotContains('catalogrule', $tables);
166			}
167			}
168

netz98 / n98-magerun2

Push — master ( fb5c6c...3561cd )

DatabaseHelperTest::getMysqlVariable() B

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like