Completed
Pull Request — develop (#167)
by Robbie
06:52 queued 02:20
created
src/N98/Util/Console/Helper/DatabaseHelper.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -6,7 +6,6 @@
 block discarded – undo
6 6
 use PDOException;
7 7
 use RuntimeException;
8 8
 use Symfony\Component\Console\Helper\Helper as AbstractHelper;
9
-use N98\Magento\Application;
10 9
 use Symfony\Component\Console\Output\NullOutput;
11 10
 use Symfony\Component\Console\Output\OutputInterface;
12 11
 
Please login to merge, or discard this patch.
src/N98/Util/Console/Helper/MagentoHelper.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace N98\Util\Console\Helper;
4 4
 
5 5
 use N98\Magento\Application;
6
-use N98\Util\BinaryString;
7 6
 use RuntimeException;
8 7
 use Symfony\Component\Console\Helper\Helper as AbstractHelper;
9 8
 use Symfony\Component\Console\Input\ArgvInput;
Please login to merge, or discard this patch.
src/N98/Util/Console/Helper/ParameterHelper.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -9,7 +9,6 @@
 block discarded – undo
9 9
 use Symfony\Component\Console\Helper\Helper as AbstractHelper;
10 10
 use Symfony\Component\Console\Output\OutputInterface;
11 11
 use Symfony\Component\Console\Input\InputInterface;
12
-use Symfony\Component\Console\Output\Output;
13 12
 use Symfony\Component\Translation\Translator;
14 13
 use Symfony\Component\Validator\Constraint;
15 14
 use Symfony\Component\Validator\Validator;
Please login to merge, or discard this patch.
tests/N98/Magento/Command/Database/Maintain/CheckTablesCommandTest.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -2,8 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace N98\Magento\Command\Database\Maintain;
4 4
 
5
-use Symfony\Component\Console\Output\NullOutput;
6
-use Symfony\Component\Console\Tester\ApplicationTester;
7 5
 use Symfony\Component\Console\Tester\CommandTester;
8 6
 use N98\Magento\Command\PHPUnit\TestCase;
9 7
 
Please login to merge, or discard this patch.
tests/N98/Util/Console/Helper/DatabaseHelperTest.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -2,7 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace N98\Util\Console\Helper;
4 4
 
5
-use Symfony\Component\Console\Tester\CommandTester;
6 5
 use N98\Magento\Command\PHPUnit\TestCase;
7 6
 
8 7
 
Please login to merge, or discard this patch.
src/N98/Magento/Application.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -392,7 +392,7 @@  discard block
 block discarded – undo
392 392
     public function checkVarDir(OutputInterface $output)
393 393
     {
394 394
         if (OutputInterface::VERBOSITY_NORMAL <= $output->getVerbosity()) {
395
-            $tempVarDir = sys_get_temp_dir() . DIRECTORY_SEPARATOR . 'magento' . DIRECTORY_SEPARATOR .  'var';
395
+            $tempVarDir = sys_get_temp_dir() . DIRECTORY_SEPARATOR . 'magento' . DIRECTORY_SEPARATOR . 'var';
396 396
 
397 397
             if (is_dir($tempVarDir)) {
398 398
                 $this->detectMagento(null, $output);
@@ -659,7 +659,7 @@  discard block
 block discarded – undo
659 659
             $this->partialConfig = $configLoader->getPartialConfig($loadExternalConfig);
660 660
             $this->detectMagento($input, $output);
661 661
             $configLoader->loadStageTwo($this->_magentoRootFolder, $loadExternalConfig, $this->_magerunStopFileFolder);
662
-            $this->config = $configLoader->toArray();;
662
+            $this->config = $configLoader->toArray(); ;
663 663
             $this->dispatcher = new EventDispatcher();
664 664
             $this->setDispatcher($this->dispatcher);
665 665
             if ($this->autoloader) {
Please login to merge, or discard this patch.
src/N98/Magento/Command/AbstractMagentoCommand.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -202,7 +202,7 @@  discard block
 block discarded – undo
202 202
 
203 203
         if (!$silent) {
204 204
             $editionString = ($this->_magentoEnterprise ? ' (Enterprise Edition) ' : '');
205
-            $output->writeln('<info>Found Magento '. $editionString . 'in folder "' . $this->_magentoRootFolder . '"</info>');
205
+            $output->writeln('<info>Found Magento ' . $editionString . 'in folder "' . $this->_magentoRootFolder . '"</info>');
206 206
         }
207 207
 
208 208
         if (!empty($this->_magentoRootFolder)) {
@@ -266,7 +266,7 @@  discard block
 block discarded – undo
266 266
         $preferSource = true
267 267
     ) {
268 268
         $dm = $this->getComposerDownloadManager($input, $output);
269
-        if (! $config instanceof PackageInterface) {
269
+        if (!$config instanceof PackageInterface) {
270 270
             $package = $this->createComposerPackageByConfig($config);
271 271
         } else {
272 272
             $package = $config;
@@ -310,7 +310,7 @@  discard block
 block discarded – undo
310 310
                 escapeshellarg($targetFolder),
311 311
                 escapeshellarg($package->getSourceReference())
312 312
             );
313
-            $existingTag =  shell_exec($command);
313
+            $existingTag = shell_exec($command);
314 314
             if ($existingTag === $package->getSourceReference()) {
315 315
                 $command = sprintf('cd %s && hg pull', escapeshellarg($targetFolder));
316 316
                 shell_exec($command);
Please login to merge, or discard this patch.
src/N98/Magento/Command/Cache/AbstractModifierCommand.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
         // Find out which types simply do not exist or are not affected by modifier
56 56
         $invalidTypes = array_diff($types, array_keys($this->getCacheTypes(!static::TARGET_IS_ENABLED)));
57 57
 
58
-        if (! empty($invalidTypes)) {
58
+        if (!empty($invalidTypes)) {
59 59
             $output->writeln(sprintf(static::INVALID_TYPES_MESSAGE, implode(', ', $invalidTypes)));
60 60
         }
61 61
 
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
         }
69 69
 
70 70
         /** @var $cacheState \Magento\Framework\App\Cache\StateInterface */
71
-        $cacheState =  $this->getObjectManager()->get('\Magento\Framework\App\Cache\StateInterface');
71
+        $cacheState = $this->getObjectManager()->get('\Magento\Framework\App\Cache\StateInterface');
72 72
         $touchedTypes = [];
73 73
 
74 74
         try {
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
             }
83 83
 
84 84
             $cacheState->persist();
85
-        } catch(\Exception $e) {
85
+        } catch (\Exception $e) {
86 86
             $output->writeln(sprintf(static::EXCEPTION_MESSAGE, $e->getMessage()));
87 87
         }
88 88
 
Please login to merge, or discard this patch.
src/N98/Magento/Command/Cache/ListCommand.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -73,7 +73,7 @@
 block discarded – undo
73 73
         foreach ($cacheTypes as $cacheType) {
74 74
 
75 75
             // If 'enabled' option is set, filter those who match
76
-            if (! is_null($input->getOption('enabled')) && $input->getOption('enabled') != $cacheType->getStatus()) {
76
+            if (!is_null($input->getOption('enabled')) && $input->getOption('enabled') != $cacheType->getStatus()) {
77 77
                 unset($cacheTypes[$cacheType->getId()]);
78 78
                 continue;
79 79
             }
Please login to merge, or discard this patch.