Completed
Pull Request — develop (#167)
by Robbie
06:52 queued 02:20
created
src/N98/Magento/Command/System/Cron/HistoryCommand.php 1 patch
Spacing   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -47,8 +47,7 @@
 block discarded – undo
47 47
         }
48 48
 
49 49
         $timezone = $input->getOption('timezone')
50
-            ? $input->getOption('timezone') :
51
-            $this->_scopeConfig->getValue('general/locale/timezone');
50
+            ? $input->getOption('timezone') : $this->_scopeConfig->getValue('general/locale/timezone');
52 51
 
53 52
         if (!$input->getOption('format')) {
54 53
             $output->writeln('<info>Times shown in <comment>' . $timezone . '</comment></info>');
Please login to merge, or discard this patch.
src/N98/Magento/Command/System/InfoCommand.php 2 patches
Indentation   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -151,32 +151,32 @@
 block discarded – undo
151 151
     protected function addProductCount()
152 152
     {
153 153
         $this->infos['Product Count'] = $this->productFactory
154
-                                             ->create()
155
-                                             ->getCollection()
156
-                                             ->getSize();
154
+                                                ->create()
155
+                                                ->getCollection()
156
+                                                ->getSize();
157 157
     }
158 158
 
159 159
     protected function addCustomerCount()
160 160
     {
161 161
         $this->infos['Customer Count'] = $this->customerFactory->create()
162
-                                              ->getCollection()
163
-                                              ->getSize();
162
+                                                ->getCollection()
163
+                                                ->getSize();
164 164
     }
165 165
 
166 166
     protected function addCategoryCount()
167 167
     {
168 168
         $this->infos['Category Count'] = $this->categoryFactory
169
-                                              ->create()
170
-                                              ->getCollection()
171
-                                              ->getSize();
169
+                                                ->create()
170
+                                                ->getCollection()
171
+                                                ->getSize();
172 172
     }
173 173
 
174 174
     protected function addAttributeCount()
175 175
     {
176 176
         $this->infos['Attribute Count'] = $this->attributeFactory
177
-                                               ->create()
178
-                                               ->getCollection()
179
-                                               ->getSize();
177
+                                                ->create()
178
+                                                ->getCollection()
179
+                                                ->getSize();
180 180
     }
181 181
 
182 182
     protected function addCacheInfos()
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -103,7 +103,7 @@
 block discarded – undo
103 103
 
104 104
     public function hasInfo()
105 105
     {
106
-        return ! empty($this->infos);
106
+        return !empty($this->infos);
107 107
     }
108 108
 
109 109
     public function getInfo($key = null)
Please login to merge, or discard this patch.
src/N98/Magento/Command/System/MaintenanceCommand.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -43,15 +43,15 @@  discard block
 block discarded – undo
43 43
                         ->get('\Magento\Framework\Filesystem')
44 44
                         ->getDirectoryWrite(MaintenanceMode::FLAG_DIR);
45 45
 
46
-        if (! is_null($input->getOption('off'))) {
47
-            if (! $flagDir->isExist(MaintenanceMode::FLAG_FILENAME)) {
46
+        if (!is_null($input->getOption('off'))) {
47
+            if (!$flagDir->isExist(MaintenanceMode::FLAG_FILENAME)) {
48 48
                 return $output->writeln(self::ALREADY_DISABLED_MESSAGE);
49 49
             }
50 50
 
51 51
             return $this->handleDisable($flagDir, $output, $input->getOption('off'));
52 52
         }
53 53
 
54
-        if (! is_null($input->getOption('on'))) {
54
+        if (!is_null($input->getOption('on'))) {
55 55
             if ($flagDir->isExist(MaintenanceMode::FLAG_FILENAME)) {
56 56
                 return $output->writeln(self::ALREADY_ENABLED_MESSAGE);
57 57
             }
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
     protected function handleDisable(
76 76
         \Magento\Framework\Filesystem\Directory\Write $flagDir,
77 77
         OutputInterface $output,
78
-        $offOption= null
78
+        $offOption = null
79 79
     ) {
80 80
         $flagDir->delete(MaintenanceMode::FLAG_FILENAME);
81 81
         $output->writeln(self::DISABLED_MESSAGE);
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
         $flagDir->touch(MaintenanceMode::FLAG_FILENAME);
101 101
         $output->writeln(self::ENABLED_MESSAGE);
102 102
 
103
-        if (! is_null($onOption)) {
103
+        if (!is_null($onOption)) {
104 104
             // Write IPs to exclusion file
105 105
             $flagDir->writeFile(MaintenanceMode::IP_FILENAME, $onOption);
106 106
             $output->writeln(self::WROTE_IP_MESSAGE);
Please login to merge, or discard this patch.
src/N98/Util/Console/Helper/ComposerHelper.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@
 block discarded – undo
29 29
         $process = ProcessBuilder::create($commandArgs)->getProcess();
30 30
         $process->setInput($this->input);
31 31
         $process->setTimeout(3600);
32
-        $process->run(function ($type, $buffer) use ($silent) {
32
+        $process->run(function($type, $buffer) use ($silent) {
33 33
             if ($silent) {
34 34
                 return;
35 35
             }
Please login to merge, or discard this patch.
src/N98/Util/Console/Helper/InjectionHelper.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@
 block discarded – undo
32 32
             $argumentsToInject[] = $objectManager->get($parameter[1]);
33 33
         }
34 34
 
35
-        call_user_func_array([ $object, $methodName ], $argumentsToInject);
35
+        call_user_func_array([$object, $methodName], $argumentsToInject);
36 36
     }
37 37
 
38 38
     /**
Please login to merge, or discard this patch.
tests/N98/Magento/Command/Cache/EnableCommandTest.php 1 patch
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -1,9 +1,9 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * @todo    writing unit tests for toggling caches is complicated because environments differ
4
- *          touching caches changes state and will result in different test result second time
5
- *          solutions: disabling/enabling, faking&mocking or having one defined test environment
6
- */
3
+     * @todo    writing unit tests for toggling caches is complicated because environments differ
4
+     *          touching caches changes state and will result in different test result second time
5
+     *          solutions: disabling/enabling, faking&mocking or having one defined test environment
6
+     */
7 7
 namespace N98\Magento\Command\Cache;
8 8
 
9 9
 use Symfony\Component\Console\Tester\CommandTester;
Please login to merge, or discard this patch.
tests/N98/Magento/Command/Cache/ListCommandTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@
 block discarded – undo
42 42
         $disabledCacheTypes = 0;
43 43
 
44 44
         foreach ($cacheTypes as $cacheType) {
45
-            if (! $cacheType->getStatus()) {
45
+            if (!$cacheType->getStatus()) {
46 46
                 $disabledCacheTypes++;
47 47
             }
48 48
         }
Please login to merge, or discard this patch.
tests/N98/Magento/Command/Config/DeleteCommandTest.php 1 patch
Indentation   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -47,11 +47,11 @@  discard block
 block discarded – undo
47 47
             $commandTester = new CommandTester($setCommand);
48 48
             $commandTester->execute(
49 49
                 array(
50
-                     'command'    => $setCommand->getName(),
51
-                     'path'       => 'n98_magerun/foo/bar',
52
-                     '--scope'    => 'stores',
53
-                     '--scope-id'  => $store->getId(),
54
-                     'value'      => 'store-' . $store->getId(),
50
+                        'command'    => $setCommand->getName(),
51
+                        'path'       => 'n98_magerun/foo/bar',
52
+                        '--scope'    => 'stores',
53
+                        '--scope-id'  => $store->getId(),
54
+                        'value'      => 'store-' . $store->getId(),
55 55
                 )
56 56
             );
57 57
         }
@@ -59,9 +59,9 @@  discard block
 block discarded – undo
59 59
         $commandTester = new CommandTester($deleteCommand);
60 60
         $commandTester->execute(
61 61
             array(
62
-                 'command' => $deleteCommand->getName(),
63
-                 'path'    => 'n98_magerun/foo/bar',
64
-                 '--all'   => true,
62
+                    'command' => $deleteCommand->getName(),
63
+                    'path'    => 'n98_magerun/foo/bar',
64
+                    '--all'   => true,
65 65
             )
66 66
         );
67 67
 
Please login to merge, or discard this patch.
tests/N98/Magento/Command/Config/GetCommandTest.php 1 patch
Indentation   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -20,26 +20,26 @@  discard block
 block discarded – undo
20 20
         $commandTester = new CommandTester($setCommand);
21 21
         $commandTester->execute(
22 22
             array(
23
-                 'command' => $setCommand->getName(),
24
-                 'path'    => 'n98_magerun/foo/bar',
25
-                 'value'   => '1234',
23
+                    'command' => $setCommand->getName(),
24
+                    'path'    => 'n98_magerun/foo/bar',
25
+                    'value'   => '1234',
26 26
             )
27 27
         );
28 28
 
29 29
         $commandTester = new CommandTester($getCommand);
30 30
         $commandTester->execute(
31 31
             array(
32
-                 'command' => $getCommand->getName(),
33
-                 'path'    => 'n98_magerun/foo/bar',
32
+                    'command' => $getCommand->getName(),
33
+                    'path'    => 'n98_magerun/foo/bar',
34 34
             )
35 35
         );
36 36
         $this->assertContains('| n98_magerun/foo/bar | default | 0        | 1234  |', $commandTester->getDisplay());
37 37
 
38 38
         $commandTester->execute(
39 39
             array(
40
-                 'command'         => $getCommand->getName(),
41
-                 'path'            => 'n98_magerun/foo/bar',
42
-                 '--update-script' => true
40
+                    'command'         => $getCommand->getName(),
41
+                    'path'            => 'n98_magerun/foo/bar',
42
+                    '--update-script' => true
43 43
             )
44 44
         );
45 45
         $this->assertContains(
@@ -49,9 +49,9 @@  discard block
 block discarded – undo
49 49
 
50 50
         $commandTester->execute(
51 51
             array(
52
-                 'command'          => $getCommand->getName(),
53
-                 'path'             => 'n98_magerun/foo/bar',
54
-                 '--magerun-script' => true
52
+                    'command'          => $getCommand->getName(),
53
+                    'path'             => 'n98_magerun/foo/bar',
54
+                    '--magerun-script' => true
55 55
             )
56 56
         );
57 57
         $this->assertContains(
Please login to merge, or discard this patch.