Completed
Pull Request — develop (#167)
by Robbie
06:52 queued 02:20
created
src/N98/Magento/Command/System/Cron/RunCommand.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -97,7 +97,7 @@
 block discarded – undo
97 97
      * @param InputInterface $input
98 98
      * @param OutputInterface $output
99 99
      * @param array $jobs
100
-     * @return mixed
100
+     * @return string
101 101
      * @throws \InvalidArgumentException
102 102
      * @throws \Exception
103 103
      */
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
 
49 49
         $jobConfig = $this->getJobConfig($jobCode);
50 50
 
51
-        if (empty($jobCode)|| !isset($jobConfig['instance'])) {
51
+        if (empty($jobCode) || !isset($jobConfig['instance'])) {
52 52
             throw new \InvalidArgumentException('No job config found!');
53 53
         }
54 54
 
@@ -104,14 +104,14 @@  discard block
 block discarded – undo
104 104
     protected function askJobCode(InputInterface $input, OutputInterface $output, $jobs)
105 105
     {
106 106
         foreach ($jobs as $key => $job) {
107
-            $question[] = '<comment>[' . ($key+1) . ']</comment> ' . $job['Job'] . PHP_EOL;
107
+            $question[] = '<comment>[' . ($key + 1) . ']</comment> ' . $job['Job'] . PHP_EOL;
108 108
         }
109 109
         $question[] = '<question>Please select job: </question>' . PHP_EOL;
110 110
 
111 111
         $jobCode = $this->getHelperSet()->get('dialog')->askAndValidate(
112 112
             $output,
113 113
             $question,
114
-            function ($typeInput) use ($jobs) {
114
+            function($typeInput) use ($jobs) {
115 115
                 if (!isset($jobs[$typeInput - 1])) {
116 116
                     throw new \InvalidArgumentException('Invalid job');
117 117
                 }
Please login to merge, or discard this patch.
src/N98/Magento/Command/System/Url/ListCommand.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -63,7 +63,7 @@
 block discarded – undo
63 63
     /**
64 64
      * @param \Magento\Store\Model\StoreManager $storeManager
65 65
      * @param \Magento\Sitemap\Model\ResourceModel\Catalog\Category $sitemapCategoryCollection
66
-     * @param \Magento\Sitemap\Model\ResourceModel\Catalog\Product $sitmapProductCollection
66
+     * @param \Magento\Sitemap\Model\ResourceModel\Catalog\Product $sitemapProductCollection
67 67
      * @param \Magento\Sitemap\Model\ResourceModel\Cms\Page $sitemapPageCollection
68 68
      */
69 69
     public function inject(
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
     {
76 76
         $this->storeManager = $storeManager;
77 77
         $this->sitemapCategoryCollection = $sitemapCategoryCollection;
78
-        $this->sitemapProductCollection= $sitemapProductCollection;
78
+        $this->sitemapProductCollection = $sitemapProductCollection;
79 79
         $this->sitemapPageCollection = $sitemapPageCollection;
80 80
     }
81 81
 
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
 
100 100
                 try {
101 101
                     $currentStore = $this->storeManager->getStore($storeId);
102
-                } catch(\Exception $e) {
102
+                } catch (\Exception $e) {
103 103
                     throw new \RuntimeException("Store with id {$storeId} doesn´t exist");
104 104
                 }
105 105
 
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
 
150 150
                     $parts = parse_url($url);
151 151
                     foreach ($parts as $key => $value) {
152
-                        $line = str_replace('{'.$key.'}', $value, $line);
152
+                        $line = str_replace('{' . $key . '}', $value, $line);
153 153
                     }
154 154
 
155 155
                     // ... and output
Please login to merge, or discard this patch.
src/N98/Magento/Framework/App/Magerun.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@
 block discarded – undo
51 51
      *
52 52
      * @param Bootstrap $bootstrap
53 53
      * @param \Exception $exception
54
-     * @return bool
54
+     * @return boolean|null
55 55
      */
56 56
     public function catchException(Bootstrap $bootstrap, \Exception $exception)
57 57
     {
Please login to merge, or discard this patch.
src/N98/Util/Console/Helper/DatabaseHelper.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -6,7 +6,6 @@
 block discarded – undo
6 6
 use PDOException;
7 7
 use RuntimeException;
8 8
 use Symfony\Component\Console\Helper\Helper as AbstractHelper;
9
-use N98\Magento\Application;
10 9
 use Symfony\Component\Console\Output\NullOutput;
11 10
 use Symfony\Component\Console\Output\OutputInterface;
12 11
 
Please login to merge, or discard this patch.
src/N98/Util/Console/Helper/MagentoHelper.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace N98\Util\Console\Helper;
4 4
 
5 5
 use N98\Magento\Application;
6
-use N98\Util\BinaryString;
7 6
 use RuntimeException;
8 7
 use Symfony\Component\Console\Helper\Helper as AbstractHelper;
9 8
 use Symfony\Component\Console\Input\ArgvInput;
Please login to merge, or discard this patch.
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -387,6 +387,9 @@
 block discarded – undo
387 387
         return $application;
388 388
     }
389 389
 
390
+    /**
391
+     * @param string $configFileName
392
+     */
390 393
     private function addBaseConfig($root, $configFileName)
391 394
     {
392 395
         $configFile = $root . '/' . $configFileName;
Please login to merge, or discard this patch.
src/N98/Util/Console/Helper/ParameterHelper.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -202,7 +202,7 @@
 block discarded – undo
202 202
      * @param OutputInterface                                $output
203 203
      * @param string                                         $name
204 204
      * @param string                                         $value
205
-     * @param Constraints\Collection|Constraint|Constraint[] $constraints The constraint(s) to validate against.
205
+     * @param Constraints\Collection $constraints The constraint(s) to validate against.
206 206
      *
207 207
      * @return mixed
208 208
      */
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -9,7 +9,6 @@
 block discarded – undo
9 9
 use Symfony\Component\Console\Helper\Helper as AbstractHelper;
10 10
 use Symfony\Component\Console\Output\OutputInterface;
11 11
 use Symfony\Component\Console\Input\InputInterface;
12
-use Symfony\Component\Console\Output\Output;
13 12
 use Symfony\Component\Translation\Translator;
14 13
 use Symfony\Component\Validator\Constraint;
15 14
 use Symfony\Component\Validator\Validator;
Please login to merge, or discard this patch.
src/N98/Util/Console/Helper/Table/Renderer/RendererInterface.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -9,6 +9,7 @@
 block discarded – undo
9 9
     /**
10 10
      * @param OutputInterface $output
11 11
      * @param array $rows
12
+     * @return void
12 13
      */
13 14
     public function render(OutputInterface $output, array $rows);
14 15
 }
Please login to merge, or discard this patch.
src/N98/View/PhpView.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@  discard block
 block discarded – undo
16 16
 
17 17
     /**
18 18
      * @param string $template
19
-     * @return Php
19
+     * @return PhpView
20 20
      */
21 21
     public function setTemplate($template)
22 22
     {
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
      * @param string $key
30 30
      * @param mixed $value
31 31
      *
32
-     * @return Php
32
+     * @return PhpView
33 33
      */
34 34
     public function assign($key, $value)
35 35
     {
Please login to merge, or discard this patch.
src/N98/View/View.php 1 patch
Doc Comments   +7 added lines patch added patch discarded remove patch
@@ -4,6 +4,13 @@
 block discarded – undo
4 4
 
5 5
 interface View
6 6
 {
7
+    /**
8
+     * @return PhpView
9
+     */
7 10
     public function assign($key, $value);
11
+
12
+    /**
13
+     * @return string
14
+     */
8 15
     public function render();
9 16
 }
Please login to merge, or discard this patch.