Completed
Pull Request — develop (#167)
by Robbie
06:52 queued 02:20
created
src/N98/Magento/Command/Database/VariablesCommand.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -72,7 +72,7 @@
 block discarded – undo
72 72
             'max_write_lock_count'     => 1,
73 73
             'slave_max_allowed_packet' => 1,
74 74
         );
75
-        $isSize  = false !== strpos($name, '_size');
75
+        $isSize = false !== strpos($name, '_size');
76 76
 
77 77
         return $isSize || isset($toHuman[$name]);
78 78
     }
Please login to merge, or discard this patch.
Command/Developer/Module/Create/SubCommand/CreateAdditionalFiles.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@
 block discarded – undo
31 31
                     $this->getCommand()->getHelper('twig')->render($template, $this->config->getArray('twigVars'))
32 32
                 );
33 33
 
34
-                $this->output->writeln('<info>Created file: <comment>' .  $outFile .'<comment></info>');
34
+                $this->output->writeln('<info>Created file: <comment>' . $outFile . '<comment></info>');
35 35
             }
36 36
 
37 37
         }
Please login to merge, or discard this patch.
Magento/Command/Developer/Module/Create/SubCommand/CreateModuleFolders.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@  discard block
 block discarded – undo
12 12
     public function execute()
13 13
     {
14 14
         if ($this->config->getBool('isModmanMode')) {
15
-            $modManDir = $this->config->getString('vendorNamespace') . '_' . $this->config->getString('moduleName'). '/src';
15
+            $modManDir = $this->config->getString('vendorNamespace') . '_' . $this->config->getString('moduleName') . '/src';
16 16
             if (file_exists($modManDir)) {
17 17
                 throw new \RuntimeException('Module already exists. Stop.');
18 18
             }
@@ -32,28 +32,28 @@  discard block
 block discarded – undo
32 32
         $this->config->setString('moduleDirectory', $moduleDir);
33 33
 
34 34
         mkdir($moduleDir, 0777, true);
35
-        $this->output->writeln('<info>Created directory: <comment>' .  $moduleDir .'<comment></info>');
35
+        $this->output->writeln('<info>Created directory: <comment>' . $moduleDir . '<comment></info>');
36 36
 
37 37
         // Add etc folder
38 38
         mkdir($moduleDir . '/etc');
39
-        $this->output->writeln('<info>Created directory: <comment>' .  $moduleDir .'/etc<comment></info>');
39
+        $this->output->writeln('<info>Created directory: <comment>' . $moduleDir . '/etc<comment></info>');
40 40
 
41 41
         // Add blocks folder
42 42
         if ($this->config->getBool('shouldAddBlocks')) {
43 43
             mkdir($moduleDir . '/Block');
44
-            $this->output->writeln('<info>Created directory: <comment>' .  $moduleDir . '/Block' .'<comment></info>');
44
+            $this->output->writeln('<info>Created directory: <comment>' . $moduleDir . '/Block' . '<comment></info>');
45 45
         }
46 46
 
47 47
         // Add helpers folder
48 48
         if ($this->config->getBool('shouldAddHelpers')) {
49 49
             mkdir($moduleDir . '/Helper');
50
-            $this->output->writeln('<info>Created directory: <comment>' .  $moduleDir . '/Helper' .'<comment></info>');
50
+            $this->output->writeln('<info>Created directory: <comment>' . $moduleDir . '/Helper' . '<comment></info>');
51 51
         }
52 52
 
53 53
         // Add models folder
54 54
         if ($this->config->getBool('shouldAddModels')) {
55 55
             mkdir($moduleDir . '/Model');
56
-            $this->output->writeln('<info>Created directory: <comment>' .  $moduleDir . '/Model' .'<comment></info>');
56
+            $this->output->writeln('<info>Created directory: <comment>' . $moduleDir . '/Model' . '<comment></info>');
57 57
         }
58 58
 
59 59
         // Create SQL and Data folder
Please login to merge, or discard this patch.
N98/Magento/Command/Developer/Module/Create/SubCommand/CreateReadmeFile.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@
 block discarded – undo
28 28
             )
29 29
         );
30 30
 
31
-        $this->output->writeln('<info>Created file: <comment>' .  $outFile .'<comment></info>');
31
+        $this->output->writeln('<info>Created file: <comment>' . $outFile . '<comment></info>');
32 32
 
33 33
         return true;
34 34
     }
Please login to merge, or discard this patch.
N98/Magento/Command/Developer/Module/Create/SubCommand/CreateSetupFiles.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
                 $this->config->getArray('twigVars')
21 21
             )
22 22
         );
23
-        $this->output->writeln('<info>Created file: <comment>' .  $setupFolder . '/InstallSchema.php' .'<comment></info>');
23
+        $this->output->writeln('<info>Created file: <comment>' . $setupFolder . '/InstallSchema.php' . '<comment></info>');
24 24
 
25 25
         \file_put_contents(
26 26
             $setupFolder . '/InstallData.php',
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
                 $this->config->getArray('twigVars')
30 30
             )
31 31
         );
32
-        $this->output->writeln('<info>Created file: <comment>' .  $setupFolder . '/InstallData.php' .'<comment></info>');
32
+        $this->output->writeln('<info>Created file: <comment>' . $setupFolder . '/InstallData.php' . '<comment></info>');
33 33
 
34 34
         \file_put_contents(
35 35
             $setupFolder . '/UpgradeSchema.php',
@@ -38,7 +38,7 @@  discard block
 block discarded – undo
38 38
                 $this->config->getArray('twigVars')
39 39
             )
40 40
         );
41
-        $this->output->writeln('<info>Created file: <comment>' .  $setupFolder . '/UpgradeSchema.php' .'<comment></info>');
41
+        $this->output->writeln('<info>Created file: <comment>' . $setupFolder . '/UpgradeSchema.php' . '<comment></info>');
42 42
 
43 43
         \file_put_contents(
44 44
             $setupFolder . '/UpgradeData.php',
@@ -47,6 +47,6 @@  discard block
 block discarded – undo
47 47
                 $this->config->getArray('twigVars')
48 48
             )
49 49
         );
50
-        $this->output->writeln('<info>Created file: <comment>' .  $setupFolder . '/UpgradeData.php' .'<comment></info>');
50
+        $this->output->writeln('<info>Created file: <comment>' . $setupFolder . '/UpgradeData.php' . '<comment></info>');
51 51
     }
52 52
 }
Please login to merge, or discard this patch.
src/N98/Magento/Command/Developer/Module/ListCommand.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -79,7 +79,7 @@
 block discarded – undo
79 79
             // First index is (probably always) vendor
80 80
             $moduleNameData = explode('_', $moduleName);
81 81
 
82
-            if (! is_null($vendor) && strtolower($moduleNameData[0]) !== strtolower($vendor)) {
82
+            if (!is_null($vendor) && strtolower($moduleNameData[0]) !== strtolower($vendor)) {
83 83
                 continue;
84 84
             }
85 85
 
Please login to merge, or discard this patch.
src/N98/Magento/Command/Developer/Module/Observer/ListCommand.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -62,15 +62,15 @@  discard block
 block discarded – undo
62 62
         $area = $input->getArgument('area');
63 63
         $eventFilter = $input->getArgument('event');
64 64
 
65
-        if (is_null($area) || ! in_array($area, $this->areas)) {
65
+        if (is_null($area) || !in_array($area, $this->areas)) {
66 66
             foreach ($this->areas as $key => $area) {
67 67
                 $question[] = '<comment>[' . ($key + 1) . ']</comment> ' . $area . PHP_EOL;
68 68
             }
69 69
 
70 70
             $question[] = '<question>Please select an area:</question>';
71 71
 
72
-            $area = $this->getHelper('dialog')->askAndValidate($output, $question, function ($areaIndex) {
73
-                if (! in_array($areaIndex, range(1, count($this->areas)))) {
72
+            $area = $this->getHelper('dialog')->askAndValidate($output, $question, function($areaIndex) {
73
+                if (!in_array($areaIndex, range(1, count($this->areas)))) {
74 74
                     throw new \InvalidArgumentException('Invalid selection.');
75 75
                 }
76 76
 
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
         if ($input->getOption('format') === null) {
82 82
             $sectionHeader = 'Observers in [' . $area . '] area';
83 83
 
84
-            if (! is_null($eventFilter)) {
84
+            if (!is_null($eventFilter)) {
85 85
                 $sectionHeader .= ' registered for [' . $eventFilter . '] event';
86 86
             }
87 87
 
@@ -109,13 +109,13 @@  discard block
 block discarded – undo
109 109
         foreach ($observerConfig as $eventName => $observers) {
110 110
             $firstObserver = true;
111 111
 
112
-            if (! is_null($eventFilter) && $eventName != $eventFilter) {
112
+            if (!is_null($eventFilter) && $eventName != $eventFilter) {
113 113
                 continue;
114 114
             }
115 115
 
116 116
             foreach ($observers as $observerName => $observerData) {
117 117
                 if ($firstObserver) {
118
-                    $firstObserver = ! $firstObserver;
118
+                    $firstObserver = !$firstObserver;
119 119
                     $table[] = [$eventName, $observerName, $observerData['instance'] . '::' . $observerData['name']];
120 120
                 } else {
121 121
                     $table[] = ['', $observerName, $observerData['instance'] . '::' . $observerData['name']];
Please login to merge, or discard this patch.
src/N98/Magento/Command/Installer/SubCommand/ChooseInstallationFolder.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@  discard block
 block discarded – undo
15 15
         $validateInstallationFolder = function($folderName) use ($input) {
16 16
             $folderName = rtrim(trim($folderName, ' '), '/');
17 17
             if (substr($folderName, 0, 1) == '.') {
18
-                $cwd = \getcwd() ;
18
+                $cwd = \getcwd();
19 19
                 if (empty($cwd) && isset($_SERVER['PWD'])) {
20 20
                     $cwd = $_SERVER['PWD'];
21 21
                 }
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
             }
28 28
 
29 29
             if (!is_dir($folderName)) {
30
-                if (!@mkdir($folderName,0777, true)) {
30
+                if (!@mkdir($folderName, 0777, true)) {
31 31
                     throw new \InvalidArgumentException('Cannot create folder.');
32 32
                 }
33 33
 
Please login to merge, or discard this patch.
src/N98/Magento/Command/Installer/SubCommand/DownloadMagento.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
 
63 63
             $process->setTimeout(86400);
64 64
             $process->start();
65
-            $process->wait(function ($type, $buffer) {
65
+            $process->wait(function($type, $buffer) {
66 66
                 $this->output->write($buffer, false, OutputInterface::OUTPUT_RAW);
67 67
             });
68 68
 
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
                 $this->getCommand()
125 125
                     ->getHelperSet()
126 126
                     ->get('formatter')
127
-                    ->formatBlock('Authentication',  'bg=blue;fg=white', true),
127
+                    ->formatBlock('Authentication', 'bg=blue;fg=white', true),
128 128
                 '',
129 129
             ));
130 130
 
@@ -137,7 +137,7 @@  discard block
 block discarded – undo
137 137
             $username = $dialog->askAndValidate(
138 138
                 $output,
139 139
                 '<comment>Please enter your public key: </comment>',
140
-                function ($value) {
140
+                function($value) {
141 141
                     if ('' === trim($value)) {
142 142
                         throw new \Exception('The private key (auth token) can not be empty');
143 143
                     }
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
             $password = $dialog->askHiddenResponseAndValidate(
153 153
                 $output,
154 154
                 '<comment>Please enter your private key: </comment>',
155
-                function ($value) {
155
+                function($value) {
156 156
                     if ('' === trim($value)) {
157 157
                         throw new \Exception('The private key (auth token) can not be empty');
158 158
                     }
Please login to merge, or discard this patch.