CreateCommandTest::testExecute() - Code Metrics - Inspection of "Merge branch 'develop'" - netz98/n98-magerun2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6764cb...4e8215 )

by Christian

created 2019-06-29 13:09 UTC

CreateCommandTest::testExecute() A

↳ Parent: CreateCommandTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	31
rs	9.424
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace N98\Magento\Command\Customer\Token;

use Magento\Store\Model\StoreManagerInterface;
use N98\Magento\Command\TestCase;
use Symfony\Component\Console\Input\ArrayInput;
use Symfony\Component\Console\Output\NullOutput;
use Symfony\Component\Console\Tester\CommandTester;

/**
 * Class CreateCommandTest
 * @package N98\Magento\Command\Customer\Token
 */
class CreateCommandTest extends TestCase
{
    public function testExecute()
    {
        $generatedEmail = uniqid() . '@example.com';

        $this->getApplication()->setAutoExit(false);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $this->getApplication()->run(
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            new ArrayInput(
                [
                    'command'   => 'customer:create',
                    'email'     => $generatedEmail,
                    'password'  => 'Password123',
                    'firstname' => 'John',
                    'lastname'  => 'Doe',
                    'website'   => $this->getWebsiteCode(),
                ]
            ),
            new NullOutput()
        );

        $command = $this->getApplication()->find('customer:token:create');
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        $commandTester = new CommandTester($command);
        $commandTester->execute([
            'email'        => $generatedEmail,
            '--no-newline' => true,
        ]);

        $output = $commandTester->getDisplay();
        $this->assertNotEmpty($output);
        $this->assertEquals(32, strlen($output));
    }

    /**
     * @return string
     */
    private function getWebsiteCode()

    {
        $storeManager = $this->getApplication()->getObjectManager()->get(StoreManagerInterface::class);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $website = $storeManager->getWebsite('base');

        return $website->getCode();
    }
}


Push — master ( 6764cb...4e8215 )

CreateCommandTest::testExecute() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1		<?php
2
3		namespace N98\Magento\Command\Customer\Token;
4
5		use Magento\Store\Model\StoreManagerInterface;
6		use N98\Magento\Command\TestCase;
7		use Symfony\Component\Console\Input\ArrayInput;
8		use Symfony\Component\Console\Output\NullOutput;
9		use Symfony\Component\Console\Tester\CommandTester;
10
11		/**
12		* Class CreateCommandTest
13		* @package N98\Magento\Command\Customer\Token
14		*/
15		class CreateCommandTest extends TestCase
16		{
17		public function testExecute()
18		{
19		$generatedEmail = uniqid() . '@example.com';
20
21		$this->getApplication()->setAutoExit(false);
		0 ignored issues – show Bug introduced 2019-06-13 16:40 UTC by Report Bug Copy Issue Report The method `setAutoExit` does only exist in `N98\Magento\Application`, but not in `PHPUnit_Framework_MockObject_MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
22		$this->getApplication()->run(
		0 ignored issues – show Bug introduced 2019-06-13 16:40 UTC by Report Bug Copy Issue Report The method `run` does only exist in `N98\Magento\Application`, but not in `PHPUnit_Framework_MockObject_MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
23		new ArrayInput(
24		[
25		'command' => 'customer:create',
26		'email' => $generatedEmail,
27		'password' => 'Password123',
28		'firstname' => 'John',
29		'lastname' => 'Doe',
30		'website' => $this->getWebsiteCode(),
31		]
32		),
33		new NullOutput()
34		);
35
36		$command = $this->getApplication()->find('customer:token:create');
		0 ignored issues – show Bug introduced 2019-06-13 16:40 UTC by Report Bug Copy Issue Report The method `find` does only exist in `N98\Magento\Application`, but not in `PHPUnit_Framework_MockObject_MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
37
38		$commandTester = new CommandTester($command);
39		$commandTester->execute([
40		'email' => $generatedEmail,
41		'--no-newline' => true,
42		]);
43
44		$output = $commandTester->getDisplay();
45		$this->assertNotEmpty($output);
46		$this->assertEquals(32, strlen($output));
47		}
48
49		/**
50		* @return string
51		*/
52	View Code Duplication	private function getWebsiteCode()
		0 ignored issues – show Duplication introduced 2019-06-13 16:40 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
53		{
54		$storeManager = $this->getApplication()->getObjectManager()->get(StoreManagerInterface::class);
		0 ignored issues – show Bug introduced 2019-06-13 16:40 UTC by Report Bug Copy Issue Report The method `getObjectManager` does only exist in `N98\Magento\Application`, but not in `PHPUnit_Framework_MockObject_MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
55		$website = $storeManager->getWebsite('base');
56
57		return $website->getCode();
58		}
59		}
60

netz98 / n98-magerun2

Push — master ( 6764cb...4e8215 )

CreateCommandTest::testExecute() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like