Completed
Push — develop ( ca40eb...664159 )
by Tom
04:30
created
src/N98/Magento/Command/Installer/SubCommand/CreateDatabase.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@
 block discarded – undo
51 51
      *
52 52
      * @param Bootstrap $bootstrap
53 53
      * @param \Exception $exception
54
-     * @return bool
54
+     * @return boolean|null
55 55
      */
56 56
     public function catchException(Bootstrap $bootstrap, \Exception $exception)
57 57
     {
Please login to merge, or discard this patch.
src/N98/Magento/Command/Installer/SubCommand/PostInstallation.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@
 block discarded – undo
51 51
      *
52 52
      * @param Bootstrap $bootstrap
53 53
      * @param \Exception $exception
54
-     * @return bool
54
+     * @return boolean|null
55 55
      */
56 56
     public function catchException(Bootstrap $bootstrap, \Exception $exception)
57 57
     {
Please login to merge, or discard this patch.
src/N98/Magento/Command/Installer/SubCommand/RemoveEmptyFolders.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@
 block discarded – undo
51 51
      *
52 52
      * @param Bootstrap $bootstrap
53 53
      * @param \Exception $exception
54
-     * @return bool
54
+     * @return boolean|null
55 55
      */
56 56
     public function catchException(Bootstrap $bootstrap, \Exception $exception)
57 57
     {
Please login to merge, or discard this patch.
tests/N98/Magento/Command/Database/DumpCommandTest.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -2,8 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace N98\Magento\Command\Database\Maintain;
4 4
 
5
-use Symfony\Component\Console\Output\NullOutput;
6
-use Symfony\Component\Console\Tester\ApplicationTester;
7 5
 use Symfony\Component\Console\Tester\CommandTester;
8 6
 use N98\Magento\Command\PHPUnit\TestCase;
9 7
 
Please login to merge, or discard this patch.
Magento/Command/Developer/Module/Create/SubCommand/CreateComposerFile.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@
 block discarded – undo
28 28
             )
29 29
         );
30 30
 
31
-        $this->output->writeln('<info>Created file: <comment>' .  $outFile .'<comment></info>');
31
+        $this->output->writeln('<info>Created file: <comment>' . $outFile . '<comment></info>');
32 32
 
33 33
         return true;
34 34
     }
Please login to merge, or discard this patch.
N98/Magento/Command/Developer/Module/Create/SubCommand/CreateModmanFile.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@
 block discarded – undo
28 28
             )
29 29
         );
30 30
 
31
-        $this->output->writeln('<info>Created file: <comment>' .  $outFile .'<comment></info>');
31
+        $this->output->writeln('<info>Created file: <comment>' . $outFile . '<comment></info>');
32 32
 
33 33
         return true;
34 34
     }
Please login to merge, or discard this patch.
tests/N98/Magento/Command/Cache/DisableCommandTest.php 1 patch
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -1,9 +1,9 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * @todo    writing unit tests for toggling caches is complicated because environments differ
4
- *          touching caches changes state and will result in different test result second time
5
- *          solutions: disabling/enabling, faking&mocking or having one defined test environment
6
- */
3
+     * @todo    writing unit tests for toggling caches is complicated because environments differ
4
+     *          touching caches changes state and will result in different test result second time
5
+     *          solutions: disabling/enabling, faking&mocking or having one defined test environment
6
+     */
7 7
 namespace N98\Magento\Command\Cache;
8 8
 
9 9
 use Symfony\Component\Console\Tester\CommandTester;
Please login to merge, or discard this patch.
src/N98/Magento/Command/GiftCard/CreateCommand.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@
 block discarded – undo
49 49
                 'status'        => 1,
50 50
                 'is_redeemable' => 1,
51 51
                 'website_id'    => $input->getOption('website')
52
-                    ? : $this->getObjectManager()->get('Magento\Store\Model\StoreManager')->getWebsite(true)->getId(),
52
+                    ?: $this->getObjectManager()->get('Magento\Store\Model\StoreManager')->getWebsite(true)->getId(),
53 53
                 'balance'       => $input->getArgument('amount'),
54 54
                 'date_expires'  => $input->getOption('expires')
55 55
             )
Please login to merge, or discard this patch.
src/N98/Magento/Application.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -319,7 +319,7 @@
 block discarded – undo
319 319
      * @TODO Move logic into "EventSubscriber"
320 320
      *
321 321
      * @param OutputInterface $output
322
-     * @return bool
322
+     * @return null|false
323 323
      */
324 324
     public function checkVarDir(OutputInterface $output)
325 325
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,6 @@
 block discarded – undo
20 20
 use Symfony\Component\Console\Input\InputInterface;
21 21
 use Symfony\Component\Console\Input\InputOption;
22 22
 use Symfony\Component\Console\Output\ConsoleOutput;
23
-use Symfony\Component\Console\Output\NullOutput;
24 23
 use Symfony\Component\Console\Output\OutputInterface;
25 24
 use Symfony\Component\EventDispatcher\EventDispatcher;
26 25
 use UnexpectedValueException;
Please login to merge, or discard this patch.