Completed
Push — develop ( ca40eb...664159 )
by Tom
04:30
created
src/N98/Util/Console/Helper/DatabaseHelper.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -6,7 +6,6 @@
 block discarded – undo
6 6
 use PDOException;
7 7
 use RuntimeException;
8 8
 use Symfony\Component\Console\Helper\Helper as AbstractHelper;
9
-use N98\Magento\Application;
10 9
 use Symfony\Component\Console\Output\NullOutput;
11 10
 use Symfony\Component\Console\Output\OutputInterface;
12 11
 
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -56,11 +56,11 @@  discard block
 block discarded – undo
56 56
             throw new RuntimeException('Cannot find default connection config in app/etc/config.php');
57 57
         }
58 58
 
59
-        $this->dbSettings = (array) $config['db']['connection']['default'];
59
+        $this->dbSettings = (array)$config['db']['connection']['default'];
60 60
 
61 61
         $this->dbSettings['prefix'] = '';
62 62
         if (isset($config['db']['table_prefix'])) {
63
-            $this->dbSettings['prefix'] = (string) $config['db']['table_prefix'];
63
+            $this->dbSettings['prefix'] = (string)$config['db']['table_prefix'];
64 64
         }
65 65
 
66 66
         if (strpos($this->dbSettings['host'], ':') !== false) {
@@ -298,7 +298,7 @@  discard block
 block discarded – undo
298 298
                         $definitions,
299 299
                         $resolved
300 300
                     );
301
-                    $resolvedList    = array_merge($resolvedList, $tables);
301
+                    $resolvedList = array_merge($resolvedList, $tables);
302 302
                 }
303 303
                 continue;
304 304
             }
Please login to merge, or discard this patch.
src/N98/Util/Console/Helper/MagentoHelper.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace N98\Util\Console\Helper;
4 4
 
5 5
 use N98\Magento\Application;
6
-use N98\Util\BinaryString;
7 6
 use RuntimeException;
8 7
 use Symfony\Component\Console\Helper\Helper as AbstractHelper;
9 8
 use Symfony\Component\Console\Input\ArgvInput;
Please login to merge, or discard this patch.
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -387,6 +387,9 @@
 block discarded – undo
387 387
         return $application;
388 388
     }
389 389
 
390
+    /**
391
+     * @param string $configFileName
392
+     */
390 393
     private function addBaseConfig($root, $configFileName)
391 394
     {
392 395
         $configFile = $root . '/' . $configFileName;
Please login to merge, or discard this patch.
src/N98/Util/Console/Helper/ParameterHelper.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -202,7 +202,7 @@
 block discarded – undo
202 202
      * @param OutputInterface                                $output
203 203
      * @param string                                         $name
204 204
      * @param string                                         $value
205
-     * @param Constraints\Collection|Constraint|Constraint[] $constraints The constraint(s) to validate against.
205
+     * @param Constraints\Collection $constraints The constraint(s) to validate against.
206 206
      *
207 207
      * @return mixed
208 208
      */
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -9,7 +9,6 @@
 block discarded – undo
9 9
 use Symfony\Component\Console\Helper\Helper as AbstractHelper;
10 10
 use Symfony\Component\Console\Output\OutputInterface;
11 11
 use Symfony\Component\Console\Input\InputInterface;
12
-use Symfony\Component\Console\Output\Output;
13 12
 use Symfony\Component\Translation\Translator;
14 13
 use Symfony\Component\Validator\Constraint;
15 14
 use Symfony\Component\Validator\Validator;
Please login to merge, or discard this patch.
src/N98/Util/Console/Helper/Table/Renderer/RendererInterface.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -9,6 +9,7 @@
 block discarded – undo
9 9
     /**
10 10
      * @param OutputInterface $output
11 11
      * @param array $rows
12
+     * @return void
12 13
      */
13 14
     public function render(OutputInterface $output, array $rows);
14 15
 }
Please login to merge, or discard this patch.
src/N98/View/PhpView.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@  discard block
 block discarded – undo
16 16
 
17 17
     /**
18 18
      * @param string $template
19
-     * @return Php
19
+     * @return PhpView
20 20
      */
21 21
     public function setTemplate($template)
22 22
     {
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
      * @param string $key
30 30
      * @param mixed $value
31 31
      *
32
-     * @return Php
32
+     * @return PhpView
33 33
      */
34 34
     public function assign($key, $value)
35 35
     {
Please login to merge, or discard this patch.
src/N98/View/View.php 1 patch
Doc Comments   +7 added lines patch added patch discarded remove patch
@@ -4,6 +4,13 @@
 block discarded – undo
4 4
 
5 5
 interface View
6 6
 {
7
+    /**
8
+     * @return PhpView
9
+     */
7 10
     public function assign($key, $value);
11
+
12
+    /**
13
+     * @return string
14
+     */
8 15
     public function render();
9 16
 }
Please login to merge, or discard this patch.
tests/N98/Magento/Command/Database/Maintain/CheckTablesCommandTest.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -2,8 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace N98\Magento\Command\Database\Maintain;
4 4
 
5
-use Symfony\Component\Console\Output\NullOutput;
6
-use Symfony\Component\Console\Tester\ApplicationTester;
7 5
 use Symfony\Component\Console\Tester\CommandTester;
8 6
 use N98\Magento\Command\PHPUnit\TestCase;
9 7
 
Please login to merge, or discard this patch.
tests/N98/Util/Console/Helper/DatabaseHelperTest.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -2,7 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace N98\Util\Console\Helper;
4 4
 
5
-use Symfony\Component\Console\Tester\CommandTester;
6 5
 use N98\Magento\Command\PHPUnit\TestCase;
7 6
 
8 7
 
Please login to merge, or discard this patch.
src/N98/Magento/Command/AbstractMagentoStoreConfigCommand.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -155,8 +155,8 @@
 block discarded – undo
155 155
         $this->getApplication()->run($input, new NullOutput());
156 156
 
157 157
         $comment = '<comment>' . $this->toggleComment . '</comment> '
158
-                 . '<info>' . (!$isFalse ? $this->falseName : $this->trueName) . '</info>'
159
-                 . ($runOnStoreView ? ' <comment>for store</comment> <info>' . $store->getCode() . '</info>' : '');
158
+                    . '<info>' . (!$isFalse ? $this->falseName : $this->trueName) . '</info>'
159
+                    . ($runOnStoreView ? ' <comment>for store</comment> <info>' . $store->getCode() . '</info>' : '');
160 160
         $output->writeln($comment);
161 161
 
162 162
         $this->_afterSave($store, $isFalse);
Please login to merge, or discard this patch.