Completed
Push — develop ( 1ec176...1495f3 )
by Tom
8s
created
src/N98/Magento/Command/Installer/SubCommand/PostInstallation.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@
 block discarded – undo
51 51
      *
52 52
      * @param Bootstrap $bootstrap
53 53
      * @param \Exception $exception
54
-     * @return bool
54
+     * @return boolean|null
55 55
      */
56 56
     public function catchException(Bootstrap $bootstrap, \Exception $exception)
57 57
     {
Please login to merge, or discard this patch.
src/N98/Magento/Command/Installer/SubCommand/RemoveEmptyFolders.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@
 block discarded – undo
51 51
      *
52 52
      * @param Bootstrap $bootstrap
53 53
      * @param \Exception $exception
54
-     * @return bool
54
+     * @return boolean|null
55 55
      */
56 56
     public function catchException(Bootstrap $bootstrap, \Exception $exception)
57 57
     {
Please login to merge, or discard this patch.
tests/N98/Magento/Command/Database/DumpCommandTest.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -2,8 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace N98\Magento\Command\Database\Maintain;
4 4
 
5
-use Symfony\Component\Console\Output\NullOutput;
6
-use Symfony\Component\Console\Tester\ApplicationTester;
7 5
 use Symfony\Component\Console\Tester\CommandTester;
8 6
 use N98\Magento\Command\PHPUnit\TestCase;
9 7
 
Please login to merge, or discard this patch.
Magento/Command/Developer/Module/Create/SubCommand/CreateComposerFile.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@
 block discarded – undo
28 28
             )
29 29
         );
30 30
 
31
-        $this->output->writeln('<info>Created file: <comment>' .  $outFile .'<comment></info>');
31
+        $this->output->writeln('<info>Created file: <comment>' . $outFile . '<comment></info>');
32 32
 
33 33
         return true;
34 34
     }
Please login to merge, or discard this patch.
N98/Magento/Command/Developer/Module/Create/SubCommand/CreateModmanFile.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@
 block discarded – undo
28 28
             )
29 29
         );
30 30
 
31
-        $this->output->writeln('<info>Created file: <comment>' .  $outFile .'<comment></info>');
31
+        $this->output->writeln('<info>Created file: <comment>' . $outFile . '<comment></info>');
32 32
 
33 33
         return true;
34 34
     }
Please login to merge, or discard this patch.
src/N98/Magento/Command/GiftCard/CreateCommand.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@
 block discarded – undo
49 49
                 'status'        => 1,
50 50
                 'is_redeemable' => 1,
51 51
                 'website_id'    => $input->getOption('website')
52
-                    ? : $this->getObjectManager()->get('Magento\Store\Model\StoreManager')->getWebsite(true)->getId(),
52
+                    ?: $this->getObjectManager()->get('Magento\Store\Model\StoreManager')->getWebsite(true)->getId(),
53 53
                 'balance'       => $input->getArgument('amount'),
54 54
                 'date_expires'  => $input->getOption('expires')
55 55
             )
Please login to merge, or discard this patch.
src/N98/Magento/Application.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -319,7 +319,7 @@
 block discarded – undo
319 319
      * @TODO Move logic into "EventSubscriber"
320 320
      *
321 321
      * @param OutputInterface $output
322
-     * @return bool
322
+     * @return null|false
323 323
      */
324 324
     public function checkVarDir(OutputInterface $output)
325 325
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,6 @@
 block discarded – undo
20 20
 use Symfony\Component\Console\Input\InputInterface;
21 21
 use Symfony\Component\Console\Input\InputOption;
22 22
 use Symfony\Component\Console\Output\ConsoleOutput;
23
-use Symfony\Component\Console\Output\NullOutput;
24 23
 use Symfony\Component\Console\Output\OutputInterface;
25 24
 use Symfony\Component\EventDispatcher\EventDispatcher;
26 25
 use UnexpectedValueException;
Please login to merge, or discard this patch.
src/N98/Magento/Command/System/Url/ListCommand.php 1 patch
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
      *
71 71
      * @param StoreManager $storeManager
72 72
      * @param Category $sitemapCategoryCollection
73
-     * @param Product $sitmapProductCollection
73
+     * @param Product $sitemapProductCollection
74 74
      * @param Page $sitemapPageCollection
75 75
      */
76 76
     public function inject(
@@ -146,7 +146,6 @@  discard block
 block discarded – undo
146 146
     }
147 147
 
148 148
     /**
149
-     * @param string $resourceModel
150 149
      * @param string $linkBaseUrl
151 150
      * @param string $storeId
152 151
      * @param array  $urls
Please login to merge, or discard this patch.
Magento/Command/Developer/Module/Create/SubCommand/CreateModuleFolders.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -34,28 +34,28 @@
 block discarded – undo
34 34
         $config->setString('moduleDirectory', $moduleDir);
35 35
 
36 36
         mkdir($moduleDir, 0777, true);
37
-        $this->output->writeln('<info>Created directory: <comment>' .  $moduleDir .'<comment></info>');
37
+        $this->output->writeln('<info>Created directory: <comment>' . $moduleDir . '<comment></info>');
38 38
 
39 39
         // Add etc folder
40 40
         mkdir($moduleDir . '/etc');
41
-        $this->output->writeln('<info>Created directory: <comment>' .  $moduleDir .'/etc<comment></info>');
41
+        $this->output->writeln('<info>Created directory: <comment>' . $moduleDir . '/etc<comment></info>');
42 42
 
43 43
         // Add blocks folder
44 44
         if ($config->getBool('shouldAddBlocks')) {
45 45
             mkdir($moduleDir . '/Block');
46
-            $this->output->writeln('<info>Created directory: <comment>' .  $moduleDir . '/Block' .'<comment></info>');
46
+            $this->output->writeln('<info>Created directory: <comment>' . $moduleDir . '/Block' . '<comment></info>');
47 47
         }
48 48
 
49 49
         // Add helpers folder
50 50
         if ($config->getBool('shouldAddHelpers')) {
51 51
             mkdir($moduleDir . '/Helper');
52
-            $this->output->writeln('<info>Created directory: <comment>' .  $moduleDir . '/Helper' .'<comment></info>');
52
+            $this->output->writeln('<info>Created directory: <comment>' . $moduleDir . '/Helper' . '<comment></info>');
53 53
         }
54 54
 
55 55
         // Add models folder
56 56
         if ($config->getBool('shouldAddModels')) {
57 57
             mkdir($moduleDir . '/Model');
58
-            $this->output->writeln('<info>Created directory: <comment>' .  $moduleDir . '/Model' .'<comment></info>');
58
+            $this->output->writeln('<info>Created directory: <comment>' . $moduleDir . '/Model' . '<comment></info>');
59 59
         }
60 60
 
61 61
         // Create SQL and Data folder
Please login to merge, or discard this patch.