DownloadMagento::checkMagentoConnectCredentials() - Code Metrics - Inspection of "Update version of development branch" - netz98/n98-magerun2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( c8bccb...27dcf1 )

by Tom

created 2016-05-18 16:00 UTC

DownloadMagento::checkMagentoConnectCredentials() B

↳ Parent: DownloadMagento

Complexity

Conditions	5
Paths	2

Size

Total Lines	59
Code Lines	37

Duplication

Lines	0
Ratio	0 %

Importance

Changes	4
Bugs	1	Features	0

Metric	Value
c	4
b	1
f	0
dl	0
loc	59
rs	8.7117
cc	5
eloc	37
nc	2
nop	1

How to fix Long Method

<?php

namespace N98\Magento\Command\Installer\SubCommand;

use Exception;
use N98\Magento\Command\SubCommand\AbstractSubCommand;
use N98\Util\Console\Helper\ComposerHelper;
use N98\Util\Exec;
use N98\Util\ProcessArguments;
use RuntimeException;
use Symfony\Component\Console\Output\OutputInterface;

class DownloadMagento extends AbstractSubCommand
{
    /**
     * @return void
     */
    public function execute()
    {
        if ($this->input->getOption('noDownload')) {
            return;
        }

        try {
            $this->implementation();
        } catch (Exception $e) {
            $this->output->writeln('<error>' . $e->getMessage() . '</error>');
        }
    }

    private function implementation()
    {
        $this->checkMagentoConnectCredentials($this->output);

        $package = $this->config['magentoVersionData'];
        $this->config->setArray('magentoPackage', $package);

        if (file_exists($this->config->getString('installationFolder') . '/app/etc/env.php')) {
            throw new RuntimeException('A magento installation already exists in this folder');
        }

        $args = new ProcessArguments(array($this->config['composer_bin'], 'create-project',));
        $args
            // Add composer options
            ->addArgs($package['options'])
            // Add arguments
            ->addArg($package['package'])
            ->addArg($this->config->getString('installationFolder'))
            ->addArg($package['version'])
        ;

        if (OutputInterface::VERBOSITY_VERBOSE <= $this->output->getVerbosity()) {
            $args->addArg('-vvv');
        }

        /**
         * @TODO use composer helper
         */
        $process = $args->createBuilder()->getProcess();
        $process->setInput($this->input);
        if (OutputInterface::VERBOSITY_VERBOSE <= $this->output->getVerbosity()) {
            $this->output->writeln($process->getCommandLine());
        }

        $process->setTimeout(86400);
        $process->start();
        $code = $process->wait(function ($type, $buffer) {
            $this->output->write($buffer, false, OutputInterface::OUTPUT_RAW);
        });

        if (Exec::CODE_CLEAN_EXIT !== $code) {
            throw new RuntimeException(
                'Non-zero exit code for composer create-project command: ' . $process->getCommandLine()
            );
        }
    }

    /**
     * construct a folder to where magerun will download the source to,
     * cache git/hg repositories under COMPOSER_HOME
     *
     * @param $composer
     * @param $package
     * @param $installationFolder
     *
     * @return string
     */
    protected function getTargetFolderByType($composer, $package, $installationFolder)
    {
        $type = $package->getSourceType();
        if ($this->getCommand()->isSourceTypeRepository($type)) {
            $targetPath = sprintf(
                '%s/%s/%s/%s',
                $composer->getConfig()->get('cache-dir'),
                '_n98_magerun_download',
                $type,
                preg_replace('{[^a-z0-9.]}i', '-', $package->getSourceUrl())
            );
        } else {
            $targetPath = sprintf(
                '%s/%s',
                $installationFolder,
                '_n98_magerun_download'
            );
        }

        return $targetPath;
    }

    /**
     * @param OutputInterface $output
     */
    protected function checkMagentoConnectCredentials(OutputInterface $output)
    {
        $configKey = 'http-basic.repo.magento.com';

        $composerHelper = $this->getCommand()->getHelper('composer');
        /** @var $composerHelper ComposerHelper */
        $authConfig = $composerHelper->getConfigValue($configKey);

        if (!isset($authConfig->username)
            || !isset($authConfig->password)
        ) {
            $this->output->writeln(array(
                '',
                $this->getCommand()
                    ->getHelperSet()
                    ->get('formatter')
                    ->formatBlock('Authentication', 'bg=blue;fg=white', true),
                '',
            ));

            $this->output->writeln(array(
                'You need to create a secury key. Login at magentocommerce.com.',
                'Developers -> Secure Keys. <info>Use public key as username and private key as password</info>',
                ''
            ));
            $dialog = $this->getCommand()->getHelper('dialog');

            $username = $dialog->askAndValidate(
                $output,
                '<comment>Please enter your public key: </comment>',
                function ($value) {
                    if ('' === trim($value)) {
                        throw new Exception('The private key (auth token) can not be empty');
                    }

                    return $value;
                },
                20,
                false
            );


            $password = $dialog->askHiddenResponseAndValidate(
                $output,
                '<comment>Please enter your private key: </comment>',
                function ($value) {
                    if ('' === trim($value)) {
                        throw new Exception('The private key (auth token) can not be empty');
                    }

                    return $value;
                },
                20,
                false
            );

            $composerHelper->setConfigValue($configKey, [$username, $password]);
        }
    }
}


1			<?php
2
3			namespace N98\Magento\Command\Installer\SubCommand;
4
5			use Exception;
6			use N98\Magento\Command\SubCommand\AbstractSubCommand;
7			use N98\Util\Console\Helper\ComposerHelper;
8			use N98\Util\Exec;
9			use N98\Util\ProcessArguments;
10			use RuntimeException;
11			use Symfony\Component\Console\Output\OutputInterface;
12
13			class DownloadMagento extends AbstractSubCommand
14			{
15			/**
16			* @return void
17			*/
18			public function execute()
19			{
20			if ($this->input->getOption('noDownload')) {
21			return;
22			}
23
24			try {
25			$this->implementation();
26			} catch (Exception $e) {
27			$this->output->writeln('<error>' . $e->getMessage() . '</error>');
28			}
29			}
30
31			private function implementation()
32			{
33			$this->checkMagentoConnectCredentials($this->output);
34
35			$package = $this->config['magentoVersionData'];
36			$this->config->setArray('magentoPackage', $package);
37
38			if (file_exists($this->config->getString('installationFolder') . '/app/etc/env.php')) {
39			throw new RuntimeException('A magento installation already exists in this folder');
40			}
41
42			$args = new ProcessArguments(array($this->config['composer_bin'], 'create-project',));
43			$args
44			// Add composer options
45			->addArgs($package['options'])
46			// Add arguments
47			->addArg($package['package'])
48			->addArg($this->config->getString('installationFolder'))
49			->addArg($package['version'])
50			;
51
52			if (OutputInterface::VERBOSITY_VERBOSE <= $this->output->getVerbosity()) {
53			$args->addArg('-vvv');
54			}
55
56			/**
57			* @TODO use composer helper
58			*/
59			$process = $args->createBuilder()->getProcess();
60			$process->setInput($this->input);
61			if (OutputInterface::VERBOSITY_VERBOSE <= $this->output->getVerbosity()) {
62			$this->output->writeln($process->getCommandLine());
63			}
64
65			$process->setTimeout(86400);
66			$process->start();
67			$code = $process->wait(function ($type, $buffer) {
68			$this->output->write($buffer, false, OutputInterface::OUTPUT_RAW);
69			});
70
71			if (Exec::CODE_CLEAN_EXIT !== $code) {
72			throw new RuntimeException(
73			'Non-zero exit code for composer create-project command: ' . $process->getCommandLine()
74			);
75			}
76			}
77
78			/**
79			* construct a folder to where magerun will download the source to,
80			* cache git/hg repositories under COMPOSER_HOME
81			*
82			* @param $composer
83			* @param $package
84			* @param $installationFolder
85			*
86			* @return string
87			*/
88			protected function getTargetFolderByType($composer, $package, $installationFolder)
89			{
90			$type = $package->getSourceType();
91			if ($this->getCommand()->isSourceTypeRepository($type)) {
92			$targetPath = sprintf(
93			'%s/%s/%s/%s',
94			$composer->getConfig()->get('cache-dir'),
95			'_n98_magerun_download',
96			$type,
97			preg_replace('{[^a-z0-9.]}i', '-', $package->getSourceUrl())
98			);
99			} else {
100			$targetPath = sprintf(
101			'%s/%s',
102			$installationFolder,
103			'_n98_magerun_download'
104			);
105			}
106
107			return $targetPath;
108			}
109
110			/**
111			* @param OutputInterface $output
112			*/
113			protected function checkMagentoConnectCredentials(OutputInterface $output)
114			{
115			$configKey = 'http-basic.repo.magento.com';
116
117			$composerHelper = $this->getCommand()->getHelper('composer');
118			/** @var $composerHelper ComposerHelper */
119			$authConfig = $composerHelper->getConfigValue($configKey);
120
121			if (!isset($authConfig->username)
122			\|\| !isset($authConfig->password)
123			) {
124			$this->output->writeln(array(
125			'',
126			$this->getCommand()
127			->getHelperSet()
128			->get('formatter')
129			->formatBlock('Authentication', 'bg=blue;fg=white', true),
130			'',
131			));
132
133			$this->output->writeln(array(
134			'You need to create a secury key. Login at magentocommerce.com.',
135			'Developers -> Secure Keys. <info>Use public key as username and private key as password</info>',
136			''
137			));
138			$dialog = $this->getCommand()->getHelper('dialog');
139
140			$username = $dialog->askAndValidate(
141			$output,
142			'<comment>Please enter your public key: </comment>',
143			function ($value) {
144			if ('' === trim($value)) {
145			throw new Exception('The private key (auth token) can not be empty');
146			}
147
148			return $value;
149			},
150			20,
151			false
152			);
153
154
155			$password = $dialog->askHiddenResponseAndValidate(
156			$output,
157			'<comment>Please enter your private key: </comment>',
158			function ($value) {
159			if ('' === trim($value)) {
160			throw new Exception('The private key (auth token) can not be empty');
161			}
162
163			return $value;
164			},
165			20,
166			false
167			);
168
169			$composerHelper->setConfigValue($configKey, [$username, $password]);
170			}
171			}
172			}
173

netz98 / n98-magerun2

Push — develop ( c8bccb...27dcf1 )

DownloadMagento::checkMagentoConnectCredentials() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like