TestCase::getTestApplication() - Code Metrics - Inspection of "Fix sales order status strip, fixes #239" - netz98/n98-magerun2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#243)

by Tom

created 2016-10-19 14:53 UTC

TestCase::getTestApplication() A

↳ Parent: TestCase

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	4
nc	2
nop	0

<?php

namespace N98\Magento\Command;

use Magento\Framework\App\ResourceConnection;
use Magento\Framework\DB\Adapter\AdapterInterface;
use N98\Magento\Application;
use N98\Magento\TestApplication;
use PHPUnit_Framework_MockObject_MockObject;

/**
 * Class TestCase
 *
 * @codeCoverageIgnore
 * @package N98\Magento\Command\PHPUnit
 */
abstract class TestCase extends \PHPUnit_Framework_TestCase
{
    /**
     * @var TestApplication
     */
    private $testApplication;

    /**
     * getter for the magento root directory of the test-suite
     *
     * @see ApplicationTest::testExecute
     *
     * @return string

     */
    public function getTestMagentoRoot()
    {
        return $this->getTestApplication()->getTestMagentoRoot();
    }

    /**
     * @return Application|PHPUnit_Framework_MockObject_MockObject
     */
    public function getApplication()
    {
        return $this->getTestApplication()->getApplication();
    }

    /**
     * @return AdapterInterface
     */
    public function getDatabaseConnection()
    {
        $resource = $this->getApplication()->getObjectManager()->get(ResourceConnection::class);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        return $resource->getConnection('write');
    }

    /**
     * @return TestApplication
     */
    private function getTestApplication()
    {
        if (null === $this->testApplication) {
            $this->testApplication = new TestApplication();
        }

        return $this->testApplication;
    }
}


1			<?php
2
3			namespace N98\Magento\Command;
4
5			use Magento\Framework\App\ResourceConnection;
6			use Magento\Framework\DB\Adapter\AdapterInterface;
7			use N98\Magento\Application;
8			use N98\Magento\TestApplication;
9			use PHPUnit_Framework_MockObject_MockObject;
10
11			/**
12			* Class TestCase
13			*
14			* @codeCoverageIgnore
15			* @package N98\Magento\Command\PHPUnit
16			*/
17			abstract class TestCase extends \PHPUnit_Framework_TestCase
18			{
19			/**
20			* @var TestApplication
21			*/
22			private $testApplication;
23
24			/**
25			* getter for the magento root directory of the test-suite
26			*
27			* @see ApplicationTest::testExecute
28			*
29			* @return string
			0 ignored issues – show Documentation introduced 2016-10-07 12:09 UTC by Report Bug Copy Issue Report Should the return type not be `string\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
30			*/
31			public function getTestMagentoRoot()
32			{
33			return $this->getTestApplication()->getTestMagentoRoot();
34			}
35
36			/**
37			* @return Application\|PHPUnit_Framework_MockObject_MockObject
38			*/
39			public function getApplication()
40			{
41			return $this->getTestApplication()->getApplication();
42			}
43
44			/**
45			* @return AdapterInterface
46			*/
47			public function getDatabaseConnection()
48			{
49			$resource = $this->getApplication()->getObjectManager()->get(ResourceConnection::class);
			0 ignored issues – show Bug introduced 2016-10-07 12:09 UTC by Report Bug Copy Issue Report The method `getObjectManager` does only exist in `N98\Magento\Application`, but not in `PHPUnit_Framework_MockObject_MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
50
51			return $resource->getConnection('write');
52			}
53
54			/**
55			* @return TestApplication
56			*/
57			private function getTestApplication()
58			{
59			if (null === $this->testApplication) {
60			$this->testApplication = new TestApplication();
61			}
62
63			return $this->testApplication;
64			}
65			}
66

netz98 / n98-magerun2

Pull Request — develop (#243)

TestCase::getTestApplication() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like