CheckAbstract::check() - Code Metrics - Inspection of "Prepare release 4.2.0" - netz98/n98-magerun2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( cda577...82aa13 )

by Christian

created 2020-08-22 09:51 UTC

CheckAbstract::check() A

↳ Parent: CheckAbstract

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	11
rs	9.9
c	0
b	0
f	0
cc	1
nc	1
nop	1

<?php

namespace N98\Magento\Command\System\Check\Env;

use Adbar\Dot;
use N98\Magento\Command\CommandAware;
use N98\Magento\Command\CommandConfigAware;
use N98\Magento\Command\System\Check\ResultCollection;
use N98\Magento\Command\System\Check\SimpleCheck;
use N98\Magento\Command\System\CheckCommand;
use Symfony\Component\Console\Command\Command;

abstract class CheckAbstract implements SimpleCheck, CommandAware, CommandConfigAware
{
    /**
     * @var ResultCollection
     */
    protected $_results;

    /**
     * @var array
     */
    protected $_commandConfig;

    /**
     * @var CheckCommand
     */
    protected $_checkCommand;

    /**
     * @var Dot
     */
    protected $_dot;

    /**
     * @var array
     */
    protected $_env;

    /**
     * @var string
     */
    protected $_envFilePath;

    /**
     * @param ResultCollection $results
     */
    public function check(ResultCollection $results)
    {
        $this->_results = $results;
        $this->_envFilePath = $this->_checkCommand->getApplication()->getMagentoRootFolder() . '/app/etc/env.php';

        $envArray = include $this->_envFilePath;
        $this->_env = $envArray;
        $this->_dot = new Dot($envArray);

        call_user_func([$this, 'checkEnv']);
    }

    /**
     * @param array $commandConfig
     */
    public function setCommandConfig(array $commandConfig)
    {
        $this->_commandConfig = $commandConfig;
    }

    /**
     * @param Command $command
     */
    public function setCommand(Command $command)
    {
        $this->_checkCommand = $command;
class Alien {}

class Dalek extends Alien {}

class Plot
{
    /** @var  Dalek */
    public $villain;
}

$alien = new Alien();
$plot = new Plot();
if ($alien instanceof Dalek) {
    $plot->villain = $alien;
}
    }
}


1			<?php
2
3			namespace N98\Magento\Command\System\Check\Env;
4
5			use Adbar\Dot;
6			use N98\Magento\Command\CommandAware;
7			use N98\Magento\Command\CommandConfigAware;
8			use N98\Magento\Command\System\Check\ResultCollection;
9			use N98\Magento\Command\System\Check\SimpleCheck;
10			use N98\Magento\Command\System\CheckCommand;
11			use Symfony\Component\Console\Command\Command;
12
13			abstract class CheckAbstract implements SimpleCheck, CommandAware, CommandConfigAware
14			{
15			/**
16			* @var ResultCollection
17			*/
18			protected $_results;
19
20			/**
21			* @var array
22			*/
23			protected $_commandConfig;
24
25			/**
26			* @var CheckCommand
27			*/
28			protected $_checkCommand;
29
30			/**
31			* @var Dot
32			*/
33			protected $_dot;
34
35			/**
36			* @var array
37			*/
38			protected $_env;
39
40			/**
41			* @var string
42			*/
43			protected $_envFilePath;
44
45			/**
46			* @param ResultCollection $results
47			*/
48			public function check(ResultCollection $results)
49			{
50			$this->_results = $results;
51			$this->_envFilePath = $this->_checkCommand->getApplication()->getMagentoRootFolder() . '/app/etc/env.php';
52
53			$envArray = include $this->_envFilePath;
54			$this->_env = $envArray;
55			$this->_dot = new Dot($envArray);
56
57			call_user_func([$this, 'checkEnv']);
58			}
59
60			/**
61			* @param array $commandConfig
62			*/
63			public function setCommandConfig(array $commandConfig)
64			{
65			$this->_commandConfig = $commandConfig;
66			}
67
68			/**
69			* @param Command $command
70			*/
71			public function setCommand(Command $command)
72			{
73			$this->_checkCommand = $command;
			0 ignored issues – show Documentation Bug introduced 2020-07-16 15:49 UTC by Report Bug Copy Issue Report `$command` is of type `object<Symfony\Component\Console\Command\Command>`, but the property `$_checkCommand` was declared to be of type `object<N98\Magento\Command\System\CheckCommand>`. Are you sure that you always receive this specific sub-class here, or does it make sense to add an `instanceof` check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a given class or a super-class is assigned to a property that is type hinted more strictly. Either this assignment is in error or an instanceof check should be added for that assignment. class Alien {} class Dalek extends Alien {} class Plot { /** @var Dalek */ public $villain; } $alien = new Alien(); $plot = new Plot(); if ($alien instanceof Dalek) { $plot->villain = $alien; } Loading history...
74			}
75			}
76

netz98 / n98-magerun2

Push — master ( cda577...82aa13 )

CheckAbstract::check() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like